On Sun, Mar 26, 2023 at 8:41 PM Kyotaro Horiguchi <horikyota....@gmail.com> wrote: > > I'd still put the LSN data before the three OIDs for consistency with > > the structures, though my opinion does not seem to count much.. > > I agree with Michael on this point. Also, although it may not be > significant for SQL, the rows are output in lsn order from the > function.
I guess that it makes sense to have the LSN data first, but to have the other columns after that. I certainly don't dislike that approach. I just noticed is that "forkname" appears towards the end among declared output parameters, even in Bharath's v6. I think that it should be after "relblocknumber" instead, because it is conceptually part of the "composite primary key", and so belongs right next to "relblocknumber". I failed to mention this detail upthread, I think. -- Peter Geoghegan
