pltcl crash on recent macOS

2022-06-12 Thread Peter Eisentraut
A little while ago, the pltcl tests starting crashing for me on macOS. I don't know what had changed, but I suspect it was either an operating system update or something like an xcode update. Here is a backtrace: * frame #0: 0x7ff7b0e61853 frame #1: 0x7ff803a28751 libsystem_c.dyl

Re: Replica Identity check of partition table on subscriber

2022-06-12 Thread Amit Kapila
On Sat, Jun 11, 2022 at 2:36 PM houzj.f...@fujitsu.com wrote: > > On Saturday, June 11, 2022 9:36 AM Amit Kapila > wrote: > > > > On Fri, Jun 10, 2022 at 2:26 PM Amit Langote > > wrote: > > > > > > +logicalrep_partmap_invalidate > > > > > > I wonder why not call this logicalrep_partmap_update()

Parse CE and BCE in dates and times

2022-06-12 Thread David Fetter
Folks, Please find attached a patch to do $Subject. As dates in a fair number of fields of endeavor are expressed this way, it seems reasonable to ensure tha we can parse them on input. Making it possible to use them in output is a more invasive patch, and would involve changes to to_date and simi

Re: bogus: logical replication rows/cols combinations

2022-06-12 Thread Amit Kapila
On Wed, Jun 8, 2022 at 11:05 AM Peter Smith wrote: > > On Wed, Jun 8, 2022 at 1:25 PM Justin Pryzby wrote: > > > > On Mon, Jun 06, 2022 at 03:42:31PM +1000, Peter Smith wrote: > > > I noticed the patch "0001-language-fixes-on-HEAD-from-Justin.patch" says: > > > > > > @@ -11673,7 +11673,7 @@ > > >

"buffer too small" or "path too long"?

2022-06-12 Thread Kyotaro Horiguchi
Recently we added the error messages "buffer for root directory too small" and siblings to pg_upgrade. This means "/pg_upgrade_output.d" was longer than MAXPGPATH. I feel that the "root directory" is obscure here, and moreover "buffer is too small" looks pointless since no user can do something o

Re: [BUG] Logical replication failure "ERROR: could not map filenode "base/13237/442428" to relation OID" with catalog modifying txns

2022-06-12 Thread Masahiko Sawada
On Tue, Jun 7, 2022 at 9:32 PM Amit Kapila wrote: > > On Mon, May 30, 2022 at 11:13 AM Masahiko Sawada > wrote: > > > > On Wed, May 25, 2022 at 12:11 PM Masahiko Sawada > > wrote: > > > > > > > poc_add_regression_tests.patch adds regression tests for this bug. The > > regression tests are requ

Re: Add header support to text format and matching feature

2022-06-12 Thread Julien Rouhaud
Hi, On Sun, Jun 12, 2022 at 09:36:13AM -0400, Andrew Dunstan wrote: > > On 2022-06-07 Tu 11:47, Julien Rouhaud wrote: > > > > First, probably nitpicking, the HEADER MATCH is allowed for COPY TO, is that > > expected? The documentation isn't really explicit about it, but there's > > nothing to ma

Re: Collation version tracking for macOS

2022-06-12 Thread Thomas Munro
Hey Jeremy, On Tue, Jun 7, 2022 at 12:42 PM Jeremy Schneider wrote: > Thomas - thanks for the link back to one of the threads. I spent some time > reading through that and it’s a lot of material; I haven’t read the whole > thread yet. If you have some others that would also be particularly good

Re: Improve TAP tests of pg_upgrade for cross-version tests

2022-06-12 Thread Andrew Dunstan
On 2022-06-12 Su 10:14, Andrew Dunstan wrote: > On 2022-06-09 Th 03:49, Michael Paquier wrote: >> On Wed, May 25, 2022 at 10:35:57AM +0900, Michael Paquier wrote: >>> On Tue, May 24, 2022 at 03:03:28PM +0900, Michael Paquier wrote: (Adding Andrew Dunstan in CC.) I have been toying

Re: Quick question regarding HeapTupleHeaderData.t_ctid

2022-06-12 Thread Aleksander Alekseev
Hi again, > Just to clarify, is t_ctid used for anything _but_ HOT? Apparently, I got carried away with HOT too much. htup_details.h pretty much answers that it does. -- Best regards, Aleksander Alekseev

Re: Quick question regarding HeapTupleHeaderData.t_ctid

2022-06-12 Thread Aleksander Alekseev
Hi Tom, > > Which brings a question, maybe it shouldn't > > take that much space on disk. > > How would you make it optional? In particular, what are you going to > to when it's time to update a row (and therefore insert a ctid link) > and the page is already completely full? In other words, if

Re: Quick question regarding HeapTupleHeaderData.t_ctid

2022-06-12 Thread Tom Lane
Aleksander Alekseev writes: > So t_ctid will point to the newer version of the tuple regardless of > whether HOT is used or not. But I couldn't find an answer to how > t_ctid is used when a tuple is not a part of a HOT chain, or is the > last item in the chain. t_ctid points to the tuple itself i

Re: connection failures on forked processes

2022-06-12 Thread Justin Pryzby
On Sun, Jun 12, 2022 at 10:05:59AM -0400, Jim Popovitch wrote: > We are seeing connection failures when using "sslmode=require" on forked > connections. Attached is example code that makes 2 passes. The first pass > uses "sslmode=disable" and the second uses "sslmode=require". The first > pass co

Re: Subscription tests vs log_error_verbosity

2022-06-12 Thread Andrew Dunstan
On 2022-06-11 Sa 14:52, Tom Lane wrote: > Andrew Dunstan writes: >> I have just got to the bottom of why the new subscription tests >> 027_nosuperuser.pl and 029_on_error.pl have been failing for me - it's >> because my test setup has log_error_verbosity set to 'verbose'. Either >> we should for

Re: Improve TAP tests of pg_upgrade for cross-version tests

2022-06-12 Thread Andrew Dunstan
On 2022-06-09 Th 03:49, Michael Paquier wrote: > On Wed, May 25, 2022 at 10:35:57AM +0900, Michael Paquier wrote: >> On Tue, May 24, 2022 at 03:03:28PM +0900, Michael Paquier wrote: >>> (Adding Andrew Dunstan in CC.) >>> >>> I have been toying with $subject, trying to improve the ways to test >>>

connection failures on forked processes

2022-06-12 Thread Jim Popovitch
Hello! We are seeing connection failures when using "sslmode=require" on forked connections. Attached is example code that makes 2 passes. The first pass uses "sslmode=disable" and the second uses "sslmode=require". The first pass completes successfully, but the second pass fails. I'm looking

Re: Add header support to text format and matching feature

2022-06-12 Thread Andrew Dunstan
On 2022-06-07 Tu 11:47, Julien Rouhaud wrote: > Hi, > > On Wed, Mar 30, 2022 at 09:11:09AM +0200, Peter Eisentraut wrote: >> Committed, after some further refinements as discussed. > While working on nearby code, I found some problems with this feature. > > First, probably nitpicking, the HEADER

Quick question regarding HeapTupleHeaderData.t_ctid

2022-06-12 Thread Aleksander Alekseev
Hi hackers, It's been a while since the last time I explored how PostgreSQL stores the data on disk, so I decided to refresh my memory. All in all this topic is well documented, but there is one question that I couldn't find an answer to quickly. >From README.HOT: > If an update changes any inde

[RFC] Add jit deform_counter

2022-06-12 Thread Dmitry Dolgov
Hi, I've noticed that JIT performance counter generation_counter seems to include actions, relevant for both jit_expressions and jit_tuple_deforming options. It means one can't directly see what is the influence of jit_tuple_deforming alone, which would be helpful when adjusting JIT options. To ma