Re: \dP and \dX use ::regclass without "pg_catalog."

On Fri, Jan 07, 2022 at 03:56:20PM -0600, Justin Pryzby wrote: > I'd propose these. Applied and backpatched down to 14. One of the aliases is present in 13~, but I have let that alone. The detection regex posted upthread is kind of cool. -- Michael signature.asc Description: PGP signature

Re: Non-superuser subscription owners

On Wed, 2021-12-15 at 12:23 -0800, Mark Dilger wrote: > > On Nov 24, 2021, at 4:30 PM, Jeff Davis wrote: > > > > We need to do permission checking for WITH CHECK OPTION and RLS. > > The > > patch right now allows the subscription to write data that an RLS > > policy forbids. > > Version 4 of the

Re: Non-superuser subscription owners

On Sat, 2022-01-08 at 12:27 +0530, Amit Kapila wrote: > For Update/Delete, we do read the table first via > FindReplTupleInLocalRel(), so is there a need to check ACL_SELECT > before that? If it's logically an update/delete, then I think ACL_UPDATE/DELETE is the right one to check. Do you have a d

Re: Non-superuser subscription owners

On Thu, Dec 16, 2021 at 1:53 AM Mark Dilger wrote: > > > On Nov 24, 2021, at 4:30 PM, Jeff Davis wrote: > > > > We need to do permission checking for WITH CHECK OPTION and RLS. The > > patch right now allows the subscription to write data that an RLS > > policy forbids. > > Version 4 of the patch

Re: Updating Copyright notices to 2022?

On Fri, Jan 07, 2022 at 07:06:06PM -0500, Bruce Momjian wrote: > Done, sorry for the delay. No problem. Thanks! -- Michael signature.asc Description: PGP signature

Re: row filtering for logical replication

On Fri, Jan 7, 2022 at 11:20 PM Euler Taveira wrote: > > On Fri, Jan 7, 2022, at 6:05 AM, Amit Kapila wrote: > > Euler, I have one more question about this patch for you. I see that > in the patch we are calling coerce_to_target_type() in > pgoutput_row_filter_init_expr() but do we really need the

Re: skip replication slot snapshot/map file removal during end-of-recovery checkpoint

On Thu, Jan 6, 2022 at 5:04 AM Bossart, Nathan wrote: > > On 12/23/21, 3:17 AM, "Bharath Rupireddy" > wrote: > > Currently the end-of-recovery checkpoint can be much slower, impacting > > the server availability, if there are many replication slot files > > .snap or map- to be enumerated

Re: Disallow quorum uncommitted (with synchronous standbys) txns in logical replication subscribers

On Fri, 2022-01-07 at 14:54 -0800, Andres Freund wrote: > > If you only promote the furthest-ahead sync replica (which is what > > you > > should be doing if you have quorum commit), why wouldn't that work? > > Remove "sync" from the above sentence, and the sentence holds true > for > combinations

Re: [PoC] Delegating pg_ident to a third party

On Tue, 2022-01-04 at 22:24 -0500, Stephen Frost wrote: > On Tue, Jan 4, 2022 at 18:56 Jacob Champion wrote: > > > > Could you talk more about the use cases for which having the "actual > > user" is better? From an auditing perspective I don't see why > > "authenticated as ja...@example.net, logg

null iv parameter passed to combo_init()

Hi, In contrib/pgcrypto/pgcrypto.c : err = px_combo_init(c, (uint8 *) VARDATA_ANY(key), klen, NULL, 0); Note: NULL is passed as iv. When combo_init() is called, if (ivlen > ivs) memcpy(ivbuf, iv, ivs); else memcpy(ivbuf, iv, ivlen); It seems we need

Re: pgsql: Refactor tar method of walmethods.c to rely on the compression m

On Fri, Jan 07, 2022 at 03:41:16PM +0100, Christoph Berg wrote: > since about this commit, pg_wal.tar is no longer compressed at all: Thanks. That's a thinko coming from the fact that Z_DEFAULT_COMPRESSION is -1, combination possible when specifying only --gzip. So, fixed. -- Michael signature

Re: Updating Copyright notices to 2022?

On Sat, Jan 8, 2022 at 08:51:08AM +0900, Michael Paquier wrote: > On Fri, Jan 07, 2022 at 04:57:11PM -0500, Bruce Momjian wrote: > > I like to be current on my email before I do it, and I have been > > completing a Debian upgrade this week so am behind. If you would like > > to do it, please go a

Re: Updating Copyright notices to 2022?

On Fri, Jan 07, 2022 at 04:57:11PM -0500, Bruce Momjian wrote: > I like to be current on my email before I do it, and I have been > completing a Debian upgrade this week so am behind. If you would like > to do it, please go ahead. If not, I will try to do it before Sunday. Thanks for the update.

Re: Add 64-bit XIDs into PostgreSQL 15

> > I'd be > curious to know where we found the bits for that -- the tuple header > isn't exactly replete with extra bit space. > +1 - and can we somehow shoehorn in a version # into the new format so we never have to look for spare bits again.

Re: Disallow quorum uncommitted (with synchronous standbys) txns in logical replication subscribers

Hi, On 2022-01-07 14:36:46 -0800, Jeff Davis wrote: > On Fri, 2022-01-07 at 12:22 -0800, Andres Freund wrote: > > I don't see how it can *not* cause a major performance / latency > > gotcha. You're deliberately delaying replication after all? > > Are there use cases where someone wants sync rep,

Re: Add 64-bit XIDs into PostgreSQL 15

Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Wed, Jan 5, 2022 at 9:53 PM Alexander Korotkov > wrote: > > 5) 32-bit limitation within the page mentioned upthread by Stephen > > Frost should be also carefully considered. Ideally, we should get rid > > of it, but I don't have parti

Re: Disallow quorum uncommitted (with synchronous standbys) txns in logical replication subscribers

On Fri, 2022-01-07 at 12:22 -0800, Andres Freund wrote: > I don't see how it can *not* cause a major performance / latency > gotcha. You're deliberately delaying replication after all? Are there use cases where someone wants sync rep, and also wants their read replicas to get ahead of the sync rep

Re: Removing more vacuumlazy.c special cases, relfrozenxid optimizations

On Fri, Jan 7, 2022 at 12:24 PM Robert Haas wrote: > This seems like a weak argument. Sure, you COULD hard-code the limit > to be autovacuum_freeze_max_age/2 rather than making it a separate > tunable, but I don't think it's better. I am generally very skeptical > about the idea of using the same

Re: [PATCH] allow src/tools/msvc/*.bat files to be called from the root of the source tree

On 1/4/22 08:37, Andrew Dunstan wrote: > On 1/4/22 07:20, Michael Paquier wrote: >> On Wed, Dec 29, 2021 at 09:48:14AM -0500, Andrew Dunstan wrote: >>> Seems reasonable. I don't see any reason not to do it for pgbison.bat >>> and pgflex.bat, just for the sake of consistency. >> Yeah, that would c

Re: Updating Copyright notices to 2022?

On Thu, Jan 6, 2022 at 02:48:05PM +0900, Michael Paquier wrote: > Hi all, > > $subject is taken care of by Bruce every year, but this has not been > done yet. That's one run of src/tools/copyright.pl on HEAD (as of the > attached) combined with updates of ./doc/src/sgml/legal.sgml and > ./COPYRI

Re: \dP and \dX use ::regclass without "pg_catalog."

On Fri, Jan 07, 2022 at 08:08:57PM +0900, Michael Paquier wrote: > On Fri, Jan 07, 2022 at 06:30:30PM +0900, Tatsuro Yamada wrote: > > We should prefix them with pg_catalog as well. > > Are you planning to make a patch? > > If not, I'll make a patch later since that's where \dX is. > > If any of y

Re: Add 64-bit XIDs into PostgreSQL 15

On Wed, Jan 5, 2022 at 9:53 PM Alexander Korotkov wrote: > I see at least the following major issues/questions in this patch. > 1) Current code relies on the fact that TransactionId can be > atomically read from/written to shared memory. With 32-bit systems > and 64-bit TransactionId, that's not

Re: libpq compression (part 2)

Greetings, * Bruce Momjian (br...@momjian.us) wrote: > On Fri, Jan 7, 2022 at 03:56:39PM -0500, Stephen Frost wrote: > > As for the details of how we allow control over it, I suppose there's a > > number of options. Having it in the HBA doesn't seem terrible, though I > > suspect most will just

Re: Add 64-bit XIDs into PostgreSQL 15

On Thu, Jan 6, 2022 at 3:45 PM Peter Geoghegan wrote: > On Tue, Jan 4, 2022 at 9:40 PM Fujii Masao > wrote: > > Could you tell me what happens if new tuple with XID larger than xid_base + > > 0x is inserted into the page? Such new tuple is not allowed to be > > inserted into that page?

Re: libpq compression (part 2)

On Fri, Jan 7, 2022 at 03:56:39PM -0500, Stephen Frost wrote: > As for the details of how we allow control over it, I suppose there's a > number of options. Having it in the HBA doesn't seem terrible, though I > suspect most will just want to enable it across the board and having to > have "compr

Re: libpq compression (part 2)

Greetings, * Justin Pryzby (pry...@telsasoft.com) wrote: > On Fri, Jan 07, 2022 at 01:46:00PM -0500, Bruce Momjian wrote: > > On Sat, Jan 1, 2022 at 11:25:05AM -0600, Justin Pryzby wrote: > > > Thanks for working on this. The patch looks to be in good shape - I hope > > > more > > > people will

Re: make MaxBackends available in _PG_init

On Fri, Jan 7, 2022 at 1:09 PM Bossart, Nathan wrote: > I wouldn't be surprised to learn of other cases, but I've only > encountered this specific issue with MaxBackends. I think MaxBackends > is notable because it is more likely to be used by preloaded libraries > but is intentionally initialize

Re: Removing more vacuumlazy.c special cases, relfrozenxid optimizations

On Thu, Jan 6, 2022 at 5:46 PM Peter Geoghegan wrote: > One obvious reason for this is that the opportunistic freezing stuff > is expected to be the thing that usually forces freezing -- not > vacuum_freeze_min_age, nor FreezeLimit, nor any other XID-based > cutoff. As you more or less pointed out

Re: Disallow quorum uncommitted (with synchronous standbys) txns in logical replication subscribers

Hi, On 2022-01-06 23:24:40 -0800, Jeff Davis wrote: > It feels like the sync quorum should always be ahead of the async > replicas. Unless I'm missing a use case, or there is some kind of > performance gotcha. I don't see how it can *not* cause a major performance / latency gotcha. You're deliber

Re: Worth using personality(ADDR_NO_RANDOMIZE) for EXEC_BACKEND on linux?

On 11/23/21, 11:29 AM, "Thomas Munro" wrote: > Here's a patch for Linux and also FreeBSD. The latter OS decided to > turn on ASLR by default recently, causing my workstation to fail like > this quite reliably, which reminded me to follow up with this. It > disables ASLR in pg_ctl and pg_regress,

Re: Disallow quorum uncommitted (with synchronous standbys) txns in logical replication subscribers

On Sat, 2022-01-08 at 00:13 +0530, Bharath Rupireddy wrote: > If there are long running txns on the primary and the async standbys > were to wait until quorum commit from sync standbys, won't they fall > behind the primary by too much? No, because replication is based on LSNs, not transactions. W

Re: libpq compression (part 2)

On Fri, Jan 07, 2022 at 01:46:00PM -0500, Bruce Momjian wrote: > On Sat, Jan 1, 2022 at 11:25:05AM -0600, Justin Pryzby wrote: > > Thanks for working on this. The patch looks to be in good shape - I hope > > more > > people will help to review and test it. I took the liberty of creating a > >

Re: libpq compression (part 2)

On Sat, Jan 1, 2022 at 11:25:05AM -0600, Justin Pryzby wrote: > Thanks for working on this. The patch looks to be in good shape - I hope more > people will help to review and test it. I took the liberty of creating a new > CF entry. http://cfbot.cputube.org/daniil-zakhlystov.html > > +zpq_shoul

Re: Disallow quorum uncommitted (with synchronous standbys) txns in logical replication subscribers

On Fri, Jan 7, 2022 at 12:54 PM Jeff Davis wrote: > > On Wed, 2022-01-05 at 23:59 -0800, SATYANARAYANA NARLAPURAM wrote: > > I would like to propose a GUC send_Wal_after_quorum_committed which > > when set to ON, walsenders corresponds to async standbys and logical > > replication workers wait unt

Re: Disallow quorum uncommitted (with synchronous standbys) txns in logical replication subscribers

On 1/6/22, 11:25 PM, "Jeff Davis" wrote: > On Wed, 2022-01-05 at 23:59 -0800, SATYANARAYANA NARLAPURAM wrote: >> I would like to propose a GUC send_Wal_after_quorum_committed which >> when set to ON, walsenders corresponds to async standbys and logical >> replication workers wait until the LSN is

Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file

On 1/7/22, 5:52 AM, "David Steele" wrote: > On 1/6/22 20:20, Euler Taveira wrote: >> On Thu, Jan 6, 2022, at 9:48 PM, Bossart, Nathan wrote: >>> After a quick glance, I didn't see an easy way to hold a session open >>> while the test does other things. If there isn't one, modifying >>> backup_fs_

Re: row filtering for logical replication

On Fri, Jan 7, 2022, at 6:05 AM, Amit Kapila wrote: > Euler, I have one more question about this patch for you. I see that > in the patch we are calling coerce_to_target_type() in > pgoutput_row_filter_init_expr() but do we really need the same? We > already do that via > transformPubWhereClauses->

Re: Disallow quorum uncommitted (with synchronous standbys) txns in logical replication subscribers

On Fri, Jan 7, 2022 at 12:27 AM Kyotaro Horiguchi wrote: > At Thu, 6 Jan 2022 23:55:01 -0800, SATYANARAYANA NARLAPURAM < > satyanarlapu...@gmail.com> wrote in > > On Thu, Jan 6, 2022 at 11:24 PM Jeff Davis wrote: > > > > > On Wed, 2022-01-05 at 23:59 -0800, SATYANARAYANA NARLAPURAM wrote: > > >

Re: Python Plain Text Sender

On Fri, Jan 07, 2022 at 03:48:24PM +0300, Ali Koca wrote: > to Dear Hackers, > > I decided to we need basic e-mail sender in command line when coding > somethings and asking one-line questions. Why ? Are there mail clients for which this is hard to do ? I don't think a custom MUA/mail client is

Re: Add 64-bit XIDs into PostgreSQL 15

On Fri, 7 Jan 2022 at 16:09, Justin Pryzby wrote: > > On Fri, Jan 07, 2022 at 03:53:51PM +, Finnerty, Jim wrote: > > I'd still like a plan to retire the "double xmax" representation > > eventually. Previously I suggested that this could be done as a > > post-process, before upgrade is compl

Re: ICU for global collation

Julien Rouhaud wrote: > If you want a database with an ICU default collation the lc_collate > and lc_ctype should inherit what's in the template database and not > what was provided in the LOCALE I think. You could still probably > overload them in some scenario, but without a list of wha

[no subject]

to Dear Hackers, I decided to we need basic e-mail sender in command line when coding somethings and asking one-line questions. Ali KocaFrom 21be4e168fae83bfcd67b219d6e4234a48f0f4f9 Mon Sep 17 00:00:00 2001 From: Ali Koca Date: Fri, 7 Jan 2022 15:28:12 +0300 Subject: [PATCH] sending plain tex

Re: make MaxBackends available in _PG_init

On 2021/08/16 13:02, Bossart, Nathan wrote: On 8/15/21, 1:05 AM, "wangsh.f...@fujitsu.com" wrote: I don't think calling function GetMaxBackends() in the for loop is a good idea. How about use a temp variable to save the return value of function GetMaxBackends() ? I did this in v4. There

Re: Add 64-bit XIDs into PostgreSQL 15

On Fri, Jan 7, 2022 at 03:53:51PM +, Finnerty, Jim wrote: > Re: The "prepare" approach was the first tried. > https://github.com/postgrespro/pg_pageprep But it appears to be > very difficult and unreliable. After investing many months into > pg_pageprep, "double xmax" approach appears to be v

Re: enhance pg_log_backend_memory_contexts() to log memory contexts of auxiliary processes

On Fri, Jan 7, 2022 at 9:19 PM Fujii Masao wrote: > > On 2021/11/29 11:44, vignesh C wrote: > > Thanks for the updated patch. The patch applies neatly, make > > check-world passes and the documentation looks good. I did not find > > any issues with the v6 patch, I'm marking the patch as Ready for

Re: Add 64-bit XIDs into PostgreSQL 15

On 07.01.22 06:18, Fujii Masao wrote: On 2022/01/06 19:24, Simon Riggs wrote: On Thu, 30 Dec 2021 at 13:19, Maxim Orlov wrote: Your opinions are very much welcome! This is a review of the Int64 options patch, "v6-0001-Add-64-bit-GUCs-for-xids.patch" Do we really need to support both int32

Re: Add 64-bit XIDs into PostgreSQL 15

On Fri, Jan 07, 2022 at 03:53:51PM +, Finnerty, Jim wrote: > I'd still like a plan to retire the "double xmax" representation eventually. > Previously I suggested that this could be done as a post-process, before > upgrade is complete, but that could potentially make upgrade very slow. > >

Re: Add 64-bit XIDs into PostgreSQL 15

Re:The "prepare" approach was the first tried. https://github.com/postgrespro/pg_pageprep But it appears to be very difficult and unreliable. After investing many months into pg_pageprep, "double xmax" approach appears to be very fast to implement and reliable. I'd still like

Re: enhance pg_log_backend_memory_contexts() to log memory contexts of auxiliary processes

On 2021/11/29 11:44, vignesh C wrote: Thanks for the updated patch. The patch applies neatly, make check-world passes and the documentation looks good. I did not find any issues with the v6 patch, I'm marking the patch as Ready for Committer. I started reading the patch. +CREATE FUNCTION m

Re: Add 64-bit XIDs into PostgreSQL 15

Re: clog page numbers, as returned by TransactionIdToPage - int pageno = TransactionIdToPage(xid); /* get page of parent */ + int64 pageno = TransactionIdToPage(xid); /* get page of parent */ ... - int pageno = Trans

Re: CREATEROLE and role ownership hierarchies

On Wed, Jan 5, 2022 at 7:05 PM Mark Dilger wrote: > > On Jan 4, 2022, at 12:47 PM, Joshua Brindle > > wrote: > > > >> I was able to reproduce that using REASSIGN OWNED BY to cause a user to > >> own itself. Is that how you did it, or is there yet another way to get > >> into that state? > >

Re: Fix vcregress plpython3 warning

On Fri, Jan 7, 2022 at 3:24 PM Andrew Dunstan wrote: > > In that case, just this should work: > > s/EXTENSION (\S*?)plpython2?u/EXTENSION $1plpython3u/g ; > > LGTM. Regards, Juan José Santamaría Flecha

Re: pgsql: Refactor tar method of walmethods.c to rely on the compression m

Re: Michael Paquier > Refactor tar method of walmethods.c to rely on the compression method Hi, since about this commit, pg_wal.tar is no longer compressed at all: $ pg_basebackup -D foo --format=tar $ ls -l foo/ -rw--- 1 cbe cbe 137152 7. Jan 15:37 backup_manifest -rw--- 1 cbe cbe

Re: ICU for global collation

On 04.01.22 17:03, Peter Eisentraut wrote: There are really a lot of places with this new code.  Maybe it could be some new function/macro to wrap that for the normal case (e.g. not formatting.c)? Right, we could just put this into pg_newlocale_from_collation(), but the comment there says

Re: Fix vcregress plpython3 warning

On 1/7/22 08:56, Juan José Santamaría Flecha wrote: > > On Fri, Jan 7, 2022 at 2:30 PM Andrew Dunstan wrote: > > > Yeah, this code is not a model of clarity though. I had to think > through > it and I write quite a bit of perl. I would probably write it > something > like thi

Re: Fix vcregress plpython3 warning

On Fri, Jan 7, 2022 at 2:56 PM Juan José Santamaría Flecha < juanjo.santama...@gmail.com> wrote: copy-paste > s/EXTENSION plpython2?u/EXTENSION plpython3u/g > s/EXTENSION ([^ ]*)_plpython2?u/EXTENSION $1_plpython3u/g >

Re: Fix vcregress plpython3 warning

On Fri, Jan 7, 2022 at 2:30 PM Andrew Dunstan wrote: > > Yeah, this code is not a model of clarity though. I had to think through > it and I write quite a bit of perl. I would probably write it something > like this: > > > s/EXTENSION (.*?)plpython2?u/EXTENSION $1plpython3u/g ; > > Yeah, I had to

Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file

On 1/6/22 20:20, Euler Taveira wrote: On Thu, Jan 6, 2022, at 9:48 PM, Bossart, Nathan wrote: After a quick glance, I didn't see an easy way to hold a session open while the test does other things.  If there isn't one, modifying backup_fs_hot() to work with non-exclusive mode might be more troub

Re: row filtering for logical replication

On Fri, Jan 7, 2022, at 3:35 AM, Amit Kapila wrote: > On Fri, Jan 7, 2022 at 9:44 AM Amit Kapila wrote: > > > > On Thu, Jan 6, 2022 at 6:42 PM Euler Taveira wrote: > > > > > > IMO we shouldn't reuse ReorderBufferChangeType. For a long-term solution, > > > it is > > > fragile. ReorderBufferChange

Re: Fix vcregress plpython3 warning

On 1/7/22 07:20, Juan José Santamaría Flecha wrote: > Hi, > > When running the plcheck in Windows we get the following warning, it > is visible in the cfbots [1]: > > Use of uninitialized value $1 in concatenation (.) or string at > src/tools/msvc/vcregress.pl line 350. > >

Re: sqlsmith: ERROR: XX000: bogus varno: 2

On Fri, Jan 7, 2022 at 12:24 AM Tom Lane wrote: > Amit Langote writes: > > Thanks for addressing that in the patch you posted. I guess fixing > > only expression_tree_walker/mutator() suffices for now, but curious to > > know if it was intentional that you decided not to touch the following > >

Re: Column Filtering in Logical Replication

On Fri, Jan 7, 2022 at 5:16 PM Peter Eisentraut wrote: > > src/backend/commands/tablecmds.c: > > ATExecReplicaIdentity(): Regarding the question of how to handle > REPLICA_IDENTITY_NOTHING: I see two ways to do this. Right now, the > approach is that the user can set the replica identity freely,

Re: RFC: Logging plan of the running query

On 2022/01/07 20:58, torikoshia wrote: On 2022-01-07 14:30, torikoshia wrote: Updated the patch for fixing compiler warning about the format on windows. I got another compiler warning, updated the patch again. Thanks for updating the patch! I ran the following query every 0.1s by using \

Re: Use generation context to speed up tuplesorts

Le vendredi 7 janvier 2022, 13:03:28 CET Tomas Vondra a écrit : > On 1/7/22 12:03, Ronan Dunklau wrote: > > Le vendredi 31 décembre 2021, 22:26:37 CET David Rowley a écrit : > >> I've attached some benchmark results that I took recently. The > >> spreadsheet contains results from 3 versions. maste

Python Plain Text Sender

to Dear Hackers, I decided to we need basic e-mail sender in command line when coding somethings and asking one-line questions. Thanks, Ali KocaFrom 21be4e168fae83bfcd67b219d6e4234a48f0f4f9 Mon Sep 17 00:00:00 2001 From: Ali Koca Date: Fri, 7 Jan 2022 15:28:12 +0300 Subject: [PATCH] sending p

Fix vcregress plpython3 warning

Hi, When running the plcheck in Windows we get the following warning, it is visible in the cfbots [1]: Use of uninitialized value $1 in concatenation (.) or string at src/tools/msvc/vcregress.pl line 350. This points to mangle_plpython3 subroutine. The attached patch addresses the problem. [1]

Re: Use generation context to speed up tuplesorts

On 1/7/22 12:03, Ronan Dunklau wrote: Le vendredi 31 décembre 2021, 22:26:37 CET David Rowley a écrit : I've attached some benchmark results that I took recently. The spreadsheet contains results from 3 versions. master, master + 0001 - 0002, then master + 0001 - 0003. The 0003 patch makes the

Re: RFC: Logging plan of the running query

On 2022-01-07 14:30, torikoshia wrote: Updated the patch for fixing compiler warning about the format on windows. I got another compiler warning, updated the patch again. -- Regards, -- Atsushi Torikoshi NTT DATA CORPORATIONFrom b8367e22d7a9898e4b85627ba8c203be273fc22f Mon Sep 17 00:00:00 20

Re: Column Filtering in Logical Replication

I think this is getting pretty good now. I like the overall behavior now. Some details: There are still a few references to "filter", but I see most of the patch now uses column list or something. Maybe do another cleanup pass before finalizing the patch. doc/src/sgml/catalogs.sgml needs to b

Re: \dP and \dX use ::regclass without "pg_catalog."

On Fri, Jan 07, 2022 at 06:30:30PM +0900, Tatsuro Yamada wrote: > We should prefix them with pg_catalog as well. > Are you planning to make a patch? > If not, I'll make a patch later since that's where \dX is. If any of you can make a patch, that would be great. Thanks! -- Michael signature.asc

Re: Logical replication timeout problem

On Wed, Dec 29, 2021 at 5:02 PM Fabrice Chapuis wrote: > I put the instance with high level debug mode. > I try to do some log interpretation: After having finished writing the > modifications generated by the insert in the snap files, > then these files are read (restored). One minute after this

Re: \dP and \dX use ::regclass without "pg_catalog."

Hi Justin, On 2022/01/07 11:22, Justin Pryzby wrote: But, we missed two casts to ::text which don't use pg_catalog. Evidently the cast is to allow stable sorting. Ah, you are right. We should prefix them with pg_catalog as well. Are you planning to make a patch? If not, I'll make a patch late

Re: row filtering for logical replication

On Fri, Jan 7, 2022 at 12:05 PM Amit Kapila wrote: > > On Fri, Jan 7, 2022 at 9:44 AM Amit Kapila wrote: > > > > On Thu, Jan 6, 2022 at 6:42 PM Euler Taveira wrote: > > > > > > IMO we shouldn't reuse ReorderBufferChangeType. For a long-term solution, > > > it is > > > fragile. ReorderBufferChan

Re: ICU for global collation

Hi, I looked a bit more in this patch and I have some additional remarks. On Thu, Dec 30, 2021 at 01:07:21PM +0100, Peter Eisentraut wrote: > > So this is a different approach: If you choose ICU as the default locale for > a database, you still need to specify lc_ctype and lc_collate settings, a

Re: Index-only scan for btree_gist turns bpchar to char

Hello, 07.01.2022 09:26, Japin Li wrote: > On Fri, 07 Jan 2022 at 03:21, Tom Lane wrote: > > In any case, if we do need same() to implement the identical > behavior to bpchareq(), then the other solution isn't sufficient > either. > > So in short, it seems like we ought to do some compatibility te

Re: In-placre persistance change of a relation

At Thu, 06 Jan 2022 16:39:21 +0900 (JST), Kyotaro Horiguchi wrote in > Fantastic! I'll give it a try. Thanks! I did that and found that the test stumbled on newlines. Tests succeeded for other than Windows. Windows version fails for a real known issue. [7916][postmaster] LOG: received immedi

Re: Disallow quorum uncommitted (with synchronous standbys) txns in logical replication subscribers

At Thu, 6 Jan 2022 23:55:01 -0800, SATYANARAYANA NARLAPURAM wrote in > On Thu, Jan 6, 2022 at 11:24 PM Jeff Davis wrote: > > > On Wed, 2022-01-05 at 23:59 -0800, SATYANARAYANA NARLAPURAM wrote: > > > I would like to propose a GUC send_Wal_after_quorum_committed which > > > when set to ON, wals