On Fri, Jul 09, 2021 at 11:31:48PM +, Jacob Champion wrote:
> On Thu, 2021-07-08 at 16:27 +0900, Michael Paquier wrote:
>> + * outputlen: The length (0 or higher) of the client response
>> buffer,
>> + * invalid if output is NULL.
>
> nitpick: maybe "ignor
On Sun, Jul 11, 2021 at 1:28 AM Tom Lane wrote:
> Justin Pryzby writes:
> > On Sun, Jul 11, 2021 at 01:00:27AM +0300, Alexander Korotkov wrote:
> >> True, but I'm a bit uncomfortable about user instances with different
> >> catalogs but the same catversions. On the other hand, initdb's with
> >
> Marking this as ready for committer. It can be committed when the branch
> is cut for 15.
I see that REL_14_STABLE is already cut. So this can go in now.
Hello,
Googling around, I didn't find any extensions that would break from this
change. Even if there are any, this change will simplify the relevant
callsites. It also aligns the interface nicely with get_qual_for_hash,
get_qual_for_list and get_qual_for_range.
Marking this as ready for committe
Justin Pryzby writes:
> On Sun, Jul 11, 2021 at 01:00:27AM +0300, Alexander Korotkov wrote:
>> True, but I'm a bit uncomfortable about user instances with different
>> catalogs but the same catversions. On the other hand, initdb's with
>> beta3 or later will be the vast majority among pg14 instan
On Sun, Jul 11, 2021 at 01:00:27AM +0300, Alexander Korotkov wrote:
> On Sat, Jul 10, 2021 at 7:34 PM Alvaro Herrera
> wrote:
> > On 2021-Jun-27, Alexander Korotkov wrote:
> >
> > > BTW, I found some small inconsistencies in the declaration of
> > > multirange operators in the system catalog. No
On Sat, Jul 10, 2021 at 7:34 PM Alvaro Herrera wrote:
> On 2021-Jun-27, Alexander Korotkov wrote:
>
> > BTW, I found some small inconsistencies in the declaration of
> > multirange operators in the system catalog. Nothing critical, but if
> > we decide to bump catversion in beta3, this patch is a
On Fri, Jul 9, 2021 at 3:49 PM Tom Lane wrote:
>
> Peifeng Qiu writes:
> > I'd like to add kerberos authentication support for postgres_fdw by adding
> > two
> > options to user mapping: krb_client_keyfile and gssencmode.
>
> As you note, this'd have to be restricted to superusers, which makes i
On 7/3/21 12:34 PM, Peter Eisentraut wrote:
On 04.06.21 17:09, Aleksander Alekseev wrote:
I decided to add the patch to the nearest commitfest.
With respect to the commit fest submission, I don't think there is
consensus right now to add this. I think people would prefer that this
dictionar
On Sat, 10 Jul 2021 at 18:30, Tom Lane wrote:
>
> [ moving to pghackers for wider visibility ]
>
> Dean Rasheed writes:
> > On Sat, 10 Jul 2021 at 16:01, Tom Lane wrote:
> >> In general, I'm disturbed that we just threw away the previous
> >> promise that numeric multiplication results were exac
On Mon, 2021-04-05 at 12:07 +, Sait Talha Nisanci wrote:
> Hi Andres,
>
> Please see the updated patch, do you mean something like this? (there
> might be a simpler way for doing this)
>
Committed with minor revisions.
My patch also avoids incrementing NextRecordTypmod until we've already
c
[ moving to pghackers for wider visibility ]
Dean Rasheed writes:
> On Sat, 10 Jul 2021 at 16:01, Tom Lane wrote:
>> In general, I'm disturbed that we just threw away the previous
>> promise that numeric multiplication results were exact. That
>> seems like a pretty fundamental property --- whi
Hello,
Of course, users themselves should be careful of problematic script, but it
would be better that pgbench itself avoids problems if pgbench can beforehand.
Or, we should terminate the last cycle of benchmark regardless it is
retrying or not if -T expires. This will make pgbench behaves
On Sat, Jul 10, 2021 at 4:31 PM Dean Rasheed wrote:
>
> On Sat, 10 Jul 2021 at 11:44, Dean Rasheed wrote:
> >
> > I'm inclined to think that it isn't worth the effort trying to
> > distinguish between conflicting options, options specified more than
> > once and faked-up options that weren't real
Hello Vignesh,
I am changing the status to "Needs review" as the review is not
completed for this patch and also there are some tests failing, that
need to be fixed:
test test_extdepend ... FAILED 50 ms
Indeed,
Attached v4 simplifies the format and fixes this one.
I ran c
On 2021-Jun-27, Alexander Korotkov wrote:
> BTW, I found some small inconsistencies in the declaration of
> multirange operators in the system catalog. Nothing critical, but if
> we decide to bump catversion in beta3, this patch is also nice to
> push.
Hmm, I think you should push this and not b
On 2021-Jul-08, Boris Kolpackov wrote:
> Alvaro Herrera writes:
>
> > To be honest, I am hesitant to changing the charter in that way; I fear
> > it may have consequences I don't foresee. I think the workaround is not
> > *that* bad.
>
> Ok, fair enough. I've updated my code to account for thi
On Sat, Jul 10, 2021 at 4:14 PM Dean Rasheed wrote:
>
> On Thu, 8 Jul 2021 at 14:40, vignesh C wrote:
> >
> > On Thu, Jul 8, 2021 at 1:52 AM Daniel Gustafsson wrote:
> > >
> > > I sort of like the visual cue of seeing ereport(ERROR .. since it makes
> > > it
> > > clear it will break execution
Hi,
I started looking at the patch allowing to export just functions [1],
and I got pointed to this patch as an alternative approach (to adding a
separate filtering option for every possible object type).
I'm familiar with the customer that inspired Pavel to start working on
this, so I under
On Sat, Jul 3, 2021 at 3:07 AM Fabien COELHO wrote:
>
>
> > "-- # QUERY\n%s\n\n"
>
> Attached an attempt along those lines. I found another duplicate of the
> ascii-art printing in another function.
>
> Completion queries seems to be out of the echo/echo hidden feature.
>
> Incredible, there is
On Thu, Apr 22, 2021 at 8:01 AM Simon Riggs
wrote:
>
> 897795240cfaaed724af2f53ed2c50c9862f951f forgot to reduce the lock
> level for CHECK constraints when allowing them to be NOT VALID.
>
> This is simple and safe, since check constraints are not used in
> planning until validated.
The patch al
On Sat, Jul 10, 2021 at 4:59 PM Michael Paquier wrote:
> So I would finish with the attached, close enough to what Quan has
> sent upthread.
Thanks. The patch looks good to me, except a minor comment - isn't it
"int2 for these fields" as the fields still exist? + /* pageinspect >=
1.10 uses int4
On Sat, Jul 10, 2021 at 5:19 PM John Naylor
wrote:
> Side note for future reference: While the feature named in the CF entry has
> been rejected, the remaining 0001 patch currently proposed no longer matches
> the title, or category. It is possible within the CF app, and helpful, to
> rename th
On Wed, May 12, 2021 at 5:45 PM Pavel Stehule wrote:
>
>
>
> st 12. 5. 2021 v 12:25 odesílatel Pavel Stehule
> napsal:
>>
>> Hi
>>
>> st 21. 4. 2021 v 8:52 odesílatel Pavel Stehule
>> napsal:
>>>
>>>
>>>
>>> st 21. 4. 2021 v 8:49 odesílatel Thomas Munro
>>> napsal:
On Wed, Apr 21,
On Mon, May 31, 2021 at 10:47 AM Greg Nancarrow wrote:
>
> On Sat, Mar 6, 2021 at 12:31 PM Thomas Munro wrote:
> >
> > On Tue, Mar 2, 2021 at 11:27 PM Thomas Munro wrote:
> > > On Fri, Feb 12, 2021 at 11:02 AM Melanie Plageman
> > > wrote:
> > > > I just attached the diff.
> > >
> > > Squashed
I have played with v14 patch. I previously complained that pgbench
always reported 9 errors (actually the number is always the number
specified by "-c" -1 in my case).
$ pgbench -p 11000 -c 10 -T 10 --max-tries=0 test
pgbench (15devel, server 13.3)
starting vacuum...end.
transaction type:
scali
On Sat, Jul 10, 2021 at 2:17 AM Andres Freund wrote:
>
> Hi,
>
> On 2021-07-07 20:46:38 +0900, Masahiko Sawada wrote:
> > Currently, the TIDs of dead tuples are stored in an array that is
> > collectively allocated at the start of lazy vacuum and TID lookup uses
> > bsearch(). There are the follow
On Tue, Mar 16, 2021 at 8:13 AM Bharath Rupireddy <
bharath.rupireddyforpostg...@gmail.com> wrote:
>
> On Tue, Mar 16, 2021 at 1:15 AM Tom Lane wrote:
> > I don't really see that this feature buys us anything you can't
> > get by explaining the view's query, so I think we're better advised
> > to
On Fri, Jul 09, 2021 at 10:13:20AM +, Peifeng Qiu wrote:
> I'd like to add kerberos authentication support for postgres_fdw by adding two
> options to user mapping: krb_client_keyfile and gssencmode.
You may want to register this patch into the next commit fest, to get
it reviewed for a potent
On Fri, Jul 09, 2021 at 05:26:37PM +0530, Bharath Rupireddy wrote:
> 1) How about just adding a comment /* support for old extension
> version */ before INT2OID handling?
> + case INT2OID:
> + values[3] = UInt16GetDatum(page->pd_lower);
> + break;
Yes, having a comment to document from which versi
On 7/10/21 1:43 AM, Tom Lane wrote:
Tomas Vondra writes:
The main question I have is whether this should include procedures.
I feel a bit uncomfortable about sticking this sort of limited-purpose
selectivity mechanism into pg_dump. I'd rather see a general filter
method that can select objec
On Sat, 10 Jul 2021 at 11:44, Dean Rasheed wrote:
>
> I'm inclined to think that it isn't worth the effort trying to
> distinguish between conflicting options, options specified more than
> once and faked-up options that weren't really specified. If we just
> make errorConflictingDefElem() report
On Thu, 8 Jul 2021 at 14:40, vignesh C wrote:
>
> On Thu, Jul 8, 2021 at 1:52 AM Daniel Gustafsson wrote:
> >
> > I sort of like the visual cue of seeing ereport(ERROR .. since it makes it
> > clear it will break execution then and there, this will require a lookup for
> > anyone who don't know
Hello again,
I hoped we were done here but I realised that your check for 1-3 log
lines will not survive the harsh environment of the build farm.
Adding sleep(2) before the final doLog() confirms that. I had two
ideas:
So I think we should do 1 for now. Objections or better ideas?
At lea
On 5/18/21 9:23 PM, Andrew Dunstan wrote:
On 5/8/21 2:23 PM, Andrew Dunstan wrote:
On 4/12/21 11:34 AM, Erik Rijkers wrote:
On 2021.03.27. 02:12 Nikita Glukhov wrote:
Attached 47th version of the patches.
We're past feature freeze for 14 and alas, JSON_TABLE has not made it.
I have tested q
Works for me: patch applies, global and local check ok. I'm fine with it.
I hoped we were done here but I realised that your check for 1-3 log
lines will not survive the harsh environment of the build farm.
Adding sleep(2) before the final doLog() confirms that. I had two
ideas:
1. Give up
On Mon, Jun 21, 2021 at 12:06 PM Nitin Jadhav
wrote:
> That was by mistake and I have corrected it in the attached patch.
Thanks for the patch. Here are some comments. Please ignore if I
repeat any of the comments given previously, as I didn't look at the
entire thread.
1) A new line between fun
37 matches
Mail list logo
