On Tue, May 4, 2021 at 9:08 PM Tom Lane wrote:
>
> Bharath Rupireddy writes:
> > On Tue, May 4, 2021 at 4:12 AM Tom Lane wrote:
> >> The buildfarm is showing that one of these test queries is not stable
> >> under CLOBBER_CACHE_ALWAYS:
>
> > I can reproduce the issue with the failing case. Issue
On Wed, May 5, 2021 at 3:20 PM Bharath Rupireddy
wrote:
>
> On Wed, May 5, 2021 at 8:05 AM Tom Lane wrote:
> >
> > Peter Smith writes:
> > > This patch replaces the global "wrconn" in AlterSubscription_refresh with
> > > a local variable of the same name, making it consistent with other
> > >
On Tue, May 4, 2021 at 10:12 PM Robert Haas wrote:
> > Is this true? that only when we have to wait for the next file to be
> > ready we got for scanning? If I read the code in
> > "pgarch_ArchiverCopyLoop", for every single file to achieve it is
> > calling "pgarch_readyXlog", wherein it scans
On Wed, May 5, 2021 at 12:06 AM Robert Haas wrote:
>
> > There are no tests in pg_dump to make sure that some ALTER
> > MATERIALIZED VIEW or ALTER TABLE commands are generated when the
> > compression of a matview's or table's column is changed.
>
> True, but it does seem to work. I am happy if y
On Wed, May 5, 2021 at 8:05 AM Tom Lane wrote:
>
> Peter Smith writes:
> > This patch replaces the global "wrconn" in AlterSubscription_refresh with a
> > local variable of the same name, making it consistent with other functions
> > in subscriptioncmds.c (e.g. DropSubscription).
> > The global
On Thu, Apr 29, 2021 at 9:31 AM Justin Pryzby wrote:
>
> On Tue, Apr 27, 2021 at 03:22:25PM +0900, Michael Paquier wrote:
> > Hi all,
>
> > And so, ALTER MATERIALIZED VIEW supports SET COMPRESSION but this is
> > not mentioned in its docs:
> > https://www.postgresql.org/docs/devel/sql-altermateria
On Wed, 5 May 2021 at 09:15, Craig Ringer wrote:
>> warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
>> 1322 |TRACE_POSTGRESQL_LWLOCK_WAIT_START(T_NAME(lock), mode);
>> | ^
>
> Odd that I didn't get t
On Tue, May 04, 2021 at 10:35:02PM -0400, Tom Lane wrote:
> Peter Smith writes:
> > This patch replaces the global "wrconn" in AlterSubscription_refresh with a
> > local variable of the same name, making it consistent with other functions
> > in subscriptioncmds.c (e.g. DropSubscription).
> > Th
On Wed, May 5, 2021 at 5:09 AM Robert Haas wrote:
>
> On Fri, Apr 23, 2021 at 10:53 PM Amit Kapila wrote:
> > Isn't parallel safety also the C code property?
>
> > Also, if the strict property of built-in functions is fixed
> > internally, why we allow users to change it and is that of any help?
Peter Smith writes:
> This patch replaces the global "wrconn" in AlterSubscription_refresh with a
> local variable of the same name, making it consistent with other functions in
> subscriptioncmds.c (e.g. DropSubscription).
> The global wrconn is only meant to be used for logical apply/tablesync
On Tue, May 4, 2021 at 5:40 PM Andres Freund wrote:
> What does the deduplication actually require from tids? Isn't it just
> that you need to be able to compare tids?
It's hard to know for sure what is essential to the design, and what
can be discarded. Though I can say for sure that it depends
On Tue, 2021-05-04 at 13:51 -0700, Peter Geoghegan wrote:
> I think maybe it is possible for GIN to work with your column store
> table AM in particular. Why aren't we talking about that concrete
> issue, or something like that?
Happy to.
At this point I'd rather obey the constraint that the offs
On Wed, 5 May 2021, 06:15 Andres Freund, wrote:
> Hi,
>
> warning: suggest braces around empty body in an ‘if’ statement
> [-Wempty-body]
> 1322 |TRACE_POSTGRESQL_LWLOCK_WAIT_START(T_NAME(lock), mode);
> | ^
>
Odd that I didn't
Hi,
On 2021-05-04 15:47:41 -0400, Tom Lane wrote:
> BTW, that conclusion shouldn't distract us from the very real bug
> that Andres identified. I was just scraping the buildfarm logs
> concerning recent failures, and I found several recent cases
> that match the symptom he reported:
> [...]
> The
Hi,
On 2021-05-04 14:13:36 -0700, Peter Geoghegan wrote:
> On Mon, May 3, 2021 at 10:01 PM Andres Freund wrote:
> > > For example, the TIDs should always work like unsigned integers -- the
> > > table AM must be willing to work with that restriction.
> >
> > Isn't that more a question of the enco
On Mon, May 03, 2021 at 02:59:42PM -0400, Bruce Momjian wrote:
> On Sun, May 2, 2021 at 12:27:37PM +0800, Julien Rouhaud wrote:
> > Hi Aleksander,
> >
> > On Wed, Apr 28, 2021 at 03:22:39PM +0300, Aleksander Alekseev wrote:
> > > Hi Julien,
> > >
> > > > You should see failures doing a check-wor
PSA v2 of this patch - it has the same content, but an improved commit comment.
I have also added a commitfest entry, https://commitfest.postgresql.org/33/3109/
--
Kind Regards,
Peter Smith
Fujitsu Australia
v2-0001-Fix-wrconn.-Use-stack-variable.patch
Description: Binary data
Hi,
On 2021-05-03 21:06:30 +0200, Peter Eisentraut wrote:
> On 30.04.21 05:22, Craig Ringer wrote:
> > On Thu, 29 Apr 2021 at 15:31, Peter Eisentraut
> > wrote:
> > > > So if you could produce a separate patch that adds the
> > > > _ENABLED guards targeting PG14 (and PG13), that would be helpful.
On Mon, May 3, 2021 at 10:01 PM Andres Freund wrote:
> > For example, the TIDs should always work like unsigned integers -- the
> > table AM must be willing to work with that restriction.
>
> Isn't that more a question of the encoding than the concrete representation?
I don't think so, no. How do
On Tue, May 04, 2021 at 01:35:50PM -0400, Greg Stark wrote:
> Fwiw, I have a suspicion that the right check for being init is
> whether `pid == ppid`.
pryzbyj@pryzbyj:~$ ps -wwf 1
UIDPID PPID C STIME TTY STAT TIME CMD
root 1 0 0 2020 ?Ss10:28 /sbin/init
On Tue, May 4, 2021 at 11:52 AM Jeff Davis wrote:
> On Mon, 2021-05-03 at 15:07 -0700, Peter Geoghegan wrote:
> > It seems senseless to *require* table AMs to support something like a
> > bitmap scan.
>
> I thought about this some more, and this framing is backwards.
> ItemPointers are fundamental
Andrew Dunstan writes:
> On 5/3/21 5:13 PM, Dagfinn Ilmari Mannsåker wrote:
>> Given that a number of minimal `init`s already exist specifically for
>> the case of running a single application in a container, I don't think
>> Postgres should to reinvent that wheel. A quick eyball of the output of
On 5/3/21 5:13 PM, Dagfinn Ilmari Mannsåker wrote:
> Tom Lane writes:
>
>
>> Maybe we should put in a startup-time check, analogous to the
>> can't-run-as-root test, that the postmaster mustn't be PID 1.
> Given that a number of minimal `init`s already exist specifically for
> the case of runnin
I wrote:
> I suppose that if we're unable to reproduce it on at least one other box,
> we have to write it off as hardware flakiness.
BTW, that conclusion shouldn't distract us from the very real bug
that Andres identified. I was just scraping the buildfarm logs
concerning recent failures, and I
On Wed, Apr 28, 2021 at 9:42 PM houzj.f...@fujitsu.com
wrote:
> So, If we do not want to lock down the parallel safety of built-in functions.
> It seems we can try to fetch the proparallel from pg_proc for built-in
> function
> in fmgr_info_cxt_security too. To avoid recursive safety check when f
út 4. 5. 2021 v 20:59 odesílatel Fabien COELHO napsal:
>
> Hello Pavel,
>
> > 1. print server version to the output of pgbench. Now only client side
> > version is printed
>
> It is easy enough and makes sense. Maybe only if it differs from the
> client side version ?
>
This is not a simple ques
On Fri, Apr 23, 2021 at 10:53 PM Amit Kapila wrote:
> Isn't parallel safety also the C code property?
In my opinion, yes.
> So, isn't it better to disallow changing parallel
> safety for built-in functions?
Superusers can do a lot of DML operations on the system catalogs that
are manifestly uns
On Tue, 2021-05-04 at 12:56 -0400, Robert Haas wrote:
> b. If you actually meant "less than or equal to MaxOffsetNumber",
> > that will fail with the GIN posting list issue raised in my first
> > email. Do you agree that's a bug?
>
> Given the above, yes.
If we just subtracted one, it would fit
Hello Pavel,
1. print server version to the output of pgbench. Now only client side
version is printed
It is easy enough and makes sense. Maybe only if it differs from the
client side version ?
2. can ve generate some output in structured format - XML, JSON ?
It is obviously possible,
On Tue, May 4, 2021 at 2:26 PM Tom Lane wrote:
> You are arguing from assumptions not in evidence, specifically that
> if we reap a PID that isn't one we recognize, this must be what
> happened. I think it's *at least* as likely that the case implies
> some bug in the postmaster's child-process b
On Mon, 2021-05-03 at 15:07 -0700, Peter Geoghegan wrote:
> It seems senseless to *require* table AMs to support something like a
> bitmap scan.
I thought about this some more, and this framing is backwards.
ItemPointers are fundamental to the table AM API: they are passed in to
required methods,
Hi,
My analysis of this open item is there are no code-level issues here,
but there is one line of documentation that clearly got forgotten,
some other documentation changes that might be nice, and maybe someone
wants to work more on testing and/or tab completion at some point.
On Tue, Apr 27, 20
Robert Haas writes:
> On Mon, May 3, 2021 at 3:37 PM Tom Lane wrote:
>> I think that'd be a net reduction in reliability, not an improvement.
>> In most scenarios it'd do little except mask bugs. And who's to say
>> that ignoring unexpected child deaths is okay, anyway? We could hardly
>> be su
> On May 4, 2021, at 9:43 AM, Justin Pryzby wrote:
>
> + /* Oversized toasted attributes should never be stored */
> + if (toast_pointer.va_rawsize > VARLENA_SIZE_LIMIT)
> + report_corruption(ctx,
> + psprintf("toast valu
On 5/4/21 1:43 PM, Tom Lane wrote:
Greg Stark writes:
On Mon, 3 May 2021 at 15:44, Tom Lane wrote:
BTW, as far as that goes, I think the general recommendation is that
the datadir shouldn't be a mount point, because bad things happen if
you mount or unmount the drive while the postmaster is u
On Mon, May 3, 2021 at 3:37 PM Tom Lane wrote:
> > I guess we can do that in older releases, but do we really need it? As
> > I understand, the only thing we need to do is verify that the dying PID
> > is a backend PID, and not cause a crash cycle if it isn't.
>
> I think that'd be a net reductio
Greg Stark writes:
> On Mon, 3 May 2021 at 15:44, Tom Lane wrote:
>> BTW, as far as that goes, I think the general recommendation is that
>> the datadir shouldn't be a mount point, because bad things happen if
>> you mount or unmount the drive while the postmaster is up. I could
>> see enforcing
On Mon, 3 May 2021 at 15:44, Tom Lane wrote:
>
> Alvaro Herrera writes:
> > I also heard a story where things ran into trouble (I didn't get the
> > whole story of *what* was the problem with that) because the datadir is /.
>
> BTW, as far as that goes, I think the general recommendation is that
Hi,
On 2021-05-04 12:32:34 -0400, Tom Lane wrote:
> Andres Freund writes:
> > Michael Paquier (running locally I think), and subsequently Thomas Munro
> > (noticing [1]), privately reported that they noticed an assertion failure in
> > GetSnapshotData(). Both reasonably were wondering if that's r
On Mon, May 3, 2021 at 2:13 PM Jeff Davis wrote:
> That's not clear to me at all, and is the whole reason I began this
> thread.
>
> a. You say "smaller than MaxOffsetNumber", but that's a little weird.
> If an offset can't be MaxOffsetNumber, it's not really the maximum, is
> it?
I wasn't tryi
+ /* Oversized toasted attributes should never be stored */
+ if (toast_pointer.va_rawsize > VARLENA_SIZE_LIMIT)
+ report_corruption(ctx,
+ psprintf("toast value %u
rawsize %u exceeds limit %u",
+
On Tue, May 4, 2021 at 11:54 AM Dilip Kumar wrote:
> I agree that if we continue to archive one file using the archive
> command then Robert's solution of checking the existence of the next
> WAL segment (N+1) has an advantage. But, currently, if you notice
> pgarch_readyXlog always consider any
Andres Freund writes:
> Michael Paquier (running locally I think), and subsequently Thomas Munro
> (noticing [1]), privately reported that they noticed an assertion failure in
> GetSnapshotData(). Both reasonably were wondering if that's related to the
> snapshot scalability patches.
> Michael rep
Hackers,
During the version 14 development period, a few checks of toasted attributes
were written but never committed. For the version 15 development cycle, I'd
like to consider extending the checks of toasted attributes. First, no toasted
attribute should ever have a rawsize larger than the
iOn Tue, May 4, 2021 at 7:38 PM Robert Haas wrote:
>
> On Tue, May 4, 2021 at 12:27 AM Andres Freund wrote:
> > On 2021-05-03 16:49:16 -0400, Robert Haas wrote:
> > > I have two possible ideas for addressing this; perhaps other people
> > > will have further suggestions. A relatively non-invasi
Bharath Rupireddy writes:
> On Tue, May 4, 2021 at 4:12 AM Tom Lane wrote:
>> The buildfarm is showing that one of these test queries is not stable
>> under CLOBBER_CACHE_ALWAYS:
> I can reproduce the issue with the failing case. Issue is that the
> backend pid will be null in the pg_stat_activi
Hi Lukasz, thanks for following up.
On 2021-May-04, Lukasz Biegaj wrote:
> The problem is as described in
> https://www.postgresql.org/message-id/flat/8bf8785c-f47d-245c-b6af-80dc1eed40db%40unitygroup.com
>
> It does occur on two separate production clusters and one test cluster - all
> belongi
On Tue, May 4, 2021 at 6:50 PM vignesh C wrote:
> Thanks for the comments, Attached patch has the fixes for the same.
Thanks! I took a final look over the v8 patch, it looks good to me and
regression tests were passed with it. I have no further comments at
this moment. I will make it "ready for c
On Tue, May 4, 2021 at 12:27 AM Andres Freund wrote:
> On 2021-05-03 16:49:16 -0400, Robert Haas wrote:
> > I have two possible ideas for addressing this; perhaps other people
> > will have further suggestions. A relatively non-invasive fix would be
> > to teach pgarch.c how to increment a WAL fil
On Tue, May 4, 2021 at 7:05 PM Tom Lane wrote:
>
> Michael Paquier writes:
> > (Worth noting that I am out this week for Golden Week, so if this can
> > wait until Monday, that would be nice. I am not willing to take my
> > chances with the buildfarm now :p)
>
> I will see to it. I think it's i
Tomas Vondra writes:
> On 5/3/21 7:42 AM, Thomas Munro wrote:
>> Hmm, yeah that does seem plausible. It would be nice to see a report
>> from any other system though. I'm still trying, and reviewing...
> FWIW I've ran the test (make installcheck-parallel in a loop) on four
> different machines
Michael Paquier writes:
> (Worth noting that I am out this week for Golden Week, so if this can
> wait until Monday, that would be nice. I am not willing to take my
> chances with the buildfarm now :p)
I will see to it. I think it's important to get a fix in in the next
couple of days, because
Hey, thanks for reaching out and sorry for the late reply - we had few
days of national holidays.
On 29.04.2021 15:55, Alvaro Herrera wrote:
https://www.postgresql.org/message-id/flat/CANDwggKYveEtXjXjqHA6RL3AKSHMsQyfRY6bK%2BNqhAWJyw8psQ%40mail.gmail.com
https://www.postgresql.org/message-id/fl
On Tue, May 4, 2021 at 2:37 PM Bharath Rupireddy
wrote:
>
> On Mon, May 3, 2021 at 7:59 PM vignesh C wrote:
> > Thanks for the comments, these comments are handle in the v7 patch
> > posted in my earlier mail.
>
> Thanks. Some comments on v7 patch:
>
> 1) How about "Add publication names from the
On 5/3/21 7:42 AM, Thomas Munro wrote:
On Sun, May 2, 2021 at 3:16 PM Tom Lane wrote:
That last point means that there was some hard-to-hit problem even
before any of the recent WAL-related changes. However, 323cbe7c7
(Remove read_page callback from XLogReader) increased the failure
rate by
On Tue, Mar 2, 2021 at 3:14 PM Dilip Kumar wrote:
> =
> ee994272ca50f70b53074f0febaec97e28f83c4e
> Author: Heikki Linnakangas 2013-01-03 14:11:58
> Committer: Heikki Linnakangas 2013-01-03 14:11:58
>
> Delay reading timeline history file until it's fetched from master.
>
> Streami
Ok, here's a new version incorporating feedback so far.
1. Invoke pg_regress directly (no make).
2. Use PG_TEST_EXTRA="wal_consistency_checking" as a way to opt in to
the more expensive test.
3. Use parallel schedule rather than serial. It's faster but also
the non-determinism might discover
On 26.04.21 14:10, Peter Eisentraut wrote:
On 05.02.21 15:18, Peter Eisentraut wrote:
Anyway, I figured out how to take account of generation expressions
with different column orders. I used the same approach that we use
for check constraints. The attached patch is good to go from my
perspec
On Mon, May 3, 2021 at 7:59 PM vignesh C wrote:
> Thanks for the comments, these comments are handle in the v7 patch
> posted in my earlier mail.
Thanks. Some comments on v7 patch:
1) How about "Add publication names from the list to a string."
instead of
* Append the list of publication to de
Hi
I am doing some test and I have few ideas:
1. print server version to the output of pgbench. Now only client side
version is printed
2. can ve generate some output in structured format - XML, JSON ?
Regards
Pavel
On Tue, May 04, 2021 at 12:43:53PM +0530, Bharath Rupireddy wrote:
> And having a retry test case with clobber cache enabled doesn't make
> sense because all the cache entries are removed/invalidated for each
> query, but the test case covers the code on non-clobber cache
> platforms, so I would li
> 4 мая 2021 г., в 09:27, Andres Freund написал(а):
>
> Hi,
>
> On 2021-05-03 16:49:16 -0400, Robert Haas wrote:
>> I have two possible ideas for addressing this; perhaps other people
>> will have further suggestions. A relatively non-invasive fix would be
>> to teach pgarch.c how to incremen
On Mon, May 3, 2021 at 1:41 PM Dilip Kumar wrote:
>
> On Mon, May 3, 2021 at 12:08 PM Bharath Rupireddy
> wrote:
> >
> > On Sun, May 2, 2021 at 8:44 PM vignesh C wrote:
> > >
> > > On Sat, May 1, 2021 at 9:02 PM Bharath Rupireddy
> > > wrote:
> > > >
> > > > On Sat, May 1, 2021 at 7:25 PM vigne
On Tue, May 4, 2021 at 4:12 AM Tom Lane wrote:
> The buildfarm is showing that one of these test queries is not stable
> under CLOBBER_CACHE_ALWAYS:
>
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=hyrax&dt=2021-05-01%2007%3A44%3A47
>
> of which the relevant part is:
>
> diff -U3
> /ho
64 matches
Mail list logo
