> On May 4, 2021, at 9:43 AM, Justin Pryzby <pry...@telsasoft.com> wrote:
>
> + /* Oversized toasted attributes should never be stored */
> + if (toast_pointer.va_rawsize > VARLENA_SIZE_LIMIT)
> + report_corruption(ctx,
> + psprintf("toast value %u
> rawsize %u exceeds limit %u",
> +
> toast_pointer.va_valueid,
> +
> toast_pointer.va_rawsize,
> +
> VARLENA_SIZE_LIMIT));
> +
>
> I think the comment sounds wrong since toast is precisely for storage of
> "oversized" attributes.
>
> https://www.postgresql.org/docs/current/storage-toast.html
> | This section provides an overview of TOAST (The Oversized-Attribute Storage
> Technique).Thanks for reviewing! Changed to: + /* Toasted attributes too large to be untoasted should never be stored */
v2-0001-Adding-more-toast-pointer-checks-to-amcheck.patch
Description: Binary data
— Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
