On Tue, Sep 29, 2020 at 3:16 PM Greg Nancarrow wrote:
>
> Hi Vignesh and Bharath,
>
> Seems like the Parallel Copy patch is regarding RI_TRIGGER_PK as
> parallel-unsafe.
> Can you explain why this is?
>
I don't think we need to restrict this case and even if there is some
reason to do so then pro
On Thu, Oct 1, 2020 at 12:06 PM Amit Kapila wrote:
>
> Thanks for the review.
>
oops, forgot to attach the updated patches, doing now.
--
With Regards,
Amit Kapila.
v7-0001-Track-statistics-for-spilling-of-changes-from-Reo.patch
Description: Binary data
v7-0002-Test-stats.patch
Description:
On Wed, Sep 30, 2020 at 4:34 PM Dilip Kumar wrote:
>
> On Wed, Sep 30, 2020 at 2:40 PM Amit Kapila wrote:
> >
> > On Wed, Sep 30, 2020 at 1:12 PM Dilip Kumar wrote:
> > >
> > > On Fri, Sep 25, 2020 at 4:33 PM Amit Kapila
> > > wrote:
> > > >
> > > > On Thu, Sep 24, 2020 at 5:44 PM Amit Kapila
From: Jamison, Kirk/ジャミソン カーク
> For non-recovery path, did you mean by any chance
> measuring the cache hit rate for varying shared_buffers?
No. You can test the speed of DropRelFileNodeBuffers() during normal
operation, i.e. by running TRUNCATE on psql, instead of performing recovery.
To ena
Hi,
On Thu, Oct 1, 2020 at 1:32 PM Michael Paquier wrote:
>
> On Fri, Sep 11, 2020 at 07:20:56PM +0900, Amit Langote wrote:
> > I have been working away at this and have updated the patches for many
> > cosmetic and some functional improvements.
>
> Please note that this patch set fails to apply.
On Thu, Oct 1, 2020 at 6:35 AM Michael Paquier wrote:
> The documentation is failing to build, and the patch does not build
> correctly on Windows. Could you address that?
> --
> Michael
Yes I'm on it.
--
Matthieu
On Thursday, October 1, 2020 11:49 AM, Amit Kapila wrote:
> On Thu, Oct 1, 2020 at 8:11 AM tsunakawa.ta...@fujitsu.com
> wrote:
> >
> > From: Jamison, Kirk/ジャミソン カーク
> > > Recovery performance measurement results below.
> > > But it seems there are overhead even with large shared buffers.
> > >
>
On Tue, Sep 29, 2020 at 06:13:46PM -0400, Tom Lane wrote:
> So I wonder why PostgresNode.pm is doing
>
> print $conf "max_wal_senders = 5\n";
>
> Considering that our default these days is 10 senders, and that a
> walsender slot doesn't really cost much, this seems unduly cheapskate
čt 1. 10. 2020 v 5:38 odesílatel Michael Paquier
napsal:
> On Thu, Sep 24, 2020 at 08:49:50PM +0200, Pavel Stehule wrote:
> > fixed patch attached
>
> It looks like there are again conflicts within setrefs.c.
>
fresh patch
Regards
Pavel
--
> Michael
>
schema-variables-20201001.patch.gz
Desc
At Thu, 1 Oct 2020 04:20:27 +, "tsunakawa.ta...@fujitsu.com"
wrote in
> From: Kyotaro Horiguchi
> > In more detail, if smgrcachednblocks() returned InvalidBlockNumber for
> > any of the forks, we should give up the optimization at all since we
> > need to run a full scan anyway. On the oth
On Thu, 1 Oct 2020 13:43:49 +0900
Fujii Masao wrote:
> When I glanced the doc patch (i.e., 0012), I found some typos.
Thank you for your pointing out typos! I'll fix it.
>
> +CRATE INCREMENTAL MATERIALIZED VIEW, for example:
>
> Typo: CRATE should be CREATE ?
>
> +with __ivm_ and
On Fri, Sep 25, 2020 at 06:11:47PM +0800, Julien Rouhaud wrote:
> Thanks a lot for the tests! I'm not surprised that forcing the lock
> will slow down the pg_check_relation() execution, but I'm a bit
> surprised that holding the buffer mapping lock longer in a workload
> that has a lot of eviction
On Tue, Sep 01, 2020 at 10:43:47AM +0900, Michael Paquier wrote:
> As of the moment this message is written, 10 hours remain until we are
> the 1st of September AoE, where I'll switch the commit fest as
> officially in progress. It will not be possible to register new
> patches to 2020-09 after th
On 2020/10/01 13:03, Tatsuo Ishii wrote:
On Thu, Sep 17, 2020 at 09:42:45AM +0900, Tatsuo Ishii wrote:
I am asking because these patch sets are now getting closer to
committable state in my opinion, and if there's someting wrong, it
should be fixed soon so that these patches are getting into
At Thu, 1 Oct 2020 12:56:02 +0900, Michael Paquier wrote
in
> On Thu, Oct 01, 2020 at 11:16:53AM +0900, Kyotaro Horiguchi wrote:
> > Thanks. Since it starts all remote nodes before local ones, the
> > startup gain would be the shorter of the startup time of the fastest
> > remote and the time r
On Wed, Sep 30, 2020 at 3:00 PM Amit Kapila wrote:
>
> On Wed, Sep 30, 2020 at 12:16 PM Dilip Kumar wrote:
> >
> > On Mon, Sep 28, 2020 at 2:22 PM Amit Kapila wrote:
> > >
> > >
> > > I don't have a patch for this idea but you can refer [1]
> > > (v25-0002-Issue-individual-invalidations-with-wal
At Thu, 1 Oct 2020 12:58:19 +0900, Fujii Masao
wrote in
> the table needs to be rewriitten. One idea for that is to improve that
> command
> so that it skips the table rewrite if wal_level=minimal.
> Of course, also you can change wal_level after marking the table as
> unlogged.
tablecmd.c:
>
On Wed, Jan 22, 2020 at 02:38:19PM +0900, Kyotaro Horiguchi wrote:
> I changed my mind to attach the benchmark patch as .txt file,
> expecting the checkers not picking up it as a part of the patchset.
>
> I have in the precise performance measurement mode for a long time,
> but I think it's settle
On 2020/10/01 12:56, Masahiro Ikeda wrote:
On 2020-10-01 11:33, Amit Kapila wrote:
On Thu, Oct 1, 2020 at 6:53 AM Kyotaro Horiguchi
wrote:
At Thu, 1 Oct 2020 09:05:19 +0900, Fujii Masao
wrote in
>
>
> On 2020/09/30 20:21, Amit Kapila wrote:
> > On Tue, Sep 29, 2020 at 9:23 PM Fujii Masao
On Mon, Sep 21, 2020 at 07:55:03PM +0200, Matthieu Garrigues wrote:
> I merged PQbatchProcessQueue into PQgetResult.
> One first init call to PQbatchProcessQueue was also required in
> PQsendQueue to have
> PQgetResult ready to read the first batch query.
>
> Tests and documentation are updated ac
On Fri, Sep 11, 2020 at 07:20:56PM +0900, Amit Langote wrote:
> I have been working away at this and have updated the patches for many
> cosmetic and some functional improvements.
Please note that this patch set fails to apply. Could you provide a
rebase please?
--
Michael
signature.asc
Descrip
From: Kyotaro Horiguchi
> In more detail, if smgrcachednblocks() returned InvalidBlockNumber for
> any of the forks, we should give up the optimization at all since we
> need to run a full scan anyway. On the other hand, if any of the
> forks is smaller than the threshold, we still can use the op
On Thu, Oct 1, 2020 at 9:19 AM Amit Kapila wrote:
>
> On Thu, Oct 1, 2020 at 8:22 AM Keisuke Kuroda
> wrote:
> >
> > Hi Dilip, Amit,
> >
> > Thank you for the patch!
> >
> > I test the patch on the master HEAD(9796f455) and it works fine.
> > * make installcheck-world: passed
> > * walsender proc
On Sun, Jul 12, 2020 at 02:11:01AM +0200, Tomas Vondra wrote:
> Because I was focused on speeding-up inserts, and that is not using
> CopyMultiInsertBuffer I think. I agree the way the tuples are stored
> may be improved, of course.
The CF bot is telling that the regression tests of postgres_fdw a
> On Thu, Sep 17, 2020 at 09:42:45AM +0900, Tatsuo Ishii wrote:
>> I am asking because these patch sets are now getting closer to
>> committable state in my opinion, and if there's someting wrong, it
>> should be fixed soon so that these patches are getting into the master
>> branch.
>>
>> I think
On 2020/10/01 12:04, osumi.takami...@fujitsu.com wrote:
Hello.
Can they use a database with all unlogged tables?
Unfortunately, no. They want to switch a cluster condition to "without WAL
logging"
only when they execute night bulk loading for their data warehouse.
In other words, they wou
On 2020-10-01 11:33, Amit Kapila wrote:
On Thu, Oct 1, 2020 at 6:53 AM Kyotaro Horiguchi
wrote:
At Thu, 1 Oct 2020 09:05:19 +0900, Fujii Masao
wrote in
>
>
> On 2020/09/30 20:21, Amit Kapila wrote:
> > On Tue, Sep 29, 2020 at 9:23 PM Fujii Masao
> > wrote:
> >>
> >> On 2020/09/29 11:51, Ma
On Thu, Oct 01, 2020 at 11:16:53AM +0900, Kyotaro Horiguchi wrote:
> Thanks. Since it starts all remote nodes before local ones, the
> startup gain would be the shorter of the startup time of the fastest
> remote and the time required for all local nodes. Plus remote
> transfer gets asynchronous
On Thu, Sep 24, 2020 at 12:51:52PM +0900, Amit Langote wrote:
> Also, I noticed that looking up a parent's partitions via
> RelationBuildPartitionDesc or directly will inspect inhdetached to
> include or exclude partitions, but checking if a child table is a
> partition of a given parent table via
On Thu, Oct 1, 2020 at 8:22 AM Keisuke Kuroda
wrote:
>
> Hi Dilip, Amit,
>
> Thank you for the patch!
>
> I test the patch on the master HEAD(9796f455) and it works fine.
> * make installcheck-world: passed
> * walsender process continues to use 100% of the CPU 1core when
> TRUNCATE 1000 partition
On Thu, Sep 24, 2020 at 08:49:50PM +0200, Pavel Stehule wrote:
> fixed patch attached
It looks like there are again conflicts within setrefs.c.
--
Michael
signature.asc
Description: PGP signature
On Thu, Sep 17, 2020 at 09:42:45AM +0900, Tatsuo Ishii wrote:
> I am asking because these patch sets are now getting closer to
> committable state in my opinion, and if there's someting wrong, it
> should be fixed soon so that these patches are getting into the master
> branch.
>
> I think this fe
Hi,
On 2020-09-08 21:11:47 -0700, Andres Freund wrote:
> > Not yet sure about what a suitable way to test this for analyze would
> > be, unless we'd also accept VacuumDelay as a wait condition :(. I guess
> > one fairly easy way would be to include an expression index, and have
> > the expression
At Thu, 1 Oct 2020 02:40:52 +, "tsunakawa.ta...@fujitsu.com"
wrote in
> With the following code, when the main fork does not meet the
> optimization criteria, other forks are not optimized as well. You
> want to determine each fork's optimization separately, don't you?
In more detail, if s
On Tue, Sep 29, 2020 at 07:04:22PM -0400, Tom Lane wrote:
> Hm. We could do so back to v10 where that came in, and there are no
> src/test/subscription tests before v10, so that should be sufficient.
> Sold.
Since this stuff has been committed, thorntail has showed a very
interesting failure with
Hello.
> >> Can they use a database with all unlogged tables?
> > Unfortunately, no. They want to switch a cluster condition to "without WAL
> logging"
> > only when they execute night bulk loading for their data warehouse.
> > In other words, they would like to keep their other usual operations w
From: Amit Kapila
> I have one idea for performance testing. We can even test this for
> non-recovery paths by removing the recovery-related check like only
> use it when there are cached blocks. You can do this if testing via
> recovery path is difficult because at the end performance should be
>
At Thu, 1 Oct 2020 10:01:56 +0900, Fujii Masao
wrote in
>
>
> On 2020/09/30 12:10, osumi.takami...@fujitsu.com wrote:
> > Hello, Ashutosh
> >
> >> Can they use a database with all unlogged tables?
> > Unfortunately, no. They want to switch a cluster condition to "without
> > WAL logging"
> >
Hi Dilip, Amit,
Thank you for the patch!
I test the patch on the master HEAD(9796f455) and it works fine.
* make installcheck-world: passed
* walsender process continues to use 100% of the CPU 1core when
TRUNCATE 1000 partition: 1s or less
** before patch : 230s
There is "ReorderBufferAddInvalid
On Thu, Oct 1, 2020 at 8:11 AM tsunakawa.ta...@fujitsu.com
wrote:
>
> From: Jamison, Kirk/ジャミソン カーク
> > Recovery performance measurement results below.
> > But it seems there are overhead even with large shared buffers.
> >
> > | s_b | master | patched | %reg |
> > |---||-|
From: Jamison, Kirk/ジャミソン カーク
> Recovery performance measurement results below.
> But it seems there are overhead even with large shared buffers.
>
> | s_b | master | patched | %reg |
> |---||-|---|
> | 128MB | 36.052 | 39.451 | 8.62% |
> | 1GB | 21.731 | 21.73 | 0
On Thu, Oct 1, 2020 at 6:53 AM Kyotaro Horiguchi
wrote:
>
> At Thu, 1 Oct 2020 09:05:19 +0900, Fujii Masao
> wrote in
> >
> >
> > On 2020/09/30 20:21, Amit Kapila wrote:
> > > On Tue, Sep 29, 2020 at 9:23 PM Fujii Masao
> > > wrote:
> > >>
> > >> On 2020/09/29 11:51, Masahiro Ikeda wrote:
> > >
Hi,
On 2020-09-30 21:16:10 -0500, Justin Pryzby wrote:
> Sep 30 19:40:08 database7 abrt-hook-ccpp: Process 17905 (postgres) of user 26
> killed by SIGABRT - dumping core
> Core was generated by `postgres: telsasoft ts 192.168.122.11(34608) SELECT
> '.
>
> Unfortunately, the filesystem wasn't
On Sat, Sep 26, 2020 at 2:49 PM Jaime Casanova
wrote:
>
> Hi,
>
> With sqlsmith I found a query that gives this error:
> ERROR: ORDER/GROUP BY expression not found in targetlist
>
> I noted the query (sql query below, sorry it uses custom tables i
> couldn't replicate with regression tables) beca
Justin Pryzby writes:
> A VM crashed which is now running PG13.0 on centos7:
> Sep 30 19:40:08 database7 abrt-hook-ccpp: Process 17905 (postgres) of user 26
> killed by SIGABRT - dumping core
> Core was generated by `postgres: telsasoft ts 192.168.122.11(34608) SELECT
> '.
> Unfortunately, t
At Wed, 30 Sep 2020 16:30:41 +0900, Etsuro Fujita
wrote in
> On Mon, Sep 28, 2020 at 10:35 AM Kyotaro Horiguchi
> wrote:
> > At Sat, 26 Sep 2020 19:45:39 +0900, Etsuro Fujita
> > wrote in
> > > Your patch (and the original patch by Robert [1]) modified
> > > ExecAppend() so that it can proces
A VM crashed which is now running PG13.0 on centos7:
Sep 30 19:40:08 database7 abrt-hook-ccpp: Process 17905 (postgres) of user 26
killed by SIGABRT - dumping core
Core was generated by `postgres: telsasoft ts 192.168.122.11(34608) SELECT'.
Unfortunately, the filesystem wasn't large enough a
From: Kyotaro Horiguchi
> Another reason that I mildly want to object to subdivided functions is
> I was annoyed that a stats view makes many individual calls to
> functions that internally share the same statistics entry. That
> behavior required me to provide an entry-caching feature to my
> sh
On Wed, Sep 30, 2020 at 03:47:26PM -0400, Tom Lane wrote:
> LGTM.
Thanks, I have applied this version then. I am curious to see what
the buildfarm thinks about it.
--
Michael
signature.asc
Description: PGP signature
At Thu, 1 Oct 2020 09:05:19 +0900, Fujii Masao
wrote in
>
>
> On 2020/09/30 20:21, Amit Kapila wrote:
> > On Tue, Sep 29, 2020 at 9:23 PM Fujii Masao
> > wrote:
> >>
> >> On 2020/09/29 11:51, Masahiro Ikeda wrote:
> >>> On 2020-09-29 11:43, Amit Kapila wrote:
> On Tue, Sep 29, 2020 at 7:
On 2020/09/30 12:10, osumi.takami...@fujitsu.com wrote:
Hello, Ashutosh
Can they use a database with all unlogged tables?
Unfortunately, no. They want to switch a cluster condition to "without WAL
logging"
only when they execute night bulk loading for their data warehouse.
In other words,
Robert Haas writes:
> Right. Ultimately, this comes down to a judgement call about what you
> think people are likely to rely on, and what you think they are
> unlikely to rely on.
Good, so at least we agree on that principle.
> But the present case does not seem to me to be comparable. If someo
On Wed, Sep 30, 2020 at 5:24 PM Robert Haas wrote:
> The
> fact that we've suddenly discovered that this is not what Oracle does
> doesn't mean that no users have discovered that it is what PostgreSQL
> does.
>
Presently I cannot seem to make up my mind so I'm going to go with my
original opinio
On Wed, Sep 30, 2020 at 7:26 PM Tom Lane wrote:
> We do not have, and never have had, a project policy against
> back-patching non-crash-related behavioral changes. If we did,
> we would not for example put timezone database updates into the
> back branches. It's not terribly hard to imagine suc
On 2020/09/30 20:21, Amit Kapila wrote:
On Tue, Sep 29, 2020 at 9:23 PM Fujii Masao wrote:
On 2020/09/29 11:51, Masahiro Ikeda wrote:
On 2020-09-29 11:43, Amit Kapila wrote:
On Tue, Sep 29, 2020 at 7:39 AM Masahiro Ikeda wrote:
On 2020-09-28 12:43, Amit Kapila wrote:
On Mon, Sep 28, 2
Hi Justin,
Attached is a minimal patch that is rebased and removes the
dependency on Konstantin's earlier patch[1], making it enough to remove
the extraneous index scans as Justin brought up. Is this the direction we
want to head in?
Tagging Konstantin in the email to hear his input on his old pa
On Wed, Sep 30, 2020 at 07:26:55PM -0400, Tom Lane wrote:
> Bruce Momjian writes:
> > On Wed, Sep 30, 2020 at 06:10:38PM -0400, Robert Haas wrote:
> >> On Wed, Sep 30, 2020 at 5:35 PM Tom Lane wrote:
> >>> By that logic, we should never fix any bug in a back branch.
>
> >> No, by that logic, we
Bruce Momjian writes:
> On Wed, Sep 30, 2020 at 06:10:38PM -0400, Robert Haas wrote:
>> On Wed, Sep 30, 2020 at 5:35 PM Tom Lane wrote:
>>> By that logic, we should never fix any bug in a back branch.
>> No, by that logic, we should not change any behavior in a back-branch
>> upon which a custom
Hi,
On 2020-09-14 16:17:18 -0700, Andres Freund wrote:
> I've also included a quite heavily revised version of your test. Instead
> of using dblink I went for having a long-running psql that I feed over
> stdin. The main reason for not liking the previous version is that it
> seems fragile, with t
On Wed, Sep 30, 2020 at 06:10:38PM -0400, Robert Haas wrote:
> On Wed, Sep 30, 2020 at 5:35 PM Tom Lane wrote:
> > By that logic, we should never fix any bug in a back branch.
>
> No, by that logic, we should not change any behavior in a back-branch
> upon which a customer is plausibly relying. N
Robert Haas writes:
> On Wed, Sep 30, 2020 at 5:35 PM Tom Lane wrote:
>> By that logic, we should never fix any bug in a back branch.
> No, by that logic, we should not change any behavior in a back-branch
> upon which a customer is plausibly relying.
I guess where we differ here is on the idea
CREATE TABLE t(i int) PARTITION BY RANGE(i);
CREATE TABLE t1 PARTITION OF t FOR VALUES FROM (1) TO (10);
CREATE OR REPLACE FUNCTION tgf() RETURNS trigger LANGUAGE plpgsql AS $$ begin
raise exception 'except'; end $$;
CREATE TRIGGER tg AFTER INSERT ON t FOR EACH ROW EXECUTE FUNCTION tgf();
ALTER TA
On 8/4/20 12:19 PM, Dave Cramer wrote:
> Attached is the rebased patch for consideration.
>
>
It's a bit sad this has been hanging around so long without attention.
The previous discussion seems to give the patch a clean bill of health
for most/all of the native drivers. Are there any implica
On Wed, Sep 30, 2020 at 5:35 PM Tom Lane wrote:
> By that logic, we should never fix any bug in a back branch.
No, by that logic, we should not change any behavior in a back-branch
upon which a customer is plausibly relying. No one relies on a certain
query causing a server crash, for example, or
Robert Haas writes:
> On Tue, Sep 29, 2020 at 1:26 PM Tom Lane wrote:
>> I think this is nuts. The current behavior is obviously broken;
>> we should just treat it as a bug and fix it, including back-patching.
>> I do not think there is a compatibility problem of any significance.
>> Who out the
On Tue, Sep 29, 2020 at 1:26 PM Tom Lane wrote:
> I think this is nuts. The current behavior is obviously broken;
> we should just treat it as a bug and fix it, including back-patching.
> I do not think there is a compatibility problem of any significance.
> Who out there is going to have an appl
On Wed, Sep 30, 2020 at 03:11:06PM -0400, Tom Lane wrote:
> Bruce Momjian writes:
> > On Wed, Sep 30, 2020 at 02:50:31PM -0400, Tom Lane wrote:
> >> Actually, I was just finishing up back-patching the patch I posted
> >> yesterday. I think we should just fix it, not document that it's
> >> broken
Hi Anastasia,
I tested the syntax with some basic commands and it works fine, regression
tests also pass.
Couple of comments:
1. The syntax used omits the { IMMEDIATE | DEFERRED} keywords suggested in
the earlier discussions. I think it is intuitive to include IMMEDIATE with
the current implement
Michael Paquier writes:
> However I would prefer the style of the attached.
LGTM.
regards, tom lane
Bruce Momjian writes:
> On Wed, Sep 30, 2020 at 02:50:31PM -0400, Tom Lane wrote:
>> Actually, I was just finishing up back-patching the patch I posted
>> yesterday. I think we should just fix it, not document that it's
>> broken.
> Agreed, that's what I wanted. You stated in a later email you
On Wed, Sep 30, 2020 at 02:50:31PM -0400, Tom Lane wrote:
> Bruce Momjian writes:
> > On Wed, Sep 30, 2020 at 02:11:54PM -0400, Tom Lane wrote:
> >> Hm, I read your reference to "the release notes" as suggesting that
> >> we should change it only in a major release, ie HEAD only (and it
> >> looks
Bruce Momjian writes:
> On Wed, Sep 30, 2020 at 02:11:54PM -0400, Tom Lane wrote:
>> Hm, I read your reference to "the release notes" as suggesting that
>> we should change it only in a major release, ie HEAD only (and it
>> looks like David read it the same). If you meant minor release notes,
>>
On Wed, Sep 30, 2020 at 02:11:54PM -0400, Tom Lane wrote:
> Bruce Momjian writes:
> > On Tue, Sep 29, 2020 at 01:26:29PM -0400, Tom Lane wrote:
> >> Bruce Momjian writes:
> >>> On Fri, Sep 4, 2020 at 12:45:36PM -0700, David G. Johnston wrote:
> Because we already have the to_date/make_date
Bruce Momjian writes:
> On Tue, Sep 29, 2020 at 01:26:29PM -0400, Tom Lane wrote:
>> Bruce Momjian writes:
>>> On Fri, Sep 4, 2020 at 12:45:36PM -0700, David G. Johnston wrote:
Because we already have the to_date/make_date inconsistency, and the -1
to -2 BC mapping is confusing, and do
"Zidenberg, Tsahi" writes:
> On 29/09/2020, 10:21, "Heikki Linnakangas" wrote:
>> If it's a good idea to use -moutline-atomics, I would expect the
>> compiler or distribution to enable it by default. And as you pointed
>> out, many have.
> -moutline-atomics is only enabled by defaul
On 2020/09/30 21:02, Bharath Rupireddy wrote:
On Tue, Sep 29, 2020 at 10:01 PM Fujii Masao
wrote:
I think this is okay, because pg_terminate_backend() sends SIGTERM to
the backend, and upon receiving SIGTERM the signal handler die() will
be called and since there is no query being executed
On 30/09/2020 19:04, Zidenberg, Tsahi wrote:
Ubuntu 20.04 even turned it off by default for gcc-10, which seems
like a compatibility step with the main gcc-9 compiler.
Ok, I definitely don't want to override that decision.
I'm marking this as Rejected in the commitfest. But thanks for the
benc
On Tue, Sep 29, 2020 at 01:26:29PM -0400, Tom Lane wrote:
> Bruce Momjian writes:
> > On Fri, Sep 4, 2020 at 12:45:36PM -0700, David G. Johnston wrote:
> >>> Because we already have the to_date/make_date inconsistency, and the -1
> >>> to -2 BC mapping is confusing, and doesn't match Oracle, I th
On 29/09/2020, 10:21, "Heikki Linnakangas" wrote:
> If it's a good idea to use -moutline-atomics, I would expect the
> compiler or distribution to enable it by default. And as you pointed
> out, many have.
-moutline-atomics is only enabled by default on the gcc-10 branch where
it w
On Tue, Sep 22, 2020 at 3:20 AM David Rowley wrote:
> It would be good if we were consistent with these parallel options.
> Right now max_parallel_workers_per_gather will restrict the
> parallel_workers reloption. I'd say this
> max_parallel_workers_per_gather is similar to
> max_parallel_mainten
Jesse Zhang writes:
> So it's been 17 months since you sent this email, so I'm not sure that
> nothing has happened (off list or in the code base), but...
Well, we fixed the case that was discussed at the time [1].
I'm not exactly convinced about removing the register keywords in
s_lock.h. Thos
Hi Tom,
So it's been 17 months since you sent this email, so I'm not sure that
nothing has happened (off list or in the code base), but...
On Sun, Jun 2, 2019 at 9:53 AM Tom Lane wrote:
> * On FreeBSD 12, I get
>
> /home/tgl/pgsql/src/include/utils/hashutils.h:23:23: warning: 'register'
> storag
On Tue, Sep 29, 2020 at 3:13 PM Peter Eisentraut
wrote:
>
> On 2020-09-26 07:32, Amit Kapila wrote:
> > This is exactly my feeling too. But how about changing documentation a
> > bit as proposed above [1] to make it precise.
> >
> > [1] -
> > https://www.postgresql.org/message-id/CAA4eK1LQWXS_4Rw
On 30/09/2020 14:25, Dagfinn Ilmari Mannsåker wrote:
Michael Paquier writes:
On Mon, Aug 10, 2020 at 12:52:17PM +, Jürgen Purtz wrote:
The new status of this patch is: Waiting on Author
This has not been answered yet, so I have marked the patch as returned
with feedback.
Updated patch
On Tue, Sep 29, 2020 at 10:01 PM Fujii Masao
wrote:
>
> > I think this is okay, because pg_terminate_backend() sends SIGTERM to
> > the backend, and upon receiving SIGTERM the signal handler die() will
> > be called and since there is no query being executed on the backend by
> > the time SIGTERM
On Mon, Sep 28, 2020 at 10:12 PM Tomas Vondra
wrote:
> Is it actually all that different from the existing BRIN indexes?
> Consider this example:
>
> create table x (a text, b text, c text);
>
> create index on x using brin (a,b,c);
>
> create or replace function random_str(p_len int) returns tex
On Wed, 2020-09-30 at 16:27 +0900, Michael Paquier wrote:
> On Fri, Sep 04, 2020 at 01:59:47PM +0200, Laurenz Albe wrote:
> > I'll set the commitfest entry to "waiting for author".
>
> This review, as well as any of the follow-up emails, have not been
> answered by the author, so I have marked the
Michael Paquier writes:
> On Mon, Aug 10, 2020 at 12:52:17PM +, Jürgen Purtz wrote:
>> The new status of this patch is: Waiting on Author
>
> This has not been answered yet, so I have marked the patch as returned
> with feedback.
Updated patch attached, wich reformats the operator lists as r
On Tue, Sep 29, 2020 at 9:23 PM Fujii Masao wrote:
>
> On 2020/09/29 11:51, Masahiro Ikeda wrote:
> > On 2020-09-29 11:43, Amit Kapila wrote:
> >> On Tue, Sep 29, 2020 at 7:39 AM Masahiro Ikeda
> >> wrote:
> >>>
> >>> On 2020-09-28 12:43, Amit Kapila wrote:
> >>> > On Mon, Sep 28, 2020 at 8:24 A
On Wed, Sep 30, 2020 at 2:40 PM Amit Kapila wrote:
>
> On Wed, Sep 30, 2020 at 1:12 PM Dilip Kumar wrote:
> >
> > On Fri, Sep 25, 2020 at 4:33 PM Amit Kapila wrote:
> > >
> > > On Thu, Sep 24, 2020 at 5:44 PM Amit Kapila
> > > wrote:
> > >
> > > I have done some more testing of this patch espe
At Tue, 29 Sep 2020 23:10:52 -0400, Tom Lane wrote in
tgl> Kyotaro Horiguchi writes:
tgl> > At Tue, 29 Sep 2020 01:03:13 +, "Hou, Zhijie"
wrote in
tgl> >> Since PG_FINALLY can be used now, I think we can use PG_FINALLY to
simplify code here.
tgl>
tgl> > The patch removes PG_RETHROW(), w
On Wed, Sep 30, 2020 at 3:27 PM Amit Kapila wrote:
>
> On Wed, Sep 30, 2020 at 3:12 PM Dilip Kumar wrote:
> >
> > On Wed, Sep 30, 2020 at 3:08 PM Amit Kapila wrote:
> > >
> > > On Wed, Sep 30, 2020 at 2:46 PM Dilip Kumar wrote:
> > > >
> > > > On Wed, Sep 30, 2020 at 2:36 PM Amit Kapila
> > >
On Wed, Sep 30, 2020 at 3:12 PM Dilip Kumar wrote:
>
> On Wed, Sep 30, 2020 at 3:08 PM Amit Kapila wrote:
> >
> > On Wed, Sep 30, 2020 at 2:46 PM Dilip Kumar wrote:
> > >
> > > On Wed, Sep 30, 2020 at 2:36 PM Amit Kapila
> > > wrote:
> > > >
> > > > On Tue, Sep 29, 2020 at 8:04 PM Dilip Kumar
On Wed, Sep 30, 2020 at 3:08 PM Amit Kapila wrote:
>
> On Wed, Sep 30, 2020 at 2:46 PM Dilip Kumar wrote:
> >
> > On Wed, Sep 30, 2020 at 2:36 PM Amit Kapila wrote:
> > >
> > > On Tue, Sep 29, 2020 at 8:04 PM Dilip Kumar wrote:
> > > >
> > > > I have started looking into you latest patches, as
On Wed, Sep 30, 2020 at 2:46 PM Dilip Kumar wrote:
>
> On Wed, Sep 30, 2020 at 2:36 PM Amit Kapila wrote:
> >
> > On Tue, Sep 29, 2020 at 8:04 PM Dilip Kumar wrote:
> > >
> > > I have started looking into you latest patches, as of now I have a
> > > few comments.
> > >
> > > v6-0001
> > >
> > >
On Wed, Sep 30, 2020 at 12:16 PM Dilip Kumar wrote:
>
> On Mon, Sep 28, 2020 at 2:22 PM Amit Kapila wrote:
> >
> >
> > I don't have a patch for this idea but you can refer [1]
> > (v25-0002-Issue-individual-invalidations-with-wal_level-lo) to see
> > what I was trying to say about registering the
On Wed, Sep 30, 2020 at 2:36 PM Amit Kapila wrote:
>
> On Tue, Sep 29, 2020 at 8:04 PM Dilip Kumar wrote:
> >
> > I have started looking into you latest patches, as of now I have a
> > few comments.
> >
> > v6-0001
> >
> > @@ -1987,7 +2072,7 @@ ReorderBufferProcessTXN(ReorderBuffer *rb,
> > Reor
On Wed, Sep 30, 2020 at 1:12 PM Dilip Kumar wrote:
>
> On Fri, Sep 25, 2020 at 4:33 PM Amit Kapila wrote:
> >
> > On Thu, Sep 24, 2020 at 5:44 PM Amit Kapila wrote:
> >
> > I have done some more testing of this patch especially for the case
> > where we spill before streaming the transaction and
On Tue, Sep 08, 2020 at 01:25:21PM -0400, James Coleman wrote:
> Álvaro's patch confused the current state of this thread, so I'm
> reattaching (rebased) v2 as v3.
+
+ CREATE INDEX (including the
CONCURRENTLY
+ option) commands are included when VACUUM calculates what
+ dead tuples are sa
On Tue, Sep 29, 2020 at 8:04 PM Dilip Kumar wrote:
>
> I have started looking into you latest patches, as of now I have a
> few comments.
>
> v6-0001
>
> @@ -1987,7 +2072,7 @@ ReorderBufferProcessTXN(ReorderBuffer *rb,
> ReorderBufferTXN *txn,
> prev_lsn = change->lsn;
>
> /* Set the current
1 - 100 of 119 matches
Mail list logo
