On Thu, Sep 24, 2020 at 12:51:52PM +0900, Amit Langote wrote: > Also, I noticed that looking up a parent's partitions via > RelationBuildPartitionDesc or directly will inspect inhdetached to > include or exclude partitions, but checking if a child table is a > partition of a given parent table via get_partition_parent doesn't. > Now if you fix get_partition_parent() to also take into account > inhdetached, for example, to return InvalidOid if true, then the > callers would need to not consider the child table a valid partition. > So, RelationGetPartitionQual() on a detached partition should actually > return NIL, making my earlier claim about not needing the defensive > CHECK constraint invalid. But maybe that's fine if all places agree > on a detached partition not being a valid partition anymore?
It would be good to get that answered, and while on it please note that the patch needs a rebase. -- Michael
signature.asc
Description: PGP signature
