On Thu, Jan 9, 2020 at 12:50 PM Neha Sharma
wrote:
>
> Hi Michael,
> Thanks for looking into the issue. Sorry by mistake I had mentioned the
> incorrect DML query,please use the query as mentioned below.
>
> On Thu, Jan 9, 2020 at 11:38 AM Michael Paquier wrote:
>>
>> On Tue, Jan 07, 2020 at 05:
Hello Karl,
Another option would be to use "bytes bytea".
(The current patch uses "string bytea".)
This would probably also require some re-wording throughout.
Please let me know your preference.
I like it, but this is only my own limited opinion, and I'm not a native
English speaker.
Hi Michael,
Thanks for looking into the issue. Sorry by mistake I had mentioned the
incorrect DML query,please use the query as mentioned below.
On Thu, Jan 9, 2020 at 11:38 AM Michael Paquier wrote:
> On Tue, Jan 07, 2020 at 05:38:49PM +0530, Neha Sharma wrote:
> > I am getting a server crash o
On Thu, Jan 9, 2020 at 12:09 PM Amit Kapila wrote:
>
> On Thu, Jan 9, 2020 at 10:30 AM Dilip Kumar wrote:
> >
> > On Thu, Jan 9, 2020 at 9:35 AM Amit Kapila wrote:
> > >
> > > On Wed, Jan 8, 2020 at 1:12 PM Dilip Kumar wrote:
> > > >
> > > > I have observed one more design issue.
> > > >
> > >
On Wed, Dec 25, 2019 at 11:11 PM Julien Rouhaud wrote:
>
> On Wed, Dec 25, 2019 at 2:01 PM Fujii Masao wrote:
> >
> > Hi,
> >
> > I'd like to propose to add pg_file_sync() function into contrib/adminpack.
> > This function fsyncs the specified file or directory named by its argument.
> > IMO this
On Wed, Jan 08, 2020 at 01:33:13PM +, Dagfinn Ilmari Mannsåker wrote:
> I noticed to my annoyance that 'make -j4 -C src/interfaces/libpq'
> doesn't work in a clean checkout, because it can't find
> libpgcommon_shlib and libpgport_shlib. It looks like that's because the
> submake-libpgport depe
On Thu, Jan 9, 2020 at 10:30 AM Dilip Kumar wrote:
>
> On Thu, Jan 9, 2020 at 9:35 AM Amit Kapila wrote:
> >
> > On Wed, Jan 8, 2020 at 1:12 PM Dilip Kumar wrote:
> > >
> > > I have observed one more design issue.
> > >
> >
> > Good observation.
> >
> > > The problem is that when we
> > > get a
Hello.
At Sun, 29 Dec 2019 15:12:16 +0300, Alexey Kondratov
wrote in
> On 2019-12-26 16:35, Alexey Kondratov wrote:
> > Another concern is that ReplicationSlotIsDirty is added with the only
> > one user. It also cannot be used by SaveSlotToPath due to the
> > simultaneous usage of both flags di
On Mon, Jan 6, 2020 at 3:42 PM Michael Paquier wrote:
>
> On Mon, Jan 06, 2020 at 03:20:13PM +0900, Arthur Zakirov wrote:
> > It isn't case if a file doesn't exist. But if there are no permissions on
> > the file:
> >
> > PANIC: could not open file "testfile": Permissions denied
> > server closed
On Thu, Jan 9, 2020 at 11:15 AM Tom Lane wrote:
>
> Noah Misch writes:
> > Even so, a web search for "extend_brk" led to the answer. By default,
> > 32-bit
> > AIX binaries get only 256M of RAM for stack and sbrk. The new regression
> > test
> > used more than that, hence this crash.
>
> Hm,
On Tue, Jan 07, 2020 at 05:38:49PM +0530, Neha Sharma wrote:
> I am getting a server crash on publication server on HEAD for the below
> test case.
>
> Test case:
> Publication server:
> create table test(a int);
> create publication test_pub for all tables;
> alter table test replica identity NOT
Noah Misch writes:
> Even so, a web search for "extend_brk" led to the answer. By default, 32-bit
> AIX binaries get only 256M of RAM for stack and sbrk. The new regression test
> used more than that, hence this crash.
Hm, so
(1) Why did we get a crash and not some more-decipherable out-of-res
On Wed, Jan 08, 2020 at 02:50:53PM +0530, Amit Khandekar wrote:
> On Sun, 5 Jan 2020 at 00:21, Noah Misch wrote:
> > The buildfarm client can capture stack traces, but it currently doesn't do
> > so
> > for TAP test suites (search the client code for get_stack_trace). If
> > someone
> > feels l
On Wed, 8 Jan 2020 at 22:16, Amit Kapila wrote:
>
> On Sat, Jan 4, 2020 at 6:48 PM Mahendra Singh Thalor
> wrote:
> >
> > Hi All,
> >
> > In other thread "parallel vacuum options/syntax" [1], Amit Kapila asked
> > opinion about syntax for making normal vacuum to parallel. From that
> > thread
On Thu, Jan 9, 2020 at 9:35 AM Amit Kapila wrote:
>
> On Wed, Jan 8, 2020 at 1:12 PM Dilip Kumar wrote:
> >
> > I have observed one more design issue.
> >
>
> Good observation.
>
> > The problem is that when we
> > get a toasted chunks we remember the changes in the memory(hash table)
> > but do
On 1/7/20 12:34 AM, Li, Zheng wrote:
Hi Andrey,
Thanks for the comment!
The unimproved cases you mentioned all fall into the category “correlated
subquery”. This category is explicitly disallowed by existing code to convert
to join in convert_ANY_sublink_to_join:
/*
* The sub-se
On Mon, 6 Jan 2020 01:35:00 -0600
"Karl O. Pinc" wrote:
> On Sun, 5 Jan 2020 12:48:59 +0100 (CET)
> Fabien COELHO wrote:
> > I'm not keen on calling the parameter the name of its type. I'd
> > suggest to keep "string" as a name everywhere, which is not a type
> > name in Pg.
> >
> > The functi
On Wed, Jan 08, 2020 at 10:56:01AM +0900, Michael Paquier wrote:
> And done this way as per the attached. I am of course open to
> objections or better ideas, though this looks formulation looks pretty
> good to me. Robert?
Just to be clear here, I would like to commit this patch and backpatch
w
On Wed, Jan 8, 2020 at 1:12 PM Dilip Kumar wrote:
>
> I have observed one more design issue.
>
Good observation.
> The problem is that when we
> get a toasted chunks we remember the changes in the memory(hash table)
> but don't stream until we get the actual change on the main table.
> Now, the
On Wed, Jan 08, 2020 at 03:31:46PM +0100, Peter Eisentraut wrote:
> On 2020-01-08 15:12, Michael Paquier wrote:
>> while syntax_error() has been
>> changed in a more modular way.
>
> I don't follow what you mean by that.
The first versions of the patch did not change syntax_error(), and the
versi
On Wed, Jan 08, 2020 at 11:04:48PM +0100, Peter Eisentraut wrote:
> Since the OpenSSL patch went ahead, I have now committed this one as well.
Yippee.
--
Michael
signature.asc
Description: PGP signature
On Thu, Jan 9, 2020 at 5:48 AM Tom Lane wrote:
>
> Andres Freund writes:
> > Is it worth having the test close superflous FDs? It'd not be hard to do
> > so via brute force (or even going through /proc/self/fd).
>
> No, it isn't, because d20703805's test is broken by design. There
> are any numb
On Sun, Jan 5, 2020 at 10:29 AM Amit Kapila wrote:
>
> On Sun, Jan 5, 2020 at 12:21 AM Noah Misch wrote:
> >
> > On Fri, Jan 03, 2020 at 02:20:09PM +0530, Amit Khandekar wrote:
> > > On Fri, 3 Jan 2020 at 10:19, Amit Kapila wrote:
> > > > On Fri, Jan 3, 2020 at 8:29 AM Amit Kapila
> > > > wrot
On Wed, Jan 8, 2020 at 6:09 PM Stephen Frost wrote:
> > To me, this seems more accidental than the natural fallout of good design.
>
> I disagree that the privilege design for FDWs was accidental.
That seems like a stronger statement than the one I made...
> What I see differently is that the pu
Andres Freund writes:
> Is it worth having the test close superflous FDs? It'd not be hard to do
> so via brute force (or even going through /proc/self/fd).
No, it isn't, because d20703805's test is broken by design. There
are any number of reasons why there might be more than three-or-so
FDs op
On 08/01/2020 23:13, Peter Eisentraut wrote:
> On 2020-01-06 17:03, Tom Lane wrote:
>> So it's not clear to me whether we have any meeting of the minds
>> on wanting this patch.
>
> This fairly far-ranging syntax reorganization of pg_hba.conf doesn't
> appeal to me. pg_hba.conf is complicated enou
Hi,
On 2020-01-08 17:31:06 -0500, Tom Lane wrote:
> (1) d20703805's test will clearly fall over if there are more than six
> FDs open in the postmaster when set_max_safe_fds is called, because it
> sets max_files_per_process = 26 while set_max_safe_fds requires at
> least 20 usable FDs to be avail
Greetings,
* Robert Haas (robertmh...@gmail.com) wrote:
> On Tue, Jan 7, 2020 at 7:32 PM Stephen Frost wrote:
> > You raised the point regarding postgres_fdw and a DB owner being able to
> > run 'create extension postgres_fdw;' and to then make network
> > connections, but that's proven to be inv
Greetings,
(I'm also overall in favor of the direction this is going, so general +1
from me, and I took a quick look through the patch and didn't
particularly see anything I didn't like besides what's commented on
below.)
* Robert Haas (robertmh...@gmail.com) wrote:
> On Wed, Jan 8, 2020 at 3:26
On Wed, Jan 8, 2020 at 5:56 AM Heikki Linnakangas wrote:
> On 04/01/2020 03:47, Peter Geoghegan wrote:
> > Attached is v28, which fixes bitrot from my recent commits to refactor
> > VACUUM-related code in nbtpage.c.
>
> I started to read through this gigantic patch.
Oh come on, it's not that big.
On Tue, Jan 7, 2020 at 7:32 PM Stephen Frost wrote:
> You raised the point regarding postgres_fdw and a DB owner being able to
> run 'create extension postgres_fdw;' and to then make network
> connections, but that's proven to be invalid because, assuming we make
> postgres_fdw trustable, we will
I wrote:
> This would happen if anything is causing the postmaster to have
> a few more open files than the test added by commit
> d207038053837ae9365df2776371632387f6f655 is allowing for. It's
> a test bug and nothing more.
> Why sidewinder is not showing this in HEAD too is an interesting
> ques
On 2020-01-06 17:03, Tom Lane wrote:
So it's not clear to me whether we have any meeting of the minds
on wanting this patch.
This fairly far-ranging syntax reorganization of pg_hba.conf doesn't
appeal to me. pg_hba.conf is complicated enough conceptually for users,
but AFAICT nobody ever com
On 2019-12-31 10:46, Peter Eisentraut wrote:
On 2019-12-09 11:37, Peter Eisentraut wrote:
Per discussion in [0], here is a patch set to remove support for Python
versions older than 2.6.
[0]:
https://www.postgresql.org/message-id/6d3b7b69-0970-4d40-671a-268c46e93...@2ndquadrant.com
It appear
On 05/01/2020 13:50, Vik Fearing wrote:
> Okay, now that I see your tests, I understand why everything is broken.
> You only test FROM-TO and with a really wide interval. There are no
> tests for AS OF and no tests for BETWEEN-AND.
I have started working on some better test cases for you. The
On Wed, Jan 8, 2020 at 3:26 PM Tom Lane wrote:
> Robert Haas writes:
> > On Wed, Jan 8, 2020 at 2:57 PM Tom Lane wrote:
> >> * I find COMMAND_IS_WEAKLY_READ_ONLY to be a more confusing concept
> >> than what it replaces. The test for LockStmt is an example --- the
> >> comment talks about restr
Robert Haas writes:
> On Wed, Jan 8, 2020 at 2:57 PM Tom Lane wrote:
>> * I find COMMAND_IS_WEAKLY_READ_ONLY to be a more confusing concept
>> than what it replaces. The test for LockStmt is an example --- the
>> comment talks about restricting locks during recovery, which is fine and
>> underst
On Wed, Jan 8, 2020 at 2:57 PM Tom Lane wrote:
> Hmm. I like the idea of deciding this in one place and insisting that
> that one place have a switch case for every statement type. That'll
> address the root issue that people fail to think about this when adding
> new statements.
Right. Assumin
Peter Griggs writes:
> In the getQuadrant function in the file src/backend/utils/adt/geo_spgist.c,
> I only added some elog statements to see the quadrant that a box is placed
> into using the current code. getQuadrant is called several times by the
> spg_box_quad_picksplit function, which is used
Robert Haas writes:
> I spent some time studying the question of how we classify queries as
> either read-only or not, and our various definitions of read-only, and
> found some bugs. ...
> However, I think that all of them can be tracked back to a more
> fundamental underlying cause, which is tha
Thank you for the tips Tomas, I really appreciate it. You're definitely
right that I should include code snippets, so here's the code i'm trying to
change.
In the getQuadrant function in the file src/backend/utils/adt/geo_spgist.c,
I only added some elog statements to see the quadrant that a box i
I spent some time studying the question of how we classify queries as
either read-only or not, and our various definitions of read-only, and
found some bugs. Specifically:
1. check_xact_readonly() prohibits most kinds of DDL in read-only
transactions, but a bunch of recently-added commands were no
On 12/20/19 10:34 PM, Tom Lane wrote:
I think the "useless" free
is cheap insurance against a permanent memory leak, as well as more
like the coding in nearby functions like RelationGetIndexAttrBitmap.
I wouldn't change it.
Good point, if there is a pattern it is good to follow it. But I am
pr
Alvaro Herrera writes:
>> I'm not 100% sure why the failure either. The assertion is in
>> code that should only be reached in a parallel worker, and surely
>> walsenders don't launch parallel queries? But it looks to me
>> that all the critters using force_parallel_mode are unhappy.
> I reprod
On 2020-Jan-07, Tom Lane wrote:
> Alvaro Herrera writes:
> > On 2020-Jan-07, Tom Lane wrote:
> > That seems a pretty simple patch; attached (untested).
>
> I think you want && not ||, but otherwise that looks about right.
Thanks, you were right; pushed.
> > However, my
> > patch seemed a pret
Hi, Tomas!
Thank you for your feedback!
On Mon, Jan 6, 2020 at 6:22 PM Tomas Vondra
wrote:
> Yeah, I can confirm those results, although on my system the timings are
> a bit different (I haven't tested v8):
>
> |Query time, ms
> WHERE
Greetings,
* Stephen Frost (sfr...@snowman.net) wrote:
> * Alvaro Herrera (alvhe...@2ndquadrant.com) wrote:
> > On 2020-Jan-06, Stephen Frost wrote:
> > > > I wonder if part of the confusion might be due to the synonyms we're
> > > > using here for "in use". Things seem to be "got running", "set
Heikki Linnakangas writes:
> In init_sql_fcache(), one comment says that the junkfilter is
> responsible for injecting NULLs for dropped columns, and a later comment
> says that the junk filter gets "rid of any dropped columns". That seems
> contradictory; which is it? Or does "get rid of" mean
On 28/11/2019 00:57, Tom Lane wrote:
Hence, the attached patch rearranges things so that we'll allow
any case where the parser's standard coercion logic can find an
assignment-level coercion, including typmod coercion if needed.
In a green field I might've argued for restricting this to
implicit
Christoph Berg writes:
> (Fwiw, I can't see your error message in
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=sidewinder&dt=2020-01-07%2022%3A45%3A24)
sidewinder is currently broken due to an unrelated problem.
The case Amit is worried about is only manifesting on the
back branches,
Re: Amit Kapila 2020-01-08
> It looks like this failure is more of what we are getting on
> "sidewinder" where it failed because of "insufficient file descriptors
> available to start server process". Can you check in the log
> (probably in 006_logical_decoding_master.log) if this is the same yo
On 2020-01-08 15:12, Michael Paquier wrote:
On Wed, Jan 08, 2020 at 02:27:46PM +0100, Peter Eisentraut wrote:
Committed.
That was fast.
- if (debug)
+ if (unlikely(__pg_log_level <= PG_LOG_DEBUG))
{
I am surprised that you kept this one,
I'm not happy about it, but it seems OK for
On Wed, Jan 08, 2020 at 02:27:46PM +0100, Peter Eisentraut wrote:
> Committed.
That was fast.
- if (debug)
+ if (unlikely(__pg_log_level <= PG_LOG_DEBUG))
{
I am surprised that you kept this one, while syntax_error() has been
changed in a more modular way.
--
Michael
signature.asc
Descr
Patch v6 makes syntax error location code more compact and tests the case.
Committed.
Thanks!
--
Fabien.
Heikki Linnakangas writes:
> On 01/11/2019 01:50, Alexander Korotkov wrote:
>> This happens so, because we're checking that there is no broken HOT
>> chains after index creation by comparison pg_index.xmin and
>> TransactionXmin. So, we check that pg_index.xmin is in the past for
>> current tran
On Tue, Jan 7, 2020 at 12:47 PM David Fetter wrote:
> Per a suggestion Christophe made, please find attached a patch to
> $Subject:
Curious, what's the benefit of autovacuum handling the oldest tables
first? If there is a related thread with the discussion, I couldn't find
it.
> Apart from caref
Hi hackers,
I noticed to my annoyance that 'make -j4 -C src/interfaces/libpq'
doesn't work in a clean checkout, because it can't find
libpgcommon_shlib and libpgport_shlib. It looks like that's because the
submake-libpgport dependency is declared on the all-lib target, not on
the shlib itself. M
On 2020-01-08 13:07, Fabien COELHO wrote:
Patch v5 attached tries to follow your above suggestions.
Patch v6 makes syntax error location code more compact and tests the case.
Committed.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remot
On Wed, Jan 8, 2020 at 12:01 PM Amit Kapila wrote:
>
>
> > For combination of VACUUM command options, although parallel vacuum is
> > enabled by default and VACUUM FULL doesn't support it yet, 'VACUUM
> > (FULL)' would work. On the other hand 'VACUUM (FULL, PARALLEL)' and
> > 'VACUUM(FULL, PARALLE
Amit Kapila writes:
> I am thinking that for now, we should raise the limit of
> max_files_per_process in the test to something like 35 or 40, so that
> sidewinder passes and unblocks other people who might get blocked due
> to this
That will not fix the problem for FD-per-semaphore platforms.
On Wed, 8 Jan 2020 at 5:28 PM, Heikki Linnakangas wrote:
> On 25/11/2019 05:52, Dilip Kumar wrote:
> > In logical decoding, while sending the changes to the output plugin we
> > need to arrange them in the LSN order. But, if there is only one
> > transaction which is a very common case then we c
On 31/12/2019 02:08, John Naylor wrote:
I'm guessing the initial data for pg_(sh)description is output into
separate files because it was too difficult for the traditional shell
script to maintain enough state to do otherwise.
Yeah, I guess so. The roots of postgres.description goes all the way
Patch v5 attached tries to follow your above suggestions.
Patch v6 makes syntax error location code more compact and tests the case.
--
Fabien.diff --git a/src/bin/pgbench/pgbench.c b/src/bin/pgbench/pgbench.c
index a1e0663c8b..cfb5110608 100644
--- a/src/bin/pgbench/pgbench.c
+++ b/src/bin/p
On 25/11/2019 05:52, Dilip Kumar wrote:
In logical decoding, while sending the changes to the output plugin we
need to arrange them in the LSN order. But, if there is only one
transaction which is a very common case then we can avoid building the
binary heap. A small patch is attached for the s
On 2020-01-07 15:18, Rafia Sabih wrote:
On Tue, 7 Jan 2020 at 06:02, Amit Langote wrote:
Rebased and updated to address your comments.
+
+ Partitioned tables are not considered when FOR ALL TABLES
+ is specified.
+
+
What is the reason for above, I mean not for the comment but not
in
On 2020-01-07 06:01, Amit Langote wrote:
On Mon, Jan 6, 2020 at 8:25 PM Rafia Sabih wrote:
Hi Amit,
I went through this patch set once again today and here are my two cents.
Thanks Rafia.
Rebased and updated to address your comments.
Looking through 0001, I think perhaps there is a better
On 28/12/2019 01:35, Jeff Davis wrote:
I've attached a new patch that adds some basic costing for disk during
hashagg.
This patch (hashagg-20191227.patch) doesn't compile:
nodeAgg.c:3379:7: error: ‘hashagg_mem_overflow’ undeclared (first use in
this function)
if (hashagg_mem_overflow)
On 01/11/2019 01:50, Alexander Korotkov wrote:
Hi!
Our customer faced with issue, when index is invisible after creation.
The reproducible case is following.
$ psql db2
# begin;
# select txid_current();
$ psql db1
# select i as id, 0 as v into t from generate_series(1, 10) i;
On Sun, 5 Jan 2020 at 00:21, Noah Misch wrote:
> The buildfarm client can capture stack traces, but it currently doesn't do so
> for TAP test suites (search the client code for get_stack_trace). If someone
> feels like writing a fix for that, it would be a nice improvement. Perhaps,
> rather tha
On 2019-12-02 00:12, Andrew Dunstan wrote:
On 11/30/19 8:48 PM, Michael Paquier wrote:
On Thu, Oct 31, 2019 at 07:54:41PM -0400, Andrew Dunstan wrote:
This patch achieves $SUBJECT and also provides some testing of the
sslpassword setting.
The patch does not apply anymore, so a rebase is needed
70 matches
Mail list logo
