According to TPC themselves, "In contrast to TPC-A, TPC-B is not an
OLTP benchmark. Rather, TPC-B can be looked at as a database stress
test..." [1]. Sounds like classic pgbench to me.
Not sure where that leaves this patch. What problem is it actually
trying to solve?
That there is no builti
Hello Tom,
[ shrug... ] TBH, the proposed patch does not look to me like actual
benchmark kit; it looks like a toy. Nobody who was intent on making their
benchmark numbers look good would do a significant amount of work in a
slow, ad-hoc interpreted language. I also wonder to what extent the
On Mon, Jul 29, 2019 at 12:58:17PM -0400, Tom Lane wrote:
> > On Sun, Feb 17, 2019 at 11:31:03PM -0800, Noah Misch wrote:
> >>> b. Arrange so only one backend runs vac_truncate_clog() at a time. Other
> >>> than
> >>> AsyncCtl, every SLRU truncation appears in vac_truncate_clog(), in a
> >>> chec
On Tue, Jul 30, 2019 at 4:47 PM Michael Paquier wrote:
> On Fri, Jul 26, 2019 at 09:51:34AM -0400, Andrew Dunstan wrote:
> > I've fixed the bitrot and some other infelicities on this patch. It's
> > not commitable yet but I think it's more reviewable.
>
> Thanks, I had a look at this version.
>
>
On Wed, Jul 31, 2019 at 11:59 PM Andres Freund wrote:
>
> On 2019-07-31 23:51:40 +0200, Julien Rouhaud wrote:
> > On Wed, Jul 31, 2019 at 10:55 AM Evgeny Efimkin
> > wrote:
> > > What reason to use pg_atomic_uint64?
> >
> > The queryid is read and written without holding any lock on the PGPROC
>
On Wed, Jul 31, 2019 at 5:28 AM Tom Lane wrote:
> Meanwhile, I looked at the v3 patch, and it seems like it might not be
> too far from committable. I think we should *not* let this get bogged
> down in questions of whether EXPLAIN can report which index quals were
> used or ignored. That's a pr
On Tue, Jul 16, 2019 at 8:58 AM Fabien COELHO wrote:
> About the feature:
>
> When using aliases both on tables and on the unifying using clause, the former
> are hidden from view. I cannot say that I understand why, and this makes it
> impossible to access some columns in some cases if there is a
On Thu, Jul 18, 2019 at 5:04 PM Tom Lane wrote:
> Tatsuo Ishii writes:
> >> Yeah, the timer logic is wrong. I didn't have time to look into it
> >> but with truss/strace for some reason I see 3 setitimer() syscalls for
> >> every query, but I think this doesn't even need to set the timer for
> >
On Thu, Jul 11, 2019 at 04:57:08PM +0300, Sergei Kornilov wrote:
> I use: ./configure --prefix=somepath --enable-cassert --enable-debug
> CFLAGS="-ggdb -Og -g3 -fno-omit-frame-pointer" --enable-tap-tests
> No other explicit options.
Thanks for the set of flags. So this comes from the use of -Og,
2019年8月1日(木) 1:41 Tom Lane :
>
> Robert Haas writes:
> > Yeah, but I have to admit that this whole design makes me kinda
> > uncomfortable. Every time somebody comes up with a new figure of
> > merit, it increases not only the number of paths retained but also the
> > cost of comparing two paths
On Thu, Aug 1, 2019 at 2:36 AM Andres Freund wrote:
> > > >
> > > > I think the only part its doing for sub-transaction is
> > > > SubTransGetTopmostTransaction(xid). If xid passed to this function is
> > > > already top most transaction which is case for zheap and zedstore, then
> > > > there is
On Thu, Aug 01, 2019 at 11:14:32AM +0530, Jeevan Ladhe wrote:
> Sure, agree, it makes sense to address float8in_internal_opt_error(),
> there might be more occurrences of such instances in other functions
> as well. I think if we agree, as and when encounter them while touching
> those areas we sho
Hi Michael,
What is more dangerous with float8in_internal_opt_error() is, it has
> the have_error flag, which is never ever set or used in that function.
> Further
> more risks are - the callers of this function e.g.
> executeItemOptUnwrapTarget()
> are passing a non-null pointer to it(default set
On Thu, Aug 1, 2019 at 5:51 PM Edmund Horner wrote:
> On Thu, 1 Aug 2019 at 17:47, Thomas Munro wrote:
> > On Thu, Aug 1, 2019 at 5:34 PM Edmund Horner wrote:
> > > Should we move to CF? We have been in the CF cycle for almost a year
> > > now...
> >
> > Hi Edmund,
> >
> > No worries, that's h
On Thu, 1 Aug 2019 at 17:47, Thomas Munro wrote:
> On Thu, Aug 1, 2019 at 5:34 PM Edmund Horner wrote:
> > Should we move to CF? We have been in the CF cycle for almost a year now...
>
> Hi Edmund,
>
> No worries, that's how it goes sometimes. Please move it to the next
> CF if you think you'll
On Thu, Aug 1, 2019 at 5:34 PM Edmund Horner wrote:
> Sadly it is the end of the CF and I have not had much time to work on
> this. I'll probably get some time in the next month to look at the
> heapam changes.
>
> Should we move to CF? We have been in the CF cycle for almost a year now...
Hi E
Hi Michael,
> On further review of the first patch, I think that it could be a good
> idea to apply the same safeguards within float8in_internal_opt_error.
> Jeevan, what do you think?
>
Sure, agree, it makes sense to address float8in_internal_opt_error(),
there might be more occurrences of such
On Tue, Jul 2, 2019 at 2:00 PM Tom Lane wrote:
> movead li writes:
> > I applied the 'alter-table-with-recursive-process-utility-calls-wip.patch'
> > on the master(e788e849addd56007a0e75f3b5514f294a0f3bca). And
> > when I test the cases, I find it works well on 'alter table t1 add column
> > f2 i
On Mon, 22 Jul 2019 at 19:44, Edmund Horner wrote:
> On Mon, 22 Jul 2019 at 19:25, David Rowley
> > On Sat, 20 Jul 2019 at 06:21, Andres Freund wrote:
> > > Yea, I was thinking of something like 2. We already have a few extra
> > > types of scan nodes (bitmap heap and sample scan), it'd not be
On Thu, Aug 1, 2019 at 12:16 PM Jamison, Kirk wrote:
> > On Saturday, July 27, 2019 7:06 AM(GMT+9), Tomas Vondra wrote:
> > > On Fri, Jul 26, 2019 at 07:03:41AM +, Jamison, Kirk wrote:
> > > >Overall, the patch is almost already in good shape for commit.
> > > >I'll wait for the next update.
On Thu, Aug 1, 2019 at 12:10 AM Thomas Munro wrote:
> Hi all,
>
> CF1 officially ends in about 8 hours, when August arrives on the
> volcanic islands of Howard and Baker, according to CURRENT_TIMESTAMP
> AT TIME ZONE '+12'. I'll probably mark it closed at least 8 hours
> later than that because
On Mon, Jul 29, 2019 at 07:04:09AM +0200, Fabien COELHO wrote:
> Bonjour Michaël,
> Yep, I will try for this week.
Please note that for now I have marked the patch as returned with
feedback as the CF is ending.
--
Michael
signature.asc
Description: PGP signature
Hi all,
7cce1593 has introduced a new routine makeIndexInfo to create
IndexInfo nodes. It happens that we can do a bit more refactoring as
per the attached, as BuildIndexInfo can make use of this routine,
removing some duplication on the way (filling in IndexInfo was still
duplicated in a couple
Hi all,
CF1 officially ends in about 8 hours, when August arrives on the
volcanic islands of Howard and Baker, according to CURRENT_TIMESTAMP
AT TIME ZONE '+12'. I'll probably mark it closed at least 8 hours
later than that because I'll be asleep. Anything that is waiting on
author and hasn't h
Hi Tom,
b654714 has reworked the way we handle removal of CLRF for several
code paths, and has repeated the same code patterns to do that in 8
different places. Could it make sense to refactor things as per the
attached with a new routine in common/string.c?
Thanks,
--
Michael
diff --git a/src/b
On Wed, 31 Jul 2019 at 23:05, Konstantin Knizhnik
wrote:
> Current Postgres implementation of temporary table causes number of
> problems:
>
> 1. Catalog bloating: if client creates and deletes too many temporary
> tables, then autovacuum get stuck on catalog.
>
This also upsets logical decoding
On the topic of pg_lsn, I recently noticed that there's no
operator(+)(pg_lsn,bigint) nor is there an operator(-)(pg_lsn,bigint) so
you can't compute offsets easily. We don't have a cast between pg_lsn and
bigint because we don't expose an unsigned bigint type in SQL, so you can't
work around it th
On 7/27/19 6:52 AM, Alvaro Herrera wrote:
On 2019-Jul-25, Michael Paquier wrote:
On Wed, Jul 24, 2019 at 11:23:30AM -0400, Alvaro Herrera wrote:
Heh, yesterday I revised the original patch as attached and was about to
push when the bell rang. I like this one because it keeps the comment
to on
Fujita-san,
Thanks for the reply and sorry I didn't wait a bit more before posting
the patch.
On Wed, Jul 31, 2019 at 9:04 PM Etsuro Fujita wrote:
> On Wed, Jul 31, 2019 at 5:05 PM Amit Langote wrote:
> > On Tue, Jul 30, 2019 at 4:20 PM Amit Langote
> > wrote:
> > > On Sat, Jul 20, 2019 at 1:
On Wed, Jul 31, 2019 at 2:21 PM Michael Paquier wrote:
> That's my impression as well. Please note that this does not involve
> an actual bug in Postgres and that this is rather invasive, so this
> does not really qualify for a back-patch. No objections to simplify
> the backend on HEAD though.
Hi,
On 2019-07-31 19:40:09 -0400, Tom Lane wrote:
> Andres Freund writes:
> > Unfortunately foreach(ListCell *lc, ...) doesn't work with the current
> > definition. Which I think isn't great, because the large scopes for loop
> > iteration variables imo makes the code harder to reason about.
>
>
On Wed, Jul 31, 2019 at 09:51:30AM +0900, Michael Paquier wrote:
> I am adding Peter Eisentraut in CC as 21f428e is his commit. I think
> that the first patch is a good idea, so I would be fine to apply it,
> but let's see the original committer's opinion first.
On further review of the first pat
I wrote:
> BTW, I think we could make equivalent macros in the old regime,
> which would be a good thing because then it would be possible to
> back-patch code using this notation.
Oh, wait-a-second. I was envisioning that
for (ListCell *anonymous__lc = ...)
would work for that, but of
Hi,
> From: Jamison, Kirk [mailto:k.jami...@jp.fujitsu.com]
> Sent: Monday, July 29, 2019 10:53 AM
> To: 'Tomas Vondra'
> Cc: Dean Rasheed ; PostgreSQL Hackers
>
> Subject: RE: Multivariate MCV list vs. statistics target
>
> On Saturday, July 27, 2019 7:06 AM(GMT+9), Tomas Vondra wrote:
> > On
I wrote:
> One idea is that we could do something like
> foreach_variant(identifier, list_value)
> {
>type *v = (type *) lfirst_variant(identifier);
>...
> }
> where the "identifier" isn't actually a variable name but just something
> we use to construct the ForEachState
Andres Freund writes:
> Unfortunately foreach(ListCell *lc, ...) doesn't work with the current
> definition. Which I think isn't great, because the large scopes for loop
> iteration variables imo makes the code harder to reason about.
Yeah, I tried to make that possible when I redid those macros,
Andres Freund writes:
> On 2019-07-31 16:55:31 -0400, Tom Lane wrote:
>> Yeah. I seem to recall a proposal that nodes.h should contain
>>
>> typedef struct Foo Foo;
>>
>> for every node type Foo, and then the other headers would just
>> fill in the structs, and we could get rid of a lot of ad-h
On 01/08/2019 01:04, Andres Freund wrote:
Hi,
On 2019-07-31 16:00:47 -0700, Andres Freund wrote:
On 2019-07-31 15:57:56 -0700, Andres Freund wrote:
I also wonder if a foreach version that includes the typical
(Type *) var = (Type *) lfirst(lc);
or
(Type *) var = castNode(Type, lfirst(lc));
or
Hi,
On 2019-07-31 16:00:47 -0700, Andres Freund wrote:
> On 2019-07-31 15:57:56 -0700, Andres Freund wrote:
> > I also wonder if a foreach version that includes the typical
> > (Type *) var = (Type *) lfirst(lc);
> > or
> > (Type *) var = castNode(Type, lfirst(lc));
> > or
> > OpExpr *hcla
Hi,
On 2019-07-31 15:57:56 -0700, Andres Freund wrote:
> I also wonder if a foreach version that includes the typical
> (Type *) var = (Type *) lfirst(lc);
> or
> (Type *) var = castNode(Type, lfirst(lc));
> or
> OpExpr *hclause = lfirst_node(OpExpr, lc);
>
> would make it nicer to use
Hi,
I was just looking at the diff for a fix, which adds a "ListCell *lc;"
to function scope, even though it's only needed in a pretty narrow
scope.
Unfortunately foreach(ListCell *lc, ...) doesn't work with the current
definition. Which I think isn't great, because the large scopes for loop
iter
Hi,
On 2019-07-31 23:51:40 +0200, Julien Rouhaud wrote:
> On Wed, Jul 31, 2019 at 10:55 AM Evgeny Efimkin
> wrote:
> > What reason to use pg_atomic_uint64?
>
> The queryid is read and written without holding any lock on the PGPROC
> entry, so the pg_atomic_uint64 will guarantee that we get a co
Hi,
On 2019-07-31 16:55:31 -0400, Tom Lane wrote:
> Alvaro Herrera writes:
> > On 2019-Jul-31, Andres Freund wrote:
> >> * I think a lot of the interlinking stems from the bad idea to use
> >> typedef's everywhere. In contrast to structs they cannot be forward
> >> declared portably in our versio
Hello,
On Wed, Jul 31, 2019 at 10:55 AM Evgeny Efimkin wrote:
>
> What reason to use pg_atomic_uint64?
The queryid is read and written without holding any lock on the PGPROC
entry, so the pg_atomic_uint64 will guarantee that we get a consistent
value in pg_stat_get_activity(). Other reads shoul
On Wed, Jul 31, 2019 at 2:11 PM Tom Lane wrote:
> > I agree with this. When I was at EnterpriseDB, while it wasn't audited, we
> > had to develop an actual TPC-B implementation because pgbench was too
> > different. pgbench itself isn't that useful as a benchmark tool, imo, but
> > if we have the
"Jonah H. Harris" writes:
> On Wed, Jul 31, 2019 at 10:10 AM Fabien COELHO wrote:
>> I agree that nobody really cares about TPC-B per se. The point of this
>> patch is to provide a built-in example of recent and useful pgbench
>> features that match a real specification.
> I agree with this. Whe
Hi,
On 2019-07-31 12:37:58 -0700, Ashwin Agrawal wrote:
> On Wed, Jul 31, 2019 at 10:55 AM Andres Freund wrote:
>
> > Hi,
> >
> > On 2019-07-31 10:42:50 -0700, Ashwin Agrawal wrote:
> > > On Tue, Jul 30, 2019 at 2:58 PM Thomas Munro
> > wrote:
> > >
> > > > On Tue, Jun 25, 2019 at 6:02 AM Andres
On Wed, Jul 31, 2019 at 12:37 PM Ashwin Agrawal wrote:
>
> On Wed, Jul 31, 2019 at 10:55 AM Andres Freund wrote:
>
>> Hi,
>>
>> On 2019-07-31 10:42:50 -0700, Ashwin Agrawal wrote:
>> > On Tue, Jul 30, 2019 at 2:58 PM Thomas Munro
>> wrote:
>> >
>> > > On Tue, Jun 25, 2019 at 6:02 AM Andres Freu
Alvaro Herrera writes:
> On 2019-Jul-31, Andres Freund wrote:
>> * I think a lot of the interlinking stems from the bad idea to use
>> typedef's everywhere. In contrast to structs they cannot be forward
>> declared portably in our version of C. We should use a lot more struct
>> forward declaratio
On 2019-Jul-31, Konstantin Knizhnik wrote:
> On 08.07.2019 11:05, Michael Paquier wrote:
> > Please note that I have not looked at that stuff in details, but I
> > find the patch proposed kind of ugly with the scan of the last segment
> > using a WAL reader to find out what is the last LSN and re
On 2019-Jul-31, Andres Freund wrote:
> IDK, I find the compilation times annoying. And it's gotten quite
> noticably worse with all the speculative execution mitigations. Although
> to some degree that's not really the fault of individual compilations,
> but our buildsystem being pretty slow.
We'
On Wed, Jul 31, 2019 at 1:59 PM vignesh C wrote:
> I feel Robert's suggestion is good.
> We can probably keep one meta file for each backup with some basic information
> of all the files being backed up, this metadata file will be useful in the
> below case:
> Table dropped before incremental back
On 31.07.2019 19:56, Heikki Linnakangas wrote:
On 09/07/2019 23:59, Konstantin Knizhnik wrote:
Fixed patch version of the path is attached.
Much of the patch and the discussion has been around the raw parsing,
and guessing which literals are actually parameters that have been
inlined into
On Wed, Jul 31, 2019 at 10:55 AM Andres Freund wrote:
> Hi,
>
> On 2019-07-31 10:42:50 -0700, Ashwin Agrawal wrote:
> > On Tue, Jul 30, 2019 at 2:58 PM Thomas Munro
> wrote:
> >
> > > On Tue, Jun 25, 2019 at 6:02 AM Andres Freund
> wrote:
> > > > > - CheckForSerializableConflictOut() no more ta
On Tue, Jul 30, 2019 at 1:58 AM Robert Haas wrote:
>
> On Wed, Jul 10, 2019 at 2:17 PM Anastasia Lubennikova
> wrote:
> > In attachments, you can find a prototype of incremental pg_basebackup,
> > which consists of 2 features:
> >
> > 1) To perform incremental backup one should call pg_basebackup
Hi,
On 2019-07-31 10:42:50 -0700, Ashwin Agrawal wrote:
> On Tue, Jul 30, 2019 at 2:58 PM Thomas Munro wrote:
>
> > On Tue, Jun 25, 2019 at 6:02 AM Andres Freund wrote:
> > > > - CheckForSerializableConflictOut() no more takes HeapTuple nor
> > > > buffer, instead just takes xid. Push heap sp
Hi,
On 2019-07-31 09:57:58 +1200, Thomas Munro wrote:
> On Tue, Jun 25, 2019 at 6:02 AM Andres Freund wrote:
> > Hm. I wonder if we somehow ought to generalize the granularity scheme
> > for predicate locks to not be tuple/page/relation. But even if, that's
> > probably a separate patch.
>
> W
On Fri, Jul 26, 2019 at 7:25 PM Peter Geoghegan wrote:
> I guess that the idea here was to prevent masking on ipv6 addresses,
> though not on ipv4 addresses. Obviously we're only dealing with a
> prefix with ipv6 addresses, whereas we usually have the whole raw
> ipaddr with ipv4. Not sure if I'm
On Tue, Jul 30, 2019 at 2:58 PM Thomas Munro wrote:
> On Tue, Jun 25, 2019 at 6:02 AM Andres Freund wrote:
> > > - CheckForSerializableConflictOut() no more takes HeapTuple nor
> > > buffer, instead just takes xid. Push heap specific parts from
> > > CheckForSerializableConflictOut() into it
On 08/07/2019 22:42, Daniel Gustafsson wrote:
My patch for using heap_multi_insert in the catalog [1] failed the logical
decoding part of test/recovery [2].
The assertion it failed on seems to not take multi inserts into the catalog
into consideration, while the main logic does. This assertion
On 09/07/2019 23:59, Konstantin Knizhnik wrote:
Fixed patch version of the path is attached.
Much of the patch and the discussion has been around the raw parsing,
and guessing which literals are actually parameters that have been
inlined into the SQL text. Do we really need to do that, though
Robert Haas writes:
> Yeah, but I have to admit that this whole design makes me kinda
> uncomfortable. Every time somebody comes up with a new figure of
> merit, it increases not only the number of paths retained but also the
> cost of comparing two paths to possibly reject one of them. A few
> y
24.07.2019 4:22, Peter Geoghegan wrote:
Attached is a revised version of your v2 that fixes this issue -- I'll
call this v3. In general, my goal for the revision was to make sure
that all of my old tests from the v12 work passed, and to make sure
that amcheck can detect almost any possible probl
On Tue, Jul 30, 2019 at 2:10 PM Tom Lane wrote:
> Sure. But I think what we can foresee is that if there are any bugs
> reachable this way, they'd be reachable and need fixing regardless.
> We've already established that parallel workers can take and release locks
> that their leader isn't holdin
On Wed, Jul 31, 2019 at 11:07 AM Tom Lane wrote:
> What you'd want to do for something like the above, I think, is to
> have some kind of figure of merit or other special marking for paths
> that will have some possible special advantage in later planning
> steps. Then you can teach add_path that
Hi,
On 2019-07-31 11:23:22 -0400, Alvaro Herrera wrote:
> I think removing unnecessary include lines from header files is much
> more useful than from .c files. However, nowadays even I am not very
> convinced that that is a very fruitful use of time, since many/most
> developers use ccache which
Hi,
On 2019-07-31 21:03:58 +0900, Etsuro Fujita wrote:
> I'm still not sure that it's a good idea to remove
> es_result_relation_info, but if I had to say then I think the latter
> would probably be better. I'm planning to rework on direct
> modification to base it on upper planner pathification
On 2019-Jul-31, vignesh C wrote:
> I noticed that there are many header files being
> included which need not be included.
Yeah, we have tooling for this already in src/tools/pginclude. It's
been used before, and it has wreaked considerable havoc; see "git log
--grep pgrminclude".
I think doing
Kohei KaiGai writes:
> When we add a new path using add_path(), it checks estimated cost and
> path-keys,
> then it also removes dominated paths, if any.
> Do we have a reasonable way to retain these "dominated" paths? Once it
> is considered
> lesser paths at a level, however, it may have a comb
Current Postgres implementation of temporary table causes number of
problems:
1. Catalog bloating: if client creates and deletes too many temporary
tables, then autovacuum get stuck on catalog.
2. Parallel queries: right now usage of temporary tables in query
disables parallel plan.
3. It is n
On Thu, 25 Jul 2019 at 05:49, Peter Geoghegan wrote:
>
> On Wed, Jul 24, 2019 at 3:06 PM Peter Geoghegan wrote:
> > There seems to be a kind of "synergy" between the nbtsplitloc.c
> > handling of pages that have lots of duplicates and posting list
> > compression. It seems as if the former mechan
On Wed, Jul 31, 2019 at 10:10 AM Fabien COELHO wrote:
>
> Hello Tom,
>
> >>> I'm also highly dubious about labeling this script "standard TPC-B",
> >>> when it resolves only some of the reasons why our traditional script
> >>> is not really TPC-B. That's treading on being false advertising.
> >
Hello Tom,
I'm also highly dubious about labeling this script "standard TPC-B",
when it resolves only some of the reasons why our traditional script
is not really TPC-B. That's treading on being false advertising.
IANAL, but it may not even be permissible to claim that we have
implemented "
On 08.07.2019 11:05, Michael Paquier wrote:
On Mon, Jul 08, 2019 at 07:56:25PM +1200, Thomas Munro wrote:
On Thu, Jan 31, 2019 at 3:34 AM Alvaro Herrera wrote:
On 2019-Jan-30, Konstantin Knizhnik wrote:
I wonder if it can be considered as acceptable solution of the problem or
there can be
Michael Paquier writes:
> On Wed, Jul 31, 2019 at 11:55:37AM +0530, Amit Kapila wrote:
>> If we can come up with some such tool, we might be able to integrate
>> it with Thomas's patch tester [1] wherein it can apply the patch,
>> verify if there are unnecessary includes in the patch and report th
On Wed, Jul 31, 2019 at 2:32 AM Masahiko Sawada
wrote:
> Just to confirm, we have 21 bits left for nonce in CTR? We have LSN (8
> bytes), page-number (4 bytes) and counter (11 bits) in 16 bytes nonce
> space. Even though we have 21 bits left we cannot store relfilenode to
> the IV.
>
Fields like
Hello Jeremy,
Comments, notes?
One oddity about pg_relation_size and pg_table_size is that they can be
easily blocked by user activity. In fact it happens to us often in
reporting environments and we have instead written different versions of
them that avoid the lock contention and still gi
On Tue, Jul 30, 2019 at 4:48 PM Bruce Momjian wrote:
> I had more time to think about the complexity of adding relfilenode to
> the IV. Since relfilenode is only unique within a database/tablespace,
> we would need to have pg_upgrade preserve database/tablespace oids
> (which I assume are the sa
On Wed, Jul 31, 2019 at 10:13 AM Amit Kapila wrote:
>
> On Tue, Jul 30, 2019 at 5:26 PM Thomas Munro wrote:
> >
> > Hi Amit
> >
> > I've been testing some undo worker workloads (more on that soon),
> >
>
> One small point, there is one small bug in the error queues which is
> that the element pus
On Wed, Jul 24, 2019 at 10:00 AM Dilip Kumar wrote:
>
> On Mon, Jul 22, 2019 at 3:51 PM Dilip Kumar wrote:
> >
> Please find my review comments for
> 0013-Allow-foreground-transactions-to-perform-undo-action
>
> + /* initialize undo record locations for the transaction */
> + for (i = 0; i < Undo
On Fri, Jun 28, 2019 at 10:13 AM Pavel Stehule
wrote:
> Hi
>
> I returned to possibility to sort output of \d* and \l by size. There was
> more a experiments in this area, but without success. Last patch was
> example of over engineering, and now, I try to implement this feature
> simply how it i
On Mon, 15 Jul 2019 at 06:12, Pavel Stehule wrote:
>
> Hi
>
> pá 12. 7. 2019 v 15:10 odesílatel Fabien COELHO napsal:
>>
>>
>> Hello Pavel,
>>
>> > rebased patch attached
>>
>> I prefer patches with a number rather than a date, if possible. For one
>> thing, there may be several updates in one da
On 2019-Jul-31, Amit Langote wrote:
> Hello,
>
> I noticed that the patch is still marked as "Waiting on Author" ever
> since Shawn set it that way on June 17. Since Hosoya-san posted
> updated patches on June 27, the status should've been changed to
> "Needs Review". Or maybe "Ready for Commit
On Wed, Jul 31, 2019 at 5:05 PM Amit Langote wrote:
> On Tue, Jul 30, 2019 at 4:20 PM Amit Langote wrote:
> > On Sat, Jul 20, 2019 at 1:52 AM Andres Freund wrote:
> > > IOW, we should just change the direct modify calls to get the relevant
> > > ResultRelationInfo or something in that vein (perh
On Tue, Jul 30, 2019 at 6:06 PM Robert Haas wrote:
> On Tue, Jul 30, 2019 at 4:52 AM Jeevan Ladhe
> wrote:
> > My only concern was something that we internally treat as invalid, why do
> > we allow, that as a valid value for that type. While I am not trying to
> > reinvent the wheel here, I am t
On 2019-07-29 16:47, Tom Lane wrote:
>> (The two tests create the same schema name, so they cannot be run in
>> parallel. I opted against changing that here, since it would blow up
>> the patch and increase the diff between the two tests.)
>
> This does create one tiny nit, which is that the orde
On 7/28/19 12:19 AM, Tomas Vondra wrote:
> Hi,
>
> I've started reviewing this patch, thinking that maybe I could get it
> committed as it's marked as RFC. In general I agree with having this
> fuature, but I think we need to rethink the GUC because the current
> approach is just confusing.
>
> T
Hi,
Attached is the latest patch for supporting min and max aggregate functions.
When new tuples are inserted into base tables, if new values are small
(for min) or large (for max), matview just have to be updated with these
new values. Otherwise, old values just remains.
However, in the cas
What reason to use pg_atomic_uint64?
In docs:
occured - > occurred
On 26.07.2019 19:20, Ryan Lambert wrote:
> PgPRO EE version of connection pooler has "idle_pool_worker_timeout"
> parameter which allows to terminate idle workers.
+1
I have implemented idle_pool_worker_timeout.
Also I added _idle_clients and n_idle_backends fields to proxy statistic
retu
Hello,
I noticed that the patch is still marked as "Waiting on Author" ever
since Shawn set it that way on June 17. Since Hosoya-san posted
updated patches on June 27, the status should've been changed to
"Needs Review". Or maybe "Ready for Committer", because the last time
I looked, at least th
On Tue, Jul 30, 2019 at 11:05 PM Tomas Vondra
wrote:
> On Tue, Jul 30, 2019 at 03:50:32PM +0800, Richard Guo wrote:
> >On Wed, Jun 12, 2019 at 10:58 AM Richard Guo wrote:
> >
> >> Hi all,
> >>
> >> Paul and I have been hacking recently to implement parallel grouping
> >> sets, and here we have t
On Tue, Jul 30, 2019 at 4:20 PM Amit Langote wrote:
> On Sat, Jul 20, 2019 at 1:52 AM Andres Freund wrote:
> > > The first one (0001) deals with reducing the core executor's reliance
> > > on es_result_relation_info to access the currently active result
> > > relation, in favor of receiving it fr
On Wed, Jul 31, 2019 at 3:29 PM Masahiko Sawada wrote:
>
>
> For WAL encryption, before flushing WAL we encrypt whole 8k WAL page
> and then write only the encrypted data of the new WAL record using
> pg_pwrite() rather than write whole encrypted page. So each time we
> encrypt 8k WAL page we end
At Tue, 30 Jul 2019 21:30:45 +0900 (Tokyo Standard Time), Kyotaro Horiguchi
wrote in
<20190730.213045.221405075.horikyota@gmail.com>
> I attach the revised patch. I'll repost the polished version
> sooner.
This is the revised patch.
- Status criteria has been changed.
"streaming" : rest
On Tue, Jul 30, 2019 at 10:45 PM Sehrope Sarkuni wrote:
>
> On Tue, Jul 30, 2019 at 8:16 AM Masahiko Sawada wrote:
>>
>> On Mon, Jul 29, 2019 at 8:18 PM Sehrope Sarkuni wrote:
>> >
>> > On Mon, Jul 29, 2019 at 6:42 AM Masahiko Sawada
>> > wrote:
>> > > > An argument could be made to push that
On 2019-07-28 00:09:51 -0400, Tom Lane wrote:
> Andres Freund writes:
> > a few prototypes look odd. It appears to be cases where previously the
> > odd indentation was put to some use, by indenting parameters less:
> > ...
> > but now that looks odd:
> > extern void DefineCustomBoolVariable(
> >
On Wed, Jul 31, 2019 at 5:48 AM Bruce Momjian wrote:
>
> On Tue, Jul 30, 2019 at 10:14:14AM -0400, Sehrope Sarkuni wrote:
> > > In general it's fine to use the same IV with different keys. Only
> > reuse
> > of Key
> > > + IV is a problem and the entire set of possible counter values
98 matches
Mail list logo
