Re: PG 12 draft release notes

2019-05-12 Thread Fabien COELHO
Hello Bruce, I have posted a draft copy of the PG 12 release notes here: http://momjian.us/pgsql_docs/release-12.html They are committed to git. It includes links to the main docs, where appropriate. Our official developer docs will rebuild in a few hours. Pgbench entry "Improve

Re: SQL-spec incompatibilities in similar_escape() and related stuff

2019-05-12 Thread Andrew Gierth
> "Tom" == Tom Lane writes: Tom> but in recent versions it's Tom> ::= Tom> SUBSTRING Tom> SIMILAR Tom> ESCAPE Tom> I am, frankly, inclined to ignore this as a bad idea. We do have To

Re: New EXPLAIN option: ALL

2019-05-12 Thread David Fetter
On Tue, May 07, 2019 at 06:25:12PM -0400, Tom Lane wrote: > Stephen Frost writes: > > I'm generally in favor of doing something like what Tom is suggesting > > with VERBOSE, but I also feel like it should be the default for formats > > like JSON. If you're asking for the output in JSON, then we r

RE: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)

2019-05-12 Thread Smith, Peter
Hi Masahiko, > Let me briefly explain the current design I'm thinking. The design employees > 2-tier key architecture. That is, a database cluster has one > master key and per-tablespace keys which are encrypted with the master key > before storing to disk. Each tablespace keys are generated > r

PANIC :Call AbortTransaction when transaction id is no normal

2019-05-12 Thread Thunder
Hello, The process crashed when running in bootstrap mode and received signal to shutdown. From the call stack we can see that the transaction id is 1, which is BootstrapTransactionId. During TransactionLogFetch function, which fetch commit status of specified transaction id, it will return

Re: PG 12 draft release notes

2019-05-12 Thread Bruce Momjian
On Mon, May 13, 2019 at 01:37:25PM +1200, David Rowley wrote: > On Sun, 12 May 2019 at 08:33, Bruce Momjian wrote: > > > > I have posted a draft copy of the PG 12 release notes here: > > > > http://momjian.us/pgsql_docs/release-12.html > > I noticed a couple of different spellings of Álva

Re: PG 12 draft release notes

2019-05-12 Thread Bruce Momjian
On Sun, May 12, 2019 at 09:49:40AM -0400, Bruce Momjian wrote: > On Sun, May 12, 2019 at 10:00:38AM +0300, Oleg Bartunov wrote: > > Bruce, > > > > I noticed that jsonpath in your version is mentioned only in functions > > chapter, but commit > > 72b6460336e86ad5cafd3426af6013c7d8457367 is about i

Re: PG 12 draft release notes

2019-05-12 Thread Bruce Momjian
On Sun, May 12, 2019 at 10:49:07AM -0400, Jonathan Katz wrote: > Hi Bruce, > > On 5/11/19 4:33 PM, Bruce Momjian wrote: > > I have posted a draft copy of the PG 12 release notes here: > > > > http://momjian.us/pgsql_docs/release-12.html > > > > They are committed to git. It includes links t

Re: cleanup & refactoring on reindexdb.c

2019-05-12 Thread Michael Paquier
On Sun, May 12, 2019 at 11:16:28AM +0200, Julien Rouhaud wrote: > I attach two patches to fix both (it could be squashed in a single > commit as both are straightforward), for upcoming v13. Squashing both patches together makes the most sense in my opinion as the same areas are reworked. I can no

pglz performance

2019-05-12 Thread Andrey Borodin
Hi hackers! I was reviewing Paul Ramsey's TOAST patch[0] and noticed that there is a big room for improvement in performance of pglz compression and decompression. With Vladimir we started to investigate ways to boost byte copying and eventually created test suit[1] to investigate performance o

Re: PG 12 draft release notes

2019-05-12 Thread David Rowley
On Sun, 12 May 2019 at 08:33, Bruce Momjian wrote: > > I have posted a draft copy of the PG 12 release notes here: > > http://momjian.us/pgsql_docs/release-12.html I noticed a couple of different spellings of Álvaro's name. Loading the file line by line into a table and crudely performin

SQL-spec incompatibilities in similar_escape() and related stuff

2019-05-12 Thread Tom Lane
Over in pgsql-bugs [1], we're looking into some bugs associated with mistranslation of SQL-spec regexes to POSIX regexes. However, while poking at that I couldn't help noticing that there are more ways in which we're not following the letter of the SQL spec in this area: * As Andrew noted, somewh

Re: [HACKERS] WAL logging problem in 9.4.3?

2019-05-12 Thread Noah Misch
On Sun, Mar 31, 2019 at 03:31:58PM -0700, Noah Misch wrote: > On Sun, Mar 10, 2019 at 07:27:08PM -0700, Noah Misch wrote: > > I also liked the design in the https://postgr.es/m/559fa0ba.3080...@iki.fi > > last paragraph, and I suspect it would have been no harder to back-patch. I > > wonder if it

Re: Wrong dead return value in jsonb_utils.c

2019-05-12 Thread Michael Paquier
On Sun, May 12, 2019 at 10:15:05AM -0400, Tom Lane wrote: > +1 for a HEAD-only change. I think the only really good arguments > for back-patching would be if this were causing compiler warnings > (but we've seen none) or if we thought it would likely lead to > hazards for back-patching future bug

Re: PG 12 draft release notes

2019-05-12 Thread Jonathan S. Katz
Hi Bruce, On 5/11/19 4:33 PM, Bruce Momjian wrote: > I have posted a draft copy of the PG 12 release notes here: > > http://momjian.us/pgsql_docs/release-12.html > > They are committed to git. It includes links to the main docs, where > appropriate. Our official developer docs will rebui

Re: Wrong dead return value in jsonb_utils.c

2019-05-12 Thread Tom Lane
Michael Paquier writes: > As that's really cosmetic, I would just change that on HEAD, or > perhaps others feel differently? +1 for a HEAD-only change. I think the only really good arguments for back-patching would be if this were causing compiler warnings (but we've seen none) or if we thought

Re: PG 12 draft release notes

2019-05-12 Thread Bruce Momjian
On Sun, May 12, 2019 at 10:00:38AM +0300, Oleg Bartunov wrote: > Bruce, > > I noticed that jsonpath in your version is mentioned only in functions > chapter, but commit > 72b6460336e86ad5cafd3426af6013c7d8457367 is about implementation of > SQL-2016 standard. We implemented JSON Path language as

Re: Why is infinite_recurse test suddenly failing?

2019-05-12 Thread Andrew Dunstan
On 5/12/19 4:57 AM, Michael Paquier wrote: > On Fri, May 10, 2019 at 05:26:43PM -0400, Andrew Dunstan wrote: >> I think we'll need to write that as: >> >>     print $handle 'p $_siginfo',"\n"; >> >> As you have it written perl will try to interpolate a variable called >> $_siginfo. > Anything in

cleanup & refactoring on reindexdb.c

2019-05-12 Thread Julien Rouhaud
Hi, As discussed in https://www.postgresql.org/message-id/caobau_yo61rwno3cw6wvywwh7eympuexhkqufb2nfgodunb...@mail.gmail.com, current coding in reindexdb.c is error prone, and reindex_system_catalogs() is also not really required. I attach two patches to fix both (it could be squashed in a single

Re: Wrong dead return value in jsonb_utils.c

2019-05-12 Thread Michael Paquier
On Sun, May 12, 2019 at 03:18:08AM +0200, Rikard Falkeborn wrote: > Returning -1 from a function with bool as return value is the same as > returning true. Now, the code is dead (since elog(ERROR, ...) does not > return) so it doesn't matter to the compiler, but changing to false is less > confusin

Re: Why is infinite_recurse test suddenly failing?

2019-05-12 Thread Michael Paquier
On Fri, May 10, 2019 at 05:26:43PM -0400, Andrew Dunstan wrote: > I think we'll need to write that as: > >     print $handle 'p $_siginfo',"\n"; > > As you have it written perl will try to interpolate a variable called > $_siginfo. Anything in double quotes with a dollar sign would be interprete

Re: Augment every test postgresql.conf

2019-05-12 Thread Noah Misch
On Sat, May 11, 2019 at 10:43:59PM -0400, Tom Lane wrote: > Noah Misch writes: > > Pushed. This broke 010_dump_connstr.pl on bowerbird, introducing 'invalid > > byte sequence for encoding "UTF8"' errors. That's because log_connections > > renders this 010_dump_connstr.pl solution insufficient: >

Re: PG 12 draft release notes

2019-05-12 Thread Oleg Bartunov
Bruce, I noticed that jsonpath in your version is mentioned only in functions chapter, but commit 72b6460336e86ad5cafd3426af6013c7d8457367 is about implementation of SQL-2016 standard. We implemented JSON Path language as a jsonpath datatype with a bunch of support functions, our implementation s