On Sat, May 19, 2018 at 4:51 PM, Thomas Munro
wrote:
> Next, make check hangs in initdb on both of my pet OSes when md.c
> raises an error (fseek fails) and we raise and error while raising and
> error and deadlock against ourselves. Backtrace here:
> https://paste.debian.net/1025336/
Ah, I see
On Sat, May 19, 2018 at 9:03 AM, Andres Freund wrote:
> I've written a patch series for this. Took me quite a bit longer than I
> had hoped.
Great.
> I plan to switch to working on something else for a day or two next
> week, and then polish this further. I'd greatly appreciate comments till
> t
On Sat, May 19, 2018 at 5:02 AM, Robert Haas wrote:
> On Fri, May 18, 2018 at 4:22 AM, Amit Langote
> wrote:
>> Yeah, I think it'd help to have Append be annotated as suggested by Robert
>> above. I guess if "at executor startup" is shown, then the subnodes
>> listed under Append will consist of
On 05/18/2018 09:05 PM, Peter Eisentraut wrote:
On 5/18/18 14:02, Andrew Dunstan wrote:
These two small patches allow us to run "perl -cw" cleanly on all our
perl code.
It's not clear to me what that really means. My understanding is that
perl "warnings" are primarily a run-time instrument,
I reread this and have some more comments.
https://www.postgresql.org/docs/devel/static/ddl-partitioning.html
"however, it is not possible to use some of the inheritance features discussed
in the previous section with partitioned tables and partitions"
=> The referenced section now follows rather
On 5/18/18 14:02, Andrew Dunstan wrote:
> These two small patches allow us to run "perl -cw" cleanly on all our
> perl code.
It's not clear to me what that really means. My understanding is that
perl "warnings" are primarily a run-time instrument, unlike 'use strict'
and perl -c. I have been pl
Greetings,
* Abhijit Menon-Sen (a...@2ndquadrant.com) wrote:
> At 2018-05-18 20:27:57 -0400, sfr...@snowman.net wrote:
> >
> > I don't agree with the general notion that we can't have a function
> > which handles the complicated bits about the kind of error because
> > someone grep'ing the source
At 2018-05-18 20:27:57 -0400, sfr...@snowman.net wrote:
>
> I don't agree with the general notion that we can't have a function
> which handles the complicated bits about the kind of error because
> someone grep'ing the source for PANIC might have to do an additional
> lookup.
Or we could just nam
Greetings,
* Ashutosh Bapat (ashutosh.ba...@enterprisedb.com) wrote:
> On Thu, May 17, 2018 at 11:45 PM, Robert Haas wrote:
> > On Thu, May 17, 2018 at 12:44 PM, Andres Freund wrote:
> >> Hi,
> >>
> >> On 2018-05-10 09:50:03 +0800, Craig Ringer wrote:
> >>> while ((src = (RewriteMappingFil
Greetings,
* Robert Haas (robertmh...@gmail.com) wrote:
> On Tue, May 15, 2018 at 6:07 PM, Tom Lane wrote:
> > That seems like an awful lot of work to handle what's still going to be
> > a pretty small set of permissions. Every permission we add is going to
> > have to be enforced in the C code,
On Fri, May 18, 2018 at 10:53 PM, John Naylor wrote:
> On 5/17/18, Thomas Munro wrote:
>> Hi John,
>>
>> This failed for my patch testing robot on Windows, with this message[1]:
> ...
>> I see that you changed src/backend/catalog/Makefile to pass the new -I
>> switch to genbki.pl. I think for Wi
Hi,
On 2018-04-27 15:28:42 -0700, Andres Freund wrote:
> == Potential Postgres Changes ==
>
> Several operating systems / file systems behave differently (See
> e.g. [2], thanks Thomas) than we expected. Even the discussed changes to
> e.g. linux don't get to where we thought we are. There's obvi
On Thu, May 17, 2018 at 10:13 AM, Tom Lane wrote:
> Maybe what you need is a redesign. This convention seems impossibly
> confusing and hence error-prone. What about using a separate bool to
> indicate which list the index refers to?
I really don't think it's a big deal. The comments may need
On Thu, May 17, 2018 at 9:56 PM, Amit Langote
wrote:
> On 2018/05/18 5:56, David Rowley wrote:
>> On 18 May 2018 at 06:21, Robert Haas wrote:
>>> All right, so let's just say that explicitly. Maybe something like
>>> the attached.
>>
>> That looks fine to me.
>
> Me too, except:
>
> +* *
On Thu, May 17, 2018 at 9:09 PM, Bruce Momjian wrote:
>> However, I think that's probably worrying about the wrong end of the
>> problem first. IMHO, what we ought to start by doing is considering
>> what a good architecture for this would be, and how to solve the
>> general problem of per-backen
On Fri, May 18, 2018 at 4:22 AM, Amit Langote
wrote:
> Yeah, I think it'd help to have Append be annotated as suggested by Robert
> above. I guess if "at executor startup" is shown, then the subnodes
> listed under Append will consist of only those that survived
> executor-startup pruning and thu
On Thu, May 17, 2018 at 9:49 AM, Alex Kliukin wrote:
> Earlier this week we have split our Postgres 9.6.8 shards, each having two
> databases, into one database per shard setup. This was done by promoting
> replicas and subsequently removing unused databases.
>
> Immediately afterwards we have dis
On Thu, May 17, 2018 at 9:37 AM, Stefan Fercot wrote:
> When restoring a plain SQL dump, we got the message :
>
> ERROR: invalid XML content
> DETAIL: line 1: StartTag: invalid element name
> http://mrcc.com/qgis.dtd' 'SYSTEM'>
> ^
> CONTEXT: COPY layer_styles, line 1, column styleqml: " 'http
On Wed, May 16, 2018 at 6:13 PM, Tom Lane wrote:
> David Rowley writes:
>> On 17 May 2018 at 08:44, Simon Riggs wrote:
>>> What I was advocating was an approach that varies according to the
>>> query cost, so we don't waste time trying to tune the heck out of OLTP
>>> queries, but for larger que
On Fri, May 18, 2018 at 4:29 AM, Kyotaro HORIGUCHI
wrote:
> I have reached to the same thought.
>
> The point here is that it is a base relation, which is not
> assumed to have additional columns not in its definition,
> including nonsystem junk columns. I'm not sure but it seems not
> that simple
On Thu, May 17, 2018 at 4:10 PM, Peter Eisentraut
wrote:
> I think I have made a mistake here. I was reading in between the lines
> of a competitor's documentation that they have functions and procedures
> in different name spaces, which made me re-read the SQL standard, which
> appears to suppor
On Wed, May 16, 2018 at 11:30 PM, Etsuro Fujita
wrote:
>>> Attached is a patch for fixing this issue.
>> This no longer applies.
> The patch has already been committed by you [1]. Thanks for committing!
Well, that's embarrassing.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Ent
These two small patches allow us to run "perl -cw" cleanly on all our
perl code.
One patch silences a warning from convutils.pl about the unportability
of the literal 0x1. We've run for many years without this giving
us a problem, so I think we can turn the warning off pretty safely
On 2018-May-03, Robert Haas wrote:
> The asymmetry doesn't seem horrible to me on its own merits, but it
> would lead to some odd behavior: suppose you defined a BEFORE ROW
> trigger and an AFTER ROW trigger on the parent, and then inserted one
> row into the parent table and a second row directly
On 17 May 2018 at 18:29, Bruce Momjian wrote:
> I regularly track the number of items documented in each major release.
> I use the attached script. You might be surprised to learn that PG 11
> has the lowest feature count of any release back through 7.4:
>
> 7.4 280
> 8.0
On Fri, May 18, 2018 at 5:19 PM, John Naylor wrote:
> On 5/18/18, Sandeep Thakkar wrote:
> > Hi
> >
> > I was building the sources I got from https://www.postgresql.org/
> > ftp/snapshot/dev/ on Windows x64 and got the whole bunch of errors
> > like "*Cannot
> > open include file: 'catalog/pg_ty
On 05/17/2018 04:29 PM, Bruce Momjian wrote:
I regularly track the number of items documented in each major release.
I use the attached script. You might be surprised to learn that PG 11
has the lowest feature count of any release back through 7.4:
7.4 280
8.0 238
> On May 18, 2018, at 10:41 AM, Alvaro Herrera wrote:
>
> On 2018-May-17, Bruce Momjian wrote:
>
>> 9.5 200
>> 9.6 220
>> 10 194
>> 11 167
>
> Just yesterday Andres was telling us that pg11 has so much new stuff,
> when compared to 9.5 and 9.6, that seemed
On Thu, May 17, 2018 at 02:14:07PM -0400, Robert Haas wrote:
> On Thu, May 17, 2018 at 1:52 PM, Tom Lane wrote:
> > Do we actually need to worry about unmapping promptly on DROP TEXT
> > DICTIONARY? It seems like the only downside of not doing that is that
> > we'd leak some address space until p
Hi Bruce.
On Tue, May 15, 2018 at 12:46 PM, Amit Langote
wrote:
> On 2018/05/15 5:30, Bruce Momjian wrote:
>> I like it, done.
>
> Thank you.
I wonder what you think about including this little performance item:
https://www.postgresql.org/message-id/e1eotsq-0005v0...@gemulon.postgresql.org
esp
> On May 11, 2018, at 11:08 AM, Bruce Momjian wrote:
>
> I have committed the first draft of the Postgres 11 release notes. I
> will add more markup soon. You can view the most current version here:
>
> http://momjian.us/pgsql_docs/release-11.html
>
> I expect a torrent of feedback. ;
On Fri, May 18, 2018 at 4:02 PM, Michael Paquier
wrote:
> On Fri, May 18, 2018 at 03:54:47PM +0300, Heikki Linnakangas wrote:
> > Looks good to me.
>
> +1 for fixing that. get_controlfile() in controldata_utils.c also needs
> to be fixed.
>
Pushed a fix including the controldata_utils.c one.
P
On Thu, May 17, 2018 at 10:18:56AM -0400, Tom Lane wrote:
> I think the point you've not addressed is that "syscache callback
> occurred" does not equate to "object was dropped". Can the code
> survive having this occur at any invalidation point?
> (CLOBBER_CACHE_ALWAYS testing would soon expose a
On Fri, May 18, 2018 at 10:49:30AM -0400, Tom Lane wrote:
> Alvaro Herrera writes:
> > Just yesterday Andres was telling us that pg11 has so much new stuff,
> > when compared to 9.5 and 9.6, that seemed to have not as much shiny
> > things. I think it's all in the eye of the beholder; our release
John Naylor writes:
> On 5/18/18, Sandeep Thakkar wrote:
>> I was building the sources I got from https://www.postgresql.org/
>> ftp/snapshot/dev/ on Windows x64 and got the whole bunch of errors
>> like "*Cannot
>> open include file: 'catalog/pg_type_d.h"* , *"Cannot open include file:
>> 'catal
On Fri, May 18, 2018 at 4:46 PM, Tom Lane wrote:
> Peter Eisentraut writes:
> > The new pg_basebackup -k option stands for --no-verify-checksums. That
> > is nearly the opposite of initdb -k, which is for enabling checksums. I
> > think it could be confusing to have two related tools use the s
Hi,
On Fri, May 18, 2018 at 10:46:37AM -0400, Tom Lane wrote:
> Peter Eisentraut writes:
> > The new pg_basebackup -k option stands for --no-verify-checksums. That
> > is nearly the opposite of initdb -k, which is for enabling checksums. I
> > think it could be confusing to have two related too
On Fri, May 11, 2018 at 9:56 AM, Masahiko Sawada wrote:
> Thank you for the comment.
>
> On Fri, May 11, 2018 at 3:57 AM, Robert Haas wrote:
>> On Tue, Feb 27, 2018 at 2:21 AM, Masahiko Sawada
>> wrote:
>>> I might be missing your point. As for API breaking, this patch doesn't
>>> break any exi
Alvaro Herrera writes:
> Just yesterday Andres was telling us that pg11 has so much new stuff,
> when compared to 9.5 and 9.6, that seemed to have not as much shiny
> things. I think it's all in the eye of the beholder; our releases are
> large, and getting larger every year.
Yeah. My feeling f
Peter Eisentraut writes:
> The new pg_basebackup -k option stands for --no-verify-checksums. That
> is nearly the opposite of initdb -k, which is for enabling checksums. I
> think it could be confusing to have two related tools use the same
> option letter for nearly opposite purposes.
> How ab
Hi
I think having only long option is enough
regards, Sergei
On 2018-May-17, Bruce Momjian wrote:
> 9.5 200
> 9.6 220
> 10 194
> 11 167
Just yesterday Andres was telling us that pg11 has so much new stuff,
when compared to 9.5 and 9.6, that seemed to have not as much shiny
things. I think it's all in the eye of th
The new pg_basebackup -k option stands for --no-verify-checksums. That
is nearly the opposite of initdb -k, which is for enabling checksums. I
think it could be confusing to have two related tools use the same
option letter for nearly opposite purposes.
How about using capital -K in pg_basebacku
On Thu, May 17, 2018 at 10:42:00PM -0700, Andres Freund wrote:
> > We also have what seems like half an OS worth of tooling to support our
> > shared-nothing-by-default multi-processing model. Custom spinlocks, our
> > LWLocks, our latches, signal based IPC + ProcSignal signal multiplexing,
> > ext
While we're all griping about omissions from the release notes ...
I think you should have documented that we fixed plpgsql to cope
(or cope better, at least) with intrasession changes in the rowtypes
of composite-type variables. See bug #15203 for the latest in a long
line of user complaints abou
Heikki Linnakangas writes:
> On 18/05/18 14:32, Magnus Hagander wrote:
>> If pg_control is for some reason empty, we give an error messagfe like:
>> 2018-05-18 13:24:03.342 CEST [19697] PANIC: could not read from control
>> file: Success
>> Which is, uh, wrong -- it's definitely not successful.
>
On Fri, May 18, 2018 at 02:42:08PM +0800, Paul Guo wrote:
> 2018-05-17 21:18 GMT+08:00 Michael Paquier :
>> You should also add this patch to the next commit fest, development of
>> v11 is done and it is a stabilization period now, so no new patches are
>> merged. Here is where you can register th
On Fri, May 18, 2018 at 03:54:47PM +0300, Heikki Linnakangas wrote:
> Looks good to me.
+1 for fixing that. get_controlfile() in controldata_utils.c also needs
to be fixed.
--
Michael
signature.asc
Description: PGP signature
On Fri, May 18, 2018 at 10:56:25AM +0500, Andrey Borodin wrote:
> H, Bruce!
>
>
> 11 мая 2018 г., в 20:08, Bruce Momjian написал(а):
>
> I expect a torrent of feedback. ;-)
>
>
> I'm not sure it is usefull in release notes since it is more about API, and
> not
> user-facing change.
On Fri, May 18, 2018 at 12:03:49PM +0900, Michael Paquier wrote:
> On Fri, May 18, 2018 at 10:46:46AM +0900, Michael Paquier wrote:
> > From a security point of view, 1) is important for libpq, but I am not
> > much enthusiast about 2) as a whole. The backend has proper support for
> > channel bin
On Thu, May 17, 2018 at 11:45 PM, Robert Haas wrote:
> On Thu, May 17, 2018 at 12:44 PM, Andres Freund wrote:
>> Hi,
>>
>> On 2018-05-10 09:50:03 +0800, Craig Ringer wrote:
>>> while ((src = (RewriteMappingFile *) hash_seq_search(&seq_status)) !=
>>> NULL)
>>> {
>>> if
On 18/05/18 14:32, Magnus Hagander wrote:
If pg_control is for some reason empty, we give an error messagfe like:
2018-05-18 13:24:03.342 CEST [19697] PANIC: could not read from control
file: Success
Which is, uh, wrong -- it's definitely not successful.
Obviously this is a state where the us
On 5/18/18, Sandeep Thakkar wrote:
> Hi
>
> I was building the sources I got from https://www.postgresql.org/
> ftp/snapshot/dev/ on Windows x64 and got the whole bunch of errors
> like "*Cannot
> open include file: 'catalog/pg_type_d.h"* , *"Cannot open include file:
> 'catalog/pg_tablespace_d.h'
If pg_control is for some reason empty, we give an error messagfe like:
2018-05-18 13:24:03.342 CEST [19697] PANIC: could not read from control
file: Success
Which is, uh, wrong -- it's definitely not successful.
Obviously this is a state where the user is fairly screwed anyway, but we
should g
On 5/17/18, Thomas Munro wrote:
> Hi John,
>
> This failed for my patch testing robot on Windows, with this message[1]:
...
> I see that you changed src/backend/catalog/Makefile to pass the new -I
> switch to genbki.pl. I think for Windows you might need to add it to
> the line in src/tools/msvc/
On Tue, May 15, 2018 at 2:11 AM, Bruce Momjian wrote:
> On Mon, May 14, 2018 at 05:34:54PM +0530, Dilip Kumar wrote:
>>
>> On Fri, May 11, 2018 at 8:38 PM, Bruce Momjian wrote:
>>
>> I have committed the first draft of the Postgres 11 release notes. I
>> will add more markup soon. You c
Hi
I was building the sources I got from https://www.postgresql.org/
ftp/snapshot/dev/ on Windows x64 and got the whole bunch of errors
like "*Cannot
open include file: 'catalog/pg_type_d.h"* , *"Cannot open include file:
'catalog/pg_tablespace_d.h'" . *I've attached the log.
The renaming was don
At Fri, 18 May 2018 10:19:30 +0530, Ashutosh Bapat
wrote in
ashutosh.bapat> On Thu, May 17, 2018 at 11:56 PM, Robert Haas
wrote:
> > On Thu, May 17, 2018 at 2:10 AM, Ashutosh Bapat
> > wrote:
> >> The second would mean that SELECT * from foreign table reports
> >> remotetableoid as well, whi
On 2018/05/17 23:24, Robert Haas wrote:
> On Thu, May 17, 2018 at 12:04 AM, David Rowley wrote:
>> I'm not really a fan of overloading properties with a bunch of text.
>> Multiple int or text properties would be easier to deal with,
>> especially so when you consider the other explain formats. Reme
Fujita-san,
On 2018/05/17 21:51, Etsuro Fujita wrote:
> (2018/05/17 14:19), Amit Langote wrote:
>> Looking at this for a bit, I wondered if this crash wouldn't have occurred
>> if the "propagation" had also considered join relations in addition to
>> simple relations. For example, if I changed in
(2018/05/17 23:19), Ashutosh Bapat wrote:
On Thu, May 17, 2018 at 4:50 PM, Etsuro Fujita
wrote:
(2018/05/16 22:49), Ashutosh Bapat wrote:
On Wed, May 16, 2018 at 4:01 PM, Etsuro Fujita
wrote:
However, considering that
pull_var_clause is used in many places where partitioning is *not*
invo
61 matches
Mail list logo
