Re: Observations in Parallel Append

2017-12-23 Thread Robert Haas
On Fri, Dec 22, 2017 at 6:18 AM, Amit Kapila wrote: > There doesn't seem to be any need for including spin.h. I think some > prior version of the patch might need it. Patch attached to remove > it. OK, good catch. > The code and comment don't seem to match. The comments indicate that > after

Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions

2017-12-23 Thread Craig Ringer
On 23 December 2017 at 12:57, Tomas Vondra wrote: > Hi all, > > Attached is a patch series that implements two features to the logical > replication - ability to define a memory limit for the reorderbuffer > (responsible for building the decoded transactions), and ability to > stream large in-pro

Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions

2017-12-23 Thread Tomas Vondra
On 12/23/2017 11:23 PM, Erik Rijkers wrote: > On 2017-12-23 21:06, Tomas Vondra wrote: >> On 12/23/2017 03:03 PM, Erikjan Rijkers wrote: >>> On 2017-12-23 05:57, Tomas Vondra wrote: Hi all, Attached is a patch series that implements two features to the logical replication - ab

Re: [HACKERS] [COMMITTERS] pgsql: Fix freezing of a dead HOT-updated tuple

2017-12-23 Thread Michael Paquier
On Sat, Dec 23, 2017 at 05:26:22PM -0300, Alvaro Herrera wrote: > I noticed that I'm committer for this patch in the commitfest, though I > don't remember setting that. Are you expecting me to commit it? I > thought you'd do it, but if you want me to assume the responsibility I > can do that. I

Re: [HACKERS] [COMMITTERS] pgsql: Fix freezing of a dead HOT-updated tuple

2017-12-23 Thread Alvaro Herrera
Andres Freund wrote: > On December 23, 2017 9:26:22 PM GMT+01:00, Alvaro Herrera > wrote: > >I noticed that I'm committer for this patch in the commitfest, though I > >don't remember setting that. Are you expecting me to commit it? I > >thought you'd do it, but if you want me to assume the res

Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions

2017-12-23 Thread Erik Rijkers
On 2017-12-23 21:06, Tomas Vondra wrote: On 12/23/2017 03:03 PM, Erikjan Rijkers wrote: On 2017-12-23 05:57, Tomas Vondra wrote: Hi all, Attached is a patch series that implements two features to the logical replication - ability to define a memory limit for the reorderbuffer (responsible fo

parallel append vs. simple UNION ALL

2017-12-23 Thread Robert Haas
As I mentioned in the commit message for the Parallel Append commit (ab72716778128fb63d54ac256adf7fe6820a1185), it's kind of sad that this doesn't work with UNION ALL queries, which are an obvious candidate for such parallelization. It turns out that it actually does work to a limited degree: assu

Re: AS OF queries

2017-12-23 Thread konstantin knizhnik
On Dec 23, 2017, at 2:08 AM, Greg Stark wrote: > On 20 December 2017 at 12:45, Konstantin Knizhnik > wrote: > >> It seems to me that it will be not so difficult to implement them in >> Postgres - we already have versions of tuples. >> Looks like we only need to do three things: >> 1. Disable au

Re: [HACKERS] [COMMITTERS] pgsql: Fix freezing of a dead HOT-updated tuple

2017-12-23 Thread Andres Freund
On December 23, 2017 9:26:22 PM GMT+01:00, Alvaro Herrera wrote: >I noticed that I'm committer for this patch in the commitfest, though I >don't remember setting that. Are you expecting me to commit it? I >thought you'd do it, but if you want me to assume the responsibility I >can do that. I

Re: [HACKERS] [COMMITTERS] pgsql: Fix freezing of a dead HOT-updated tuple

2017-12-23 Thread Alvaro Herrera
I noticed that I'm committer for this patch in the commitfest, though I don't remember setting that. Are you expecting me to commit it? I thought you'd do it, but if you want me to assume the responsibility I can do that. -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL

Re: PoC: custom signal handler for extensions

2017-12-23 Thread Maksim Milyutin
23.12.17 12:58, legrand legrand wrote: +1 if this permits to use extension pg_query_state , that would be great ! Yes, attached patch is the single critical point. It allows to loose pg_query_state from the need to patch postgres core. -- R

Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions

2017-12-23 Thread Tomas Vondra
On 12/23/2017 03:03 PM, Erikjan Rijkers wrote: > On 2017-12-23 05:57, Tomas Vondra wrote: >> Hi all, >> >> Attached is a patch series that implements two features to the logical >> replication - ability to define a memory limit for the reorderbuffer >> (responsible for building the decoded transa

Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions

2017-12-23 Thread Erikjan Rijkers
On 2017-12-23 05:57, Tomas Vondra wrote: Hi all, Attached is a patch series that implements two features to the logical replication - ability to define a memory limit for the reorderbuffer (responsible for building the decoded transactions), and ability to stream large in-progress transactions (

Re: Add hint about replication slots when nearing wraparound

2017-12-23 Thread Michael Paquier
On Fri, Dec 22, 2017 at 07:55:19AM +0100, Feike Steenbergen wrote: > On 21 December 2017 at 05:32, Michael Paquier > wrote: > > > Don't you want to put that in its own block? That's rather > > important not to miss for administrators. > > I didn't want to add yet another block on that document

Re: Fix permissions check on pg_stat_get_wal_senders

2017-12-23 Thread Michael Paquier
On Fri, Dec 22, 2017 at 07:49:34AM +0100, Feike Steenbergen wrote: > On 21 December 2017 at 14:11, Michael Paquier > wrote: > > You mean a WAL receiver here, not a WAL sender. > > Fixed, thanks [nit] /* - * Only superusers can see details. Other users only get the

Re: PoC: custom signal handler for extensions

2017-12-23 Thread legrand legrand
+1 if this permits to use extension pg_query_state , that would be great ! -- Sent from: http://www.postgresql-archive.org/PostgreSQL-hackers-f1928748.html