Re: pg_createsubscriber clarification

2024-07-28 Thread Masahiko Sawada
al table data because it uses the tables with their initial data on the target server. It only does the synchronization phase, which ensures each table is brought up to a synchronized state by applying changes using standard logical replication. Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com

Re: Update maintenance_work_mem/autovacuum_work_mem to reflect the 1GB limitation with VACUUM

2021-06-02 Thread Masahiko Sawada
supported versions), at least until such limitation is > > lifted. > > Here is a patch for that, The patch adds the description in the autovacuum_work_mem section. Isn't it better to add it in mantenance_work section or VACUUM command section since this limitation is not onl

Re: How to reference the type of lock in the documentation.

2022-07-07 Thread Masahiko Sawada
ks view > don't appear in our documentation. The attached patches adds the > pg_locks names after each lock name. You can see the doc output here: > > https://momjian.us/tmp/pgsql/explicit-locking.html > > If people like this, I can apply it to all supported branches. +1 Regards, -- Masahiko Sawada EDB: https://www.enterprisedb.com/

Re: The sample FDW table: pglog not work in https://www.postgresql.org/docs/14/file-fdw.html

2022-08-04 Thread Masahiko Sawada
t; > There is a "bbb" and "ccc" to by pass the error. You said you added 2 extra columns to the example in PG14 doc but both pglog table definitions you mentioned above have the same number of columns, 26. The first table definition worked with PG14 in my environment. Could you try using the first example again and share the error message if an error occurs? Regards, -- Masahiko Sawada EDB: https://www.enterprisedb.com/

Re: 52.88. pg_shmem_allocations, missing units

2022-08-14 Thread Masahiko Sawada
* # bytes requested for the structure */ > Sizeallocated_size; /* # bytes actually allocated */ > } ShmemIndexEnt; > > The unit is bytes. A patch is attached to add such information. +1 The patch looks good to me. Regards, -- Masahiko Sawada EDB: https://www.enterprisedb.com/

Re: pg_copy_logical_replication_slot doesn't copy the failover property

2025-02-20 Thread Masahiko Sawada
h the slot synchronization." > > > > Hi Nisha, > > I have addressed the comments and attached the updated v2 patch. IIUC the two_phase field is also not copied from the source slot. I think we can clarify in the doc that these two fields are not copied. Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com

Re: Fix incorrect UUID index entry in function documentation

2025-06-20 Thread Masahiko Sawada
> > > I suspect that "datatype-uuid" is a copy-paste error and should be > "functions-uuid" to reflect the correct section. The attached patch > updates this accordingly. > > Thoughts? +1. I think it also makes sense that &