On Mon, Aug 15, 2022 at 3:56 AM Euler Taveira <eu...@eulerto.com> wrote: > > On Fri, Aug 12, 2022, at 5:43 PM, PG Doc comments form wrote: > > Could someone add the units of size & allocated_size on the documentation > for pg_shmem_allocations? Currently there aren't any listed. > > According to ShmemIndexEnt struct: > > /* this is a hash bucket in the shmem index table */ > typedef struct > { > char key[SHMEM_INDEX_KEYSIZE]; /* string name */ > void *location; /* location in shared mem */ > Size size; /* # bytes requested for the structure */ > Size allocated_size; /* # bytes actually allocated */ > } ShmemIndexEnt; > > The unit is bytes. A patch is attached to add such information.
+1 The patch looks good to me. Regards, -- Masahiko Sawada EDB: https://www.enterprisedb.com/