On 07.06.23 17:34, Jonathan S. Katz wrote:
On 6/7/23 11:17 AM, Peter Eisentraut wrote:
The proposed text in the patch is
"This parameter is supported only on systems that {have this property}
(which does not include Windows)."
I don't see how the change you are proposing is correct.
I see
On 6/7/23 11:17 AM, Peter Eisentraut wrote:
The proposed text in the patch is
"This parameter is supported only on systems that {have this property}
(which does not include Windows)."
I don't see how the change you are proposing is correct.
I see -- I had read it quickly and didn't sound i
On 05.06.23 19:10, Jonathan S. Katz wrote:
On 5/31/23 7:53 AM, Daniel Gustafsson wrote:
On 31 May 2023, at 13:16, Peter Eisentraut
wrote:
The first two hunks are pretty straightforward, they just move the
existing text around.
For the other two, which are not supported on Windows, I added
> On 5 Jun 2023, at 19:10, Jonathan S. Katz wrote:
> "It is only supported on systems where TCP_USER_TIMEOUT is available; on
> other systems, it has no effect."
>
> If this is really only unsupported / has different settings on Windows, I
> think it's OK to call that out. The original gripe w
On 5/31/23 7:53 AM, Daniel Gustafsson wrote:
On 31 May 2023, at 13:16, Peter Eisentraut
wrote:
The first two hunks are pretty straightforward, they just move the existing
text around.
For the other two, which are not supported on Windows, I added an explicit
parenthetical note. We don't
> On 31 May 2023, at 13:16, Peter Eisentraut
> wrote:
> The first two hunks are pretty straightforward, they just move the existing
> text around.
>
> For the other two, which are not supported on Windows, I added an explicit
> parenthetical note. We don't list which of the Unix-like platfor
ed, 31 May 2023 07:12:38 -0400
Subject: [PATCH] doc: Fix confusing positioning of notes in connection
settings
Discussion:
https://www.postgresql.org/message-id/flat/6f825d42-a1ce-492a-2ea7-c83e6e65fa8b%40postgresql.org
---
doc/src/sgml/config.sgml | 30 ++
1 file
> On 26 Apr 2023, at 10:18, Daniel Gustafsson wrote:
>
>> On 26 Apr 2023, at 08:08, Peter Eisentraut
>> wrote:
>
>> I wonder if the notes are even true. The text for tcp_keepalives_interval
>> already says that it is only supported if TCP_KEEPCNT is supported.
Re-reading this I think there
> On 26 Apr 2023, at 08:08, Peter Eisentraut
> wrote:
> I wonder if the notes are even true. The text for tcp_keepalives_interval
> already says that it is only supported if TCP_KEEPCNT is supported.
Don't forget the "and on Windows;" part.
> There is no specific code for Windows.
We have
On 22.04.23 21:53, Jonathan S. Katz wrote:
While testing a few other things on the connection settings page[1], I
noticed the notes on the "tcp_*" family of settings. While scrolling
further down the page, I found myself slightly confused over which note
corresponded to which setting (example i
10 matches
Mail list logo
