On 05.06.23 19:10, Jonathan S. Katz wrote:
On 5/31/23 7:53 AM, Daniel Gustafsson wrote:
On 31 May 2023, at 13:16, Peter Eisentraut
<peter.eisentr...@enterprisedb.com> wrote:
The first two hunks are pretty straightforward, they just move the
existing text around.
For the other two, which are not supported on Windows, I added an
explicit parenthetical note. We don't list which of the Unix-like
platforms support the respective options, but I suspect that it's all
of them in practice? (Otherwise we should be more explicit.) So I
think calling out Windows explicitly is sensible, also considering
that the first two settings are supported on Windows but the latter
two are not.
I think this is a clear improvement over the current docs.
+1.
Small nit:
"which does not include Windows" =>
"which is not supported on Windows"
(in two places)
The proposed text in the patch is
"This parameter is supported only on systems that {have this property}
(which does not include Windows)."
I don't see how the change you are proposing is correct.
