On 10.11.25 04:15, jian he wrote:
On Thu, Nov 6, 2025 at 11:06 AM David Rowley wrote:
I reviewed this and double checked you left "uPDaTE" in [1]. Found no
issues, so pushed.
hi.
in doc/src/sgml/func/func-matching.sgml
substring(string similar
pattern escape
escape-character)
or us
On Mon, 10 Nov 2025 at 16:40, Erik Wienhold wrote:
> > in doc/src/sgml/func/func-matching.sgml
> > key word: "similar", "escape", "from", "for" within the above synopsis
> > section need uppercase too?
>
> Thanks, good catch. Not surprised that I've missed those because it
> already took me a co
On 2025-11-10 04:15 +0100, jian he wrote:
> On Thu, Nov 6, 2025 at 11:06 AM David Rowley wrote:
> >
> > I reviewed this and double checked you left "uPDaTE" in [1]. Found no
> > issues, so pushed.
> >
>
> in doc/src/sgml/func/func-matching.sgml
>
>
> substring(string similar
> pattern escape
>
On Thu, Nov 6, 2025 at 11:06 AM David Rowley wrote:
>
> I reviewed this and double checked you left "uPDaTE" in [1]. Found no
> issues, so pushed.
>
hi.
in doc/src/sgml/func/func-matching.sgml
substring(string similar
pattern escape
escape-character)
or using the now obsolete SQL:1999 syn
On 2025-11-06 04:06 +0100, David Rowley wrote:
> On Thu, 6 Nov 2025 at 07:09, Erik Wienhold wrote:
> >
> > On 2025-11-04 03:09 +0100, David Rowley wrote:
> > > I think just the keyword upper casing is a good idea for now. I'm
> > > starting to lose hope that there's enough merit and consistency to
On Thu, 6 Nov 2025 at 07:09, Erik Wienhold wrote:
>
> On 2025-11-04 03:09 +0100, David Rowley wrote:
> > I think just the keyword upper casing is a good idea for now. I'm
> > starting to lose hope that there's enough merit and consistency to the
> > proposed whitespace changes. Maybe there's a sub
On 2025-11-04 03:09 +0100, David Rowley wrote:
> On Tue, 4 Nov 2025 at 13:04, Erik Wienhold wrote:
> >
> > On 2025-11-03 23:37 +0100, David Rowley wrote:
> > > I'm starting to wonder if adjusting the spacing here is a worthwhile
> > > change.
> >
> > I think it's worth to have that consistency. I
On Tue, 4 Nov 2025 at 13:04, Erik Wienhold wrote:
>
> On 2025-11-03 23:37 +0100, David Rowley wrote:
> > I'm starting to wonder if adjusting the spacing here is a worthwhile
> > change.
>
> I think it's worth to have that consistency. If the patch is too broad
> I can of course limit it to the li
On 2025-11-03 23:37 +0100, David Rowley wrote:
> On Tue, 4 Nov 2025 at 09:06, Erik Wienhold wrote:
> > Fixed in the attached v4. Except for one match in dblink.sgml that
> > is the sample output of dblink_build_sql_insert which actually omits
> > the space after the table name and VALUES keyword.
On Tue, 4 Nov 2025 at 09:06, Erik Wienhold wrote:
> Fixed in the attached v4. Except for one match in dblink.sgml that is
> the sample output of dblink_build_sql_insert which actually omits the
> space after the table name and VALUES keyword.
I went through all these and I think it's mostly good
On 2025-10-31 04:03 +0100, David Rowley wrote:
> On Fri, 31 Oct 2025 at 13:53, Erik Wienhold wrote:
> > But I also agree with Tom that keeping a consistent style is impossible
> > in the long run. But it also shows that the docs are still written by
> > humans. As long as we can keep a consisten
On Fri, 31 Oct 2025 at 13:53, Erik Wienhold wrote:
> But I also agree with Tom that keeping a consistent style is impossible
> in the long run. But it also shows that the docs are still written by
> humans. As long as we can keep a consistent style within a single
> listing (or even an entire pa
On 2025-10-29 22:24 +0100, David Rowley wrote:
> On Thu, 30 Oct 2025 at 09:48, Tom Lane wrote:
> >
> > Bruce Momjian writes:
> > > On Tue, Oct 28, 2025 at 04:34:45PM -0500, Nathan Bossart wrote:
> > >> I noticed the patch also changes some column types to lowercase:
> > >> ...
> > >> -categor
On Wed, Oct 29, 2025 at 05:25:43PM -0400, Bruce Momjian wrote:
> On Thu, Oct 30, 2025 at 10:24:30AM +1300, David Rowley wrote:
>> How about if Eric just drops the portion of the patch that alters the
>> casing of the types and leaves all the keyword uppercasing stuff in.
>> Any objections to that p
On Thu, Oct 30, 2025 at 10:24:30AM +1300, David Rowley wrote:
> On Thu, 30 Oct 2025 at 09:48, Tom Lane wrote:
> >
> > Bruce Momjian writes:
> > > On Tue, Oct 28, 2025 at 04:34:45PM -0500, Nathan Bossart wrote:
> > >> I noticed the patch also changes some column types to lowercase:
> > >> ...
> >
On Thu, 30 Oct 2025 at 09:48, Tom Lane wrote:
>
> Bruce Momjian writes:
> > On Tue, Oct 28, 2025 at 04:34:45PM -0500, Nathan Bossart wrote:
> >> I noticed the patch also changes some column types to lowercase:
> >> ...
> >> -category_N TEXT
> >> +category_N text
> >>
> >> FWIW I tend to u
Bruce Momjian writes:
> On Tue, Oct 28, 2025 at 04:34:45PM -0500, Nathan Bossart wrote:
>> I noticed the patch also changes some column types to lowercase:
>> ...
>> -category_N TEXT
>> +category_N text
>>
>> FWIW I tend to use uppercase for those, too, but I'm not sure there is a
>> pref
On Tue, Oct 28, 2025 at 04:34:45PM -0500, Nathan Bossart wrote:
> I noticed the patch also changes some column types to lowercase:
>
>
> CREATE TYPE tablefunc_crosstab_N AS (
> -row_name TEXT,
> -category_1 TEXT,
> -category_2 TEXT,
> +row_name text,
> +category_1 text,
> +
I noticed the patch also changes some column types to lowercase:
CREATE TYPE tablefunc_crosstab_N AS (
-row_name TEXT,
-category_1 TEXT,
-category_2 TEXT,
+row_name text,
+category_1 text,
+category_2 text,
.
.
.
-category_N TEXT
+categ
On Fri, Oct 24, 2025 at 10:40:18AM -0300, Euler Taveira wrote:
> On Thu, Oct 23, 2025, at 7:50 PM, David Rowley wrote:
>> I'm not so sure about the "Should be pushed to all stable branches"
>> part as it seems more of a general improvement than fixing a mistake.
>> I imagine there will be varying o
On Thu, Oct 23, 2025, at 7:50 PM, David Rowley wrote:
> I'm not so sure about the "Should be pushed to all stable branches"
> part as it seems more of a general improvement than fixing a mistake.
> I imagine there will be varying opinions on that, however.
>
I also classify this as an improvement.
On Fri, 24 Oct 2025 at 09:39, Erik Wienhold wrote:
> This of course produces a lot of noise, but I managed to find and fix a
> couple more places with the attached v2 (including the ones you've
> listed) that I've missed previously. I've searched for "primary key"
> across the docs previously but
On 2025-10-21 04:37 +0300, Euler Taveira wrote:
> On Thu, Oct 16, 2025, at 5:37 AM, Erik Wienhold wrote:
> > While browsing the docs I saw that the foreign key tutorial [1] uses
> > some lowercase keywords which are inconsistent with the rest of the
> > docs. The attached patch fixes that. Should
On Thu, Oct 16, 2025, at 5:37 AM, Erik Wienhold wrote:
> While browsing the docs I saw that the foreign key tutorial [1] uses
> some lowercase keywords which are inconsistent with the rest of the
> docs. The attached patch fixes that. Should be pushed to all stable
> branches.
>
Register your pa
>From c4fe1831fedc07ebb123c6cdc79eb97b32a1847c Mon Sep 17 00:00:00 2001
From: Erik Wienhold
Date: Thu, 16 Oct 2025 10:30:21 +0200
Subject: [PATCH] doc: Use uppercase keywords in foreign key tutorial
Make it consistent with the rest of the docs.
---
doc/src/sgml/advanced.sgml | 4 ++--
1 f
25 matches
Mail list logo
