On 2025-11-10 04:15 +0100, jian he wrote:
> On Thu, Nov 6, 2025 at 11:06 AM David Rowley <[email protected]> wrote:
> >
> > I reviewed this and double checked you left "uPDaTE" in [1]. Found no
> > issues, so pushed.
> >
>
> in doc/src/sgml/func/func-matching.sgml
>
> <synopsis>
> substring(<replaceable>string</replaceable> similar
> <replaceable>pattern</replaceable> escape
> <replaceable>escape-character</replaceable>)
> </synopsis>
> or using the now obsolete SQL:1999 syntax:
> <synopsis>
> substring(<replaceable>string</replaceable> from
> <replaceable>pattern</replaceable> for
> <replaceable>escape-character</replaceable>)
> </synopsis>
> or as a plain three-argument function:
> <synopsis>
> substring(<replaceable>string</replaceable>,
> <replaceable>pattern</replaceable>,
> <replaceable>escape-character</replaceable>)
> </synopsis>
>
> key word: "similar", "escape", "from", "for" within the above synopsis
> section need uppercase too?
Thanks, good catch. Not surprised that I've missed those because it
already took me a couple of rounds to find everything that's in the
previous patch. Here's another patch.
--
Erik Wienhold
diff --git a/doc/src/sgml/func/func-matching.sgml
b/doc/src/sgml/func/func-matching.sgml
index 91a0b7ca0de..f466860ddb0 100644
--- a/doc/src/sgml/func/func-matching.sgml
+++ b/doc/src/sgml/func/func-matching.sgml
@@ -369,11 +369,11 @@
regular expression pattern. The function can be written according
to standard SQL syntax:
<synopsis>
-substring(<replaceable>string</replaceable> similar
<replaceable>pattern</replaceable> escape
<replaceable>escape-character</replaceable>)
+substring(<replaceable>string</replaceable> SIMILAR
<replaceable>pattern</replaceable> ESCAPE
<replaceable>escape-character</replaceable>)
</synopsis>
or using the now obsolete SQL:1999 syntax:
<synopsis>
-substring(<replaceable>string</replaceable> from
<replaceable>pattern</replaceable> for
<replaceable>escape-character</replaceable>)
+substring(<replaceable>string</replaceable> FROM
<replaceable>pattern</replaceable> FOR
<replaceable>escape-character</replaceable>)
</synopsis>
or as a plain three-argument function:
<synopsis>
