Re: Typo on tutorial window page

2025-01-22 Thread Олег Семенов
sorry, my bad, thanks for the clarification! вт, 21 січ. 2025 р., 18:40 користувач David G. Johnston < david.g.johns...@gmail.com> пише: > On Tue, Jan 21, 2025 at 10:39 AM Tom Lane wrote: > >> PG Doc comments form writes: >> > EXPECTED: >> > As shown here, the rank function produces a numerical

Re: Typo on tutorial window page

2025-01-21 Thread Tom Lane
"David G. Johnston" writes: > I was going to write basically that but something feels off to me. Maybe > something like this: > "As shown here, the rank function produces a numerical ranking within each > partition, using the order defined by the ORDER BY clause. Ranking assigns > the same rank

Re: Typo on tutorial window page

2025-01-21 Thread David G. Johnston
On Tue, Jan 21, 2025 at 10:39 AM Tom Lane wrote: > PG Doc comments form writes: > > EXPECTED: > > As shown here, the rank function produces a numerical rank for each > distinct > > PARTITION BY value in the current row's partition, using the order > defined > > by the ORDER BY clause. rank needs

Re: Typo on tutorial window page

2025-01-21 Thread David G. Johnston
On Tue, Jan 21, 2025 at 10:39 AM Tom Lane wrote: > PG Doc comments form writes: > > EXPECTED: > > As shown here, the rank function produces a numerical rank for each > distinct > > PARTITION BY value in the current row's partition, using the order > defined > > by the ORDER BY clause. rank needs

Re: Typo on tutorial window page

2025-01-21 Thread Tom Lane
PG Doc comments form writes: > EXPECTED: > As shown here, the rank function produces a numerical rank for each distinct > PARTITION BY value in the current row's partition, using the order defined > by the ORDER BY clause. rank needs no explicit parameter, because its > behavior is entirely determ

Re: Typo in doc page?

2025-01-07 Thread Daniel Gustafsson
> On 26 Dec 2024, at 16:43, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/17/sql-keywords-appendix.html > Description: > > I could be mistaken but, in the following documentation page: > https://www.

Re: Typo on 2.3. PostgreSQL

2024-08-21 Thread Tom Lane
PG Doc comments form writes: > In https://www.postgresql.org/docs/16/history.html#HISTORY-POSTGRESQL, > Chapter 2.3. PostgreSQL is written in first sentence: "By 1996, it became > clear that the name “Postgres95” would not stand the test of time." > I think there should be "the rest of time" inste

Re: Typo in 15.3.4

2024-07-29 Thread David G. Johnston
On Mon, Jul 29, 2024 at 7:00 AM Daniel Gustafsson wrote: > On 25 Jul 2024, at 19:07, David G. Johnston > wrote: > > On Thu, Jul 25, 2024 at 9:50 AM PG Doc comments form < > nore...@postgresql.org> wrote: > >> The following documentation comment has been logged on the website: >> >> Page: https:/

Re: Typo in 15.3.4

2024-07-29 Thread Daniel Gustafsson
On 25 Jul 2024, at 19:07, David G. Johnston wrote:On Thu, Jul 25, 2024 at 9:50 AM PG Doc comments form wrote:The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/16/parallel-plans.html Description: In section 15.3.4, I

Re: Typo in 15.3.4

2024-07-25 Thread David G. Johnston
On Thu, Jul 25, 2024 at 9:50 AM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/16/parallel-plans.html > Description: > > In section 15.3.4, I believe "multiple results sets" is a typo for > "multiple > re

Re: Typo in '8.5. Date/Time Types' v16

2023-11-30 Thread Tom Lane
PG Doc comments form writes: > In the interval example outputs, for postgres and postgres_verbose. > It says mons instead of months. That is in fact the datatype's output format. regression=# show intervalstyle; IntervalStyle --- postgres (1 row) regression=# select '2 month'::in

Re: Typo in documentation - runtime-config-wal

2023-11-09 Thread Bruce Momjian
On Fri, Feb 15, 2019 at 07:51:31PM +, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/10/runtime-config-wal.html > Description: > > This page: https://www.postgresql.org/docs/10/runtime-config-wal.html

Re: Typo in "43.9.1. Reporting Errors and Messages"?

2023-11-01 Thread Michael Paquier
On Wed, Nov 01, 2023 at 09:18:47AM +0900, Michael Paquier wrote: > So you mean something like the attached then? Fixed that with f8b96c211da0 down to 11, in time for next week's release set. -- Michael signature.asc Description: PGP signature

Re: Typo in "43.9.1. Reporting Errors and Messages"?

2023-10-31 Thread Michael Paquier
On Tue, Oct 31, 2023 at 09:00:00PM +0300, Alexander Lakhin wrote: > I don't remember details, but I think the primary reason for the change > was that "RAISE_EXCEPTION" occurred in the whole tree only once (before > 66bde49d96). Now I see, that I had chosen the wrong replacement — I agree > with Eu

Re: Typo in "43.9.1. Reporting Errors and Messages"?

2023-10-31 Thread Alexander Lakhin
Hi Bruce, 31.10.2023 17:52, Bruce Momjian wrote: It is referring to the internal constant (see src/backend/utils/errcodes.h). It was like you are proposing and it was changed in 66bde49d96a9ddacc49dcbdf1b47b5bd6e31ead5. Reading the original thread, there is no explanation why it was changed. R

Re: Typo in "43.9.1. Reporting Errors and Messages"?

2023-10-31 Thread Bruce Momjian
On Tue, Aug 2, 2022 at 09:49:47AM -0300, Euler Taveira wrote: > On Sun, Jul 31, 2022, at 8:37 PM, PG Doc comments form wrote: > > Towards the end of the "43.9.1. Reporting Errors and Messages" section > (here > https://www.postgresql.org/docs/current/plpgsql-errors-and-messages.html#

Re: Typo in docs for "recovery_init_sync_method" parameter.

2023-10-27 Thread Bruce Momjian
On Tue, Aug 23, 2022 at 02:38:13PM +, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/14/runtime-config-error-handling.html > Description: > > The second paragraph contains the sentence: > > > ...

Re: Typo in PL/pgSQL trigger Example 43.4?

2023-10-09 Thread Tom Lane
Daniel Gustafsson writes: >> On 7 Oct 2023, at 22:22, Tom Lane wrote: >> Yeah, either way has the same result. However, I wonder if we should >> change this example to use current_user for clarity. It does look >> more like it's intended to be a variable or column reference than >> a built-in f

Re: Typo in PL/pgSQL trigger Example 43.4?

2023-10-09 Thread Daniel Gustafsson
> On 7 Oct 2023, at 22:22, Tom Lane wrote: > > "David G. Johnston" writes: >> On Sat, Oct 7, 2023 at 11:11 AM Kirk Parker wrote: >>> INSERT INTO emp_audit SELECT 'D', now(), user, OLD.*; -- <= ARGUMENT IN >>> QUESTION >>> The emp_audit table has a column named 'userid', which in actual usage >

Re: Typo in PL/pgSQL trigger Example 43.4?

2023-10-08 Thread Kirk Parker
On Sat, Oct 7, 2023 at 1:22 PM Tom Lane wrote: > "David G. Johnston" writes: > > On Sat, Oct 7, 2023 at 11:11 AM Kirk Parker wrote: > >> INSERT INTO emp_audit SELECT 'D', now(), user, OLD.*; -- <= ARGUMENT IN > QUESTION > >> The emp_audit table has a column named 'userid', which in actual usage

Re: Typo in PL/pgSQL trigger Example 43.4?

2023-10-07 Thread Tom Lane
"David G. Johnston" writes: > On Sat, Oct 7, 2023 at 11:11 AM Kirk Parker wrote: >> INSERT INTO emp_audit SELECT 'D', now(), user, OLD.*; -- <= ARGUMENT IN >> QUESTION >> The emp_audit table has a column named 'userid', which in actual usage >> (next-to-last line quoted) is populated by 'user' w

Re: Typo in PL/pgSQL trigger Example 43.4?

2023-10-07 Thread David G. Johnston
On Sat, Oct 7, 2023 at 11:11 AM Kirk Parker wrote: > > INSERT INTO emp_audit SELECT 'D', now(), user, OLD.*; -- <= > ARGUMENT IN QUESTION > The emp_audit table has a column named 'userid', which in actual usage > (next-to-last line quoted) is populated by 'user' which seems undefined

Re: Typo/wording on https://www.postgresql.org/docs/current/catalog-pg-class.html

2023-09-22 Thread Tom Lane
Daniel Gustafsson writes: >> On 22 Sep 2023, at 19:04, Tom Lane wrote: >> I propose the attached. (I also modified the para's last sentence to >> speak of "kind" not "type", for consistency with the relkind field name >> and the rest of the para.) > LGTM. Pushed, thanks for looking.

Re: Typo/wording on https://www.postgresql.org/docs/current/catalog-pg-class.html

2023-09-22 Thread Daniel Gustafsson
> On 22 Sep 2023, at 19:04, Tom Lane wrote: > > I wrote: >> "Most" here is good English, although I concede it's a slightly >> old-fashioned usage. Maybe it'd be clearer to just remove the >> word altogether. > >> If we were going to touch this sentence I'd worry about some other >> things too.

Re: Typo/wording on https://www.postgresql.org/docs/current/catalog-pg-class.html

2023-09-22 Thread Tom Lane
I wrote: > "Most" here is good English, although I concede it's a slightly > old-fashioned usage. Maybe it'd be clearer to just remove the > word altogether. > If we were going to touch this sentence I'd worry about some other > things too. Use of "catalogs" as a verb is probably not the greates

Re: Typo/wording on https://www.postgresql.org/docs/current/catalog-pg-class.html

2023-09-20 Thread Tom Lane
Daniel Gustafsson writes: >> On 20 Sep 2023, at 07:23, PG Doc comments form >> wrote: >> I've just read this: >> "catalogs tables and most everything else that has columns or is otherwise >> similar to a table" >> It seems that it should be: >> "catalogs tables and almost everything else that ha

Re: Typo/wording on https://www.postgresql.org/docs/current/catalog-pg-class.html

2023-09-20 Thread Daniel Gustafsson
> On 20 Sep 2023, at 07:23, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/16/catalog-pg-class.html > Description: > > I've just read this: > > "catalogs tables and most everything else that has colu

Re: Typo

2023-05-23 Thread David G. Johnston
On Tuesday, May 23, 2023, Tom Lane wrote: > Laurenz Albe writes: > > On Wed, 2023-05-24 at 07:32 +0900, Michael Paquier wrote: > >> This is the current sentence, and it sounds kind of OK to me, FWIW: > >> "Postgres95 code was completely ANSI C and trimmed in size by 25%. > > > That uses "ANSI C"

Re: Typo

2023-05-23 Thread Tom Lane
Laurenz Albe writes: > On Wed, 2023-05-24 at 07:32 +0900, Michael Paquier wrote: >> This is the current sentence, and it sounds kind of OK to me, FWIW: >> "Postgres95 code was completely ANSI C and trimmed in size by 25%. > That uses "ANSI C" as an adjective, which I think is sloppy wording > (ev

Re: Typo

2023-05-23 Thread Laurenz Albe
On Wed, 2023-05-24 at 07:32 +0900, Michael Paquier wrote: > On Tue, May 23, 2023 at 08:52:25PM +, PG Doc comments form wrote: > > There appears to be a typo, here: > > https://www.postgresql.org/docs/current/history.html#:~:text=Postgres95%20code%20was%20completely%20ANSI%20C. > > A word or two

Re: Typo

2023-05-23 Thread David G. Johnston
On Tue, May 23, 2023 at 3:32 PM Michael Paquier wrote: > On Tue, May 23, 2023 at 08:52:25PM +, PG Doc comments form wrote: > > There appears to be a typo, here: > > > https://www.postgresql.org/docs/current/history.html#:~:text=Postgres95%20code%20was%20completely%20ANSI%20C > . > > A word or

Re: Typo

2023-05-23 Thread Michael Paquier
On Tue, May 23, 2023 at 08:52:25PM +, PG Doc comments form wrote: > There appears to be a typo, here: > https://www.postgresql.org/docs/current/history.html#:~:text=Postgres95%20code%20was%20completely%20ANSI%20C. > A word or two should be added between 'completely' and 'ANSI C', such as > 're-

Re: Typo in 2.7 Aggregate Functions

2023-01-16 Thread Tom Lane
PG Doc comments form writes: > Near the end of Chapter 2.7 Aggregate Functions of the documentation, the > command FILTER is introduced. The full query is > SELECT city, max(temp_lo), count(*) FILTER (WHERE temp_lo < 30) > FROM weather > GROUP BY city > HAVING max(temp_lo) < 40; > an

Re: Typo in description of PROGRAM parameter for the COPY command

2022-08-21 Thread Tom Lane
Daniel Gustafsson writes: > Skimming the page I noticed that we wrap CSV in in all but a few > places, which seemed randomly "chosen". Another sentence which stood out to > me > was this one on FREEZE: > "This violates the normal rules of MVCC visibility and users specifying > shou

Re: Typo in description of PROGRAM parameter for the COPY command

2022-08-21 Thread Daniel Gustafsson
> On 21 Aug 2022, at 20:48, Tom Lane wrote: > > Daniel Gustafsson writes: >> On 21 Aug 2022, at 03:31, PG Doc comments form >> wrote: >>> ...so if you need to pass any arguments to shell command that come >>> from an untrusted source... >>> >>> The "to shell command that come" part should be

Re: Typo in description of PROGRAM parameter for the COPY command

2022-08-21 Thread Tom Lane
Daniel Gustafsson writes: > On 21 Aug 2022, at 03:31, PG Doc comments form wrote: >> ...so if you need to pass any arguments to shell command that come >> from an untrusted source... >> >> The "to shell command that come" part should be changed so it either reads >> like this: >> >> ...so if yo

Re: Typo in description of PROGRAM parameter for the COPY command

2022-08-21 Thread Daniel Gustafsson
> On 21 Aug 2022, at 03:31, PG Doc comments form wrote: >> ...so if you need to pass any arguments to shell command that come > from an untrusted source... > > The "to shell command that come" part should be changed so it either reads > like this: > >> ...so if you need to pass any arguments to

Re: Typo in "43.9.1. Reporting Errors and Messages"?

2022-08-02 Thread Euler Taveira
On Sun, Jul 31, 2022, at 8:37 PM, PG Doc comments form wrote: > Towards the end of the "43.9.1. Reporting Errors and Messages" section (here > https://www.postgresql.org/docs/current/plpgsql-errors-and-messages.html#PLPGSQL-STATEMENTS-RAISE) > we have the following sentence: > > > If no condition

Re: Typo in examples in "8.14.5. jsonb Subscripting"

2022-07-10 Thread Michael Paquier
On Thu, Jul 07, 2022 at 12:27:01AM +, PG Doc comments form wrote: > Towards the end of the section, the code examples given have comments where > the JSON is using single quotes instead of double quotes around the > properties. For example this: > > -- Where jsonb_field was {}, it is now {

Re: Typo in "27.2.8. Synchronous Replication"

2022-01-24 Thread Eric Mutta
> While I appreciate we could be even more cool if we used a more modern set of features, the effort it would take to do so doesn't seem to match the benefit we would get. Our documentation is, on the whole, a strength. Many thanks David, for the clarification on how the documentation release pro

Re: Typo in "27.2.8. Synchronous Replication"

2022-01-18 Thread David G. Johnston
On Tue, Jan 18, 2022 at 4:01 PM Eric Mutta wrote: > > 2. I noticed the typo and on the top right of the page there's an "edit" > link. Click that and it takes you to GitHub where the Markdown text is. > I suspect a large part of your expectation is based upon this and that GitHub can display pro

Re: Typo in "27.2.8. Synchronous Replication"

2022-01-18 Thread Eric Mutta
Hi Magnus, You are correct that doing a Pull Request would involve more overhead in terms of checking out code, doing builds, etc, however GitHub automates much of that and it all runs in the cloud so you can do it in a browser on your phone while on the train if you wanted to. It literally takes

Re: Typo in "27.2.8. Synchronous Replication"

2022-01-16 Thread Magnus Hagander
On Mon, Jan 3, 2022 at 1:40 PM Eric Mutta wrote: > > Hi Magnus, happy new year! Thanks for pushing the fix. > > Coming from an SQL Server background where the docs are hosted on GitHub and > minor changes like this can be made by simply submitting a pull request, I am > wondering is there anythi

Re: Typo in "27.2.8. Synchronous Replication"

2022-01-04 Thread Bruce Momjian
On Mon, Jan 3, 2022 at 03:40:40PM +0300, Eric Mutta wrote: > Hi Magnus, happy new year! Thanks for pushing the fix. > > Coming from an SQL Server background where the docs are hosted on GitHub and > minor changes like this can be made by simply submitting a pull request, I am > wondering is there

Re: Typo in "27.2.8. Synchronous Replication"

2022-01-03 Thread Eric Mutta
Hi Magnus, happy new year! Thanks for pushing the fix. Coming from an SQL Server background where the docs are hosted on GitHub and minor changes like this can be made by simply submitting a pull request, I am wondering is there anything similar for the Postgres docs? Going through a mailing list

Re: Typo in "27.2.8. Synchronous Replication"

2022-01-02 Thread Magnus Hagander
On Mon, Dec 27, 2021 at 12:07 AM PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/14/warm-standby.html > Description: > > The following sentence: > > > The minimum wait time is the round-trip time **betwee

Re: Typo in release notes for pg14

2021-09-23 Thread Erwin Brandstetter
On Thu, 23 Sep 2021, 16:45 Tom Lane, wrote: > > No, "memoize" is the intended spelling. > > regards, tom lane Oh, my bad. Cool new term. Thanks.

Re: Typo in release notes for pg14

2021-09-23 Thread Tom Lane
Erwin Brandstetter writes: > https://www.postgresql.org/docs/14/release-14.html#id-1.11.6.5.5.3.7 >> Add executor method to memoize results from the inner side of a > nested-loop join (David Rowley) > -> > Add executor method to memorize results from the inner side of a > nested-loop join (David

Re: Typo in release notes for pg14

2021-09-23 Thread Daniel Gustafsson
> On 23 Sep 2021, at 16:26, Erwin Brandstetter wrote: > > https://www.postgresql.org/docs/14/release-14.html#id-1.11.6.5.5.3.7 > > > Add executor method to memoize results from the inner side of a nested-loop > > join (David Rowley) > > -> > Add executor method to memorize results from the inn

Re: Typo in "13.2.3. Serializable Isolation Level"

2021-06-07 Thread Eric Mutta
> That sentence is a suggestion of an action for the reader to take, conditionally upon verifying that such things are no longer necessary. I see, that makes sense now, I was parsing the sentence differently. Perhaps for clarity those explicit locks could be mentioned in brackets so the sentence r

Re: Typo in "13.2.3. Serializable Isolation Level"

2021-06-04 Thread Tom Lane
PG Doc comments form writes: > The following sentence: >> Eliminate explicit locks, SELECT FOR UPDATE, and SELECT FOR SHARE where no > longer needed due... > Uses the word "where" when it should probably use the word "are" and thus > read: > Eliminate explicit locks, SELECT FOR UPDATE, and SELE

RE: typo in doc for "Miscellaneous Coding Conventions"

2021-05-18 Thread tanghy.f...@fujitsu.com
>"were not" is typical usage when stating a contrary-to-fact hypothetical. > If the implementation (or you) didn’t do X, then Y bad thing could happen. Really thanks for your kindly reply and explain. Please forgive me for my poor English. Anyway, got it. Regards, Tang

Re: typo in doc for "Miscellaneous Coding Conventions"

2021-05-18 Thread Bryn Llewellyn
t...@sss.pgh.pa.us wrote: > PG Doc comments form writes: > >> small fix in description at [1] as follows > >> -If that were not done interrupted code that's currently inspecting errno >> might see the wrong value. >> +If that was not done interrupted code that's currently inspecting errno >> mi

Re: typo in doc for "Miscellaneous Coding Conventions"

2021-05-18 Thread Tom Lane
PG Doc comments form writes: > small fix in description at [1] as follows > -If that were not done interrupted code that's currently inspecting errno > might see the wrong value. > +If that was not done interrupted code that's currently inspecting errno > might see the wrong value. The existing

Re: Typo in DATATYPE-JSONPATH

2021-04-15 Thread Michael Paquier
On Fri, Apr 16, 2021 at 08:11:53AM +0200, Erik Rijkers wrote: > FWIW, I agree with this and already sent a doc-patch [1], which is > be applied from 12, 13, and master. Arf. I completely forgot about this thread but I marked it as something to look at. Will do so now. -- Michael signature.asc

Re: Typo in DATATYPE-JSONPATH

2021-04-15 Thread Erik Rijkers
> On 2021.04.15. 22:04 PG Doc comments form wrote: > > Page: https://www.postgresql.org/docs/13/datatype-json.html > Description: > > Hello, > > On the DATATYPE-JSONPATH page: > https://www.postgresql.org/docs/13/datatype-json.html#DATATYPE-JSONPATH > > There is a line that shows that GIN ind

Re: Typo in psql doc

2021-04-15 Thread Ludovic Kuty
Yes indeed, thanks. I re-tested the example this morning and it worked correctly with the space. I guess I had messed up things when I first tried it. Michael Paquier 14 April 2021 at 07:58 Both commands sey in your .psqlrc results in the same path being used, as I

Re: Typo in psql doc

2021-04-15 Thread Michael Paquier
On Thu, Apr 15, 2021 at 09:55:53AM +0200, Ludovic Kuty wrote: > Yes indeed, thanks. I re-tested the example this morning and it worked > correctly with the space. I guess I had messed up things when I first tried > it. After seeing Tom's argument that this behavior become more consistent in 9.2, a

Re: Typo in psql doc

2021-04-14 Thread Michael Paquier
On Wed, Apr 14, 2021 at 10:12:02AM -0400, Tom Lane wrote: > As you say, both ways now give the same result. Since it's not the > point of this example to illustrate \set's space-eating behavior, > it might be clearer to revert the addition of the space. Oh, interesting point. I did not notice th

Re: Typo in psql doc

2021-04-14 Thread Tom Lane
Michael Paquier writes: > On Tue, Apr 13, 2021 at 07:57:54AM +, PG Doc comments form wrote: >> There is a spurious space inside the documentation: >> \set HISTFILE ~/.psql_history- :DBNAME >> instead of >> \set HISTFILE ~/.psql_history-:DBNAME > Both commands sey in your .psqlrc results in th

Re: Typo in psql doc

2021-04-13 Thread Michael Paquier
On Tue, Apr 13, 2021 at 07:57:54AM +, PG Doc comments form wrote: > There is a spurious space inside the documentation: > \set HISTFILE ~/.psql_history- :DBNAME > instead of > \set HISTFILE ~/.psql_history-:DBNAME Both commands sey in your .psqlrc results in the same path being used, as I gues

Re: Typo

2021-01-13 Thread Magnus Hagander
On Wed, Jan 13, 2021 at 11:01 AM Michael Vastola wrote: > > Crap. Meant to include link. > > See > https://www.postgresql.org/docs/current/functions-string.html#id-1.5.8.10.7.2.2.28.1.1.1 > > On 1/12/21 10:59 PM, PG Doc comments form wrote: > > The following documentation comment has been logged o

Re: Typo

2021-01-13 Thread Michael Vastola
Crap. Meant to include link. See https://www.postgresql.org/docs/current/functions-string.html#id-1.5.8.10.7.2.2.28.1.1.1 On 1/12/21 10:59 PM, PG Doc comments form wrote: The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/13/functions-st

Re: Typo in manual

2021-01-05 Thread Bruce Momjian
On Tue, Jan 5, 2021 at 06:32:11AM +, Tang, Haiying wrote: > Hi > > I think there's a typo in the manual so I tried to fix it. Also, I changed > some description for better reading. > Please take a check at my attached patch. Any comment is welcome. Agreed, applied to all branches, thanks.

Re: Typo for cd commands

2020-12-19 Thread Tom Lane
PG Doc comments form writes: > I believe that the following two commands in the page > "https://www.postgresql.org/docs/13/tutorial-sql-intro.html"; should have a > slash in the middle of the four dots. > cd /src/tutorial > cd /tutorial Hmm. The first one is written that way to be vague

Re: typo in literature reference

2020-09-10 Thread Robert Kahlert
No fair, I only looked at the back of the spine, not at the front page, so I missed the actual subtitle :P nice work Daniel --trc On Thu, Sep 10, 2020 at 1:50 PM Daniel Gustafsson wrote: > > On 10 Sep 2020, at 11:26, PG Doc comments form > wrote: > > > > The following documentation comment has

Re: typo in literature reference

2020-09-10 Thread Magnus Hagander
On Thu, Sep 10, 2020 at 1:50 PM Daniel Gustafsson wrote: > > On 10 Sep 2020, at 11:26, PG Doc comments form > wrote: > > > > The following documentation comment has been logged on the website: > > > > Page: https://www.postgresql.org/docs/12/biblio.html > > Description: > > > > Ullmann's classic

Re: typo in literature reference

2020-09-10 Thread Daniel Gustafsson
> On 10 Sep 2020, at 11:26, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/12/biblio.html > Description: > > Ullmann's classic should be > > [ull88] > Principles of Database and Knowledge-Base System

Re: Typo in the Section "3.6. Inheritance"

2020-08-31 Thread Bruce Momjian
On Fri, Aug 21, 2020 at 07:09:31PM -0700, David G. Johnston wrote: > On Fri, Aug 21, 2020 at 4:36 PM Bruce Momjian wrote: > > On Wed, Aug  5, 2020 at 11:29:31PM -0700, David G. Johnston wrote: > > > Removing "char" from the tutorial is a nice side-effect that we probably > want >

Re: Typo in the Section "3.6. Inheritance"

2020-08-21 Thread David G. Johnston
On Fri, Aug 21, 2020 at 4:36 PM Bruce Momjian wrote: > On Wed, Aug 5, 2020 at 11:29:31PM -0700, David G. Johnston wrote: > > > Removing "char" from the tutorial is a nice side-effect that we probably > want > > to do even if we keep "state". > > I think CHAR(2) is fine because it is always 2 cha

Re: Typo in the Section "3.6. Inheritance"

2020-08-21 Thread Michael Paquier
On Fri, Aug 21, 2020 at 07:36:41PM -0400, Bruce Momjian wrote: > How is the attached patch, based on your suggestions? Looks good to me. -- Michael signature.asc Description: PGP signature

Re: typo in sentence

2020-08-21 Thread Bruce Momjian
On Tue, Aug 4, 2020 at 06:03:26PM -0700, David G. Johnston wrote: > On Tuesday, August 4, 2020, Tom Lane wrote: > > Ganesh A Hegde writes: > > There is only a single sentence starting with 'if' and not two. The > phrase > > 'it is therefore ..' is preceded by a comma and not a p

Re: Typo in the Section "3.6. Inheritance"

2020-08-21 Thread Bruce Momjian
On Wed, Aug 5, 2020 at 11:29:31PM -0700, David G. Johnston wrote: > On Wed, Aug 5, 2020 at 10:41 PM Michael Paquier wrote: > > On Wed, Aug 05, 2020 at 05:36:56PM -0400, Bruce Momjian wrote: > > On Wed, Aug  5, 2020 at 05:12:43PM -0400, Bruce Momjian wrote: > > > !     type for variab

Re: Typo in the Section "3.6. Inheritance"

2020-08-05 Thread David G. Johnston
On Wed, Aug 5, 2020 at 10:41 PM Michael Paquier wrote: > On Wed, Aug 05, 2020 at 05:36:56PM -0400, Bruce Momjian wrote: > > On Wed, Aug 5, 2020 at 05:12:43PM -0400, Bruce Momjian wrote: > > > ! type for variable length character strings. The > > > ! capitals table has > > > ! an ext

Re: Typo in the Section "3.6. Inheritance"

2020-08-05 Thread Michael Paquier
On Wed, Aug 05, 2020 at 05:36:56PM -0400, Bruce Momjian wrote: > On Wed, Aug 5, 2020 at 05:12:43PM -0400, Bruce Momjian wrote: > > ! type for variable length character strings. The > > ! capitals table has > > ! an extra column, state, which shows their > > states. In >

Re: Typo in the Section "3.6. Inheritance"

2020-08-05 Thread Bruce Momjian
On Wed, Aug 5, 2020 at 05:12:43PM -0400, Bruce Momjian wrote: > ! type for variable length character strings. The > ! capitals table has > ! an extra column, state, which shows their > states. In -- U

Re: Typo in the Section "3.6. Inheritance"

2020-08-05 Thread Bruce Momjian
On Mon, Jul 27, 2020 at 02:47:07PM +, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/12/tutorial-inheritance.html > Description: > > Hello Team, > > https://www.postgresql.org/docs/current/tutorial-i

Re: typo in sentence

2020-08-04 Thread David G. Johnston
On Tuesday, August 4, 2020, Tom Lane wrote: > Ganesh A Hegde writes: > > There is only a single sentence starting with 'if' and not two. The > phrase > > 'it is therefore ..' is preceded by a comma and not a period. Hence, > > there's a single sentence and not two as you are referring to. > > I

Re: typo in sentence

2020-08-04 Thread Tom Lane
Ganesh A Hegde writes: > There is only a single sentence starting with 'if' and not two. The phrase > 'it is therefore ..' is preceded by a comma and not a period. Hence, > there's a single sentence and not two as you are referring to. I concur with Magnus that the "therefore" refers to the sente

Re: typo in sentence

2020-08-04 Thread Ganesh A Hegde
There is only a single sentence starting with 'if' and not two. The phrase 'it is therefore ..' is preceded by a comma and not a period. Hence, there's a single sentence and not two as you are referring to. Regards. On Tue, Aug 4, 2020, 5:15 PM Magnus Hagander wrote: > > > On Fri, Jul 24, 2020

Re: typo in sentence

2020-08-04 Thread Magnus Hagander
On Fri, Jul 24, 2020 at 3:28 PM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/12/manage-ag-overview.html > Description: > > The sentence has a typo: "If one PostgreSQL server instance is to house > proje

Re: Typo

2020-01-29 Thread Magnus Hagander
On Wed, Jan 29, 2020 at 9:55 AM PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/11/libpq-ssl.html > Description: > > On page https://www.postgresql.org/docs/11/libpq-ssl.html in phrase "if no > Subject Al

Re: Typo in Documentation for Version 12 Section 40.3

2020-01-09 Thread Tom Lane
Daniel Gustafsson writes: >> On 9 Jan 2020, at 10:34, Octopus ZHANG wrote: >> I partially agree. But with the context, it doesn't assume we want >> `view<->visualize` the data. It also says: >>> Another use for a materialized view is to allow faster access to data >>> brought across from a rem

Re: Typo in Documentation for Version 12 Section 40.3

2020-01-09 Thread Daniel Gustafsson
> On 9 Jan 2020, at 10:34, Octopus ZHANG wrote: Please don't top-post on the mailinglists. > I partially agree. But with the context, it doesn't assume we want > `view<->visualize` the data. It also says: > > >> Another use for a materialized view is to allow faster access to data > >> broug

Re: Typo in Documentation for Version 12 Section 40.3

2020-01-09 Thread Octopus ZHANG
I partially agree. But with the context, it doesn't assume we want `view<->visualize` the data. It also says: >> Another use for a materialized view is to allow faster access to data brought across from a remote system through a foreign data wrapper. It is talking about 'the view' not the graph.

Re: Typo in Documentation for Version 12 Section 40.3

2020-01-09 Thread Daniel Gustafsson
> On 9 Jan 2020, at 09:05, PG Doc comments form wrote: If people want to be able to quickly graph historical sales data, ... > > This sentence doesn't make sense. I think it should be: > > --- If people want to be able to quickly grab/obtain/get historical sales > data, ... I'm not a nat

Re: Typo in perform.sgml?

2019-12-08 Thread Tom Lane
Julien Rouhaud writes: > On Sun, Dec 8, 2019 at 3:51 AM Tatsuo Ishii wrote: >> Thanks for looking into this. The patch looks much cleaner than >> before. > I agree this is way better! Pushed like that, then. regards, tom lane

Re: Typo in perform.sgml?

2019-12-08 Thread Julien Rouhaud
On Sun, Dec 8, 2019 at 3:51 AM Tatsuo Ishii wrote: > > > I wrote: > >> Actually, that whole para could do with a rewrite; whoever wrote > >> it was obviously not familiar with Strunk & White's dictum > >> "Omit needless words". > > > > Looking closer, there were also some unnecessary inconsistenci

Re: Typo in perform.sgml?

2019-12-07 Thread Tatsuo Ishii
> I wrote: >> Actually, that whole para could do with a rewrite; whoever wrote >> it was obviously not familiar with Strunk & White's dictum >> "Omit needless words". > > Looking closer, there were also some unnecessary inconsistencies with > the rest of the section, such as use of "records" rathe

Re: Typo in perform.sgml?

2019-12-07 Thread Tom Lane
I wrote: > Actually, that whole para could do with a rewrite; whoever wrote > it was obviously not familiar with Strunk & White's dictum > "Omit needless words". Looking closer, there were also some unnecessary inconsistencies with the rest of the section, such as use of "records" rather than "row

Re: Typo in perform.sgml?

2019-12-07 Thread Tom Lane
Julien Rouhaud writes: > On Sat, Dec 7, 2019 at 12:05 PM Tatsuo Ishii wrote: >> Around line 904 of perform.sgml >> "These node types have the ability to discard subnodes which they are >> able to determine won't contain any records required by the query." >> >> I was not able to parse this. Mayb

Re: Typo in perform.sgml?

2019-12-07 Thread Julien Rouhaud
On Sat, Dec 7, 2019 at 12:05 PM Tatsuo Ishii wrote: > > Around line 904 of perform.sgml > > "These node types have the ability to discard subnodes which they are > able to determine won't contain any records required by the query." > > I was not able to parse this. Maybe "that they " is needed aft

Re: Typo on Refresh Materialized View page

2019-10-23 Thread Bruce Momjian
On Fri, Oct 11, 2019 at 04:31:21AM +, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/12/sql-refreshmaterializedview.html > Description: > > Hello > > There appears to be a typo on this page: > https:

Re: typo in 9.15. JSON Functions and Operators Table 9.46. JSON Processing Functions - alternate

2019-09-27 Thread Tom Lane
PG Doc comments form writes: > The following documentation comment has been logged on the website: > Page: https://www.postgresql.org/docs/10/functions-json.html > Description: > sorry, the last message may have been incorrect. if so, the next row in > table 9.46 should be changed from: >

Re: Typo in GSSAPI docs

2019-05-16 Thread Michael Paquier
On Thu, May 16, 2019 at 11:26:39AM +0200, Daniel Gustafsson wrote: > Reading a bit closer there was one more, updated diff attached. Thanks Daniel, committed. -- Michael signature.asc Description: PGP signature

Re: Typo in GSSAPI docs

2019-05-16 Thread Daniel Gustafsson
> On 16 May 2019, at 10:40, Daniel Gustafsson wrote: > > Commit b0b39f72b99 introduced a small typo in the GSSAPI documentation, see > attached diff. Reading a bit closer there was one more, updated diff attached. cheers ./daniel gssapi_typo-v2.diff Description: Binary data

Re: typo in tableam docs

2019-04-17 Thread Andres Freund
Hi, On 2019-04-17 10:24:03 -0700, Michel Pelletier wrote: > At the very end of : > > https://www.postgresql.org/docs/devel/tableam.html > > it mentions the path 'src/backend/heap/heapam_handler.c ' which I believe > should be 'src/backend/access/heap/heapam_handler.c ' Thanks for the report, I'

Re: typo in tableam docs

2019-04-17 Thread Bruce Momjian
On Wed, Apr 17, 2019 at 10:24:03AM -0700, Michel Pelletier wrote: > At the very end of : > > https://www.postgresql.org/docs/devel/tableam.html > > it mentions the path 'src/backend/heap/heapam_handler.c ' which I believe > should be 'src/backend/access/heap/heapam_handler.c ' Agreed. -- Bru

Re: Typo

2019-04-10 Thread Jonathan S. Katz
On 4/10/19 12:30 PM, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/11/sql-createfunction.html > Description: > > I have noted that it seems not convenient. > " > Writing > SECURITY DEFINER > Functions

Re: Typo in ECPG documentation

2019-03-26 Thread Magnus Hagander
On Tue, Mar 26, 2019 at 1:21 PM Daniel Gustafsson wrote: > Attached patch fixes a small typo in the ECPG documentation that I happened > to spot: s/DELARE/DECLARE/. > > Applied, thanks. //Magnus

  1   2   >