Re: PostgreSQL 15 minor fixes in protocol.sgml

2022-08-08 Thread Peter Smith
On Thu, Aug 4, 2022 at 1:04 PM Amit Kapila wrote: > > On Wed, Aug 3, 2022 at 10:56 AM Peter Smith wrote: > > > > PSA a patch to modify the descriptions as suggested by Amit. > > > > * > > - The end LSN of the commit prepared transaction. > + The end LSN of the commit of the prepa

Re: PostgreSQL 15 minor fixes in protocol.sgml

2022-08-03 Thread Amit Kapila
On Wed, Aug 3, 2022 at 10:56 AM Peter Smith wrote: > > PSA a patch to modify the descriptions as suggested by Amit. > * - The end LSN of the commit prepared transaction. + The end LSN of the commit of the prepared transaction. ... ... - Identifies the message as the commi

Re: PostgreSQL 15 minor fixes in protocol.sgml

2022-08-03 Thread Amit Kapila
On Tue, Aug 2, 2022 at 4:28 PM Michael Paquier wrote: > > On Mon, Aug 01, 2022 at 11:00:20PM +0300, Ekaterina Kiryanova wrote: > > > Another point worth mentioning is that only this file contains the phrase > > "two-phase transaction". I believe that "two-phase commit transaction" or > > "transact

Re: PostgreSQL 15 minor fixes in protocol.sgml

2022-08-03 Thread Peter Smith
On Wed, Aug 3, 2022 at 1:58 PM Amit Kapila wrote: > > On Tue, Aug 2, 2022 at 4:28 PM Michael Paquier wrote: > > > > On Mon, Aug 01, 2022 at 11:00:20PM +0300, Ekaterina Kiryanova wrote: > > > > > Another point worth mentioning is that only this file contains the phrase > > > "two-phase transaction

Re: PostgreSQL 15 minor fixes in protocol.sgml

2022-08-02 Thread Michael Paquier
On Mon, Aug 01, 2022 at 11:00:20PM +0300, Ekaterina Kiryanova wrote: > I didn't include it in the patch but I also suggest removing single quotes > around 'method' for the COMPRESSION option to help avoid confusion. (All the > supported compression methods consist of a single word so in my opinion

PostgreSQL 15 minor fixes in protocol.sgml

2022-08-01 Thread Ekaterina Kiryanova
Hello! I've come across some typos in protocol.sgml for PostgreSQL 15 so please have a look at the attached patch. I didn't include it in the patch but I also suggest removing single quotes around 'method' for the COMPRESSION option to help avoid confusion. (All the supported compression met