Re: pg_createsubscriber: publication-name and subscription-name options do not exist

2024-12-02 Thread Shubham Khanna
as the following name pattern:". > > That would make it consistent with the similar sentences which are saying: > "... the replication slot has the following name pattern: > "... the subscription has the following name pattern:" > I have added the suggested cha

Re: pg_createsubscriber: publication-name and subscription-name options do not exist

2024-12-02 Thread Shubham Khanna
3DAejiX-pF0417Vc7tMrh%2BYuZjBt7ozjvPUA%40mail.gmail.com > I have fixed the suggested changes. The attached Patch contains the required changes. Thanks and regards, Shubham Khanna. v5-0001-DOCS-Fix.patch Description: Binary data

Re: pg_createsubscriber: publication-name and subscription-name options do not exist

2024-12-02 Thread Shubham Khanna
On Tue, Dec 3, 2024 at 8:39 AM Shubham Khanna wrote: > > On Tue, Dec 3, 2024 at 7:16 AM Peter Smith wrote: > > > > Hi Shubham, > > > > I took a look at the patch v2-0001. Here are some review comments. > > > > 1. > > Previously when this

Re: pg_createsubscriber: publication-name and subscription-name options do not exist

2024-12-02 Thread Shubham Khanna
> > e.g. > /If replication-slot-name is not specified.../If the > --replication-slot switch is not specified.../ > or > /If replication-slot-name is not specified.../If --replication-slot is > not specified.../ > I have fixed the suggested changes. The attached Patch contains the required changes. Thanks and regards, Shubham Khanna. v3-0001-DOCS-Fix.patch Description: Binary data

Re: pg_createsubscriber: publication-name and subscription-name options do not exist

2024-12-02 Thread Shubham Khanna
On Mon, Dec 2, 2024 at 4:57 PM vignesh C wrote: > > On Mon, 2 Dec 2024 at 15:00, Shubham Khanna > wrote: > > > > On Mon, Dec 2, 2024 at 2:57 PM PG Doc comments form > > wrote: > > > > > > The following documentation comment has been l

Re: pg_createsubscriber: publication-name and subscription-name options do not exist

2024-12-02 Thread Shubham Khanna
plication-slot=NAME replication slot name > --subscription=NAME subscription name > > I suppose that the options should be respectively --publication and > --subscription. > I have updated the Documentation for pg_createsubscriber with the suggested changes. The attached Patch contai