Re: Logical replication - initial data synchronization

2025-02-17 Thread Peter Smith
On Tue, Feb 18, 2025 at 11:25 AM David G. Johnston wrote: > > On Sun, Dec 15, 2024 at 11:10 PM Peter Smith wrote: >> >> On Mon, Nov 25, 2024 at 11:55 AM Peter Smith wrote: >> >> > "When logical replication of a table starts, PostgreSQL typically >> &

Re: Logical replication - initial data synchronization

2024-12-15 Thread Peter Smith
On Mon, Nov 25, 2024 at 11:55 AM Peter Smith wrote: > > On Fri, Nov 22, 2024 at 9:15 AM Bruce Momjian wrote: > > > > On Thu, Oct 31, 2024 at 06:52:34PM -0400, Bruce Momjian wrote: > > > On Fri, Nov 1, 2024 at 09:07:38AM +1100, Peter Smith wrote: > > > &g

Re: pg_createsubscriber: publication-name and subscription-name options do not exist

2024-12-02 Thread Peter Smith
Patch v6-0001 LGTM. == Kind Regards, Peter Smith. Fujitsu Australia

Re: pg_createsubscriber: publication-name and subscription-name options do not exist

2024-12-02 Thread Peter Smith
replication slot has the following name pattern: "... the subscription has the following name pattern:" == Kind Regards, Peter Smith. Fujitsu Australia

Re: pg_createsubscriber: publication-name and subscription-name options do not exist

2024-12-02 Thread Peter Smith
specified/ == [1] https://www.postgresql.org/message-id/CAHut%2BPs8Xq-e5XL%3DAejiX-pF0417Vc7tMrh%2BYuZjBt7ozjvPUA%40mail.gmail.com Kind Regards, Peter Smith. Fujitsu Australia

Re: pg_createsubscriber: publication-name and subscription-name options do not exist

2024-12-02 Thread Peter Smith
that one using the same consistent wording. e.g. /If replication-slot-name is not specified.../If the --replication-slot switch is not specified.../ or /If replication-slot-name is not specified.../If --replication-slot is not specified.../ == Kind Regards, Peter Smith. Fujitsu Australia

Re: Logical replication - initial data synchronization

2024-11-24 Thread Peter Smith
On Fri, Nov 22, 2024 at 9:15 AM Bruce Momjian wrote: > > On Thu, Oct 31, 2024 at 06:52:34PM -0400, Bruce Momjian wrote: > > On Fri, Nov 1, 2024 at 09:07:38AM +1100, Peter Smith wrote: > > > On Fri, Nov 1, 2024 at 2:16 AM Bruce Momjian wrote: > > > > > >

Re: Logical replication - initial data synchronization

2024-10-31 Thread Peter Smith
this together --- the feedback from everyone was helpful. > One small nit -- I think "PostgreSQL" typically would have SGML markup: PostgreSQL == Kind Regards, Peter Smith. Fujitsu Australia

Re: Logical replication - initial data synchronization

2024-10-24 Thread Peter Smith
copying that to the subscriber. Or, AFTER #2 (I added "PostgreSQL internally") Logical replication of a table typically starts with PostgreSQL internally taking a snapshot of the data on the publisher database and copying that to the subscriber. == Kind Regards, Peter Smith. Fujitsu Australia

Re: Ambiguous description on new columns

2024-05-31 Thread Peter Smith
On Wed, May 29, 2024 at 8:04 PM vignesh C wrote: > > On Wed, 22 May 2024 at 14:26, Peter Smith wrote: > > > > On Tue, May 21, 2024 at 8:40 PM PG Doc comments form > > wrote: > > > > > > The following documentation comment has been logged on t

Re: Ambiguous description on new columns

2024-05-22 Thread Peter Smith
3:19.098 AEST [16226] ERROR: logical replication target relation "public.t" is missing replicated column: "d" I think the following small change will remove any ambiguity: BEFORE If no column list is specified, any columns added later are automatically replicated. SUGGES

Re: Ambiguous description on new columns

2024-05-21 Thread Peter Smith
On Wed, May 22, 2024 at 1:22 PM David G. Johnston wrote: > > On Tue, May 21, 2024 at 7:48 PM Peter Smith wrote: >> >> >> I think the following small change will remove any ambiguity: >> >> BEFORE >> If no column list is specified, any columns a

Re: Ambiguous description on new columns

2024-05-21 Thread Peter Smith
3:19.098 AEST [16226] ERROR: logical replication target relation "public.t" is missing replicated column: "d" I think the following small change will remove any ambiguity: BEFORE If no column list is specified, any columns added later are automatically replicated. SUGGES

Re: clarifying trigger/rule behavior on logical replication subscribers

2023-07-27 Thread Peter Smith
It seems this was pushed already [1]. Sorry for the false alarm. -- [1] https://github.com/postgres/postgres/commit/f5c446e3367527f9db1506d7c38d2f56e20950b6 Kind Regards, Peter Smith. Fujitsu Australia.

Re: clarifying trigger/rule behavior on logical replication subscribers

2023-07-26 Thread Peter Smith
I created patches for this over a month ago, but then the thread went quiet. Is there something more needed, or was it just accidentally overlooked? Should this be added to the commitfest? -- Kind Regards, Peter Smith. Fujitsu Australia.

Re: clarifying trigger/rule behavior on logical replication subscribers

2023-06-20 Thread Peter Smith
com [2] https://www.postgresql.org/message-id/288747bd-911b-4370-8db2-6ecbb096037e%40app.fastmail.com [3] https://www.postgresql.org/docs/devel/runtime-config-client.html Kind Regards, Peter Smith. Fujitsu Australia v2-0001-doc-Clarify-behavior-of-triggers-rules-in-a-logical-subscriber-REL_13.patch Des

Re: PostgreSQL 15 minor fixes in protocol.sgml

2022-08-08 Thread Peter Smith
On Thu, Aug 4, 2022 at 1:04 PM Amit Kapila wrote: > > On Wed, Aug 3, 2022 at 10:56 AM Peter Smith wrote: > > > > PSA a patch to modify the descriptions as suggested by Amit. > > > > * > > - The end LSN of the commit prepared transaction. > +

Re: PostgreSQL 15 minor fixes in protocol.sgml

2022-08-03 Thread Peter Smith
The end LSN of the prepare transaction. > > > Is it a typo of "prepared transaction"? > > I think in this case it should be a "prepared transaction". > > > Thanks for the report and Thanks Michael for including me. I am just > redirecting it to -hackers s