Re: [DOCS] Confusing Trigger Docs.

2023-11-22 Thread Peter Geoghegan
e row as it was prior to the BEFORE triggers ran, after they ran, or something else? Or is it more like the execution context of a single row? -- Peter Geoghegan

Re: Transaction wraparound and read committed isolation level

2023-02-21 Thread Peter Geoghegan
On Tue, Feb 21, 2023 at 9:46 AM Peter Geoghegan wrote: > All that you need is two statements within the same READ COMMITTED > transaction, combined with a second concurrently executing > transaction. The second transaction need only start after the first > one (giving it a later XI

Re: Transaction wraparound and read committed isolation level

2023-02-21 Thread Peter Geoghegan
gt; default isolation level but more for higher levels such as repeatable read > > and such. > > > > please correct me if my understanding is incorrect. > > Wraparound can be a problem on all isolation levels. It has to do with > transaction IDs and visibility. The way t

Re: 64.4.2. Bottom-up Index Deletion

2022-11-09 Thread Peter Geoghegan
liably). > Adding "no-longer-visible" at the start should hopefully be a sufficient > reminder for someone familiar with MVCC; or a clue that more reading of > pre-requisite features is needed before understanding this internal part of > the system. Yeah, it's not clear what the prerequisites for reading this material should be. It is part of the B-Tree internals chapter, though, so it is very advanced material. -- Peter Geoghegan

Re: 64.4.2. Bottom-up Index Deletion

2022-11-09 Thread Peter Geoghegan
load). I don't think that these subtleties need to be documented. But it's difficult to know where to draw the line. -- Peter Geoghegan

Re: 64.4.2. Bottom-up Index Deletion

2022-11-07 Thread Peter Geoghegan
t much less likely that index bloat will be very destabilizing. So the main difference between bottom-up deletion and simple deletion is the information that drives the whole process. The physical modifications to the index page are actually identical (the LP_DEAD bit is set by index scans, not the deletion process itself). -- Peter Geoghegan

Re: relpages in pg_class

2022-08-19 Thread Peter Geoghegan
eeds into a lot of things, and is quite easy to take for granted -- which might actually cost you. -- Peter Geoghegan

Re: documentation on HOT

2022-07-23 Thread Peter Geoghegan
rall, I think that this is suitable to commit, and I don't want to make too much of a fuss. It's great that we're doing this. Thanks -- Peter Geoghegan

Re: documentation on HOT

2022-07-22 Thread Peter Geoghegan
e the role of VACUUM. We may not even require a little help from VACUUM, under ideal conditions. -- Peter Geoghegan

Re: documentation on HOT

2022-07-22 Thread Peter Geoghegan
one important way, but totally ineffective in another way. There is a section about bottom-up index deletion in the docs (in the B-Tree internals chapter) that already references HOT. It should link to this new chapter now, I think. -- Peter Geoghegan

Re: Remove recommendation for nightly VACUUM

2022-06-27 Thread Peter Geoghegan
instead, as done in the attached patch. > > > Agred. A nightly vacuum is definitely not something for "most people" anymore. +1. The VACUUM documentation needs to be totally overhauled. This is a start. -- Peter Geoghegan

Re: proposal: convert comments in documents to html comments

2022-06-26 Thread Peter Geoghegan
during a general discussion of the release note writing process. I don't have much of a clue about our docbook toolchain, beyond the basics (plus I have no front-end experience). Is anybody else aware of a reasonable approach to making git hashes discoverable from the html release notes? -- Peter Geoghegan

Re: proposal: convert comments in documents to html comments

2022-06-26 Thread Peter Geoghegan
eing obtrusive). But this patch is a start. -- Peter Geoghegan

Re: proposal: convert comments in documents to html comments

2022-06-26 Thread Peter Geoghegan
On Sun, Jun 26, 2022 at 5:19 AM Noboru Saito wrote: > The release notes have the git commit information in the comments, > it would be great to have it in the html comments as well. > > That can be done with the attached patch. Sounds like a good idea to me. -- Peter Geoghegan

Re: "GIN and GiST Index Types" page is about usage in full text search, but looks general purpose

2022-04-12 Thread Peter Geoghegan
onical was a wise one, on balance. The reality is that we have very few ways of influencing search results from Google. I don't know enough about the topic to be able to claim that the robots.txt solution would also work out well, in about the same way. But I suspect that it might, and know that it's a reversible process. -- Peter Geoghegan

Re: "GIN and GiST Index Types" page is about usage in full text search, but looks general purpose

2022-04-12 Thread Peter Geoghegan
ww list, it's possible > that Google will eventually stop indexing the 9.1 page altogether, > but I'm not holding my breath. There is always the extreme option of excluding older versions in robots.txt. I bet that would work. Do you see any downside with that solution, Jonathan? -- Peter Geoghegan

Re: "GIN and GiST Index Types" page is about usage in full text search, but looks general purpose

2022-04-12 Thread Peter Geoghegan
sion of FTS indexing) seems like a problem in itself. At one point GiST was competitive with GIN for full text search performance (or at least more competitive). These days use of GiST for FTS should be rare. So the title should suggest that GiST FTS indexing is the nonstandard choice. -- Peter Geoghegan

Re: 11.7. Indexes on Expressions

2021-12-22 Thread Peter Geoghegan
mes to mind). -- Peter Geoghegan

Re: Correction for vacuum_multixact_failsafe_age

2021-10-28 Thread Peter Geoghegan
On Thu, Oct 28, 2021 at 1:58 PM Alvaro Herrera wrote: > It is in 14. Right. It won't be reflected on the website until 14.1 is released, though. -- Peter Geoghegan

Re: Correction for vacuum_multixact_failsafe_age

2021-10-12 Thread Peter Geoghegan
On Tue, Oct 12, 2021 at 10:46 AM Alvaro Herrera wrote: > Yeah, this one is new as of commit 1e55e7d1755c; ISTM we should just fix it. Agreed. Pushed Pavel's patch just now. Thanks -- Peter Geoghegan

Re: Common case not at all clear

2021-09-19 Thread Peter Geoghegan
from the docs as written. MVCC really relies on Select > For Update to work for transactions, I think. I suggest using a higher isolation level. Ideally SERIALIZABLE. -- Peter Geoghegan

Re: "stable storage"

2020-08-21 Thread Peter Geoghegan
table storage" to > "durable storage". I agree that this is an improvement. The word "durable" is more descriptive than "stable". (The word "stable" might be more recognizable, but that in itself doesn't make the text any clearer.) -- Peter Geoghegan

Re: btree index maximum row size

2020-03-12 Thread Peter Geoghegan
limitation of the B-Tree access method specifically. However, I think that there is a good practical argument to be made for including it here as well. -- Peter Geoghegan

Re: Duplicating website's formatting in local doc builds

2020-02-14 Thread Peter Geoghegan
On Fri, Feb 14, 2020 at 6:09 PM Tom Lane wrote: > > Language updates attached...mostly kept Tom's suggestions. > > Typo (optoin), otherwise LGTM. Great. Pushed with that tweak. -- Peter Geoghegan

Re: Duplicating website's formatting in local doc builds

2020-02-14 Thread Peter Geoghegan
> stylesheets hosted at www.postgresql.org, so that viewing them will > require network access." But everything else looks good, right? I would like to commit this patch shortly. -- Peter Geoghegan

Re: Duplicating website's formatting in local doc builds

2020-02-11 Thread Peter Geoghegan
t" diagram is massive, though. IIRC was an issue that had to be addressed on the website a little after the introduction of images into the docs. It seems as if my local build of the docs needs that same fix. -- Peter Geoghegan

Re: Duplicating website's formatting in local doc builds

2020-02-11 Thread Peter Geoghegan
On Tue, Feb 11, 2020 at 10:37 AM Tom Lane wrote: > I also wonder why duplicating the website's style isn't the default. > Doesn't seem like having authors optimize for some other style is > what we really want. FWIW, I've often wondered about it myself. -- Peter Geoghegan

Re: Improvement of GIN figure

2019-07-09 Thread Peter Geoghegan
am not an expert in the area but I think we should cosider people > with color disability. Good point. I think that that shouldn't be too hard to mostly get right. It's good that the diagrams will already work with a screen reader. -- Peter Geoghegan

Re: Improvement of GIN figure

2019-07-09 Thread Peter Geoghegan
and that muted pastel colors would work better. Doesn't seem like something that should happen at the cost of making the diagram less informative, though. -- Peter Geoghegan

Re: First SVG graphic

2019-03-27 Thread Peter Geoghegan
hanges through a browser, rather than expecting them to install Java locally. I don't think that it's necessary to have something like that available immediately. It is an option, though. -- Peter Geoghegan