Re: Minor necessary/sufficient slip-up?

2025-09-03 Thread Peter Eisentraut
On 03.09.25 09:52, Laurenz Albe wrote: On Tue, 2025-09-02 at 08:22 +, PG Doc comments form wrote: Page: https://www.postgresql.org/docs/17/routine-vacuuming.html This is a most pedantic point, but since the postgres documentation is incredibly accurate and well written I indulge my pedantry

Re: Small typo in doc

2025-08-27 Thread Peter Eisentraut
On 27.08.25 04:49, PG Doc comments form wrote: The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/17/wal-async-commit.html Description: within this document https://www.postgresql.org/docs/current/wal-async-commit.html in the paragraph tha

Re: Make pgoutput documentation easier to find

2025-08-06 Thread Peter Eisentraut
On 03.08.25 03:32, Fujii Masao wrote: The current documentation for pgoutput is buried in the logical streaming replication protocol section (in protocol.sgml), and there's no index entry for it. This makes it hard to discover and access, for example, when trying to look up the options it support

Re: Initcap works differently with different locale providers

2025-08-06 Thread Peter Eisentraut
On 04.08.25 22:59, Jeff Davis wrote: On Mon, 2025-08-04 at 12:30 +0700, Oleg Tselebrovskiy wrote: First patch just adds this warning about not relying on initcap() exact result. The second one is the same, but removes the part "what is a word" since it's could be moot because we recommend writin

Re: Mention the default io_method?

2025-06-16 Thread Peter Eisentraut
On 03.04.25 17:14, Pavel Stehule wrote: čt 3. 4. 2025 v 13:26 odesílatel Daniel Westermann (DWE) mailto:daniel.westermann@dbi- services.com>> napsal: st 2. 4. 2025 v 12:28 odesílatel Daniel Westermann (DWE) mailto:daniel.westermann@dbi- services.com>> napsal: Hi,

Re: generated constraint name

2025-04-29 Thread Peter Eisentraut
On 24.04.25 17:13, Robert Treat wrote: On Fri, Apr 11, 2025 at 8:45 AM Euler Taveira wrote: On Fri, Apr 11, 2025, at 5:32 AM, Yaroslav Saburov wrote: On the tutorial-agg page in the code example SELECT city FROM weather WHERE temp_lo = max(temp_lo); WRONG you need to add a comment before WRON

Re: generated constraint name

2025-04-10 Thread Peter Eisentraut
On 07.04.25 15:34, David G. Johnston wrote: On Sunday, April 6, 2025, PG Doc comments form > wrote: The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/17/ddl-alter.html Description: url:

Re: Some comments on PL/Python documentation

2025-04-03 Thread Peter Eisentraut
On 08.01.25 09:45, Peter Eisentraut wrote: 44.2.5. Set-Returning Functions 1. You say: '...Sequence type (tuple, list, set)...' Being an unordered collection, sets do not record element position or order of insertion. Accordingly, sets do not support indexing, slicing, or other seq

Re: Ordering of statistic views

2025-02-03 Thread Peter Eisentraut
On 31.01.25 11:46, Daniel Westermann (DWE) wrote: I am wondering if there is a reason that the list on top of: https://www.postgresql.org/docs/devel/monitoring-stats.html ... is not alphabetically ordered? This was cleaned up most recently in commit 72e0ff2677c. Please check there if the cur

Re: Some comments on PL/Python documentation

2025-01-08 Thread Peter Eisentraut
On 29.12.24 01:48, PG Doc comments form wrote: Page: https://www.postgresql.org/docs/17/plpython-data.html Description: Hello, In my opinion, some phrases on this page are not quite correct. 44.2.4. Composite Types You say: '...Object (any object providing method __getattr__)...' Actually, the

Re: vm.overcommit_ratio

2025-01-08 Thread Peter Eisentraut
On 26.12.24 08:44, PG Doc comments form wrote: The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/16/kernel-resources.html Description: PostgreSQL documentation point to kernel documentation for info about vm.overcommit_ratio. But kernel do

Re: Improved security for https://www.postgresql.org/docs/current/install-make.html

2024-11-13 Thread Peter Eisentraut
On 12.11.24 22:50, Bear Giles wrote: My point was mostly that I did a fresh 'git clone', followed the instructions, and was immediately hit by a "permission denied" error because the make script tried to create a directory under /usr/local. It wasn't clear whether that was the only thing that r

Re: Improved security for https://www.postgresql.org/docs/current/install-make.html

2024-11-11 Thread Peter Eisentraut
On 06.11.24 22:58, PG Doc comments form wrote: The 'short' script can then be rewritten as ``` # work done as a regular user ./configure make build # work that requires ROOT access su mkdir /usr/local/pgsql/data chown (current user):(current group) /usr/local/pgsql adduser --system --group post

Re: Limitation relates to memory allocation

2024-10-16 Thread Peter Eisentraut
On 14.10.24 08:03, Ekaterina Kiryanova wrote: We encountered an issue related to internal memory allocation limit: ERROR: invalid memory alloc request size In the documentation on limits: https://www.postgresql.org/docs/17/ limits.html the description suggests that only a single field is limite

Re: Elaborate on phrase "table metadata" in the Notes section of ALTER by specifying pg_attribute

2024-09-18 Thread Peter Eisentraut
On 11.09.24 22:12, PG Doc comments form wrote: Page:https://www.postgresql.org/docs/16/sql-altertable.html Description: I am newish to Postgres, and the term "table metadata" was confusing to me. I think it is pretty easy to do a quick internet search to find out what table metadata is in the

Re: Documentation improvement patch

2024-09-11 Thread Peter Eisentraut
On 10.09.24 15:02, Daniel Gustafsson wrote: On 10 Sep 2024, at 13:46, Oleg Sibiryakov wrote: 1. Since we do not want to use here, I suggest we hyphenate it as "built-in". What's your take on it? I think that's the right choice given the hyphenation used in the rest of the docs. There are

Re: DocBook 5.2

2024-09-11 Thread Peter Eisentraut
On 06.09.24 10:50, Jürgen Purtz wrote: For the PG community I would like to raise the question: Do we need DocBook in the distro of any operating system? In the past we developed some stylesheets to adopt DocBook to our needs. They are part of PG's distro and refer to the standard with statemen

Re: Incorrect option name for meson build

2024-08-27 Thread Peter Eisentraut
On 26.08.24 09:15, PG Doc comments form wrote: The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/12/catalog-pg-type.html Description: Page: https://www.postgresql.org/docs/16/install-meson.html#CONFIGURE-AUTO-FEATURES-MESON Description: He

Re: Avoid too prominent use of "backup" on pg_dump man page

2024-07-30 Thread Peter Eisentraut
On 31.05.24 10:24, Laurenz Albe wrote: On Thu, 2024-05-30 at 08:21 +0200, Daniel Gustafsson wrote: No objections to using export over backup, but it does make the use of "restore" feel awkward as that's generally an operation on a backup and not an export. -    least one schema/table in the

Re: incorrect (incomplete) description for "alter domain"

2024-07-30 Thread Peter Eisentraut
On 29.07.24 17:17, Tom Lane wrote: I wrote: I think the page is technically correct, but I'm inclined to duplicate this text from the CREATE DOMAIN page: where domain_constraint is: [ CONSTRAINT constraint_name ] { NOT NULL | NULL | CHECK (expression) } rather than

Re: tutorial not accurate

2024-07-03 Thread Peter Eisentraut
On 02.07.24 22:00, PG Doc comments form wrote: The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/16/tutorial-accessdb.html Description: I was able to create a db (mydb) but when I use any of the test SELECT statements, nothing happens. Her

Re: Document when ssl_prefer_server_ciphers went in

2024-07-03 Thread Peter Eisentraut
On 03.07.24 11:23, Daniel Gustafsson wrote: In the documentation for ssl_prefer_server_ciphers we only say it's not in "older version" but we omit to specify it further. Since it's a fairly important setting for security I think it makes sense to add the version to help users, as in the small at

Re: COALESCE documentation

2024-07-03 Thread Peter Eisentraut
On 02.07.24 12:45, Navrátil, Ondřej wrote: Hello, as per documentation > The |COALESCE| function returns the first of its arguments that is not null. Null is returned only if all arguments are n

Avoid too prominent use of "backup" on pg_dump man page

2024-05-29 Thread Peter Eisentraut
0]: https://www.pgevents.ca/events/pgconfdev2024/schedule/session/126-how-postgres-is-misused-and-abused-in-the-wild/From dbf7c0785b9f2ddf85d19f3e41c22c72a600bb66 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Wed, 29 May 2024 16:01:26 -0700 Subject: [PATCH] doc: Avoid too prominent use of "b

Re: Explanations not clear

2024-05-14 Thread Peter Eisentraut
On 13.05.24 21:10, Jeff Davis wrote: On Wed, 2024-05-08 at 08:52 +0200, Peter Eisentraut wrote: I created a collation specifying the ks-level3 setting and with deterministic set to false. But when I compare "a_b" to "a-b" with this collation I get false. According to the

Re: Explanations not clear

2024-05-07 Thread Peter Eisentraut
On 06.05.24 19:59, PG Doc comments form wrote: The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/16/collation.html Description: I created a collation specifying the ks-level3 setting and with deterministic set to false. But when I compare

Re: nchar is undocumented

2024-05-06 Thread Peter Eisentraut
On 06.05.24 10:53, Alvaro Herrera wrote: On 2024-May-05, David Rowley wrote: On Sun, 5 May 2024 at 12:41, Erik Wienhold wrote: So, I think we should either remove that one nchar instance (because it doesn't add any real value) or document it properly. The attached patch does the latter. It

Re: The PostgreSQL Select Syntax

2024-05-03 Thread Peter Eisentraut
On 02.05.24 20:08, PG Doc comments form wrote: I'm writing to seek clarification regarding the scope of the formal syntax outlined in the documentation for the SELECT statement (https://www.postgresql.org/account/comments/new/16/sql-select.html/). I understand that this syntax defines the core s

Re: wal_init_zero / wal_recycle

2024-04-24 Thread Peter Eisentraut
On 24.04.24 10:08, Nicolas Seinlet wrote: while searching the doc to solve an issue, I found the interdependency between those 2 parameters was not obvious. Here: https://www.postgresql.org/docs/14/runtime-config-wal.html#GUC-WAL-INIT-ZERO

Re: No documentation on how pg_ctl is installed

2024-04-24 Thread Peter Eisentraut
On 23.04.24 14:40, PG Doc comments form wrote: The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/15/app-pg-ctl.html Description: I have used postgresql@14 for several years and have always used pg_ctl to start the postgres server, check st

Re: incorrect order? in "D.1. Supported Features" of PostgreSQL 16 manual

2024-02-23 Thread Peter Eisentraut
On 23.02.24 12:23, 小泉 悟 wrote: Upon closer inspection, F305 is also "INTERSECT ALL table operator”. Perhaps F302-02 would be unnecessary. Correct, F302-02 should have been deleted. I have fixed it, thanks. 2024/02/23 18:06、Daniel Gustafsson のメール: On 23 Feb 2024, at 06:36, PG Doc comments

Re: create table explicitly mention that unique|primary key constraint will create an

2024-01-31 Thread Peter Eisentraut
On 18.01.24 22:21, David G. Johnston wrote: I started looking at this specific item and immediately got the idea to actually document in user-facing (i.e., not system catalogs) what these object categories are in which object types share the schema namespace. The "Other Object Types" section al

Re: create table explicitly mention that unique|primary key constraint will create an

2024-01-31 Thread Peter Eisentraut
On 26.01.24 16:52, Laurenz Albe wrote: On Fri, 2024-01-26 at 19:01 +0530, vignesh C wrote: CFBot shows that the patch does not apply anymore as in [1]: There was a conflict with 46a0cd4cefb. Updated version attached. Sprinkled in some of David's suggestions, and pushed. I was hesitant to bu

Re: create table explicitly mention that unique|primary key constraint will create an

2024-01-18 Thread Peter Eisentraut
On 27.11.23 03:30, Laurenz Albe wrote: True; I don't find it documented that all objects in pg_class share a namespace and that constraints are implemented by indexes of the same name. But I think that the first part is a property of schemas and had better be documented there. It is documented

Re: INFORMATION_SCHEMA.routine_column_usage

2023-11-30 Thread Peter Eisentraut
On 29.11.23 15:01, Peter Eisentraut wrote: Here https://www.postgresql.org/docs/current/infoschema-routine-column-usage.html <https://www.postgresql.org/docs/current/infoschema-routine-column-usage.html> it is stated that "The view |routine_column_usage| is meant to identify all c

Re: INFORMATION_SCHEMA.routine_column_usage

2023-11-29 Thread Peter Eisentraut
other views are similarly affected. How about this attached patch. From dfe65ace27a5b2e11511e5d929eea356c8ca89e5 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Wed, 29 Nov 2023 14:56:41 +0100 Subject: [PATCH] doc: Update info on information schema usage tables Commit f40c6969d0 added the in

Re: "name" vs "alias" in datatype table

2023-11-29 Thread Peter Eisentraut
On 23.11.23 21:51, PG Doc comments form wrote: I think there could be some clarification of what is a "name" vs. "alias" on the datatypes table. Right now, what's in the "Aliases" column is sometimes postgres's internal type (e.g. `pg_catalog.int4`), and sometimes the "pretty name", (e.g. `integ

Re: T is a mandatory date time separator in RFC3339 but documentation states differently

2023-11-19 Thread Peter Eisentraut
On 19.11.23 21:34, Erik Wienhold wrote: * Making explicit references to ISO 8601:2004 where section numbers are referenced. Mostly in source comments but also a couple of places in the docs. This is about avoiding confusion as ISO 8601:2019 has been published since then, with different

Re: T is a mandatory date time separator in RFC3339 but documentation states differently

2023-11-15 Thread Peter Eisentraut
On 15.11.23 09:37, Erik Wienhold wrote: On 2023-11-15 08:16 +0100, Peter Eisentraut wrote: The SQL standard does not refer to ISO 8601 to define date formats, it has its own definitions. In fact, PostgreSQL implements more date formats than the SQL standard requires. Really? Then what does

Re: T is a mandatory date time separator in RFC3339 but documentation states differently

2023-11-14 Thread Peter Eisentraut
On 14.11.23 19:21, Erik Wienhold wrote: I did not say that occurrences of "ISO 8601" should be replaced with "RFC 3339". Just that the docs should have a cautionary note about the SQL standard using a subset of ISO 8601 and that Postgres does not implement (at the moment) all of its date formats

Re: JSON type unsupported

2023-10-06 Thread Peter Eisentraut
On 26.09.23 17:31, Vik Fearing wrote: For example, we do not have the JSON_SERIALIZE(), JSON()[1], JSON_SCALAR() functions.  We don't have the IS JSON predicate, or a few other things hiding behind T801. AFAICT, commit 03734a7fed, which is new in master, adds exactly those, so maybe we could

Re: Hyperlinks for source file references

2023-09-27 Thread Peter Eisentraut
On 25.09.23 13:09, Daniel Gustafsson wrote: Commit b73c3a11963 introduced xyz hyperlinks for files in the postgres source tree by linking to the gitweb interface at git.postgresql.org. This, IMO, makes the content referred to more accessible, and is especially interesting for README files. The

Re: Replica vs standby

2023-09-06 Thread Peter Eisentraut
On 06.09.23 03:42, Bruce Momjian wrote: There are other cases in our docs where we call something a standby and mean only a physical standby/replica. Should these be clarified? When "hot standby" was added, I argued that it's not really a standby if it's hot. The response was that this is so

Re: streaming replication depends on matching glibc versions / LOCALE sort order

2023-08-15 Thread Peter Eisentraut
On 08.08.23 21:05, Dan Stoner wrote: I'm circling back around to this. I've cloned the postgresql git repo and started looking thru doc/src/sgml directory, looking thru the developer FAQ on the wiki, etc. Great! For documentation updates such as this, where would I submit the patch(es)? Is

Re: 3.6 Inheritance Documentation

2023-08-08 Thread Peter Eisentraut
On 02.08.23 21:54, PG Doc comments form wrote: In the provided example, the cities table and the capitals table have a parent-child relationship through inheritance. However, querying the cities table directly (e.g., SELECT name, elevation FROM cities WHERE elevation > 500;) will not automaticall

Re: confusing positioning of notes in connection settings

2023-06-07 Thread Peter Eisentraut
On 07.06.23 17:34, Jonathan S. Katz wrote: On 6/7/23 11:17 AM, Peter Eisentraut wrote: The proposed text in the patch is "This parameter is supported only on systems that {have this property} (which does not include Windows)." I don't see how the change you are proposing

Re: confusing positioning of notes in connection settings

2023-06-07 Thread Peter Eisentraut
On 05.06.23 19:10, Jonathan S. Katz wrote: On 5/31/23 7:53 AM, Daniel Gustafsson wrote: On 31 May 2023, at 13:16, Peter Eisentraut wrote: The first two hunks are pretty straightforward, they just move the existing text around. For the other two, which are not supported on Windows, I added

Re: confusing positioning of notes in connection settings

2023-05-31 Thread Peter Eisentraut
On 26.04.23 07:36, Daniel Gustafsson wrote: On 26 Apr 2023, at 10:18, Daniel Gustafsson wrote: On 26 Apr 2023, at 08:08, Peter Eisentraut wrote: I wonder if the notes are even true. The text for tcp_keepalives_interval already says that it is only supported if TCP_KEEPCNT is supported

tables on pgbench man page look garbled

2023-05-09 Thread Peter Eisentraut
The tables "pgbench Operators" and "pgbench Functions" on the pgbench man page (the actual man page, not the HTML reference page) look pretty garbled. Also, on macOS, man prints a warning that the page is invalidly formatted. But the garbledness happens on Linux as well, for example. Apparen

Re: some new glossary entries

2023-05-03 Thread Peter Eisentraut
On 02.05.23 12:55, Daniel Gustafsson wrote: On 2 May 2023, at 12:24, Alvaro Herrera wrote: On 2023-May-02, Daniel Gustafsson wrote: + + LSN + + The other entries doesn't have a glossentry id attribute set, is the use here related to the glossentry.show.acronym param? I debated wi

some new glossary entries

2023-05-02 Thread Peter Eisentraut
ary, so I moved things around a bit.From 8ef8a2f08bc4225bfb3528db78e57021d682ec93 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Tue, 2 May 2023 08:54:54 +0200 Subject: [PATCH 1/2] doc: New glossary entry "Restartpoint" --- doc/src/sgml/glossary.sgml | 14 ++ 1 file changed, 14 inse

Re: confusing positioning of notes in connection settings

2023-04-25 Thread Peter Eisentraut
On 22.04.23 21:53, Jonathan S. Katz wrote: While testing a few other things on the connection settings page[1], I noticed the notes on the "tcp_*" family of settings. While scrolling further down the page, I found myself slightly confused over which note corresponded to which setting (example i

Re: Certificate authentication docs in multiple places

2023-03-28 Thread Peter Eisentraut
On 23.03.23 14:33, Steve Atkins wrote: A couple of times recently I’ve been chatting with someone about using certificate authentication, and the docs they’ve found on it are the ones in section 21.12 (Client Authentication -> Certificate Authentication). But the useful documentation about how

Re: Add missing meson arguments in docs

2023-02-22 Thread Peter Eisentraut
On 22.02.23 02:57, Michael Paquier wrote: -Db_coverage is part of the core options of meson because it is not listed in meson_options.txt, no? Documenting the switch is fine, but it seems like we lack contents here. The paragraph describing -Db_coverage links to regress-coverage, still this onl

Re: Adding visual clues that accesskey exists

2023-01-20 Thread Peter Eisentraut
On 18.01.23 22:49, Corey Huinker wrote: Attached is a patch to add the nav- tags to the header (could just as easily have done the footer) for up/down/left/right and the javascript to find those ids and simulate a click. I've tested this on chrome (where accesskeys work with alt+ ) and firefox

Re: Adding visual clues that accesskey exists

2023-01-18 Thread Peter Eisentraut
On 13.01.23 23:07, Corey Huinker wrote: 1. Add static hints to each link, so "Next" becomes "Next [n]". Fairly simple, but visually clumsy, and it might not actually clue the user that they need to hit ALT+n, not just "n". This chrome extension is an example of how it might look https://chrome

Re: Tablespace with multiple locations

2023-01-03 Thread Peter Eisentraut
On 29.12.22 15:29, PG Doc comments form wrote: I m kindly requesting a clarification regarding a debatable subject in one of my projects, that if it's possible to create one global tablespace and assign many locations like the following example: create tablespace TBS1 location ('/pgdata1','/pgda

Re: SQL-standard function bodies and creating SECURITY DEFINER routines securely

2022-09-08 Thread Peter Eisentraut
On 01.09.22 03:11, Bruce Momjian wrote: On Tue, Aug 16, 2022 at 03:38:13PM -0400, Bruce Momjian wrote: On Tue, Aug 16, 2022 at 03:34:22PM -0400, Tom Lane wrote: Bruce Momjian writes: I have written the attached patch to mention this issue about sql_body functions. Spell-check, please. Seem

Re: DocBook 5.2

2022-09-06 Thread Peter Eisentraut
On 05.09.22 11:50, Jürgen Purtz wrote: Therefore, we should consider to introduce another validator. During the migration phase, we have used **jing**. It's Java, it's fast, the error messages are very precise. But there are many others:https://relaxng.org/#validators. Should we possibly provid

Re: [PATCH] doc/queries.sgml: add missing comma

2022-08-24 Thread Peter Eisentraut
On 18.08.22 20:10, Bruce Momjian wrote: Thus: Strictly speaking, this process is iteration, but RECURSIVE is the terminology chosen by the SQL standards committee." Because the above sounds just fine, I'd argue that if one does leave "not recursion" it should be set off by a comma. I went with

Re: proposal: convert comments in documents to html comments

2022-06-29 Thread Peter Eisentraut
On 29.06.22 09:29, Noboru Saito wrote: Comments aren't really associated with anything, so it's difficult to associate them correctly. I think it is better to stop commenting xml (sgml) and format it as follows (tags are tentative). Yeah, with the exception of the release notes, XML comments w

Re: Unclear Wording

2022-06-08 Thread Peter Eisentraut
On 08.06.22 02:15, Bruce Momjian wrote: -you can write a format +you can specify a format string The "format" refers to the earlier synopsis, so that should be changed, too. Or put the "string" outside the element.

Re: Documentation Suggestion

2022-04-29 Thread Peter Eisentraut
On 29.04.22 11:09, Alvaro Herrera wrote: + +Be mindful that arguments to options --auth, +--auth-local, --encoding, +--locale (and all --lc-* options) are +case-sensitive. + Almost all arguments of command-line options of all PostgreSQL tools are case-sensitive. Consider

Re: maximum number of backtrace frames logged by backtrace_functions

2022-03-23 Thread Peter Eisentraut
On 18.02.22 17:05, Fujii Masao wrote: Or even backtrace should be logged by write_stderr() so that it's written to eventlog if necessary? I just wonder why backtrace_symbols_fd() is used only in ExceptionalCondition(). Probably because it was simpler.  It would also make sense to convert the

Re: maximum number of backtrace frames logged by backtrace_functions

2022-02-18 Thread Peter Eisentraut
On 18.02.22 09:24, Fujii Masao wrote: Or even backtrace should be logged by write_stderr() so that it's written to eventlog if necessary? I just wonder why backtrace_symbols_fd() is used only in ExceptionalCondition(). Probably because it was simpler. It would also make sense to convert the

Re: maximum number of backtrace frames logged by backtrace_functions

2022-02-17 Thread Peter Eisentraut
On 07.02.22 17:42, Fujii Masao wrote: On 2022/02/08 1:12, Peter Eisentraut wrote: This change looks good to me.  There is also backtrace code in assert.c that might want the same treatment. Yeah, that's good idea! The attached patch also adds the same treatment into assert.c. I don&#

Re: Does the POSITION() function takes into account the COLLATION... or not ?!?

2022-02-16 Thread Peter Eisentraut
On Wed, Feb 16, 2022 at 12:01 PM Pierre-Aurélien GEORGES < pierre-aurelien.geor...@univ-cotedazur.fr> wrote: > ok, let's take it forwards, then :-) > > Can someone provide some examples where a supported deterministic > collation is having an impact on the result of a call to function > POSITION()

Re: Does the POSITION() function takes into account the COLLATION... or not ?!?

2022-02-16 Thread Peter Eisentraut
On 15.02.22 17:17, PG Doc comments form wrote: Does the POSITION() function pretends taking into account the COLLATION ?? or not ?? - If not, then why the hell is there this error message about nondeterministic collations while the POSITION() doesn't care at all about the COLLATION... - If yes,

Re: maximum number of backtrace frames logged by backtrace_functions

2022-02-07 Thread Peter Eisentraut
On 07.02.22 06:29, Fujii Masao wrote: On 2022/02/03 23:48, Tom Lane wrote: Peter Eisentraut writes: How about we issue a message when the backtrace is cut off.  Then it's immediately visible to the user, instead of hidden away somewhere in the documentation.  Something like this (unt

Re: maximum number of backtrace frames logged by backtrace_functions

2022-02-03 Thread Peter Eisentraut
On 03.02.22 06:33, Fujii Masao wrote: I encountered the "more than 100 backtrace frames" case when investigating the bug of pg_log_query_plan() patch [1]. Since the function that the patch added can be called repeatedly during call to that function, the backtrace became larger than 100. I think

Re: Minor error in calling a python list a tuple

2022-02-02 Thread Peter Eisentraut
On 01.02.22 20:57, PG Doc comments form wrote: The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/13/plpython-data.html Description: Hello, In the link bellow there is the mentioned error. https://www.postgresql.org/docs/13/plpython-data.ht

Re: maximum number of backtrace frames logged by backtrace_functions

2022-02-01 Thread Peter Eisentraut
On 01.02.22 18:04, Fujii Masao wrote: The maximum number of backtrace frames logged by backtrace_functions is 100. Isn't it better to document this information so that users can understand not all backtrace always can be logged? Patch attached. The 100 was chosen as more than you'll ever need.

Re: bad style for SECURITY DEFINER

2021-12-13 Thread Peter Eisentraut
On 13.12.21 01:17, Justin Pryzby wrote: The title of this section looks poor in the first two web browsers I tried. https://www.postgresql.org/docs/current/sql-createfunction.html#id-1.9.3.67.10.2 | Writing SECURITY DEFINER Functions Safely This appears to be a web site styling issue. It looks

Re: ORDER BY in materialized view example?

2021-11-23 Thread Peter Eisentraut
On 23.11.21 07:18, Maciek Sakrejda wrote: An example in the materialized view documentation [1] includes an ORDER BY clause without a clear reason. Does it help build the index more efficiently? I suppose it's also sort of like a CLUSTER? But it seems like the ORDER BY should either be explain

Re: Add link to unicode collation docs

2021-11-09 Thread Peter Eisentraut
On 07.11.21 19:46, PG Doc comments form wrote: The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/14/collation.html Description: This page should include a link to the Collation docs for the Unicode Locale Data Markup Language (LDML). http:

Re: Link t the souce code

2021-07-21 Thread Peter Eisentraut
On 21.07.21 19:21, Alvaro Herrera wrote: On 2021-Jul-21, Peter Eisentraut wrote: On 21.07.21 01:45, Alvaro Herrera wrote: -gunzip postgresql-&version;.tar.gz -tar xf postgresql-&version;.tar +tar xfa postgresql-&version;.tar.gz The "a" option only appli

Re: Link t the souce code

2021-07-21 Thread Peter Eisentraut
On 21.07.21 01:45, Alvaro Herrera wrote: -gunzip postgresql-&version;.tar.gz -tar xf postgresql-&version;.tar +tar xfa postgresql-&version;.tar.gz The "a" option only applies when creating a tar archive ("c" command). So adding it here does nothing.

Re: change float4 to floating point about type of autovacuum_vacuum_insert_scale_factor

2021-06-24 Thread Peter Eisentraut
On 16.06.21 07:22, shinya11.k...@nttdata.com wrote: As shown below, the argument types of autovacuum_vacuum_insert_scale_factor and toast.autovacuum_vacuum_insert_scale_factor are different from the others. --- autovacuum_vacuum_scale_factor, toast.autovacuum_vacuum_scale_factor (floating point

Re: Cities name column name inconsistent

2021-06-24 Thread Peter Eisentraut
On 14.06.21 18:29, Bruce Momjian wrote: On Sat, Jun 12, 2021 at 12:48:25PM -0700, David G. Johnston wrote: On Sat, Jun 12, 2021, 12:28 PG Doc comments form wrote: The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/13/tutorial-f

Re: Has the Update savepoint example outlived its usefulness?

2021-06-24 Thread Peter Eisentraut
On 04.06.21 02:08, David G. Johnston wrote: The example in the update documentation that does an upsert using a savepoint seems like it should just go away now that we have insert...on conflict.  Making an explicit reference (and link) to that feature in the Update documentation should be added

Re: Simplify COMMENT and SECURITY LABEL documentation

2021-06-05 Thread Peter Eisentraut
On 02.06.21 21:32, Alvaro Herrera wrote: On 2021-Jun-02, Peter Eisentraut wrote: On 01.06.21 17:56, Alvaro Herrera wrote: +1 for the concept, but I feel that "live in" is a bit too informal for this context. I'm too caffeine-deprived to instantly come up with le mot juste; but

Re: Simplify COMMENT and SECURITY LABEL documentation

2021-06-02 Thread Peter Eisentraut
On 01.06.21 17:56, Alvaro Herrera wrote: +1 for the concept, but I feel that "live in" is a bit too informal for this context. I'm too caffeine-deprived to instantly come up with le mot juste; but perhaps "exist within" would be an improvement? The glossary uses "reside in". I like that. I

Re: Note that ALTER TABLE cannot alter generated stored columns

2021-06-02 Thread Peter Eisentraut
On 30.05.21 15:25, Emre Hasegeli wrote: I was trying to change the generation expression of a generated stored column using ALTER TABLE. It took me a while before I figured SET GENERATED applies only to generated identity columns. I think it'd be useful to note this in the documentation with so

Simplify COMMENT and SECURITY LABEL documentation

2021-05-31 Thread Peter Eisentraut
there is any doubt. Patch attached. Thoughts? From d5072256b1faabe516eb58990d6f89fa1a3bdd9f Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Tue, 1 Jun 2021 08:50:40 +0200 Subject: [PATCH] doc: Simplify COMMENT and SECURITY LABEL documentation Just say that objects that live in schemas can be

Re: "there is no way to insert less than one row"

2021-04-07 Thread Peter Eisentraut
On 25.03.21 00:55, Alvaro Herrera wrote: : When a table is created, it contains no data. The first thing to do : before a database can be of much use is to insert data. Data is : inserted one row at a time. Of course you can also insert : more than one row in a single command, but it is not possi

Re: Update to reflect that TLS1 and TLSv1.1 are now deprecated

2021-03-24 Thread Peter Eisentraut
On 24.03.21 10:49, Daniel Gustafsson wrote: The recently published RFC 8996 deprecates the use of TLSv1 and TLSv1.1, the attached rewords where we say our default of 1.2 is industry best practice with a link to the authoritative source. The "industry best practices" the original text refers to

Re: "there is no way to insert less than one row"

2021-03-24 Thread Peter Eisentraut
On 20.03.21 20:16, PG Doc comments form wrote: So, the last insert command inserted zero rows. What is meant by "there is no way to insert less than one row"? I think the point was that you can't insert partial rows.

Re: Additional Chapter for Tutorial

2020-09-10 Thread Peter Eisentraut
On 2020-09-02 09:04, Jürgen Purtz wrote: On 01.09.20 23:30, Peter Eisentraut wrote: It is mostly advanced low-level information that is irrelevant for someone starting up, That applies only to the VACUUM chapter. VACUUM and AUTOVACUUM are controlled by a lot of parameters. Therefor the current

Re: Change JOIN tutorial to focus more on explicit joins

2020-09-03 Thread Peter Eisentraut
uld imply that one of them is unprofessional and then leave it at that and give no further guidance. I think we should leave this out. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Additional Chapter for Tutorial

2020-09-01 Thread Peter Eisentraut
ained elsewhere. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Procedures

2020-08-25 Thread Peter Eisentraut
Often people read this and then wonder why it doesn't work. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Signed-ness of ints is unclear in FE-BE protocol docs

2020-06-11 Thread Peter Eisentraut
hange the documentation to unsigned. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Adding xreflable

2020-06-04 Thread Peter Eisentraut
sect1, which by default creates text like "Section 23.2", which perhaps someone wanted to override. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Adding xreflable

2020-06-04 Thread Peter Eisentraut
xamples of all three of those points. Generally, xreflabels are a bit of antipattern IMO, so there need to be solid arguments in favor of adding more. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Adding xreflable

2020-05-26 Thread Peter Eisentraut
Which is basically what it was before, IIRC. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Adding xreflable

2020-05-22 Thread Peter Eisentraut
now do see and which are both sect2s in the same chapter, then you get a rendered text of see Section 24.1.1 and autovacuum which is bizarre. If you want the link appearance to change only in the release notes, then the right approach is to use the tag, as was done before.

Re: Add A Glossary

2020-05-19 Thread Peter Eisentraut
On 2020-05-19 08:17, Laurenz Albe wrote: The term "cluster" is unfortunate, because to most people it suggests a group of machines, so the term "instance" is better, but that ship has sailed long ago. I don't see what would stop us from renaming some things,

Re: Rendering pi more nicely in PDF

2020-04-29 Thread Peter Eisentraut
s embedded into the built PDF. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Additional Chapter for Tutorial

2020-04-29 Thread Peter Eisentraut
into the tutorial. The tutorial should be hands-on, how do you get started, how do you get some results. Your material is more of an overview of the whole system. What's a new user supposed to do with that? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL De

Re: Documentation: 21.5. Default Roles

2020-04-29 Thread Peter Eisentraut
shipped with the name as it did, and users know it as such. If we start retroactively renaming all functionality when we change our mind, it will create complete madness. New ideas belong into the master branch. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development

  1   2   3   >