Re: Second paragraph a little bit misleading

2025-02-21 Thread Bruce Momjian
On Fri, Feb 21, 2025 at 01:42:09PM +0100, Laurenz Albe wrote: > On Fri, 2025-02-21 at 07:00 -0500, Bruce Momjian wrote: > > > > diff --git a/doc/src/sgml/wal.sgml b/doc/src/sgml/wal.sgml > > > > index 52b5b8f793b..705ca682777 100644 > > > > --- a/doc/src/s

Re: Second paragraph a little bit misleading

2025-02-21 Thread Bruce Momjian
On Fri, Feb 21, 2025 at 08:25:56AM +0100, Laurenz Albe wrote: > On Thu, 2025-02-20 at 11:38 -0500, Bruce Momjian wrote: > > On Tue, Feb 11, 2025 at 02:00:10PM +, PG Doc comments form wrote: > > > Page: https://www.postgresql.org/docs/17/checksums.html > > > &

Re: Second paragraph a little bit misleading

2025-02-20 Thread Bruce Momjian
x27;s recommended to > enable Checksums when initializing a cluster using initdb". I can see your point. Attached is a doc patch that improves it. I chose very simple language and plan to backpatch this to all supported versions. -- Bruce Momjian https://momjian.us EDB

Re: Formal Syntax of PL/pgSQL

2024-12-05 Thread Bruce Momjian
ng and manipulation of PL/pgSQL code. I doubt it since no one has ever asked for this before, and we usually tell them to look at the plpgsql parser if they want those details. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Do not let urgent matters crowd out time for investment in the future.

Re: Logical replication - initial data synchronization

2024-11-21 Thread Bruce Momjian
On Thu, Oct 31, 2024 at 06:52:34PM -0400, Bruce Momjian wrote: > On Fri, Nov 1, 2024 at 09:07:38AM +1100, Peter Smith wrote: > > On Fri, Nov 1, 2024 at 2:16 AM Bruce Momjian wrote: > > > > > > On Fri, Oct 25, 2024 at 11:48:16PM +0200, Koen De Groote wrote: > >

Re: wal_compression = on: what is the algorithm?

2024-11-20 Thread Bruce Momjian
4) and zstd (if PostgreSQL was compiled with --with-zstd). The > default value is off. The value on is synonym of pglz.” I think we kept 'on' just for backward compatibility, so we don't mention it in the docs anymore. -- Bruce Momjian https://momjian.us EDB

Re: fir for row level security

2024-11-18 Thread Bruce Momjian
On Fri, Nov 1, 2024 at 10:23:25AM -0400, Bruce Momjian wrote: > On Fri, Nov 1, 2024 at 11:04:53AM +, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > > > Page: https://www.postgresql.org/docs/16/ddl-rowsecurity

Re: A minor bug in doc. Hovering over heading shows # besides it.

2024-11-18 Thread Bruce Momjian
en made? I still see "#": https://www.postgresql.org/docs/devel/tutorial-arch.html I am actually fine with "#" since that is the symbol that will be added to the URL. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com When a patient asks the doctor, "Am I going to die?", he means "Am I going to die soon?"

Re: pgsql: doc: improve build for non-Latin1 characters

2024-11-04 Thread Bruce Momjian
't know how to test if they are working properly or not. I assume ASCII double quotes do work. I am thinking Tatsuo's idea of using iconv to check files with any non-ASCII characters is a better approach and will reply to that thread. -- Bruce Momjian https://momjian.us EDB

Re: (Very minor) Link towards the 'bug-submission' web form

2024-11-04 Thread Bruce Momjian
On Thu, Oct 31, 2024 at 03:24:06PM -0400, Bruce Momjian wrote: > On Mon, Oct 21, 2024 at 02:01:37AM +, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > > > Page: https://www.postgresql.org/docs/17/bug-reporting

Re: Mistake in statement example

2024-11-01 Thread Bruce Momjian
On Wed, Sep 27, 2023 at 07:23:09PM -0400, Bruce Momjian wrote: > On Wed, Mar 1, 2023 at 09:45:00AM -0700, David G. Johnston wrote: > > That may be, but the descriptive text and point of the example (which isn't > > atomicity, but concurrency) doesn't even require the seco

Re: MERGE examples not clear

2024-11-01 Thread Bruce Momjian
On Wed, Sep 27, 2023 at 07:42:42PM -0400, Bruce Momjian wrote: > On Tue, Feb 21, 2023 at 08:56:50AM -0700, David G. Johnston wrote: > > On Tue, Feb 21, 2023 at 8:35 AM PG Doc comments form > > > > wrote: > > > > The following documentation comme

Re: Add mention to related system catalog functions on Tablespaces documentation pages.

2024-11-01 Thread Bruce Momjian
On Mon, Oct 14, 2024 at 07:21:32PM -0400, Bruce Momjian wrote: > On Mon, Oct 14, 2024 at 07:15:50PM -0400, Bruce Momjian wrote: > > On Wed, Sep 11, 2024 at 11:26:50PM +, PG Doc comments form wrote: > > Yes, very good points. I have developed the attached patch which I > &g

Re: incorrect (incomplete) description for "alter domain"

2024-11-01 Thread Bruce Momjian
On Wed, Oct 16, 2024 at 05:11:54PM -0400, Bruce Momjian wrote: > > Actually, there *is* a bug in the description, because experimentation > > shows that CREATE DOMAIN accepts NULL in this syntax (as advertised) > > but ALTER DOMAIN does not. We could alternatively decide that

Re: Documentation of .pgpass for Unix is incomplete

2024-11-01 Thread Bruce Momjian
db5ff434c9c3 > > > > Is it worth going into that detail in the docs? > > Yes definitely. This not being properly documented caused me hours of work… Patch applied, thanks. -- Bruce Momjian https://momjian.us EDB https://enterp

Re: Connection Info

2024-11-01 Thread Bruce Momjian
On Wed, Oct 16, 2024 at 09:36:00PM -0400, Bruce Momjian wrote: > On Mon, May 6, 2024 at 04:15:24PM +0200, Laurenz Albe wrote: > > On Sun, 2024-05-05 at 20:25 +, PG Doc comments form wrote: > > > On this page: > > > https://www.postgresql.org/docs/14/server-s

Re: fir for row level security

2024-11-01 Thread Bruce Momjian
s "this is". May be better "The default behaviour is > similar..." I see your point. Attached is a patch which clarifies this. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com When a patient asks the doctor, &q

Re: PostgreSQL limits

2024-11-01 Thread Bruce Momjian
tement length that > PostgreSQL can handle > in the Appendix K. PostgreSQL Limits. > If I'm not wrong it is 2147483648 that is a quite large number, larger than > many other RDBMS. Uh, we can add it, but we try to only list limits that are likely to be exceeded. -- Bruce Momjia

Re: Logical replication - initial data synchronization

2024-10-31 Thread Bruce Momjian
On Fri, Nov 1, 2024 at 09:07:38AM +1100, Peter Smith wrote: > On Fri, Nov 1, 2024 at 2:16 AM Bruce Momjian wrote: > > > > On Fri, Oct 25, 2024 at 11:48:16PM +0200, Koen De Groote wrote: > > > Number 2 would be perfect, I think. It leaves no doubt at all. > > &g

Re: (Very minor) Link towards the 'bug-submission' web form

2024-10-31 Thread Bruce Momjian
d is to fill in the bug > report web-form available at the project's web site.", where "web site" is a > link: https://www.postgresql.org/ > > Suggestion: it should be a link to the web form ( > https://www.postgresql.org/account/submitbug/ ) Good idea, patch

Re: Logical replication - initial data synchronization

2024-10-31 Thread Bruce Momjian
On Fri, Oct 25, 2024 at 11:48:16PM +0200, Koen De Groote wrote: > Number 2 would be perfect, I think. It leaves no doubt at all. I went with even more direct wording, patch attached. Glad we could improve this together --- the feedback from everyone was helpful. -- Bruce Momj

Re: Logical replication - initial data synchronization

2024-10-17 Thread Bruce Momjian
rify that. > > It's the reason I created this mail: I would like it stated explicitly that > the > database process takes care of this for us. Well, you are the first person to report this confusion, and we can't go around explaining what Postgres does and does not do in each

Re: Logical replication - initial data synchronization

2024-10-17 Thread Bruce Momjian
had me confused early on, wondering if I had to perform the > copy once the snapshot was ready. Updated patch attached. I tried to tighten up the wording and add more detail. I didn't see the point in repeating the same paragraph later on so I removed it. -- Bruce Momjian h

Re: Connection Info

2024-10-16 Thread Bruce Momjian
> > Perhaps it should say: > > A common mistake is to forget to configure "listen_addresses" so that the > server accepts remote TCP connections. > > Then "listen_addresses" could hyperlink to the parameter's documentation. Agreed, patch attached. --

Re: Logical replication - initial data synchronization

2024-10-16 Thread Bruce Momjian
itself. > > Am I missing something extremely simple, or can the description of the > involved operations be made more consistent across documentation pages? Is the attached patch an improvement? -- Bruce Momjian https://momjian.us EDB h

Re: A minor bug in doc. Hovering over heading shows # besides it.

2024-10-16 Thread Bruce Momjian
visibility: hidden; > + text-decoration: none; > +} > + > +a.id_link:hover:after { > + content: "Pemalink to this heading"; > + font-size: 10px; > + font-weight: normal; > + text-decoration: none; > + border: 1px solid #44; >

Re: Undocumented optionality of handler_statements

2024-10-16 Thread Bruce Momjian
at it > is helpful to show this pattern as well. So if I were to do something > about that, I would suggest the attached. Do we want to apply this patch? I added a comma to the text, attached. -- Bruce Momjian https://momjian.us EDB https://

Re: incorrect (incomplete) description for "alter domain"

2024-10-16 Thread Bruce Momjian
; > [ CONSTRAINT constraint_name ] > { NOT NULL | CHECK (expression) } > > to the ALTER DOMAIN page, and then remove the claim that it's > identical to CREATE DOMAIN. I have written the attached patch to document this. I assume this should be backpatched to PG 12.

Re: Documentation of .pgpass for Unix is incomplete

2024-10-16 Thread Bruce Momjian
On Mon, Aug 19, 2024 at 05:42:33PM -0700, David G. Johnston wrote: > On Mon, Aug 19, 2024 at 5:06 PM Bruce Momjian wrote: > Well, it is more complicated than checking just HOME because it calls > getpwuid_r() if HOME is not set: > >         https://doxygen.po

Re: Add mention to related system catalog functions on Tablespaces documentation pages.

2024-10-14 Thread Bruce Momjian
On Mon, Oct 14, 2024 at 07:15:50PM -0400, Bruce Momjian wrote: > On Wed, Sep 11, 2024 at 11:26:50PM +, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > > > Page: https://www.postgresql.org/docs/16/manag

Re: Add mention to related system catalog functions on Tablespaces documentation pages.

2024-10-14 Thread Bruce Momjian
example to > the one that is currently shown. Yes, very good points. I have developed the attached patch which I think achieves the goals you mentioned. I plan to apply the patch for master/PG 18. I also removed the unnecessary mention of PG 9.1. Seems the reply email address is g***@gm

Re: Streaming Replication vs Logical

2024-10-12 Thread Bruce Momjian
ol". > > This is confusing, and I am also sometimes confused in the way you described > above. > > I think the mess is too well established to be really cleaned up. But adding > some clarity is a good thing, so +1. I don't think our current setup is sustainable so I

Re: 15.7 and 16.3 release notes are exactly the same on postgresql.org

2024-09-19 Thread Bruce Momjian
s avoids putting redundant entries into the generated postgresql.conf file. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com When a patient asks the doctor, "Am I going to die?", he means "Am I going to die soon?"

Re: Documentation of .pgpass for Unix is incomplete

2024-08-19 Thread Bruce Momjian
ct_8c.html#a3f49cbb20595c1765bd0db5ff434c9c3 Is it worth going into that detail in the docs? -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: Managing SSL Connections

2024-08-19 Thread Bruce Momjian
u? https://momjian.us/main/blogs/pgblog/2020.html#July_17_2020 -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: add 'from the command line' to tutorial-createdb.html

2024-08-19 Thread Bruce Momjian
"To create a new database from the command line, in this example named > mydb, you use the following command:" Yes, good idea, patch applied to master, so it will appear in PG 18. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: pg_createsubscriber clarification

2024-08-19 Thread Bruce Momjian
criber is > the > - initial data copy. It does only the synchronization phase, which ensures > - each table is brought up to a synchronized state. > + replication setup and pg_createsubscriber is > how > + the data synchronization is done. > pg_createsubscriber > + does

Re: Change detail text in last example of 43.5.3. Executing a Command with a Single-Row Result

2024-08-16 Thread Bruce Momjian
arameters: username = 'nosuchuser' Wow, this error goes all the way back to Postgres 12, which is our earliest supported release. I have patched all our supported releases with this fix. Thanks. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

pg_createsubscriber clarification

2024-07-28 Thread Bruce Momjian
Seems this needs improvement. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: Need clarification on "field"

2024-06-05 Thread Bruce Momjian
e PostgreSQL term would be "attribute". Perhaps we should use that. > Alternatively, what about "column value"? It is perhaps not accurate, > because a Datum need not be stored in a column, but it might be readily > understandable.

Re: psql option

2024-04-09 Thread Bruce Momjian
/current/app-psql.html > > > > > > Nice catch, will fix. > > Committed, turns out the stray comma has been there since 7.3, so backpatched > it all the way. Thanks for the report! Yikes! :-) -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: CREATE ROLE

2024-03-27 Thread Bruce Momjian
in the attached patch, applied back to PG 16 where this typo was created. Thanks for the report. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you. diff --git a/doc/src/sgml/ref/create_

Re: substring start position behavior

2024-03-26 Thread Bruce Momjian
On Tue, Mar 26, 2024 at 11:07:07AM -0400, Bruce Momjian wrote: > On Wed, Mar 6, 2024 at 12:42:09AM -0500, Tom Lane wrote: > > I'm kind of inclined to not document this weirdness. I especially > > don't think it's worth giving an example that neither explains

Re: substring start position behavior

2024-03-26 Thread Bruce Momjian
. I retract my doc patch for this. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: Minor typo in Section, 27.2.8.4.

2024-03-11 Thread Bruce Momjian
sing the word "the" > as shown below .. > "Such transaction commits may never be completed if any one of THE > synchronous standbys should crash." Agreed, word "the" added to all supported versions. -- Bruce Momjian https://momjian.us EDB

Re: substring start position behavior

2024-03-05 Thread Bruce Momjian
r than 0-indexed. Sure, updated patch attached. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you. diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml index e5fa82c161..f9817

Re: substring start position behavior

2024-03-05 Thread Bruce Momjian
rvers/14.10?topic=smf-substr-function Oracle doesn't have substring(), just substr(), and matches Informix behavior, I think. I have developed the attached doc patch to document this. The only question is whether this substring behavior is so odd that we should not document it. -- Br

Re: CREATE ROLE inheritance details

2024-02-01 Thread Bruce Momjian
in the PG 16 minor release which will be packaged on Monday. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: CREATE ROLE inheritance details

2024-01-29 Thread Bruce Momjian
On Sun, Jan 28, 2024 at 10:11:18AM -0700, David G. Johnston wrote: > On Fri, Jan 26, 2024 at 5:18 PM Bruce Momjian wrote: >   > +        Role membership with the inherit attribute can automatically use > +        whatever database privileges have been granted to all roles it &

Re: CREATE ROLE inheritance details

2024-01-26 Thread Bruce Momjian
fferent way. Patch attached. I also found we didn't document that GRANT can be used to modify a membership's attributes even after it is created; I added that. Just a reminder, this is for PG 16 and master. -- Bruce Momjian https://momjian.us EDB

Re: CREATE ROLE inheritance details

2024-01-17 Thread Bruce Momjian
On Wed, Jan 17, 2024 at 09:28:38AM +0100, Laurenz Albe wrote: > On Tue, 2024-01-16 at 17:03 -0500, Bruce Momjian wrote: > > I am unhappy with the documentation adjustments made to CREATE ROLE in > > Postgres 16 by this commit: > > > > commit e3ce2de09d > >

CREATE ROLE inheritance details

2024-01-16 Thread Bruce Momjian
e-add this information, and clarify it. I would like to apply this to PG 16 and master. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you. test_inh.sh Description: Bourne shell script te

Re: initdb username doc bug

2024-01-10 Thread Bruce Momjian
On Wed, Jan 10, 2024 at 06:05:17PM +0100, Álvaro Herrera wrote: > On 2024-Jan-10, Bruce Momjian wrote: > > > On Mon, Jan 8, 2024 at 04:50:19PM -0500, Tom Lane wrote: > > > Bruce Momjian writes: > > > > Agreed, updated patch attached. > > > > > &g

Re: initdb username doc bug

2024-01-10 Thread Bruce Momjian
On Mon, Jan 8, 2024 at 04:50:19PM -0500, Tom Lane wrote: > Bruce Momjian writes: > > Agreed, updated patch attached. > > WFM. Patch applied back to PG 16, which is where the erroneous text was added. -- Bruce Momjian https://m

Re: initdb username doc bug

2024-01-08 Thread Bruce Momjian
b anyway. > > Or if you want a few more words, "name of the operating-system user > running initdb". I don't like "installation user", that's just about > as vague as could be. Agreed, updated patch attached. -- Bruce Momjian https://momji

Re: initdb username doc bug

2024-01-06 Thread Bruce Momjian
On Sat, Jan 6, 2024 at 08:11:14PM -0700, David G. Johnston wrote: > On Saturday, January 6, 2024, Bruce Momjian wrote: > > This commit: > >         commit 910cab820d >         Author: Alvaro Herrera >         Date:   Fri Nov 18 11:59:26 2022 +0100 >

initdb username doc bug

2024-01-06 Thread Bruce Momjian
cluster owner. This seems wrong since the cluster owner doesn't exist until the cluster is created. The text exists in PG 16 and master. The attached patch fixes this. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Onl

Re: [DOCS] Add example about date ISO format

2023-12-26 Thread Bruce Momjian
On Thu, Dec 7, 2023 at 02:18:28PM -0500, Bruce Momjian wrote: > Yes, there were a few problems with my initial patch. First, I should > have used "Z" instead of a Z which could be interpreted as a format > specification; I had already done that for "T" in the exampl

Re: unclear wording re: spoofing prevention on network connections

2023-12-09 Thread Bruce Momjian
d for some time. ... I have CC'ed the patch author. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: [DOCS] Confusing Trigger Docs.

2023-12-07 Thread Bruce Momjian
On Sun, Nov 26, 2023 at 08:59:02PM +0100, Laurenz Albe wrote: > On Fri, 2023-11-24 at 13:14 -0500, Bruce Momjian wrote: > > On Thu, Nov 23, 2023 at 08:36:34AM +0100, Laurenz Albe wrote: > > > On Wed, 2023-11-22 at 14:49 -0800, Peter Geoghegan wrote: > > > > I don'

Re: SELECT ... FOR UPDATE OF clause documentation implies use of table_names rather than aliases

2023-12-07 Thread Bruce Momjian
On Mon, Nov 20, 2023 at 08:20:57PM -0700, David G. Johnston wrote: > On Mon, Nov 20, 2023 at 8:16 PM Bruce Momjian wrote: > > On Mon, Nov 20, 2023 at 07:19:39PM -0700, David G. Johnston wrote: > > The placement in the numbered listing section feels wrong, I am OK with >

Re: [DOCS] intagg.sgml: example wrongly named and does not compile

2023-12-07 Thread Bruce Momjian
On Wed, Nov 22, 2023 at 10:19:57AM +0100, Laurenz Albe wrote: > On Tue, 2023-11-21 at 22:27 -0500, Bruce Momjian wrote: > > I like this six year old patch so would like to apply it to master, > > attached. > > +1, since it is arguably a bug fix. Patch applied to master.

Re: [DOCS] Add example about date ISO format

2023-12-07 Thread Bruce Momjian
y to get the time zone _name_ or even the offset from the AT TIME ZONE value, so we must just pass the literal "Z" from the input to the output. This proves Alvaro's point on this issue: SELECT pg_typeof(current_timestamp AT TIME ZONE 'America/Santiago');

Re: [DOCS] Rewording for ALTER TABLE ... ADD table_constraint_using_index

2023-11-24 Thread Bruce Momjian
are of. > I > like "convert" slightly better instead. Nine year old patch, but still valid, so applied to master. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: [DOCS] Confusing Trigger Docs.

2023-11-24 Thread Bruce Momjian
tgreSQL knowledge, like me. I moved the parition pagagraph to a more logical location and tried to clarify the new paragraph to be more targeted on the goal, patch attached. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only

Re: [DOCS] Add example about date ISO format

2023-11-24 Thread Bruce Momjian
On Thu, Nov 23, 2023 at 09:29:39AM +0100, Laurenz Albe wrote: > On Wed, 2023-11-22 at 11:58 -0500, Bruce Momjian wrote: > > Okay, I moved it into the "Note" section that talked about ISO 8601 > > output with "T", in the attached patch. > > Fine by me, exc

Re: [DOCS] Double negation in parameter description

2023-11-22 Thread Bruce Momjian
: > > "This option may only be used on a populated materialized view."? > > Your clarification is much appreciated. I know this is six years old, but fixed in master with the attached patch. -- Bruce Momjian https://momjian.us EDB

Re: [DOCS] Confusing Trigger Docs.

2023-11-22 Thread Bruce Momjian
ce those effects may have contributed to the row being excluded from insertion. I modified the attached patch to explain this since it is not really the same as modifying the actual row. Does that add any value? If not, let's remove it. -- Bruce Momjian https://mo

Re: [DOCS] Add example about date ISO format

2023-11-22 Thread Bruce Momjian
r Examples". I originally thought it belonged in section 9.8 too, but I think the value of this example is ISO 8601 and I don't see how we can cleanly mention that in table 9.31. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: [DOCS] Add example about date ISO format

2023-11-22 Thread Bruce Momjian
gml around line 2552. > > +1 for moving it to section 8.5.2. Okay, I moved it into the "Note" section that talked about ISO 8601 output with "T", in the attached patch. I will apply this only to master since it is not a correction. -- Bruce Momjian

Re: [DOCS] Add example about date ISO format

2023-11-21 Thread Bruce Momjian
developed the attached patch I would like to apply to master. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you. diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml inde

Re: [DOCS] intagg.sgml: example wrongly named and does not compile

2023-11-21 Thread Bruce Momjian
t;> reserved words. > > Ouch. Shows you how old this module is :-( > > Indeed. > > >> I propose the attached patch to fix that. > > Um, the attached file seems empty from here. > > Ooops, sorry. It is attached. I like this six year old patch so would l

Re: [DOCS] The reference to 'atacontrol' on FreeBSD is outdated.

2023-11-21 Thread Bruce Momjian
On Wed, Nov 22, 2023 at 03:25:07PM +1300, Thomas Munro wrote: > On Wed, Nov 22, 2023 at 2:12 PM Bruce Momjian wrote: > > On Sat, Aug 12, 2017 at 10:47:00PM +0100, John Ekins wrote: > > > Sure. Camcontrol does indeed cover IDE, SCSI and SAS drives. > > > > > >

Re: [DOCS] Confusing Trigger Docs.

2023-11-21 Thread Bruce Momjian
On Thu, Aug 31, 2017 at 09:22:22AM -0700, Peter Geoghegan wrote: > On Thu, Aug 31, 2017 at 6:25 AM, Bruce Momjian wrote: > > On Mon, Jul 3, 2017 at 08:07:10PM +, n...@fairwindsoft.com wrote: > >> The following documentation comment has been logged on the website: >

Re: [DOCS] The reference to 'atacontrol' on FreeBSD is outdated.

2023-11-21 Thread Bruce Momjian
Support Enabled Value Vendor > write cacheyes yes > > I appreciate the Postgresql docs are not meant to be FreeBSD tutorials. I know this email is six years old, but I have applied this fix to all supported Postgres versions. A huge apology

Re: Documentation of FOR ROLE clause of ALTER DEFAULT PRIVILEGES missing

2023-11-21 Thread Bruce Momjian
/sql-alterdefaultprivileges.html We felt the doc rewrite was too extensive to backpatch. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: SELECT ... FOR UPDATE OF clause documentation implies use of table_names rather than aliases

2023-11-20 Thread Bruce Momjian
;FOR UPDATE" so I missed that section; updated patch attached. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you. diff --git a/doc/src/sgml/ref/select.sgml b/doc/src/sgml/ref/selec

Re: SELECT ... FOR UPDATE OF clause documentation implies use of table_names rather than aliases

2023-11-20 Thread Bruce Momjian
(i.e., an unaliased table name or an alias in the sibling FROM > clause attached to this level of the query).  I like this better anyway on the > grounds that the thing being referenced can be a subquery or a view as well as > a table. Okay, how is the attached patch?

Re: SELECT ... FOR UPDATE OF clause documentation implies use of table_names rather than aliases

2023-11-17 Thread Bruce Momjian
x | x ---+--- SELECT * FROM test AS t1 JOIN test AS t2 ON (TRUE) FOR UPDATE OF t2; x | x ---+--- The attached patch documents this. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.co

Re: Missing documentation for FETCH FIRST in chapter 7.6

2023-11-17 Thread Bruce Momjian
link to the LIMIT > section in the SELECT reference page. I also renamed the "number" > variables to the same names used in the SELECT reference page and put > OFFSET in a new line (it looks visually better). I applied the attached patch based on your p

Re: Documentation of return values of range functions lower and upper

2023-11-13 Thread Bruce Momjian
On Thu, Nov 2, 2023 at 06:22:59PM -0400, Bruce Momjian wrote: > On Thu, Nov 2, 2023 at 03:42:53PM +0100, Laurenz Albe wrote: > > On Thu, 2023-11-02 at 10:14 -0400, Bruce Momjian wrote: > > > Better, though "Is the range's upper bound unbounded?" makes me cring

Re: 'pg_global' cannot be used as default_tablespace.

2023-11-13 Thread Bruce Momjian
On Thu, Nov 2, 2023 at 11:08:53AM -0400, Bruce Momjian wrote: > On Thu, Nov 2, 2023 at 09:58:54AM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > I found a cleaner improvement, attached. > > > > OK by me. Maybe that doesn't make the point strong

Re: Typo in documentation - runtime-config-wal

2023-11-09 Thread Bruce Momjian
is this correction accurate? It seems so to me. After flushing WAL the writer sleeps for the length of time given by wal_writer_delay, unless woken up sooner --> by an asynchronously committing transaction. -- Bruce Momjian https://momjian.us EDB

Re: WAL Configuration Grammar Fix

2023-11-09 Thread Bruce Momjian
This patch is 4.5 years old, but still valid. Fixed with the attached patch applied to master. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you. diff --git a/doc/src/sgml/wal.sgml

Re: User mapping security

2023-11-09 Thread Bruce Momjian
On Thu, Nov 9, 2023 at 05:03:33PM -0500, Tom Lane wrote: > Bruce Momjian writes: > > On Tue, Jul 16, 2019 at 02:01:00AM +, PG Doc comments form wrote: > >> I suppose it should be warned on the pages that foreign credentials with be > >> stored as simple text and wi

Re: User mapping security

2023-11-09 Thread Bruce Momjian
know this is four years old, but the attached patch documents it. I don't think postgresql-fdw needs it since it relies on user mapping and discourages passwords in the connection string. -- Bruce Momjian https://momjian.us EDB https://e

Re: readability changes to postgres.sgml

2023-11-08 Thread Bruce Momjian
his patch. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: Required locks for ANALYZE

2023-11-08 Thread Bruce Momjian
t; > parallel with non-DDL activity on the table. I know this report is four years old, but attached patch applied to master. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: Usage instructions for pg_hba.conf file

2023-11-03 Thread Bruce Momjian
On Sat, Oct 28, 2023 at 04:04:47PM -0400, Bruce Momjian wrote: > On Tue, Aug 2, 2022 at 08:08:07PM +, PG Doc comments form wrote: > > 21.1.1 Loading or Reloading the Configuration > > The pg_hba.conf file is read on start-up... > > Note: The preceding statement...

Re: "22.3. Template Databases" documentation is incomplete

2023-11-03 Thread Bruce Momjian
On Sat, Oct 28, 2023 at 03:14:32PM -0400, Bruce Momjian wrote: > On Sat, Oct 28, 2023 at 02:42:06PM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > Sorry, I attached a _colorized_ diff; here is a normal one. > > > > The new sentence is fine in isolation, bu

Re: Incorrect mention of number of columns?

2023-11-03 Thread Bruce Momjian
ugh to be useful. > > I am not speaking about a warning at creation time, but rather a warning in > the > docs. Something like: Although a table with e.g. 1600 bigint columns can be > created, creating a tuple of more than 8160 bytes will fail. It is in the "limits" docs:

Re: Document target_role param of ALTER DEFAULT PRIVILEGES

2023-11-03 Thread Bruce Momjian
On Thu, Nov 2, 2023 at 09:51:58PM -0400, Bruce Momjian wrote: > On Wed, Nov 1, 2023 at 09:31:52PM +0100, Laurenz Albe wrote: > > There is another patch in the current commitfest that addresses a similar > > problem, triggered by another complaint: > > https://commitfest.p

Re: Document target_role param of ALTER DEFAULT PRIVILEGES

2023-11-02 Thread Bruce Momjian
On Wed, Nov 1, 2023 at 09:31:52PM +0100, Laurenz Albe wrote: > On Wed, 2023-11-01 at 13:09 -0400, Bruce Momjian wrote: > > On Thu, Feb 18, 2021 at 08:16:13AM +0100, Laurenz Albe wrote: > > > On Wed, 2021-02-17 at 15:08 -0500, Jordi Gutiérrez Hermoso wrote: > > > >

Re: Documentation of return values of range functions lower and upper

2023-11-02 Thread Bruce Momjian
On Thu, Nov 2, 2023 at 03:42:53PM +0100, Laurenz Albe wrote: > On Thu, 2023-11-02 at 10:14 -0400, Bruce Momjian wrote: > > Better, though "Is the range's upper bound unbounded?" makes me cringe. > > > > Oh, yeah, totally cringe, me too.  :-) > > > &

Re: 'pg_global' cannot be used as default_tablespace.

2023-11-02 Thread Bruce Momjian
On Thu, Nov 2, 2023 at 09:58:54AM -0400, Tom Lane wrote: > Bruce Momjian writes: > > I found a cleaner improvement, attached. > > OK by me. Maybe that doesn't make the point strongly enough, > but we can hope it's enough. Agreed. I thought last night about the s

Re: Documentation of return values of range functions lower and upper

2023-11-02 Thread Bruce Momjian
On Thu, Nov 2, 2023 at 08:56:13AM +0100, Laurenz Albe wrote: > On Wed, 2023-11-01 at 18:03 -0400, Bruce Momjian wrote: > > On Wed, Nov 1, 2023 at 09:40:43PM +0100, Laurenz Albe wrote: > > > > Yes, I agree this documentation needs help. > > > > > > >

Re: 'pg_global' cannot be used as default_tablespace.

2023-11-02 Thread Bruce Momjian
On Wed, Nov 1, 2023 at 07:34:59PM -0400, Bruce Momjian wrote: > On Wed, Nov 1, 2023 at 07:12:48PM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > On Wed, Nov 1, 2023 at 06:32:37PM -0400, Tom Lane wrote: > > >> But it *is* permissible, unless we add code to

Re: 'pg_global' cannot be used as default_tablespace.

2023-11-01 Thread Bruce Momjian
On Wed, Nov 1, 2023 at 07:12:48PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > On Wed, Nov 1, 2023 at 06:32:37PM -0400, Tom Lane wrote: > >> But it *is* permissible, unless we add code to reject it during > >> SET as Bruce mentioned. Which seems fairly

Re: 'pg_global' cannot be used as default_tablespace.

2023-11-01 Thread Bruce Momjian
On Wed, Nov 1, 2023 at 06:32:37PM -0400, Tom Lane wrote: > "David G. Johnston" writes: > > On Wednesday, November 1, 2023, Bruce Momjian wrote: > >> Did you want an error from the SET command? > > > That would probably be a decent addition but the req

Re: 'pg_global' cannot be used as default_tablespace.

2023-11-01 Thread Bruce Momjian
years old, but I am now looking at this email can can't see the problem: SET default_tablespace = 'pg_global'; CREATE TABLE test (x int); ERROR: only shared relations can be placed in pg_global tablespace Did you want an error from the SET command? -- Bru

  1   2   3   4   5   6   7   8   >