> >
> > IIUC the two_phase field is also not copied from the source slot. I
> > think we can clarify in the doc that these two fields are not copied.
> >
+1.
--
With Regards,
Amit Kapila.
7;t have a main slot terminology at
other places, so it would be better not to introduce a new one. I know
that it was introduced in the original commit but it seems better to
change if we agree.
--
With Regards,
Amit Kapila.
ds to be run only once
> on *any* database to get combined results of all main slots while
> pg_subscription_rel query needs to be run on each database having
> concerned subscription (and table), does it makes sense to separate
> the 2 queries instead of having UNION ? Thoughts?
>
I think so
small
> > patch to fix it.
>
> The patch looks good to me except there is repetition of commands in
> both the lines now. But I could not think of a better way. So I think
> it is okay to have this way.
>
Thanks for the review. I also couldn't think of a better way to
document this information. The patch as proposed looks good to me.
--
With Regards,
Amit Kapila.
On Fri, Jun 7, 2024 at 3:23 PM Koen De Groote wrote:
>
> Yes, this change is clear to me that the "columns added" applies to the table
> on the publisher.
>
Thanks for the confirmation. I have pushed and backpatched the fix.
--
With Regards,
Amit Kapila.
On Tue, Jun 4, 2024 at 11:26 AM Amit Kapila wrote:
>
> >
> > IIUC you're saying my v1 patch *content* and rendering is OK, but you
> > only wanted the SGML text to have better wrapping for < 80 chars
> > lines. So I have attached a patch v2 with improved w
cally
> > + If no column list is specified, any columns added to the table
> > later are automatically
> > replicated. This means that having a column list which names all columns
>
> Hi Vignesh,
>
> IIUC you're saying my v1 patch *content* and rendering is OK, but you
> only wanted the SGML text to have better wrapping for < 80 chars
> lines. So I have attached a patch v2 with improved wrapping. If you
> meant something different then please explain.
>
Your patch is an improvement. Koen, does the proposed change make
things clear to you?
--
With Regards,
Amit Kapila.
s to be the best bet
considering the way current logical replication is documented.
[1] -
https://www.postgresql.org/docs/devel/logical-replication-subscription.html
--
With Regards,
Amit Kapila.
the three messages.
Thoughts?
--
With Regards,
Amit Kapila.
nks for the report and Thanks Michael for including me. I am just
redirecting it to -hackers so that others involved in this feature
also can share their views.
--
With Regards,
Amit Kapila.
10 matches
Mail list logo
