Re: wal_sender_timeout / wal_receiver_timeout - seconds or milliseconds?

2019-11-07 Thread Michael Paquier
On Thu, Nov 07, 2019 at 05:36:17PM -0500, Bruce Momjian wrote: > Right. I am just asking if we need to do this for _every_ case where > the default value doesn't match the default _units_, or if we need to > have some kind of central notification. Doing it for all places where it matters makes se

Re: The word "virgin" used incorrectly and probably better off replaced

2019-11-07 Thread Bruce Momjian
On Thu, Nov 7, 2019 at 06:50:10PM -0300, Alvaro Herrera wrote: > On 2019-Nov-07, Bruce Momjian wrote: > > > On Thu, Nov 7, 2019 at 07:55:22PM +0100, Daniel Gustafsson wrote: > > > > On 7 Nov 2019, at 16:03, Alvaro Herrera > > > > wrote: > > > > > We could say "empty", which seems better suite

Re: wal_sender_timeout / wal_receiver_timeout - seconds or milliseconds?

2019-11-07 Thread Bruce Momjian
On Wed, Nov 6, 2019 at 04:41:10PM +0900, Michael Paquier wrote: > On Tue, Nov 05, 2019 at 10:21:38AM -0500, Bruce Momjian wrote: > > Ugh, the "if no unit specified" is true of all the settings. Should we > > make that clearer in a more central location. > > Hmm. Are you thinking about a new sin

Re: Does 'instead of delete' trigger support modification of OLD

2019-11-07 Thread Bruce Momjian
On Thu, Nov 7, 2019 at 04:26:55PM -0500, Bruce Momjian wrote: > On Thu, Nov 7, 2019 at 11:24:29AM +0200, Eugen Konkov wrote: > > >> As far as allowing DELETE to modify the trigger row for RETURNING, I am > > >> not sure how much work it would take to allow that, but it seems like it > > >> is a v

Re: The word "virgin" used incorrectly and probably better off replaced

2019-11-07 Thread Alvaro Herrera
On 2019-Nov-07, Bruce Momjian wrote: > On Thu, Nov 7, 2019 at 07:55:22PM +0100, Daniel Gustafsson wrote: > > > On 7 Nov 2019, at 16:03, Alvaro Herrera wrote: > > > We could say "empty", which seems better suited than both "virgin" and > > > "pristine" anyway. > > > > empty is a lot better, but

Re: The word "virgin" used incorrectly and probably better off replaced

2019-11-07 Thread Bruce Momjian
On Thu, Nov 7, 2019 at 07:55:22PM +0100, Daniel Gustafsson wrote: > > On 7 Nov 2019, at 16:03, Alvaro Herrera wrote: > > > because we have not explained what a "virgin database" is. > > I think this is the key observation. > > > We could say "empty", which seems better suited than both "virg

Re: Does 'instead of delete' trigger support modification of OLD

2019-11-07 Thread Bruce Momjian
On Thu, Nov 7, 2019 at 11:24:29AM +0200, Eugen Konkov wrote: > Hello Eugen, > > Thursday, November 7, 2019, 11:20:32 AM, you wrote: > > >> I looked in the CREATE TRIGGER manual page and found this: > > >> https://www.postgresql.org/docs/12/sql-createtrigger.html > >> If the trig

Re: Nit: "Immutable" should be "pure"

2019-11-07 Thread Brian Williams
Thanks for the feedback folks. I had not seen the IMMUTABLE argument to CREATE FUNCTION and realize this change is too expensive. This probably will not be the last you hear on this since pureness and immutability are all the rage in development circles. > On Nov 7, 2019, at 12:38 PM, Tom La

Re: Adding a Column documentation is misleading

2019-11-07 Thread Gavin Flower
On 07/11/2019 02:13, Alvaro Herrera wrote: On 2019-Nov-06, PG Doc comments form wrote: Page: https://www.postgresql.org/docs/12/ddl-alter.html Description: In 5.6.1. Adding a Column, there is a kind of example 'ALTER TABLE products ADD COLUMN description text;' The words 'description' and 'te

Re: The word "virgin" used incorrectly and probably better off replaced

2019-11-07 Thread Daniel Gustafsson
> On 7 Nov 2019, at 16:03, Alvaro Herrera wrote: > because we have not explained what a "virgin database" is. I think this is the key observation. > We could say "empty", which seems better suited than both "virgin" and > "pristine" anyway. empty is a lot better, but still isn't conveying th

Re: Nit: "Immutable" should be "pure"

2019-11-07 Thread Tom Lane
Bruce Momjian writes: > On Thu, Nov 7, 2019 at 02:17:58PM +, PG Doc comments form wrote: >> The adjective "immutable" describing the functions and operators used in an >> index (see two occurrences in doc snippet below) is incorrect and should be >> replaced with "pure". > I think the best w

Re: Nit: "Immutable" should be "pure"

2019-11-07 Thread Bruce Momjian
On Thu, Nov 7, 2019 at 02:17:58PM +, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/12/sql-createindex.html > Description: > > The adjective "immutable" describing the functions and operators used in

Re: Small typo in func.sgml

2019-11-07 Thread Tom Lane
Tatsuo Ishii writes: > I thinkk a new line is needed after . > - JSON query functions and operators > + > + JSON query functions and operators It doesn't really make any difference, I believe. I agree it's neater with the newline, but I wouldn't bother changing it unless you're making some

Re: The word "virgin" used incorrectly and probably better off replaced

2019-11-07 Thread Alvaro Herrera
On 2019-Nov-07, PG Doc comments form wrote: > Page: https://www.postgresql.org/docs/12/manage-ag-templatedbs.html > Description: > > The use of the word virgin as an adjective is incorrect here and also an > anachronism. It is better off replaced with the word pristine - quotes > unnecessary. Not

Nit: "Immutable" should be "pure"

2019-11-07 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/12/sql-createindex.html Description: The adjective "immutable" describing the functions and operators used in an index (see two occurrences in doc snippet below) is incorrect and should be re

The word "virgin" used incorrectly and probably better off replaced

2019-11-07 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/12/manage-ag-templatedbs.html Description: The use of the word virgin as an adjective is incorrect here and also an anachronism. It is better off replaced with the word pristine - quotes unne

Re: Does 'instead of delete' trigger support modification of OLD

2019-11-07 Thread Eugen Konkov
Hello Eugen, Thursday, November 7, 2019, 11:20:32 AM, you wrote: >> I looked in the CREATE TRIGGER manual page and found this: >> https://www.postgresql.org/docs/12/sql-createtrigger.html >> If the trigger fires before or instead of the event, the trigger >> can skip the

Re: Does 'instead of delete' trigger support modification of OLD

2019-11-07 Thread Eugen Konkov
> I looked in the CREATE TRIGGER manual page and found this: > https://www.postgresql.org/docs/12/sql-createtrigger.html > If the trigger fires before or instead of the event, the trigger > can skip the operation for the current row, or change the row > being insert