[BUGS] pg_dump - foreign table - server name is not quoted

2011-11-28 Thread Ronan Dunklau
Hello. I noticed what I think is a bug in pg_dump. When dumping foreign tables, the server name is not properly quoted, which leads to unrestorable dumps. eg, a foreign table attached to a foreign server named "file-test" is dumped as: CREATE FOREIGN TABLE "test-table" ( col1 integer ) SERV

Re: [BUGS] BUG #6308: Problem w. encoding in client

2011-11-28 Thread Thomas Goerner
Hello Craig, thanks for your answer. > Restore using PgAdmin III or using a unicode console. > This is a limitation of using a Win1252 client encoding when restoring > data that isn't restricted to Win1252 and cannot be fixed directly. That's new to me. AFAIK pg_restore looks int

Re: [BUGS] pg_dump - foreign table - server name is not quoted

2011-11-28 Thread Tom Lane
Ronan Dunklau writes: > When dumping foreign tables, the server name is not properly quoted, > which leads to unrestorable dumps. Clearly a bug. > Please look at the attached test case and the proposed patch. I think this patch is not in keeping with typical coding practices in pg_dump. Usuall

Re: [BUGS] pg_dump - foreign table - server name is not quoted

2011-11-28 Thread Ronan Dunklau
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Thanks for the response. How will this bug be handled with regards to releases ? If the fix is going to take a while to be released, we could rename our servers to valid names but we would prefer not to. Regards, - -- Ronan Dunklau -BEGIN PGP

[BUGS] objects tied to missing extension

2011-11-28 Thread Phil Sorber
I stumbled upon this situation when playing with extension upgrades. The problem I was having was that auto-generated datatypes were also being added to the extension and it wasn't obvious this was happening. I know this has been changed in 9.1 stable and in master. What happened was that I was ab

Re: [BUGS] pg_dump - foreign table - server name is not quoted

2011-11-28 Thread Tom Lane
Ronan Dunklau writes: > How will this bug be handled with regards to releases ? It'll be fixed in next week's releases. regards, tom lane -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mail

Re: [BUGS] objects tied to missing extension

2011-11-28 Thread Tom Lane
Phil Sorber writes: > I stumbled upon this situation when playing with extension upgrades. > The problem I was having was that auto-generated datatypes were also > being added to the extension and it wasn't obvious this was happening. > I know this has been changed in 9.1 stable and in master. I

Re: [BUGS] objects tied to missing extension

2011-11-28 Thread Phil Sorber
On Mon, Nov 28, 2011 at 3:12 PM, Tom Lane wrote: > Phil Sorber writes: >> I stumbled upon this situation when playing with extension upgrades. >> The problem I was having was that auto-generated datatypes were also >> being added to the extension and it wasn't obvious this was happening. >> I kno

Re: [BUGS] objects tied to missing extension

2011-11-28 Thread Tom Lane
Phil Sorber writes: > I am still able to reproduce the "ERROR: cache lookup failed for extension > x" if I use an explicit 'drop extension'. I am unsure how I can > reverse the state it is now in. I assume there is some system catalog > I can edit that will fix it? I think you have some dang

Re: [BUGS] objects tied to missing extension

2011-11-28 Thread Phil Sorber
On Mon, Nov 28, 2011 at 4:10 PM, Tom Lane wrote: > Phil Sorber writes: >> I am still able to reproduce the "ERROR:  cache lookup failed for extension >> x" if I use an explicit 'drop extension'. I am unsure how I can >> reverse the state it is now in. I assume there is some system catalog >>

Re: [BUGS] BUG #6307: intarray extention gin index does not work with Hot standby

2011-11-28 Thread Maxim Boguk
On Mon, Nov 28, 2011 at 6:02 PM, Simon Riggs wrote: > On Fri, Nov 25, 2011 at 6:33 PM, Tom Lane wrote: > > Maxim Boguk writes: > >> I know GIST on intarray[] do not have that problem. > >> Very likely the problem is limited to intarray[] GIN indexes only > >> (but I going to test some other not

Re: [BUGS] objects tied to missing extension

2011-11-28 Thread Tom Lane
Phil Sorber writes: > I compiled 9.1 stable head and tested it out. You are correct my > example no longer works there because of the patch that stopped the > auto-generated types from becoming dependencies of the extension. In > fact, the cascade no longer works even if I don't remove the table o

Re: [BUGS] [ADMIN] Repeatable crash in pg_dump (with -d2 info)

2011-11-28 Thread Tom Lane
David Schnur writes: > I probably can't get a stack trace, but I was able to reproduce it with > just that function. Without the function, pg_dump works fine. I can DROP > the function, pg_dump works, then add it back again and pg_dump crashes. Hmph. I still can't reproduce this here, which se

Re: [BUGS] BUG #6307: intarray extention gin index does not work with Hot standby

2011-11-28 Thread Tom Lane
Maxim Boguk writes: > Is that fix will be included to the next minor versions releases? Yes, it's in already: http://git.postgresql.org/gitweb/?p=postgresql.git regards, tom lane -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your sub

Re: [BUGS] BUG #6308: Problem w. encoding in client

2011-11-28 Thread Craig Ringer
On 11/28/2011 08:26 PM, Thomas Goerner wrote: Hello Craig, thanks for your answer. > Restore using PgAdmin III or using a unicode console. > This is a limitation of using a Win1252 client encoding when restoring > data that isn't restricted to Win1252 and cannot be fixed directly. That's ne