Re: [BUGS] pg_ctl restart bug

2001-04-21 Thread Peter Eisentraut
Tom Lane writes: > ! eval '$po_path' '$POSTOPTS' $logopt '&' > --- 323,335 > ! eval '$po_path' $POSTOPTS $logopt '&' Actually, I think it needs to be "$POSTOPTS" (double quoted), to preserve whitespace. peter ~$ opts="-N -o '-F -S'" peter ~$ eval ./argprint $opts -N -o -F -S pe

Re: [BUGS] pg_ctl restart bug

2001-04-20 Thread Peter Eisentraut
Tom Lane writes: > pg_ctl restart works fine with this patch, but I'm not sure whether it > breaks useful cases for the other paths: Looks good. -- Peter Eisentraut [EMAIL PROTECTED] http://funkturm.homeip.net/~peter ---(end of broadcast)--

Re: [BUGS] pg_ctl restart bug

2001-04-20 Thread Bruce Momjian
I can assure you that $@ is never the way to go, always use "$@". Not sure about the second change. > pg_ctl restart works fine with this patch, but I'm not sure whether it > breaks useful cases for the other paths: > > *** > *** 323,335 > shift > po_pa

Re: [BUGS] pg_ctl restart bug

2001-04-20 Thread Bruce Momjian
> > $ cat postmaster.opts > > /usr/bin/postmaster '-D' '/var/lib/pgsql/data' > > Unless someone can show me a way to extract the command line options out > of the opts file while preserving whitespace in them, I'm going to > eliminate the quotes being put out. You know, I looked at that

Re: [BUGS] pg_ctl restart bug

2001-04-20 Thread Tom Lane
pg_ctl restart works fine with this patch, but I'm not sure whether it breaks useful cases for the other paths: *** *** 323,335 shift po_path=$1 shift ! POSTOPTS=$@ fi else # -o given POSTOPTS="-D $PGDATA $

Re: [BUGS] pg_ctl restart bug

2001-04-20 Thread Tom Lane
Peter Eisentraut <[EMAIL PROTECTED]> writes: > Unless someone can show me a way to extract the command line options out > of the opts file while preserving whitespace in them, I'm going to > eliminate the quotes being put out. Won't work if any of the options contain whitespace, which is quite pr

Re: [BUGS] pg_ctl restart bug

2001-04-20 Thread Peter Eisentraut
[EMAIL PROTECTED] writes: > "pg_ctl restart" fails if anything is quoted in postmaster.opts. > > $ pg_ctl restart > Smart Shutdown request at Fri Apr 20 10:11:38 2001 > postmaster successfully shut down > postmaster successfully started > /usr/bin/postmaster: invalid argument

[BUGS] pg_ctl restart bug

2001-04-20 Thread jmitchell
"pg_ctl restart" fails if anything is quoted in postmaster.opts. $ pg_ctl restart Smart Shutdown request at Fri Apr 20 10:11:38 2001 postmaster successfully shut down postmaster successfully started /usr/bin/postmaster: invalid argument -- '-D' Try '/usr/bin/postmaster --h