I can assure you that $@ is never the way to go, always use "$@".  Not
sure about the second change.

> pg_ctl restart works fine with this patch, but I'm not sure whether it
> breaks useful cases for the other paths:
> 
> ***************
> *** 323,335 ****
>           shift
>               po_path=$1
>               shift
> !         POSTOPTS=$@
>       fi
>       else # -o given
>           POSTOPTS="-D $PGDATA $POSTOPTS"
>       fi
>   
> !     eval '$po_path' '$POSTOPTS' $logopt '&'
>   
>       # if had an old lockfile, check to see if we were able to start
>       if [ -n "$oldpid" ];then
> --- 323,335 ----
>           shift
>               po_path=$1
>               shift
> !         POSTOPTS="$@"
>       fi
>       else # -o given
>           POSTOPTS="-D $PGDATA $POSTOPTS"
>       fi
>   
> !     eval '$po_path' $POSTOPTS $logopt '&'
>   
>       # if had an old lockfile, check to see if we were able to start
>       if [ -n "$oldpid" ];then
> 
> 
> 
>                       regards, tom lane
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]
> 

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  [EMAIL PROTECTED]               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

---------------------------(end of broadcast)---------------------------
TIP 4: Don't 'kill -9' the postmaster

Reply via email to