Hi,
On Fri, Jan 16, 2009 at 12:23 AM, Heikki Linnakangas
wrote:
>> Only a part of backup
>> history file (the file name including stop wal location) is changed.
>> Currently, the file name is wrong if stop wal location indicates a
>> boundary
>> byte. This would confuse the user, I think.
>
> Hmm
Hi,
On Fri, Jan 16, 2009 at 11:42 AM, Tom Lane wrote:
> It's really not worth changing the file contents. We're far more likely
> to hear complaints like "you broke my archive script and I lost all my
> data" than compliments about "the contents of this internal
> implementation file are lots mo
Fujii Masao writes:
> Currently, stop wal filename is not always exclusive. If stop wal location
> doesn't indicate a boundary byte, its filename is inclusive. I'm afraid that
> the users cannot easily judge which "filename - 1" or "filename" should be
> waited. I mean that the users need to calcu
Heikki has updated the documentation to mention the meaning of this
field. Thanks for the report.
---
Fujii Masao wrote:
> On Fri, Dec 5, 2008 at 11:41 PM, Randy Isbell wrote:
> >
> > The following bug has been logged onli
On Thu, 2009-01-15 at 12:43 -0500, Bruce Momjian wrote:
> OK, do you have updated wording?
We are not changing the code, so Heikki's wording is appropriate since
it matches the code.
--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support
--
Sent via pgsql-b
Simon Riggs wrote:
>
> On Thu, 2009-01-15 at 11:15 -0500, Tom Lane wrote:
> > Heikki Linnakangas writes:
> > > Fujii Masao wrote:
> > >> Only a part of backup
> > >> history file (the file name including stop wal location) is changed.
> > >> Currently, the file name is wrong if stop wal location
On Thu, 2009-01-15 at 11:15 -0500, Tom Lane wrote:
> Heikki Linnakangas writes:
> > Fujii Masao wrote:
> >> Only a part of backup
> >> history file (the file name including stop wal location) is changed.
> >> Currently, the file name is wrong if stop wal location indicates a boundary
> >> byte. T
Heikki Linnakangas writes:
> Fujii Masao wrote:
>> Only a part of backup
>> history file (the file name including stop wal location) is changed.
>> Currently, the file name is wrong if stop wal location indicates a boundary
>> byte. This would confuse the user, I think.
> Should we change it in H
Fujii Masao wrote:
On Thu, Jan 15, 2009 at 9:09 PM, Heikki Linnakangas
wrote:
1. The proposed patch would remove the "+ 1". Seems like an unnecessary API
change, and I don't recall any reason why the new definition would be
better.
My patch doesn't change the return value of pg_stop_backup(),
Looking at the original post again:
The resulting *.backup file:
START WAL LOCATION: 10/FE1E2BAC (file 0002001000FE)
STOP WAL LOCATION: 10/FF00 (file 0002001000FF)
CHECKPOINT LOCATION: 10/FE1E2BAC
START TIME: 2008-11-09 01:15:06 CST
LABEL: /bck/db/sn200811090115.tar.
Hi,
On Thu, Jan 15, 2009 at 9:09 PM, Heikki Linnakangas
wrote:
> I think not
> (http://archives.postgresql.org/pgsql-hackers/2008-12/msg00126.php). The
> return value of pg_stop_backup() is currently the same as
> pg_switch_xlog()'s: the location of the last byte before the XLOG switch +
> 1. The
I think not
(http://archives.postgresql.org/pgsql-hackers/2008-12/msg00126.php). The
return value of pg_stop_backup() is currently the same as
pg_switch_xlog()'s: the location of the last byte before the XLOG switch
+ 1. The proposed patch would remove the "+ 1". Seems like an
unnecessary API
Would someone please tell me if this should be applied?
---
Fujii Masao wrote:
> On Fri, Dec 5, 2008 at 11:41 PM, Randy Isbell wrote:
> >
> > The following bug has been logged online:
> >
> > Bug reference: 4566
> > Lo
On Fri, Dec 5, 2008 at 11:41 PM, Randy Isbell <[EMAIL PROTECTED]> wrote:
>
> The following bug has been logged online:
>
> Bug reference: 4566
> Logged by: Randy Isbell
> Email address: [EMAIL PROTECTED]
> PostgreSQL version: 8.3.4
> Operating system: FreeBSD 6.2
> Description:
The following bug has been logged online:
Bug reference: 4566
Logged by: Randy Isbell
Email address: [EMAIL PROTECTED]
PostgreSQL version: 8.3.4
Operating system: FreeBSD 6.2
Description:pg_stop_backup() reports incorrect STOP WAL LOCATION
Details:
An inconsistency
15 matches
Mail list logo
