Hi, On Thu, Jan 15, 2009 at 9:09 PM, Heikki Linnakangas <[email protected]> wrote: > I think not > (http://archives.postgresql.org/pgsql-hackers/2008-12/msg00126.php). The > return value of pg_stop_backup() is currently the same as > pg_switch_xlog()'s: the location of the last byte before the XLOG switch + > 1. The proposed patch would remove the "+ 1". Seems like an unnecessary API > change, and I don't recall any reason why the new definition would be > better.
My patch doesn't change the return value of pg_stop_backup(), it's still the same as the return value of pg_switch_xlog(). Only a part of backup history file (the file name including stop wal location) is changed. Currently, the file name is wrong if stop wal location indicates a boundary byte. This would confuse the user, I think. Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center -- Sent via pgsql-bugs mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs
