Re: [BUGS] [HACKERS] 0x1A in control file on Windows

2008-09-19 Thread Magnus Hagander
Andrew Dunstan wrote: > > > Magnus Hagander wrote: >> I had a chat with Heikki about this, and the proper way to fix it. >> >> Should there actually be any reason not to *always* open our files with >> O_BINARY? That seems to be what should mimic what Unix does, which would >> be what we expect,

Re: [BUGS] [HACKERS] 0x1A in control file on Windows

2008-09-19 Thread Andrew Dunstan
Magnus Hagander wrote: I had a chat with Heikki about this, and the proper way to fix it. Should there actually be any reason not to *always* open our files with O_BINARY? That seems to be what should mimic what Unix does, which would be what we expect, no? If that is so, then I propose we do

Re: [BUGS] [HACKERS] 0x1A in control file on Windows

2008-09-19 Thread Magnus Hagander
Magnus Hagander wrote: > Heikki Linnakangas wrote: >> ITAGAKI Takahiro wrote: >>> Tom Lane <[EMAIL PROTECTED]> wrote: >>> ITAGAKI Takahiro <[EMAIL PROTECTED]> writes: > We probably need to add PG_BINARY when we open control files > because 0x1A is an end-of-file marker on Windows.

Re: [BUGS] BUG #4421: convert_to() should be immutable

2008-09-19 Thread Andreas Peer
Tom Lane schrieb: > Andreas Peer <[EMAIL PROTECTED]> writes: > >> Well, the use case is a strange one... I would like to use a varchar() >> column for storing a variable-length vector of integers. The numbers are >> represented by the codepoints. Therefore, I need to sort them as binary >> da