[BUGS] BUG #2694: Memory allocation error when selecting array of empty arrays

2006-10-15 Thread Vitali Stupin
The following bug has been logged online: Bug reference: 2694 Logged by: Vitali Stupin Email address: [EMAIL PROTECTED] PostgreSQL version: 8.1.4 Operating system: sparc-sun-solaris2.10 Description:Memory allocation error when selecting array of empty arrays Details:

Re: [BUGS] BUG #2683: spi_exec_query in plperl returns column names which are not marked as UTF8

2006-10-15 Thread David Fetter
On Mon, Oct 16, 2006 at 12:10:42AM -0400, Bruce Momjian wrote: > David Fetter wrote: > > On Sun, Oct 15, 2006 at 07:07:18PM -0400, Tom Lane wrote: > > > David Fetter <[EMAIL PROTECTED]> writes: > > > > At some point, we will find something where we will have to > > > > duplicate some large hunk of

Re: [BUGS] BUG #2683: spi_exec_query in plperl returns column

2006-10-15 Thread Bruce Momjian
David Fetter wrote: > On Sun, Oct 15, 2006 at 07:07:18PM -0400, Tom Lane wrote: > > David Fetter <[EMAIL PROTECTED]> writes: > > > At some point, we will find something where we will have to duplicate > > > some large hunk of 5.8's functionality to support 5.6. > > > > No, we won't; we are not in

Re: [BUGS] BUG #2683: spi_exec_query in plperl returns column names which are not marked as UTF8

2006-10-15 Thread David Fetter
On Sun, Oct 15, 2006 at 07:07:18PM -0400, Tom Lane wrote: > David Fetter <[EMAIL PROTECTED]> writes: > > At some point, we will find something where we will have to duplicate > > some large hunk of 5.8's functionality to support 5.6. > > No, we won't; we are not in the business of fixing Perl bugs

Re: [BUGS] BUG #2683: spi_exec_query in plperl returns column names which are not marked as UTF8

2006-10-15 Thread Tom Lane
David Fetter <[EMAIL PROTECTED]> writes: > At some point, we will find something where we will have to duplicate > some large hunk of 5.8's functionality to support 5.6. No, we won't; we are not in the business of fixing Perl bugs. You haven't given any reason why someone who is using 5.6 and is

Re: [BUGS] BUG #2683: spi_exec_query in plperl returns column names which are not marked as UTF8

2006-10-15 Thread David Fetter
On Sun, Oct 15, 2006 at 06:12:43PM -0400, Tom Lane wrote: > David Fetter <[EMAIL PROTECTED]> writes: > > On Sun, Oct 15, 2006 at 04:43:17PM -0400, Tom Lane wrote: > >> ISTM the real question is what do we buy if we make such a > >> restriction? Getting rid of a few small ifdefs doesn't seem like >

Re: [HACKERS] [BUGS] BUG #2683: spi_exec_query in plperl returns

2006-10-15 Thread Andrew Dunstan
Tom Lane wrote: > I wrote: >> It looks to me like basically everywhere in plperl.c that does newSVpv() >> should follow it with >> >> #if PERL_BCDVERSION >= 0x5006000L >> if (GetDatabaseEncoding() == PG_UTF8) >> SvUTF8_on(sv); >> #endif > > Experimentation proved that th

Re: [HACKERS] [BUGS] BUG #2683: spi_exec_query in plperl returns

2006-10-15 Thread David Fetter
On Sun, Oct 15, 2006 at 04:50:15PM -0500, Andrew Dunstan wrote: > Tom Lane wrote: > > I wrote: > >> It looks to me like basically everywhere in plperl.c that does > >> newSVpv() should follow it with > >> > >> #if PERL_BCDVERSION >= 0x5006000L > >> if (GetDatabaseEncoding() == PG_UTF8)

Re: [HACKERS] [BUGS] BUG #2683: spi_exec_query in plperl returns

2006-10-15 Thread Tom Lane
"Andrew Dunstan" <[EMAIL PROTECTED]> writes: > I am also wondering, now that it's been raised, if we need to issue a "use > utf8;" in the startup code, so that literals in the code get the right > encoding. Good question. I took care to ensure that the code strings passed to Perl are marked as UT

Re: [BUGS] BUG #2683: spi_exec_query in plperl returns column names which are not marked as UTF8

2006-10-15 Thread Tom Lane
David Fetter <[EMAIL PROTECTED]> writes: > On Sun, Oct 15, 2006 at 04:43:17PM -0400, Tom Lane wrote: >> ISTM the real question is what do we buy if we make such >> a restriction? Getting rid of a few small ifdefs doesn't seem like >> an adequate reason. Is there some major improvement we could ma

Re: [BUGS] BUG #2683: spi_exec_query in plperl returns column names which are not marked as UTF8

2006-10-15 Thread David Fetter
On Sun, Oct 15, 2006 at 04:43:17PM -0400, Tom Lane wrote: > David Fetter <[EMAIL PROTECTED]> writes: > > I'd like to suggest that raise that minimum requirement for Perl > > to 5.8 for 8.3, as Perl 5.8 will be about five years old by then. > > Well, we're still supporting some OS versions that are

Re: [BUGS] BUG #2683: spi_exec_query in plperl returns column names which are not marked as UTF8

2006-10-15 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Tom Lane asked: > Well, we're still supporting some OS versions that are way over five > years old. ISTM the real question is what do we buy if we make such > a restriction? Getting rid of a few small ifdefs doesn't seem like > an adequate reason.

Re: [BUGS] BUG #2683: spi_exec_query in plperl returns column names which are not marked as UTF8

2006-10-15 Thread Tom Lane
David Fetter <[EMAIL PROTECTED]> writes: > I'd like to suggest that raise that minimum requirement for Perl to > 5.8 for 8.3, as Perl 5.8 will be about five years old by then. Well, we're still supporting some OS versions that are way over five years old. ISTM the real question is what do we buy

Re: [BUGS] BUG #2683: spi_exec_query in plperl returns column names which are not marked as UTF8

2006-10-15 Thread David Fetter
On Sun, Oct 15, 2006 at 05:34:21PM -, Greg Sabino Mullane wrote: > > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > > Tom Lane wrote: > > #if PERL_BCDVERSION >= 0x5006000L > ... > > #endif > ... > > I'm tempted to consolidate this into a function on the order of > > newSVstring(const ch

Re: [BUGS] BUG #2683: spi_exec_query in plperl returns column names which are not marked as UTF8

2006-10-15 Thread Tom Lane
I wrote: > It looks to me like basically everywhere in plperl.c that does newSVpv() > should follow it with > > #if PERL_BCDVERSION >= 0x5006000L > if (GetDatabaseEncoding() == PG_UTF8) > SvUTF8_on(sv); > #endif Experimentation proved that this was insufficient to fix V

Re: [BUGS] BUG #2683: spi_exec_query in plperl returns column names which are not marked as UTF8

2006-10-15 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Tom Lane wrote: > #if PERL_BCDVERSION >= 0x5006000L ... > #endif ... > I'm tempted to consolidate this into a function on the order of > newSVstring(const char *) or some such. Comments? +1 I suggested at one point raising the minimum requirement