[pgAdmin4][Patch]: Fixed #2487: get_preference() uses a synchronous AJAX request

Hi, Please find attached patch to fix RM #2487: get_preference() uses a synchronous AJAX request. Introduced the client side caching for preferences to get rid of synchronous AJAX request. Thanks, Khushboo diff --git a/web/pgadmin/browser/templates/browser/js/browser.js b/web/pgadmin/browser/te

Re: [pgAdmin4][Patch]: Fixed #2487: get_preference() uses a synchronous AJAX request

ave binary path set it is throwing an error. > > > > -- > > Regards, > > Murtuza Zabuawala > > EnterpriseDB: http://www.enterprisedb.com > > The Enterprise PostgreSQL Company > > > > On Wed, Jun 21, 2017 at 9:40 PM, Dave Page wrote: > >> > &g

Re: [pgAdmin4][Patch]: Fixed #2487: get_preference() uses a synchronous AJAX request

Hi Dave, One more fix for this module. Thanks, Khushboo On Thu, Jun 22, 2017 at 4:49 PM, Dave Page wrote: > Thanks, patch applied. > > On Thu, Jun 22, 2017 at 11:06 AM, Khushboo Vashi > wrote: > > Hi, > > > > Please find the attached fix for the same. > >

[pgAdmin4][Patch]: Feature #2506 - Allow the dashboard panel to be closed

Hi, Please find the attached patch for the feature #2506: Allow the dashboard panel to be closed. Thanks, Khushboo diff --git a/web/pgadmin/browser/static/js/panel.js b/web/pgadmin/browser/static/js/panel.js index 71d2c68..bfa2e32 100644 --- a/web/pgadmin/browser/static/js/panel.js +++ b/web/pgad

[pgAdmin4][patch]: Fixed RM #2507 : REVOKE privileges do not display in SQL tab for the function

Hi, Please find the attached patch to fix the RM #2507: REVOKE privileges do not display in SQL tab for the function Thanks, Khushboo diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/__init__.py b/web/pgadmin/browser/server_groups/servers/databases/schemas/functi

[pgAdmin4][Patch]: Fixed RM #1920 - [Web Based] Unexpected behaviour observed when connect server with save password option.

Hi, Please find the attached patch to fix RM #1920 - [Web Based] Unexpected behaviour observed when connect server with save password option. Thanks, Khushboo diff --git a/web/pgadmin/browser/server_groups/servers/__init__.py b/web/pgadmin/browser/server_groups/servers/__init__.py index d88363a.

Re: [pgAdmin4][Patch]: Feature #2506 - Allow the dashboard panel to be closed

Can we stop it immediately? > > Fixed > On Mon, Jun 26, 2017 at 1:56 AM, Khushboo Vashi > wrote: > > Hi, > > > > Please find the attached patch for the feature #2506: Allow the dashboard > > panel to be closed. > > > > Thanks, > > Khushboo

Re: crypto.py bug on server add form (button save) with python 3.5 - Can't convert 'bytes' object to str implicitly

Hi, Can you send the patch for the same. I think this is the valid fix. Thanks, Khushboo On Tue, Jun 27, 2017 at 3:02 PM, Ladislav Jech wrote: > I am running on following Gentoo system with Python 3.5 as default > (although i have 2.7 and 3.4 available to switch as well). > > I compiled from s

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

On 27 Jun 2017 18:33, "Dave Page" wrote: Thanks - patch committed! Awsome job :-) Gr8. Finally no more rebase request for Harshal. :) On Tue, Jun 27, 2017 at 3:26 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please find rebased patch. > > -- > *Harshal Dhumal* > *Sr.

Re: [pgadmin-hackers][patch] History Detail Pane

On Tue, Jun 27, 2017 at 8:26 PM, Dave Page wrote: > Thanks - patch applied (just in time for Raffi's & my talk)! > > The history tab looks really very good. > On Tue, Jun 27, 2017 at 10:05 AM, Joao Pedro De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Yep, >> please see attached

Re: [pgAdmin4][Patch]: Feature #2506 - Allow the dashboard panel to be closed

things to reproduce it but not succeeded. I also switched server_mode but no luck. I think there should be any specific condition that fails this but have no clue. I have rebased this patch and attached. > On Tue, Jun 27, 2017 at 9:21 AM, Dave Page wrote: > >> Thanks,

Re: crypto.py bug on server add form (button save) with python 3.5 - Can't convert 'bytes' object to str implicitly

upport fully github or any GIT repository for > managing pull requests. Is there any or you wan't me to generate *.patch > file? I am new to pgadmin 4, so not sure how this works. Let me know. > Ladislav > > 2017-06-27 11:52 GMT+02:00 Khushboo Vashi >: > >> Hi, >&g

[pgAdmin4][Patch]: Fixed RM #2489: Copy from the results grid is extremely slow and fails with large datasets

Hi, Please find the attached patch to fix the RM #2489: Copy from the results grid is extremely slow and fails with large datasets. Thanks, Khushboo diff --git a/web/pgadmin/static/js/selection/clipboard.js b/web/pgadmin/static/js/selection/clipboard.js index 9794ae7..844e20c 100644 --- a/web/pga

Re: [pgAdmin4][Patch]: Feature #2506 - Allow the dashboard panel to be closed

Hi, Please find the attached updated patch. Thanks, Khushboo On Wed, Jun 28, 2017 at 7:08 PM, Dave Page wrote: > Hi > > On Tue, Jun 27, 2017 at 11:54 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Tue, Jun 27, 2017

Re: UI issue

Hi, Please find the attached patch for the same. This is due to my precious patch. Thanks, Khushboo On Fri, Jun 30, 2017 at 5:06 PM, Dave Page wrote: > > > On Fri, Jun 30, 2017 at 12:29 PM, Dave Page wrote: > >> >> >> On Fri, Jun 30, 2017 at 12:25 PM, Dave Page wrote: >> >>> >>> >>> On Fri,

[pgAdmin4][Patch]: Fixed couple of minor issues

Hi, 1. When we try to delete the table row with the column definition having NOT NULL TRUE and HAS NO DEFAULT VALUE then it fails. Please find the attached patch for the same. (delete_row.patch) 2. The debugger can not be opened from the View trigger. Please find the attached patch for th

[pgAdmin4][Patch]: Fixed the issue related to Domain Constraint module

Hi, The Domain Constraint module doesn't load as it can not find the domain_constraints.js file. To fix this issue, renamed the domain_constraint.js to domain_constraints.js. Please find the attached fix. diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/domains/domain_cons

Re: [pgAdmin4][Patch]: Fixed couple of minor issues

Nope. I found these issues when I tried to reproduce another issue :). On Mon, Jul 3, 2017 at 3:29 PM, Dave Page wrote: > Are there RMs for these? > > On Mon, Jul 3, 2017 at 2:27 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >>

Re: [pgAdmin4][Patch]: Fixed couple of minor issues

On Mon, Jul 3, 2017 at 11:57 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > 1. When we try to delete the table row with the column definition having > NOT NULL TRUE and HAS NO DEFAULT VALUE then it fails. > Please find the attached patch for the sa

Re: [pgAdmin4][Patch]: Fixed the issue related to Domain Constraint module

On Mon, Jul 3, 2017 at 1:10 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > The Domain Constraint module doesn't load as it can not find the > domain_constraints.js file. > To fix this issue, renamed the domain_constraint.js to > domain_constr

Re: [pgAdmin4][Patch]: Fixed the issue related to Domain Constraint module

On Mon, Jul 3, 2017 at 7:52 PM, Dave Page wrote: > Hi > > On Mon, Jul 3, 2017 at 6:10 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Mon, Jul 3, 2017 at 1:10 PM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrot

[pgAdmin4][Patch]: Fixed #2532 - Left side tree: The node disappears on update if there is only one child exist for that category.

Hi, Please find the attached patch to fix the RM #2532 : Left side tree: The node disappears on update if there is only one child exist for that category. Thanks, Khushboo diff --git a/web/pgadmin/browser/templates/browser/js/browser.js b/web/pgadmin/browser/templates/browser/js/browser.js index

[pgAdmin4][Patch]: Fixed RM #1165 - Too many request to update dashboard graphs when server is disconnected.

Hi, Please find the attached patch to fix the RM #1165 - Too many request to update dashboard graphs when server is disconnected. Thanks, Khushboo diff --git a/web/pgadmin/dashboard/templates/dashboard/js/dashboard.js b/web/pgadmin/dashboard/templates/dashboard/js/dashboard.js index 34a1ab7..e858

Re: [pgAdmin4][Patch]: Fixed RM #1165 - Too many request to update dashboard graphs when server is disconnected.

Hi, please find the attached updated patch. Thanks, Khushboo On Mon, Jul 10, 2017 at 6:54 PM, Dave Page wrote: > Hi > > On Mon, Jul 10, 2017 at 2:14 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attach

Re: pgAdmin 4 v1.6 Released!

On Fri, Jul 14, 2017 at 12:23 PM, Pawel Hadam wrote: > Hi, > > I have also installed "pgadmin4-1.6-x86.exe" on Windows 10 PRO (AMD > FX, 6 cores, 16 GB RAM, SSD) and tried to run it. After 1min 58 sec I > got a message saying "The application server could not be contacted". > > pgAdmin 4 v 1.5 wa

Re: pgAdmin 4 v1.6 Released!

On Fri, Jul 14, 2017 at 1:55 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > On Fri, Jul 14, 2017 at 12:23 PM, Pawel Hadam wrote: > >> Hi, >> >> I have also installed "pgadmin4-1.6-x86.exe" on Windows 10 PRO (AMD >> FX, 6 cores, 1

Re: pgAdmin 4 v1.6 Released!

On Fri, Jul 14, 2017 at 4:18 PM, Raymond O'Donnell wrote: > Hi all, > > I'm trying to install pgAdmin4 in server mode on my laptop (Debian > Jessie), and I've got as far as: > >python setup.py > > I don't have a python environment set up, so I'm apt-getting my way > through various unmet depe

[pgAdmin4][Patch]: Minor patch to fix a typo in README

Hi, Please find a minor patch to fix a typo in README. Thanks, Khushboo README_typo.patch Description: Binary data

[pgAdmin4][Patch]: RM #2556: Runtime connection retry loop timeout

Hi, Please find the attached patch for RM #2556: Runtime connection retry loop timeout Thanks, Khushboo diff --git a/docs/en_US/desktop_deployment.rst b/docs/en_US/desktop_deployment.rst index 9765c77..745b83f 100644 --- a/docs/en_US/desktop_deployment.rst +++ b/docs/en_US/desktop_deployment.rst

Re: [pgAdmin4]: Webpacking of static JS/CSS

On Tue, Jul 18, 2017 at 7:46 PM, Dave Page wrote: > Thanks - applied! > > Awesome work - on an average of 3 tests on my Mac, load time reduced from > 11.55s with v1.6 to 5.53s with GIT Head. > > Surinder, great work... > On Mon, Jul 17, 2017 at 5:57 PM, Surinder Kumar < > surinder.ku...@enterpr

[pgAdmin4][Patch]: Backform control visibility fix

Hi, Please find the attached patch to handle the control visibility even in the javascript strict mode. Thanks, Khushboo diff --git a/web/pgadmin/browser/server_groups/servers/roles/templates/role/js/role.js b/web/pgadmin/browser/server_groups/servers/roles/templates/role/js/role.js index 1c0917d

[pgAdmin4][Patch]: Fixed RM #2603 - Import/Export File issues

Hi, Please find the attached patch to fix the RM #2603: Import/Export File issues. Fixed Issues: 1. Couldn't click on the File Control once gets an error 2. The encoding is not in alphabetical order Thanks, Khsuhboo diff --git a/web/pgadmin/browser/server_groups/servers/databases/templates/dat

[pgAdmin4][Patch]: Dashboard requests don't stop even after closing the panel

Hi, If we close the Dashboard tab even then the requests don't stop. This is the regression of web-packing of browser.js file. Please find the attached patch for the same. Thanks, Khushboo diff --git a/web/pgadmin/browser/templates/browser/js/browser.js b/web/pgadmin/browser/templates/browser/js/

Re: Error using pgadmin4 HEAD

Hi Dave, Please provide below information to investigate: 1. OS Details 2. pgAdmin 4 version 3. The steps you followed to install the application pgAdmin 4 documentation to help in deployment process. Thanks, Khushboo On Fri, Jul 28,

Re: [gpAdmin4][patch] query history updates

you please re-base that patch? > Thanks, > > Wenlin & Violet > > > On Mon, Aug 7, 2017 at 1:45 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Sarah & Hao, >> >> The copy/paste functionality through the added copy bu

Re: [pgAdmin4][patch] Fix feature tests failure

Hi Sarah, I am doing this and didn't reply on this thread as we are discussing this on the another thread (the History Update patch). Thanks, Khushboo On Wed, Aug 9, 2017 at 9:10 AM, Sarah McAlear wrote: > Hi Hackers! > > Could someone review this patch, please? > > Thanks so much! > Sarah > >

Re: [gpAdmin4][patch] query history updates

cleanly on > Master. If we rebase it here, we won't be able to apply it on master. > > Thanks, > Sarah > > On Tue, Aug 8, 2017 at 6:27 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Wenlin & Violet, >> >> >> On T

Re: [pgAdmin4][patch] extract generate_url function from node.js and collection.js

Hi, The patch looks good to me. > Thanks, Khushboo On Fri, Aug 11, 2017 at 12:08 PM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > On Thu, Aug 10, 2017 at 1:15 PM, Violet Cheng wrote: > >> Hi hackers, >> >> We tried to extract and refactor generate_url function in node.js and >> colle

Re: v2.0 RC2 test builds

The setting which worked for me is "*Anywhere", not "**App Store and identified developers" for me*. On Tue, Sep 19, 2017 at 4:29 PM, Dave Page wrote: > Is this accurate? > > https://www.pgadmin.org/faq/#9 > > On Tue, Sep 19, 2017 at 10:58 AM, Dave Page wrote: > >> >> >> On Tue, Sep 19, 2017 at

[pgAdmin4][Patch]: RM #2651 : "Create Script" view of functions always shows "ROWS 0"

Hi, Please find the attached patch to fix RM #2651 : "Create Script" view of functions always shows "ROWS 0". Right now function displays ROWS 0 in case of empty ROWS field. Now it will display correct value of the filed. This has been fixed in Create/Update/View function. Thanks, Khushboo diff

[pgAdmin4][Patch]: RM #2846: Add a context menu option to manually (re)count rows in tables

Hi, Please find the attached patch for RM #2846 : Add a context menu option to manually (re)count rows in tables, including those with >2K rows Thanks, Khushboo diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py b/web/pgadmin/browser/server_groups/servers/

[pgAdmin4][Patch]: RM #2781 - New option to set the quotation mark for copying to clipboard.

Hi, Please find the attached patch for RM #2781 : New option to set the quotation mark for copying to clipboard. This patch includes: - Provide options in preferences to control the CSV output which includes copy to clipboard and download as CSV features in Query Tool - Modified related jasmine

Re: [pgAdmin4][Patch]: RM #2781 - New option to set the quotation mark for copying to clipboard.

Hi Dave, Thanks for reviewing the patch. On Thu, Nov 16, 2017 at 7:42 PM, Dave Page wrote: > Hi > > On Thu, Nov 16, 2017 at 10:01 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch for RM #2781 :

Re: [pgAdmin4][Patch]: RM #2781 - New option to set the quotation mark for copying to clipboard.

b/python2.7/site-packages/backports/csv.py", line 185, in __init__ raise TypeError(*e.args) TypeError: "delimiter" must be string, not bytes Please share your CSV Output settings. On Mon, Nov 20, 2017 at 1:51 PM, Dave Page wrote: > Thanks, applied. > > On Mon, Nov 20,

Re: [pgAdmin4][Patch]: RM #2781 - New option to set the quotation mark for copying to clipboard.

;/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/wrappers.py", >> line 81, in _iter_encoded >> >> for item in iterable: >> >> File >> "/Users/dpage/git/pgadmin4/web/pgadmin/utils/driver/psycopg2/__init__.py", >> line

Re: [pgAdmin4][Patch]: RM #2781 - New option to set the quotation mark for copying to clipboard.

Hi Dave, Please find the attached patch. Thanks, Khushboo On Mon, Nov 20, 2017 at 8:59 PM, Dave Page wrote: > Hi > > Thanks, but I'm still getting the same error. > > On Mon, Nov 20, 2017 at 3:23 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: &g

Re: [pgAdmin4][Patch]: Allow user to choose background colour for server

On Tue, Nov 21, 2017 at 5:37 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > PFA updated patch with changes suggested by Ashesh. > Hopefully the last revision :) > > +1 :) > > On Tue, Nov 21, 2017 at 4:12 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi Da

[pgAdmin4][Patch]: RM-2859: Can't create new user

Hi, Please find the attached patch to fix RM #2859: Can't create new user. The "User Management" dialogue footer was overlapping the back-grid table which has been fixed. Thanks, Khushboo diff --git a/web/pgadmin/static/css/bootstrap.overrides.css b/web/pgadmin/static/css/bootstrap.overrides.cs

Re: [pgAdmin4][Patch]: RM-2859: Can't create new user

On Thu, Nov 23, 2017 at 2:58 PM, Dave Page wrote: > Hi > > On Thu, Nov 23, 2017 at 5:03 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch to fix RM #2859: Can't create new user. >

[pgAdmin4][Patch]: RM #2849 - Allow editing of data on tables with OIDs but no primary key

Hi, Please find the attached patch for RM #2849: Allow editing of data on tables with OIDs but no primary key. Thanks, Khushboo diff --git a/docs/en_US/query_tool.rst b/docs/en_US/query_tool.rst index e6dec55..957dcf7 100644 --- a/docs/en_US/query_tool.rst +++ b/docs/en_US/query_tool.rst @@ -148,

Re: [pgAdmin4][Patch]: RM-2859: Can't create new user

Hi Dave, On Fri, Nov 24, 2017 at 3:21 PM, Dave Page wrote: > > > On Thu, Nov 23, 2017 at 10:43 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Thu, Nov 23, 2017 at 2:58 PM, Dave Page wrote: >> >>> Hi &

Re: [pgAdmin4][Patch]: RM-2859: Can't create new user

On Mon, Nov 27, 2017 at 2:20 PM, Dave Page wrote: > > > On Mon, Nov 27, 2017 at 5:25 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Fri, Nov 24, 2017 at 3:21 PM, Dave Page wrote: >> >>> &g

Re: [pgAdmin4][Patch]: RM-2859: Can't create new user

On Mon, Nov 27, 2017 at 2:59 PM, Dave Page wrote: > > > On Mon, Nov 27, 2017 at 9:19 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Mon, Nov 27, 2017 at 2:20 PM, Dave Page wrote: >> >>> >>> >&g

Re: [pgAdmin4][Patch]: RM-2859: Can't create new user

On Mon, Nov 27, 2017 at 4:13 PM, Dave Page wrote: > > > On Mon, Nov 27, 2017 at 10:39 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Mon, Nov 27, 2017 at 2:59 PM, Dave Page wrote: >> >>> >>> >&g

Re: [pgAdmin4][Patch]: RM-2859: Can't create new user

On Mon, Nov 27, 2017 at 4:47 PM, Dave Page wrote: > > > On Mon, Nov 27, 2017 at 11:03 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Mon, Nov 27, 2017 at 4:13 PM, Dave Page wrote: >> >>> >>> >>

Re: [pgAdmin4][Patch]: RM-2859: Can't create new user

On Mon, Nov 27, 2017 at 4:58 PM, Dave Page wrote: > > > On Mon, Nov 27, 2017 at 11:26 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Mon, Nov 27, 2017 at 4:47 PM, Dave Page wrote: >> >>> >>> >>

Re: [pgAdmin4][Patch]: RM-2859: Can't create new user

On Mon, Nov 27, 2017 at 5:01 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Mon, Nov 27, 2017 at 4:58 PM, Dave Page wrote: > >> >> >> On Mon, Nov 27, 2017 at 11:26 AM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wr

Re: [pgAdmin4][Patch]: RM-2859: Can't create new user

On Tue, Nov 28, 2017 at 3:40 PM, Dave Page wrote: > > > On Tue, Nov 28, 2017 at 7:10 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Mon, Nov 27, 2017 at 5:01 PM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com>

Re: [pgAdmin4][Patch]: RM-2859: Can't create new user

Hi Dave, Please find the attached updated patch, which includes: - The fix for this RM - Close button for the error message, which is applicable globally Thanks, Khushboo On Tue, Nov 28, 2017 at 4:18 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Tue, No

Re: [pgAdmin4][Patch]: RM #2849 - Allow editing of data on tables with OIDs but no primary key

Hi, Please find the attached updated patch. On Mon, Nov 27, 2017 at 5:15 PM, Dave Page wrote: > Hi > > On Thu, Nov 23, 2017 at 1:28 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch for RM #2849:

Re: [pgAdmin4][Patch]: RM #2849 - Allow editing of data on tables with OIDs but no primary key

On Sat, Dec 2, 2017 at 10:42 AM, Dave Page wrote: > Hi > > On Thursday, November 30, 2017, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached updated patch. >> >> On Mon, Nov 27, 2017 at 5:15 PM,

[pgAdmin4][Patch]: Fixed RM #2779 - Lost field size

Hi, Please find the attached patch to fix RM #2779: Lost field size. While editing the table column, if we change collate then, the length and the precision are lost. Also, while changing column type, it does not honour the length and precision. Thanks, Khushboo diff --git a/web/pgadmin/browser/

Re: [pgAdmin4][Patch]: RM #2849 - Allow editing of data on tables with OIDs but no primary key

Hi Dave, On Tue, Dec 5, 2017 at 9:43 AM, Dave Page wrote: > Hi > > On Mon, Dec 4, 2017 at 4:01 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Sat, Dec 2, 2017 at 10:42 AM, Dave Page wrote: >> >>> Hi

Re: [pgAdmin4][Patch]: RM #2849 - Allow editing of data on tables with OIDs but no primary key

Please find the attached updated patch with some code cleanup. On Wed, Dec 6, 2017 at 2:34 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Dave, > > On Tue, Dec 5, 2017 at 9:43 AM, Dave Page wrote: > >> Hi >> >> On Mon, Dec 4, 2017 at 4:01

Re: [pgAdmin4][Patch]: Fixed RM #2779 - Lost field size

On Mon, Dec 11, 2017 at 5:40 PM, Dave Page wrote: > Hi > > On Wed, Dec 6, 2017 at 5:45 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch to fix RM #2779: Lost field size. >> >> While

Re: [pgAdmin4][Patch]: Fixed RM #2779 - Lost field size

On Mon, Dec 11, 2017 at 5:45 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Mon, Dec 11, 2017 at 5:40 PM, Dave Page wrote: > >> Hi >> >> On Wed, Dec 6, 2017 at 5:45 AM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wr

Re: [pgAdmin4][Patch]: Fixed RM #2779 - Lost field size

On Mon, Dec 11, 2017 at 6:03 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Mon, Dec 11, 2017 at 5:45 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Mon, Dec 11, 2017 at 5:40 PM, Dave Page wrote:

Re: pgAdmin 4 - Update for Server dialog

Hi susan, I am getting an error while applying the patch, attached the screen-shot for the same. Thanks, Khushboo On Wed, Dec 13, 2017 at 11:20 PM, Susan Douglas < susan.doug...@enterprisedb.com> wrote: > > Hi All, > > I've attached a patch that (hopefully) updates the documented behaviors of

Re: [pgAdmin4][Patch]: Add basic Tab navigation - Debugger

On Thu, Dec 14, 2017 at 2:07 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Yes, we can commit this code, It will add basic button navigation via Tab > key. > > I think we should hold till our final design gets ready. > I will keep the RM open until we add Tab navigation :)

[pgAdmin4][Patch]: RM #2964 - [Desktop Runtime] pgAdmin4 crash if user download query as CVS

Hi, Please find the attached patch to fix the RM #2964: [Desktop Runtime] pgAdmin4 crash if user download query as CVS. Patch by Neel Patel. Thanks, Khushboo diff --git a/runtime/BrowserWindow.cpp b/runtime/BrowserWindow.cpp index 2dd5b49..38982c7 100644 --- a/runtime/BrowserWindow.cpp +++ b/ru

[pgAdmin4][Patch]: RM #2949 : [Web Based] Complete sql should displayed for fts directory in sql pane

Hi, Please find the attached patch to fix RM #2949 : [Web Based] Complete sql should displayed for fts directory in sql pane. Thanks, Khushboo diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/fts_dictionaries/__init__.py b/web/pgadmin/browser/server_groups/servers/database

[pgAdmin4][Patch]: RM #2933 - Add support for transition tables in Postgres 10 triggers

Hi, Please find the attached patch to fix RM #2933 - Add support for transition tables in Postgres 10 triggers. Thanks, Khushboo diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/trigger/sql/10_plus/create.sql b/web/pgadmin/browser/server_groups/servers/dat

[pgAdmin4][Patch]: RM #2956 - pgAdmin 2.0 Preferences: User language drop down remains on screen if not collapsed

Hi, Please find the attached patch to fix RM # 2956 - pgAdmin 2.0 Preferences: User language drop down remains on screen if not collapsed. Thanks, Khushboo diff --git a/web/pgadmin/preferences/static/js/preferences.js b/web/pgadmin/preferences/static/js/preferences.js index ca22a4c..635a6b7 10064

[pgAdmin4][Patch]: RM #2945 - [Web based] Message "can't execute an empty query" displayed if user Click Yes on constrains trigger for view trigger

Hi, Please find the attached patch to fix RM #2945 : [Web based] Message "can't execute an empty query" displayed if user Click Yes on constrains trigger for view trigger Fixed issues: 1. Disable "Constraint trigger?" option in View node 2. Disable "Constraint trigger?" option in edit mode for

Re: [pgAdmin4][Patch]: RM #2933 - Add support for transition tables in Postgres 10 triggers

Hi, Please find the attached updated patch. One small change made in the SQL file due to fix for RM #2945. Thanks, Khushboo On Fri, Dec 22, 2017 at 3:14 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix RM #2933 -

[pgAdmin4][Patch]: RM #2963 - Backup database, Restore database and Maintenance Database failed for é object.

Hi, Please find the attached patch to fix RM #2963: Backup database, Restore database and Maintenance Database failed for é object. Thanks, Khushboo diff --git a/web/pgadmin/misc/bgprocess/processes.py b/web/pgadmin/misc/bgprocess/processes.py index 209c2a1..a5d2655 100644 --- a/web/pgadmin/misc/

Re: [pgAdmin4][Patch]: RM #2963 - Backup database, Restore database and Maintenance Database failed for é object.

On Wed, Jan 3, 2018 at 8:54 PM, Dave Page wrote: > Hi > > On Mon, Dec 25, 2017 at 11:03 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch to fix RM #2963: Backup database, Restore >> database

[pgAdmin4][Patch]: RM #2993 : - [Web Based] User can not view data for View and MATERIALIZED View object.

Hi, Please find the patch to fix RM #2993 : [Web Based] User can not view data for View and MATERIALIZED View object. Thanks, Khushboo diff --git a/web/pgadmin/tools/sqleditor/__init__.py b/web/pgadmin/tools/sqleditor/__init__.py index 84c98d3..aeca5cc 100644 --- a/web/pgadmin/tools/sqleditor/__i

[pgAdmin4][Patch]: RM #2904: As a visually impaired user I need all buttons in the application to have appropriate tooltips for my screen reader to interpret

Hi, Please find the attached patch for RM # 2904: As a visually impaired user I need all buttons in the application to have appropriate tooltips for my screen reader to interpret. Thanks, Khushboo diff --git a/web/pgadmin/about/static/js/about.js b/web/pgadmin/about/static/js/about.js index 1e72c

Re: [pgAdmin4][Patch]: RM #2904: As a visually impaired user I need all buttons in the application to have appropriate tooltips for my screen reader to interpret

On Mon, Jan 15, 2018 at 10:39 PM, Dave Page wrote: > Hi > > On Mon, Jan 15, 2018 at 10:23 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch for RM # 2904: As a visually impaired user >>

Re: [pgAdmin4][Patch]: RM #2904: As a visually impaired user I need all buttons in the application to have appropriate tooltips for my screen reader to interpret

On Wed, Jan 17, 2018 at 12:23 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Mon, Jan 15, 2018 at 10:39 PM, Dave Page wrote: > >> Hi >> >> On Mon, Jan 15, 2018 at 10:23 AM, Khushboo Vashi < >> khushboo.va...@enterprisedb.c

Re: "Fetching all records..."

of the grid header. > It seems that when click the header, the SELECT script is re-executed with > bug behaviour. > > > Logged the bug. Please track with https://redmine.postgresql.org/issues/3035 One suggestion, please upgrade your pgAdmin 4, the latest version is 2.1. Always keep pgadmin-hac

Re: Table Properties... > [Columns tab] very slow

Hi, Please log your bug at https://redmine.postgresql.org/projects/pgadmin4 Thanks, Khushboo On Tue, Jan 23, 2018 at 7:10 PM, microsys.gr microsys.gr < microsys...@gmail.com> wrote: > Version 2.1 > Python Version 2.7.13 (v2.7.13:a06454b1afa1, Dec 17 2016, 20:42:59) > Flask Version 0.12.2 > Appl

Re: suggestion: discard python2.x venv

Hi Loseph, On Tue, Feb 6, 2018 at 9:21 AM, Ioseph Kim wrote: > Hi, > > I used pgadmin4 since 2 month. > > pgadmin4 is a good application for PostgreSQL. that is true! > > but, in multibytes environment, python2 + pgadmin4 is not good choice. > > > if table name or column name is multibytes, exp

[pgAdmin4][Patch]: RM #2899: Provide access keys/shortcuts to all commonly used menu options in the main window.

Hi, Please find the attached patch for RM #2899: Provide access keys/shortcuts to all commonly used menu options in the main window. Shortcuts provided in this patch: Alt+Shift+Q Open the query tool Alt+Shift+V View data Alt+Shift+C Open the context menu Alt+Shift+N Create an object Alt+Shift+E

Re: [pgAdmin4][Patch]: RM #2899: Provide access keys/shortcuts to all commonly used menu options in the main window.

the same. > > Thanks > Joao > > Thanks, Khushboo > On Thu, Feb 8, 2018 at 2:08 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch for RM #2899: Provide access >> keys/shortcuts to all common

[pgAdmin4][Patch]: RM 3081- Reverse engineered SQL for Sequences missing comment header and drop statement

Hi, Please find the attached patch to fix RM #3081 : Reverse engineered SQL for Sequences missing comment header and drop statement Thanks, Khushboo diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/sequences/__init__.py b/web/pgadmin/browser/server_groups/servers/databases

[pgAdmin4][Patch]: RM #3066 - Create script doesn't add quotation marks to column names for the "add index" functions

Hi, Please find the attached patch to fix RM #3066 - Create script doesn't add quotation marks to column names for the "add index" functions Thanks, Khushboo diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/index/sql/default/create.sql b/web/pgadmin/brow

Re: [pgAdmin4][Patch]: RM #3066 - Create script doesn't add quotation marks to column names for the "add index" functions

On Mon, Feb 19, 2018 at 5:19 PM, Dave Page wrote: > Hi > > On Mon, Feb 19, 2018 at 7:56 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch to fix RM #3066 - Create script doesn't >> add

[pgAdmin4][Patch]: RM #3077 - ERROR: invalid byte sequence for encoding "LATIN1":0x00

Hi, Please find the attached patch to fix RM #3077 : ERROR: invalid byte sequence for encoding "LATIN1":0x00 Thanks, Khushboo diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/trigger/sql/10_plus/properties.sql b/web/pgadmin/browser/server_groups/servers/da

Re: [pgAdmin4][Patch]: RM #3077 - ERROR: invalid byte sequence for encoding "LATIN1":0x00

On Wed, Feb 21, 2018 at 10:51 PM, Dave Page wrote: > > > On Wed, Feb 21, 2018 at 3:45 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hi >> The patch looks good, do we have any example error that we can test in >> order to ensure the problem no longer shows up in the fut

[pgAdmin4][Patch]: Remove webpack plugin hardSourceWebpackPlugin from the production environment

Hi, Please find the attached patch to remove webpack plugin hardSourceWebpackPlugin from the production environment. Thanks, Khushboo diff --git a/web/webpack.config.js b/web/webpack.config.js index b989a4c..84f8466 100644 --- a/web/webpack.config.js +++ b/web/webpack.config.js @@ -324,7 +324,6 @

Re: [pgAdmin4][Patch]: RM #3077 - ERROR: invalid byte sequence for encoding "LATIN1":0x00

On Thu, Feb 22, 2018 at 5:32 PM, Dave Page wrote: > > > On Thu, Feb 22, 2018 at 4:11 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Wed, Feb 21, 2018 at 10:51 PM, Dave Page wrote: >> >>> >>&g

Re: [pgAdmin4][Patch]: RM #3077 - ERROR: invalid byte sequence for encoding "LATIN1":0x00

On Fri, Feb 23, 2018 at 9:45 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Thu, Feb 22, 2018 at 5:32 PM, Dave Page wrote: > >> >> >> On Thu, Feb 22, 2018 at 4:11 AM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wro

Re: PoC electron and pgAdmin4

On Sat, Feb 24, 2018 at 1:44 AM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > After the removal of the Webkit environment we gave a shot to add electron > as our runtime environment. We were able to do it with some degree of > success. > The links to get a version

[pgAdmin4][Patch]: RM #3094 - Notices from query n are shown in messages from query n+1

Hi, Please find the attached patch to fix the RM #3094: Notices from query n are shown in messages from query n+1 Thanks, Khushboo diff --git a/web/pgadmin/utils/driver/abstract.py b/web/pgadmin/utils/driver/abstract.py index 32e1c97..1722e21 100644 --- a/web/pgadmin/utils/driver/abstract.py +++

[pgAdmin4][Patch]: PEP-8 issue fixes

Hi, Please find the attached patch to fix PEP-8 issues in the below modules: 1. about 2. feature_tests 3. misc 4. utils Thanks, Khushboo diff --git a/web/pgadmin/about/__init__.py b/web/pgadmin/about/__init__.py index 98a4dd6..6d1e0b2 100644 --- a/web/pgadmin/about/__init__.py +++ b/web/pgadmin/

Re: [pgAdmin4][Patch]: PEP-8 issue fixes

On Mon, Feb 26, 2018 at 9:19 PM, Dave Page wrote: > Can you rebase this please? It doesn't apply against master. > > Please find the updated patch excluding utils module as it is already done. > On Mon, Feb 26, 2018 at 12:04 PM, Khushboo Vashi < > khushboo.va...@enterpris

Re: pgAdmin 4 commit: Ensure we pick up the messages from the current query

>>> >>> >>> -- >>> Regards, >>> Murtuza Zabuawala >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> >>> On Mon, Feb 26, 2018 at 7:49 PM, Dave Page wrote: >>> &

Re: pgAdmin 4 commit: Ensure we pick up the messages from the current query

> > 79 characters) > pgadmin/utils/driver/psycopg2/__init__.py:1283: [E501] line too long (91 > > 79 characters) > 4 E501 line too long (81 > 79 characters) > > Fixed. Thanks for pointing out. > > Thanks > Joao > > > On Wed, Feb 28, 2018 at 6:49 AM

  1   2   3   4   5   6   7   8   >