Hi,
Please find the attached fix for the same.
Thanks,
Khushboo
On Thu, Jun 22, 2017 at 2:18 PM, Dave Page <dp...@pgadmin.org> wrote:
> Hmm, yes - and it's not giving the normal error instructing the user
> to set the path, but another one: "Failed to load preference
> pg_bin_dir of module paths".
>
> Khushboo, can you investigate and fix ASAP please?
>
> On Thu, Jun 22, 2017 at 9:31 AM, Murtuza Zabuawala
> <murtuza.zabuaw...@enterprisedb.com> wrote:
> > Hi Khusboo,
> >
> > Looks like given change have broken Backup, Restore, Import/Export &
> > Maintenance, even if I have binary path set it is throwing an error.
> >
> > --
> > Regards,
> > Murtuza Zabuawala
> > EnterpriseDB: http://www.enterprisedb.com
> > The Enterprise PostgreSQL Company
> >
> > On Wed, Jun 21, 2017 at 9:40 PM, Dave Page <dp...@pgadmin.org> wrote:
> >>
> >> Thanks, patch applied!
> >>
> >> On Wed, Jun 21, 2017 at 12:44 PM, Khushboo Vashi
> >> <khushboo.va...@enterprisedb.com> wrote:
> >> > Hi,
> >> >
> >> > Please find attached patch to fix RM #2487: get_preference() uses a
> >> > synchronous AJAX request.
> >> >
> >> > Introduced the client side caching for preferences to get rid of
> >> > synchronous
> >> > AJAX request.
> >> >
> >> >
> >> > Thanks,
> >> > Khushboo
> >>
> >>
> >>
> >> --
> >> Dave Page
> >> Blog: http://pgsnake.blogspot.com
> >> Twitter: @pgsnake
> >>
> >> EnterpriseDB UK: http://www.enterprisedb.com
> >> The Enterprise PostgreSQL Company
> >>
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
diff --git a/web/pgadmin/preferences/__init__.py b/web/pgadmin/preferences/__init__.py
index a59e26d..e3af7d0 100644
--- a/web/pgadmin/preferences/__init__.py
+++ b/web/pgadmin/preferences/__init__.py
@@ -154,7 +154,7 @@ def preferences_s():
if len(m['categories']):
for c in m['categories']:
for p in c['preferences']:
- p['module'] = m['label']
+ p['module'] = m['name']
res.append(p)
return ajax_response(
diff --git a/web/pgadmin/utils/preferences.py b/web/pgadmin/utils/preferences.py
index 3148417..c7127c9 100644
--- a/web/pgadmin/utils/preferences.py
+++ b/web/pgadmin/utils/preferences.py
@@ -303,6 +303,7 @@ class Preferences(object):
res = {
'id': self.mid,
'label': self.label or self.name,
+ 'name': self.name,
'categories': []
}
for c in self.categories:
