Re: [pgadmin-hackers][Patch] Change alert styling

Hi! Are you committing to migrating all the main CSS to SCSS? Whilst I can see > the advantages of SCSS, I don't want to end up with a mix and match mess of > the two (though, I'd be fine with keeping the smaller, module-specific CSS > if it doesn't make sense to migrate it). It makes more sense

[pgadmin-hackers][patch] delete icon width in security labels form

Hello Hackers, We found a discrepancy with the width of inserted columns in some backform tables. It is at least present in Create Table -> Security [tab] -> clicking [+] for new rows under each of Privileges and Security Labels. In this case, the cell containing the delete icon is spaced differen

[pgadmin-hackers][patch] Update the error alerts style in dialog

Hi Hackers, We updated the style of the error alerts in the dialogs window to match the style guide. Below is a screenshot of how it looks: [image: Inline image 1] Thanks Shruti & Joao change-style-of-error-alerts-in-dialogs.patch Description: Binary data

[pgadmin-hackers][pgaweb][patch] Website patch to add SCSS

Hi Hackers, In this email you will be able to find the first patches to start the migration of the Styleguide from http://pgadmin4-styleguide.cfapps.io/ to the pgadmin.org webpage. The first patch adds a Readme to the project and also the yarn.lock file The second patch: - Adds SCSS processor to

Re: [pgadmin-hackers][pgaweb][patch] Website patch to add SCSS

Hello Dave, Instead of using the current library we found another one that compiles the SCSS when the application starts. We recreated the patches we sent before. Thanks Joao & Sarah On Fri, Jul 14, 2017 at 5:42 AM, Dave Page wrote: > > > On Wed, Jul 12, 2017 at 9:27 PM, George Gelashvili > wr

[pgadmin-hackers] 10k Tables and more

Hi Hackers, We were looking at a schema that had 10k+ tables on it and we noticed a substantial decrease of performance while loading the tables and after they are loaded and we try to scroll over them. After some search on the web we found a post of the ACITree maintainer here

[pgadmin-hackers][pgaweb][Patch] Add style guide to pga website

Hello Hackers, With this patch we added the style guide to the current pgAdmin website. It is not 100% migrated yet, but we already have the Alerts and colors. Thanks Matt && João diff --git a/README.md b/README.md index 3b1c852..0eaec2e 100644 --- a/README.md +++ b/README.md @@ -65,9 +65,12 @@ p

Re: [pgadmin-hackers][pgaweb][Patch] Add style guide to pga website

ish is en_US (of which there are a surprisingly large > amount). > > >> >> -- Rob >> >> On Tue, Jul 18, 2017 at 7:54 AM, Dave Page wrote: >> >>> >>> >>> On Mon, Jul 17, 2017 at 7:51 PM, Joao De Almeida Pereira < >>> jdealm

Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

Hello Dave, Did you use the latest one patch we sent? We realised that this was an issue in the second email we sent. Thanks Joao On Thu, Jul 20, 2017, 8:15 AM Dave Page wrote: > Hi > > On Wed, Jul 19, 2017 at 8:33 PM, Shruti Iyer wrote: > >> Hi again! >> >> Attached are the most updated patche

[pgadmin-hackers][pgaweb][patch] Update SCSS of styleguide

Hi Hackers, This patch updates the SCSS files of the styleguide to move all the colors into variables to be easier to use in the application. Thanks Joao && Matt diff --git a/pgaweb/static/css/styleguide/_alert.scss b/pgaweb/static/css/styleguide/_alert.scss index 26680b7..2c85514 100644 --- a/pg

[pgadmin-hackers][patch]

Hi hackers, With the last commits, the behavior of focusing on a selected entry when entering the History Tab was not working as expected. This patch will bring this behavior back. Thanks Joao & Matt focus-on-entry-when-enter-history.diff Description: Binary data

[pgadmin4][Patch]: Display Functions node for GreenPlum database

Hello Hackers, We had some requests from GreenPlum users to display the functions node again. This patch reintroduces functions as a node underneath the Schemas. Unfortunately this patch is not final because I could not find the place where the Data Type is populated from. (See next image)[image:

[pgAdmin4][Patch] Statistics button not working for GreenPlum

Hello Hackers, Find attached a patch that enables the retrieval of statistics for databases and servers on GreenPlum databases. Thanks Joao diff --git a/web/pgadmin/browser/server_groups/servers/databases/templates/databases/sql/default/stats.sql b/web/pgadmin/browser/server_groups/servers/dat

Re: [pgadmin4][Patch]: Display Functions node for GreenPlum database

> -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > On Thu, Jan 11, 2018 at 9:31 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hello Hackers, >> We had some reques

[pgadmin4][Patch] Access Database properties

Hi Hackers, This patch tackles the visualization of properties on a GreenPlum Database. Previously when you tried to access these properties a SQL error was displayed. Also in the patch we made some correction to feature tests, and skipped other test that were failing against GreenPlum Thanks Joa

Re: [pgadmin4][Patch]: Display Functions node for GreenPlum database

on line 304 (function.js) > > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > On Fri, Jan 12, 2018 at 8:10 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote

Re: [pgadmin4][Patch]: Display Functions node for GreenPlum database

@Dave I sent the new patch with correction in the previous email. Can you review it and let us know if it is ok? On Fri, Jan 12, 2018 at 12:48 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Thanks for the help Murtuza > > Attached you can find the revisited

[pgadmin4]{Patch] Display GreenPlum partitions and correct SQL on SQL Tab

Hello Hackers, In the attached patches we enable the display of partitions on GreenPlum database and also correct SQL that was being used in the SQL tab form Schemas Thanks Joao diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/schema/gpdb_5.0_plus/sql/acl.sql

Re: [pgadmin4][Patch]: Display Functions node for GreenPlum database

Hello Hackers, I am updating this patch as we found out that the SQL tab was not showing the functions properly, and we corrected that in the new update patch in this email Thanks Joao On Wed, Jan 17, 2018 at 12:25 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: >

[pgadmin4] Explain plans

Hello Hackers, We are trying to find a solution for the explain plans that currently are not working in GP, due to the lack of support for JSON. We believe that the best options for this it would be to display the text in the tab instead of the visual version for our case. In order to implement thi

[pgadmin4] Feature tests

Hello Hackers, Is the latest commit in master passing the Feature tests? Thanks Joao

Re: [pgadmin4] Explain plans

try to do some work in this extraction. Thanks Joao On Mon, Jan 22, 2018 at 4:58 AM, Dave Page wrote: > Hi > > On Fri, Jan 19, 2018 at 2:09 PM, Joao De Almeida Pereira > wrote: > > Hello Hackers, > > We are trying to find a solution for the explain plans that currently a

Re: [pgadmin4]{Patch] Display GreenPlum partitions and correct SQL on SQL Tab

. It is now ready for Review and Merge Thanks Joao On Thu, Jan 18, 2018 at 9:48 AM Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Hackers, > > In the attached patches we enable the display of partitions on GreenPlum > database and also correct SQL that

Re: [pgadmin4][Patch]: Display Functions node for GreenPlum database

Any comments on this patch? Or is it ready to merge? On Fri, Jan 19, 2018 at 7:56 AM Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Hackers, > I am updating this patch as we found out that the SQL tab was not showing > the functions properly, and we correc

[pgadmin4][patch] Correct Bug #3050

Hi Hackers, We corrected the SQL tab display of partitioned table in GreenPlum, with the attached diff. I was able to create the Issue in Redmine and assign it to me, but I cannot change the status of it. Do I need to have any special permission? Thanks Joao display_partition_sql_in_tab.diff De

[pgadmin][patch] Make Feature and Unit tests Green Again

Hi Hackers, Attached you can find a diff with the correction of Bug 3057. With the latest changes to display some information in GP some Feature Tests stopped working when run against a GP instance. Also we found out that the Feature Test(PGDataType) against 9.2 is failing for some time as well. S

Re: [pgadmin][patch] Make Feature and Unit tests Green Again

Hello, We changed the name in the JSON and extracted the validation to a function to make the code more readable. Thanks Joao On Fri, Jan 26, 2018 at 5:47 AM Dave Page wrote: > Hi > > On Thu, Jan 25, 2018 at 7:10 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io&

Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan and Explain analyze plan an error is displayed

Hello, Any feedback on this Patch? Thanks Joao On Fri, Feb 2, 2018 at 5:50 PM Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > This is quite a big patch in order to solve the problem with the Explain > Plan. > > We sent 2 patches th

[pgadmin4] Hide tabs in create table

Hi hackers, We are trying to hide the advanced tab in the Create Table screen, and we were looking into table.js file, but cannot find a way to hide it . Does anyone have an idea on how to do this? Thanks Joao

Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan and Explain analyze plan an error is displayed

Hello, Any Feedback on this Patch? We have other changes that we already developed that depend on this change. Thanks On Tue, Feb 6, 2018 at 9:33 AM Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello, > Any feedback on this Patch? > > Thanks > Joao >

Re: [pgAdmin4][Patch]: RM #2899: Provide access keys/shortcuts to all commonly used menu options in the main window.

Hello Khushboo, We were looking into the your patch and have some questions. - What is the reason being the front end shortcuts being registered in the python code? There is already some precedent in the code, but this looks like a concern of the front end. - Didn't saw any tests around this,

Re: [pgAdmin4][RM#2901] Make shortcuts configurable in Debugger

Hello Murtuza, After some review of the code we do have some questions: - Do we really need to have the shortcuts in the backend?(I already asked this in Khushboo's patch) - Do we need to have keyAction function(in direct.js) inside this Javascript file or can we extract that an create some tests

Re: [pgadmin4] Hide tabs in create table

Thanks Ashesh I will give it a try and see if I can me it work. On Wed, Feb 7, 2018 at 10:04 PM Ashesh Vashi wrote: > On Thu, Feb 8, 2018 at 4:01 AM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hi hackers, >> We are trying to hide the advan

Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan and Explain analyze plan an error is displayed

> Thanks. > > On Fri, Feb 9, 2018 at 11:54 AM, Dave Page wrote: > >> Thanks, patches applied. >> >> On Fri, Feb 2, 2018 at 10:50 PM, Joao De Almeida Pereira < >> jdealmeidapere...@pivotal.io> wrote: >> >>> Hi Hackers, >>> This is quite

[pgadmin4][patch] #3099 GPDB: Creating table and creating column in table fails

Hi Hackers, Attached is the patch that correct the creation of tables and columns. Also started using in a more widespread way the `compile_template_path` function to have the logic in a single place. Hides the Advanced Tab on table creation for GreenPlum Databases Correctly retrieves the collat

[pgadmin4][patch] Hides the tablespace node in ACI tree for GreenPlum

Hi Hackers The attached patch implements the feature #3107 to hide the tablespaces on GreenPlum databases. Thanks Joao hide-tablespaces-for-greenplum.diff Description: Binary data

Re: [pgAdmin4][RM#3105] Allow user to insert new row if PK is in capital letters

Hello Murtuza, Just reviewed your patch, and it looks good. Do you think you can wrap some tests around this behavior to ensure it doesn't happen again in the future? Thanks Joao On Thu, Feb 15, 2018 at 8:34 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to

Re: [pgAdmin4][RM#2950] Add marker to dashboard queries

Hello Murtuza, I was looking into the Issue information and the solution that was provided there needs some polish. With the solution that was asked, the log will still be generated, but eventually will not show up in a log monitor, but nevertheless will be there. After some digging around the cod

Re: [pgAdmin4][RM#3121] Fix PEP-8 issues

Hello Murtuza, I just run this patch as you suggested(no errors reported) and also run it through our CI pipeline and it look good Thanks Joao On Wed, Feb 14, 2018 at 7:23 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the PEP-8 issues, > > To verify

Re: [pgAdmin4][RM#2950] Add marker to dashboard queries

o, > > It was mainly intended for PostgreSQL database logs and not pgAdmin4 logs > :) > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > On Thu, Feb 15, 2018 at 8:03 PM, Joao De Almeida

Re: [pgAdmin4][RM#3105] Allow user to insert new row if PK is in capital letters

Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> >> On Thu, Feb 15, 2018 at 7:34 PM, Joao De Almeida Pereira < >> jdealmeidapere...@pivotal.io> wrote: >> >>> Hello Murtuza, >

Re: [pgadmin4][patch] Hides the tablespace node in ACI tree for GreenPlum

Hello Dave, No there is only tests around the the backendsupport function Thanks Joao On Mon, Feb 19, 2018 at 6:08 AM Dave Page wrote: > Hi > > On Mon, Feb 12, 2018 at 6:30 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hi Hackers >>

Re: [pgadmin4][patch] Hides the tablespace node in ACI tree for GreenPlum

Hello, It is to make it clear which shortcut test is failing, something similar to the query tool tests. If you want I can separate those in 2 separate patches Thanks Joao On Tue, Feb 20, 2018 at 12:05 PM Dave Page wrote: > Hi > > On Tue, Feb 20, 2018 at 4:51 PM, Joao De Almeid

Re: [pgAdmin4][RM#2900] Adding accessibility features in query tool

Hello Murtuza, After reviewing the code I have some suggestions: - We should split the PEP and the features into different patches, or else it becomes very hard to separate Feature code from Code Style change - The function: `getTextRepresentaionShortcut` has a typo - As a personal point I have

[pgadmin4] Priorities of features

Hi Hackers, After the last month or something that I came back to this project I noticed that we put a lot of effort in making all these shortcuts configurable. But I do not understand the driver for this push. Do we have people complaining about the lack of shortcuts? Are people complaining abou

Re: [pgAdmin4][Patch]: RM #3077 - ERROR: invalid byte sequence for encoding "LATIN1":0x00

Hi The patch looks good, do we have any example error that we can test in order to ensure the problem no longer shows up in the future? If they could be Unit Tests instead of Feature tests that would be awesome, because Feature tests are much more expensive then Unit. Thanks Joao On Wed, Feb 21,

Re: [pgAdmin4][RM#3014] Fix validation issues while creating new sequence

Hi Murtuza, Looks good. Was there any reason for the change in position of the if statements in the sql file. Makes the output more readable? Looks like we need some test to ensure that the Sequence issue does not happen again. Maybe a Unit Test is good enough, to ensure that we are creating a good

Re: RM2898 Keyboard navigation in dialog tabs (nav tabs)

Hello Harshal, I passed the patch through our CI and all the tests passed. The changes do not break previous behavior but because there are no tests on the new feature we could not be sure it was really working. So we did some manual testing and sometimes it doesn't work, like it gets stuck in a

Re: RM2898 Keyboard navigation in dialog tabs (nav tabs)

Yep I installed the V2 file On Wed, Feb 21, 2018 at 11:31 AM Dave Page wrote: > On Wed, Feb 21, 2018 at 4:22 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hello Harshal, >> >> I passed the patch through our CI and all the tests pa

Re: [pgAdmin4][RM#2900] Adding accessibility features in query tool

we could avoid the problem above. Thanks Joao On Wed, Feb 21, 2018 at 12:50 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Joao, > > Thank you for your time in reviewing the patch. > > > On Wed, Feb 21, 2018 at 9:11 PM, Joao De Almeida Pe

[pgadmin4] PEP-8 on pgadmin/tools

Hi hackers, Attached, you can find the PEP-8 the pgadmin/tools fixes. Thanks Joao pep8-on-pgadmin-tools.diff Description: Binary data

Re: [pgadmin4] PEP-8 on pgadmin/tools

Not 100% working, sorry I will send the patch again as soon as I have a fix On Wed, Feb 21, 2018 at 6:17 PM Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi hackers, > Attached, you can find the PEP-8 the pgadmin/tools fixes. > > Thanks > Joao >

Re: [pgadmin4] PEP-8 on pgadmin/tools

Hello, I fixed the issues from the previous patch. This new patch should be working as expected. Thanks Joao On Thu, Feb 22, 2018 at 9:19 AM Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Not 100% working, sorry I will send the patch again as soon as I have a fix &

[pgadmin4] Creating a new Node in ACI Tree

Hello Hackers, Need some pointers while creating new node on ACI Tree. In GreenPlum there is a concept of External Tables that are more or less similar to Foreign Wrappers, but different. So we started implementing a new node for it. We copied the Foreign Wrappers node and started it playing with

Re: [pgadmin4] Creating a new Node in ACI Tree

s on Dependencies panel > Which will call to method def dependencies(...) method > > *'dependent'* - Displays object dependents on SQL panel > Which will call to method def dependents(...) method > > Hope that helps. > > -- > Regards, > Murtuza Zabuawala &

PoC electron and pgAdmin4

Hi Hackers, After the removal of the Webkit environment we gave a shot to add electron as our runtime environment. We were able to do it with some degree of success. The links to get a version running with electron are: Windows: https://storage.googleapis.com/pgadmin-binaries/releases/pgAdmin%204%2

[pgadmin4][patch] Table Statistics in GreenPlum #3059

Hi Hackers, The attached patch fixes the statistics retrieval of tables in GreenPlum Thanks Joao diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/table/sql/9.1_plus/stats.sql b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/tab

Re: PoC electron and pgAdmin4

ala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > On Sat, Feb 24, 2018 at 1:44 AM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hi Hackers, >> After the removal of the Webkit environment we gave a shot

Re: [pgAdmin4][RM#2900] Adding accessibility features in query tool

; always get *undefined* for preferences values. > > Thanks, > Murtuza > > On Thu, Feb 22, 2018 at 3:17 AM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hello Murtuza, >> I created a small patch on the way I believe the function should wo

Re: PoC electron and pgAdmin4

libraries present. Thanks Joao On Mon, Feb 26, 2018 at 9:42 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Joao, > > Attaching the screenshot. > > On Mon, Feb 26, 2018 at 7:50 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: >

Re: [pgadmin4] Creating a new Node in ACI Tree

Thanks for the stearing, I finally found out the problem. I was missing an 's' in the end of one of the names Joao On Fri, Feb 23, 2018 at 10:19 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Joao, > > On Fri, Feb 23, 2018 at 11:23 PM

[pgadmin4][patch] Solves the bug #3150

Hi hackers, Attached you can find the correct for the bug #3150. The functions SQL tab stopped working after #3060, this patch changes the SQL to ensure that the tab is working again. Thanks Joao functions-display-sql-greenplum.diff Description: Binary data

Re: [pgAdmin4][RM#3002] To fix the indentation issue in query tool editor

Hello Murtuza, The patch looks good, and solves the problem. Run the patch on our CI and everything is green. Thanks Joao On Tue, Feb 27, 2018 at 8:11 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue where Tab key was not working as expected

Re: RM3079 fix for wrong sql datetime/time related datatypes

Hello Harshal, I tried the example you showed and it works. Also passed the patch through our CI Pipeline and everything is good. Thanks Joao On Wed, Feb 28, 2018 at 6:25 AM Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > On Tue, Feb 27, 2018 at 8:54 PM, Dave Page wrote: > >

Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI

Hello Murtuza, I do not have the pgAgent installed so it was a little it hard to test this. After looking into the code I think we are missing some testing coverage around the pga_job Javascript part so that we can catch these problems. Even some code extraction can be done around the pg_jobset cha

Re: pgAdmin 4 commit: Ensure we pick up the messages from the current query

Hello Khushboo, After reviewing the patch I have the gut feeling that we do not have enough test coverage on this issue, specially due to the intricate while loop and conditions around the polling. I think that this deserve Unit tests around it, When I say Unit Test I am not talking about executing

Re: Feature #3061

Hello Neethu Welcome to the pgadmin-hackers, nice to see you here. In order to start this story, I believe that we need to talk with some users to understand what does this story mean. At this point the issue is to broad and I personally do not understand what customization means. But feel free t

Re: [pgAdmin4][RM#3161] Fix PEP-8 issues

Hello Murtuza, I passed the patch through our CI and all test are green. Also run the codestyle in all those folders and everything is clean. 575 issues to go Thanks Joao On Wed, Feb 28, 2018 at 1:05 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix t

Re: [pgAdmin4][Patch]: RM #3135 - [Web based] Syntax error displayed when user try to insert data on table where primray key is in captial letters and table contains OIDS

Hello Kushboo, Can we add some Unit test to ensure this does not happen again? Thanks Joao On Thu, Mar 1, 2018 at 2:28 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix RM # 3135 - [Web based] Syntax error > displayed when user try to in

Re: [pgAdmin4][Patch]: PEP-8 fixes in the foreign data wrapper module

Hello Khushboo, I applied this patch and here is the result: 2018-03-01 09:41:00 ⌚ |ruby-2.4.1| pgadmin-dev in ~/workspace/pgadmin4/web ± |pep-8-fdw {2} U:13 ✗| → git st On branch pep-8-fdw Changes not staged for commit: (use "git add ..." to update what will be committed) (use "git checkout

Re: pgAdmin 4 commit: Ensure we pick up the messages from the current query

le to refactor and simply our code. Like everything in life there need to be a balance. Thanks Joao On Thu, Mar 1, 2018 at 12:56 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Joao, > > Thanks for reviewing. > > On Wed, Feb 28, 2018 at 8:55 PM, Joao De Almeida

Re: [pgAdmin4][RM#3129] handle encoding issue in File manager

Hello Murtuza, The code looks pretty good, love the fact that you extracted it so that our file size stop growing and get more manageable. All tests pass on our CI. The only issue I found was linting: pycodestyle --config=.pycodestyle pgadmin/tools/sqleditor/ pgadmin/tools/sqleditor/utils/query_

Re: Bug #2309 fix

Hello Neethu, We run the patch though our test pipeline and all tests are green. Everything looks good with this patch Thanks Joao On Thu, Mar 1, 2018 at 10:37 AM Neethu Mariya Joy wrote: > Hi, > I am Neethu Mariya Joy, an undergraduate pursuing BE in Computer Science > at BITS Pilani. > > I've

Re: [pgAdmin4][RM#3129] handle encoding issue in File manager

> Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > On Thu, Mar 1, 2018 at 8:56 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hello Murtuza, >> >> The code lo

Re: Bug #3083 fix

Hello Neethu, We passed the patch through our CI pipeline and all tests pass. The code looks good, but we are trying to decouple files as much as we can so that we do not end up with files with over 1000 lines, that are hard to read and to maintain. Also we are trying to create Unit Tests to have

[pgadmin4][patch] External Tables for GreenPlum #3168

Hello Hackers, Attached you can find the patch that remove the External Tables from the Tables node and create a new node at the database level for GreenPlum. - Do not display External Tables in the Tables node - Create a new node under databases for External Tables - Generate DDL for external

Re: pgAdmin 4 commit: Ensure we pick up the messages from the current query

igher you go in the pyramid the more volatile the test are and more variables need to be taken into account when doing them. Thanks Joao On Fri, Mar 2, 2018 at 8:31 AM Dave Page wrote: > On Thu, Mar 1, 2018 at 3:21 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io>

[pgadmin4][patch] GreenPlum function statistics through an exception

Hi Hackers, You can find attached the resolution for issue 3176. When trying to retrieve the statistics from a function in a GreenPlum database an error is displayed, To fix this for version 5.X we decided to remove the ability to get statistics. Thanks Joao diff --git a/web/pgadmin/browser/server

Re: pgAdmin 4 commit: Ensure we pick up the messages from the current query

;> >> Please find the attached updated patch. > >> Thanks. >> >> On Thu, Mar 1, 2018 at 5:56 AM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi Joao, >>> >>> Thanks for reviewing. >>> >>>

Re: [pgAdmin4][RM#3037] Allow user to disable Gravatar image

Hi Murtuza, Why are we doing this using templates? Can this be done with a request to the backend to get the image and then retrieve the Gravatar if it is defined or return a static image if not? + +{% if config.SERVER_MODE %} window.onload = function(e){ setTimeout(function() { - var gravat

Re: [pgAdmin4][RM#3175] Fix PEP-8 issues

Hi Murtuza, Looks good, and all tests are green. I run the commands provided and nothing pops up. Only missing 374 :D Thanks Joao On Mon, Mar 5, 2018 at 7:09 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix PEP8 issues in Browser & Database modules,

Re: [pgAdmin4][RM#3037] Allow user to disable Gravatar image

ravatar/> > module for this and it is designed to work with template only. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > On Mon, Mar 5, 2018 at 8:57 PM, Joao De Almeida Pereira <

Re: pgAdmin 4 commit: Support for external tables in GPDB. Fixes #3168

Hello Neel, You can find attached the corrections of the path's needed for windows. The fix should correct TestExternalTablesView and TestTemplateCreate but for the ChangePasswordTestCase I need more information to help you out. We need to understand what is the response that the endpoint /user_ma

Re: pgAdmin 4 commit: Ensure we pick up the messages from the current query

Hello Khushboo, Thanks for the changes here. Now everything looks good, and the tests all pass. Thanks Joao On Tue, Mar 6, 2018 at 5:09 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > On Mon, Mar 5, 2018 at 8:42 PM, Joao De Almeida Pereira < > jdealmeidapere...@pi

Re: [pgAdmin4][Patch]: RM #3135 - [Web based] Syntax error displayed when user try to insert data on table where primray key is in captial letters and table contains OIDS

ao On Tue, Mar 6, 2018 at 7:33 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Joao, > > Thanks for reviewing. > > On Thu, Mar 1, 2018 at 8:06 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hello Kushboo, >> >

Re: [pgAdmin4][RM#2989] To fix the issue in Table node

Hi Murtuza, The code change works, and I passed the patches through our pipeline and everything is green. Personally I would love this bug fixes to have refactored the function into smaller chunk and made it more readable so that the next time someone need to check out a problem in the same area i

Re: [pgAdmin4][RM#3037] Allow user to disable Gravatar image

brainer really, > assuming we ensure we update/invalidate the cache when needed), and using > promises for accessing them. > > >> >> I may be wrong, Let's wait for the input from other community members. >> >> Regards, >> Murtuza >> >> On Tue

[pagdmin][patch] Update jasmine #3182

Hi Hackers, Attached you can find the patch that updates the version of jasmine to 3.0 Thanks Joao diff --git a/web/package.json b/web/package.json index 2707b334..a4cb58d5 100644 --- a/web/package.json +++ b/web/package.json @@ -18,7 +18,7 @@ "file-loader": "^0.11.2", "image-webpack-lo

Re: pgAdmin 4 commit: Support EXPLAIN on Greenplum. Fixes #3097

Hello Khushboo, Completely forgot about this python "feature"... Attached is the fix. Just as a side question, does anyone else feel the pain of wanting to run a single test using a IDE or the command line and not being able to? We an HandRolled the loader, and that as some implications. Did a

Re: [pgAdmin4][RM#2989] To fix the issue in Table node

Hello Murtuza/Dave, Nice splitting of some of the functionality into functions, removing some of the complexity of the initial function. Good job. I made some changes because the linter was failing and also changed some variable names. These changes pass our CI and the linter. Thanks Joao On Th

Re: pgAdmin 4 commit: Support EXPLAIN on Greenplum. Fixes #3097

response_data = json.loads(response.data.decode('utf-8')) self.server_id = response_data['node']['_id'] def tearDown(self): """This function delete the server from SQLite """ utils.delete_server_with_api(self.

Re: pgAdmin 4 commit: Support EXPLAIN on Greenplum. Fixes #3097

On Fri, Mar 9, 2018 at 11:04 AM Dave Page wrote: > Hi > > On Fri, Mar 9, 2018 at 3:54 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hello, >> Definitely running single tests is something that would be great, >> specially if

Re: ACI Tree

Hi Hackers, Maybe this list might not have a big group of users of the application itself, nevertheless it would be interesting to understand if this is a specific problem of GreenPlum Use Case or not. This issue is preventing a wider adoption of pgAdmin4 by the GreenPlum users. >From a preliminar

[pgadmin4][patch] Unit test fail on GreenPlum (#3190)

Hello Hackers, Attached you can find the patch that skip some tests and correct issues on SQL that are failing when trying to connect to a GreenPlum database. We did this by adding a attribute to to test_json called "db_type" that will carry the type of database we are running tests against. Whe

Re: [pgadmin4][patch] Unit test fail on GreenPlum (#3190)

Hello, Can you point out an example? Thanks On Sat, Mar 10, 2018, 3:53 PM Dave Page wrote: > Hi > > On Friday, March 9, 2018, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hello Hackers, >> >> Attached you can find the patch that s

Re: pgAdmin 4 commit: Support for external tables in GPDB. Fixes #3168

also encounter similar issue on Windows while running tests. >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> >> On Tue, Mar 6, 2018 at 8:25 PM, Joao De Almeida Pere

Re: [pgAdmin4][RM#3140] Add service parameter

Hi Dave and Murtuza, Regarding this patch we refactored the Javascript code so that is lives in a different file and added some tests. Also we found an issue with karma-jasmine that does not allow us to use jasmine 3.1 yet. You can find attached a patch that reverts that commit. Thanks Victoria

Re: pgAdmin 4 commit: Fix unicode handling in the external process tools an

Hi Dave, Khushboo Looks like there is a linting issue with this commit: Successfully installed pycodestyle-2.3.1 /tmp/build/4a5630c2/pgadmin-master/web /tmp/b

Re: pgAdmin 4 commit: Refactor server dialogue validation for better unit t

Hi Khushboo, Good catch, attached you can find the fix for the problem. Thanks Victoria & Joao On Wed, Mar 14, 2018 at 10:37 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Joao/Victoria, > > I am getting an error while editing the server properties. Please refer > the attached

Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn

Hello, Personally I believe we should fix the config_local pep issues and just ignore the migrations. Specially because the migration file should not have a lot of python code. Thanks On Thu, Mar 15, 2018 at 3:32 PM Dave Page wrote: > On Thu, Mar 15, 2018 at 12:25 PM, Murtuza Zabuawala < > murt

  1   2   >