Hello, We changed the name in the JSON and extracted the validation to a function to make the code more readable.
Thanks Joao On Fri, Jan 26, 2018 at 5:47 AM Dave Page <dp...@pgadmin.org> wrote: > Hi > > On Thu, Jan 25, 2018 at 7:10 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hi Hackers, >> >> Attached you can find a diff with the correction of Bug 3057. >> With the latest changes to display some information in GP some Feature >> Tests stopped working when run against a GP instance. >> Also we found out that the Feature Test(PGDataType) against 9.2 is >> failing for some time as well. >> Some Unit tests were not working when running with Python Version 3.5 due >> to missing functions in the Mocking Library. >> >> This patch solves all the problems above. >> > > I notice that datatype_test.json adds a field for > "datatypes_minimum_versions" (maybe should be datatype_minimum_versions?), > whilst the code is checking the server version is greater than that value. > Should the comparison be >=, or is the name misleading? > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company >
bug-3057-feature-and-unit-tests-green-again.diff
Description: Binary data
