pgAdmin 4 commit: Correct alignment of the X button on dismissable aler

2017-09-18 Thread Dave Page
Correct alignment of the X button on dismissable alerts. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5ebfd88f11048bfde586d2caeaef63f51745b2bf Author: Murtuza Zabuawala Modified Files -- web/pgadmin/static/css/bootstrap.overrid

Re: [pgAdmin4][Patch]: Fix the logic to extract the error in Query tool

2017-09-18 Thread Dave Page
? At the very least something like: Error: can't execute an empty query > > Another minor issue which I observed on login page is that close button on > alert is little misaligned(screenshot attached). > > Also applied - thanks! -- Dave Page Blog: http://pgsnake

pgAdmin 4 commit: Fix tablespace move prompt message. Fixes #2708

2017-09-18 Thread Dave Page
Fix tablespace move prompt message. Fixes #2708 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e64c52a4467af24a20512e849756f89947ed6084 Author: Murtuza Zabuawala Modified Files -- .../browser/server_groups/servers/tablespaces/sta

Re: [pgAdmin4][Patch]: Fix the Enabale/Disbale trigger functionality

2017-09-18 Thread Dave Page
ng causing malformed string in > TableSpace module. > RM#2708 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > [image: https://community.postgresrocks.net/] > <https://community.postgresrocks.

pgAdmin 4 commit: Fix disable trigger menu option. Fixes #2707

2017-09-18 Thread Dave Page
Fix disable trigger menu option. Fixes #2707 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8bededa859041ee6384a6dff22b93c67dbeeedc8 Author: Murtuza Zabuawala Modified Files -- .../schemas/tables/triggers/static/js/trigger.js |

pgAdmin 4 commit: Fix View Data option and column config for Foreign Ta

2017-09-18 Thread Dave Page
Fix View Data option and column config for Foreign Tables. Fixes #2691 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bdc08d94c494301c20135371c59356fac5c40f1c Author: Akshay Joshi Modified Files -- .../databases/schemas/foreign_t

Re: [pgAdmin4][Patch] RM 2691 View data option is missing from pgAdmin4 2.0 version

2017-09-18 Thread Dave Page
re variable is not declare so it throws > an error. > 2) Columns and Constraints tab are empty, remove "visible: false" from js > file. > > -- > *Akshay Joshi* > *Principal Software Engineer * > > > > *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile

pgAdmin 4 commit: Fix for Exception when the server is restarted. Fixes

2017-09-18 Thread Dave Page
Fix for Exception when the server is restarted. Fixes #2713 This issue was caused because we recently added session_write_delay in session. So session won't be written/updated to disk from memory until specified seconds are elapsed. However we must forcefully write/update session to disk if user

Re: Fix for Exception when the server is restarted [RM2713][pgAdmin4]

2017-09-18 Thread Dave Page
gt; *Sr. Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: Fix the logic to extract the error in Query tool

2017-09-18 Thread Dave Page
ariable, for consistency & backward compatibility I have used `var` in my > latest patch. > That seems like an odd way to fix this - we put in * Error * in the backend, then remove it in the front end. I think it would be better to ensure it's formatted sensibly at the backed t

Re: [pgAdmin4][Patch]: Fix the logic to extract the error in Query tool

2017-09-18 Thread Dave Page
=== ERROR: ERROR: relation "pg_foo" does not exist LINE 1: select * from pg_foo ^ ERROR: relation "pg_foo" does not exist SQL state: 42P01 Character: 15 -- Dave Page Blog: http://p

pgAdmin 4 commit: Bump version for RC2 release.

2017-09-18 Thread Dave Page
Bump version for RC2 release. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5ae681f2baffdef551c9a0c4359657066c7c8743 Modified Files -- web/config.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

pgAdmin 4 commit: Remove unused import that was causing a hard error on

2017-09-18 Thread Dave Page
Remove unused import that was causing a hard error on Windows Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=62d7a1044e58fd2f5a65ac41c70bd0cd8df55464 Modified Files -- web/pgadmin/static/jsx/react_shapes.jsx | 1 - 1 file changed,

v2.0 RC2 test builds

2017-09-18 Thread Dave Page
I've put v2.0-rc2 test builds at https://developer.pgadmin.org/~dpage/2.0-rc2/ for anyone who needs them. Please report any show-stopper issues ASAP! Devrim; these includes the WSGI fix needed for the problem I ran into when testing the RPMs in web mode. Thanks. -- Dave Page Blog:

Re: v2.0 RC2 test builds

2017-09-19 Thread Dave Page
>> The application server couldn't be contacted. >>> >>> @Fahar, Can you please verify If you got same error? >>> >>> Thanks, >>> Surinder >>> >>> >>> On Tue, Sep 19, 2017 at 1:27 AM, Anthony DeBarros >>>

Re: v2.0 RC2 test builds

2017-09-19 Thread Dave Page
On Tue, Sep 19, 2017 at 10:21 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > On Tue, Sep 19, 2017 at 1:51 PM, Dave Page wrote: > >> I assume that's the same as: >> >> Allow apps downloaded from: >> >> [ ] App Store >&g

Re: v2.0 RC2 test builds

2017-09-19 Thread Dave Page
Is this accurate? https://www.pgadmin.org/faq/#9 On Tue, Sep 19, 2017 at 10:58 AM, Dave Page wrote: > > > On Tue, Sep 19, 2017 at 10:21 AM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Hi >> On Tue, Sep 19, 2017 at 1:51 PM, Dave Page wrote

Re: v2.0 RC2 test builds

2017-09-19 Thread Dave Page
f I can re-word to account for that. > > On Tue, Sep 19, 2017 at 4:29 PM, Dave Page wrote: > >> Is this accurate? >> >> https://www.pgadmin.org/faq/#9 >> >> On Tue, Sep 19, 2017 at 10:58 AM, Dave Page wrote: >> >>> >>> >>> O

pgAdmin 4 commit: Improve display of error messages in the query tool.

2017-09-20 Thread Dave Page
Improve display of error messages in the query tool. Fixes #2700 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2ddbddba33ea695cb479509a1928920525c29893 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/utils/driver/psycopg

pgAdmin 4 commit: Tag REL-2_0-RC2 has been created.

2017-09-20 Thread Dave Page
Tag REL-2_0-RC2 has been created. View: https://git.postgresql.org/gitweb?p=pgadmin4.git;a=tag;h=refs/tags/REL-2_0-RC2 Log Message --- Tag 2.0 RC2

Re: [pgAdmin4][Patch]: Fix the logic to extract the error in Query tool

2017-09-20 Thread Dave Page
ates in error messages. > SQL: insert into pg_roles values(1); > > 5) Tested RAISE notices from function. > > 6) Tested JS testcases > > Please review and let me know if I missed anything. > > Regards, > Murtuza > > On Mon, Sep 18, 2017 at 8:20 PM, Dave Page wrot

pgAdmin 4 commit: Fix validation message styling on thegrant wizard. Fi

2017-09-20 Thread Dave Page
Fix validation message styling on thegrant wizard. Fixes #2673 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=13665f68d8e5b51621c176ada17c4f910a305055 Author: Akshay Joshi Modified Files -- web/pgadmin/browser/static/css/wizard.c

Re: [pgAdmin4][Patch] RM 2673 Error not displaying in proper format in User management and Grant Wizard

2017-09-20 Thread Dave Page
nt > Wizard, as fix for user management is already committed. > > -- > *Akshay Joshi* > *Principal Software Engineer * > > > > *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246 > <+91%2097678%2088246>* > -- Dave Page B

pgAdmin 4 commit: Fix font on alertify dialogues

2017-09-20 Thread Dave Page
Fix font on alertify dialogues Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=64159d11ce6a437b13d115834bfaec3a25618232 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/static/css/pgadmin.style.css | 4 ++-- 1 file changed,

Re: pgAdmin 4 commit: Bundle fonts with pgAdmin so we have a standard set f

2017-09-20 Thread Dave Page
t;> The Enterprise PostgreSQL Company >> >> [image: https://community.postgresrocks.net/] >> <https://community.postgresrocks.net/> >> >> On Fri, Sep 15, 2017 at 6:38 PM, Dave Page wrote: >> >>> Thanks, applied. >>> >>> On Fr

pgAdmin 4 commit: Fix an issue where we were executing SELECT statement

2017-09-20 Thread Dave Page
Fix an issue where we were executing SELECT statements in transactions in query tool which probably is not required because SELECT statements are already protected from dirty reads. Fixes #2683 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=

Re: [pgAdmin4][Patch]: To exclude SELECT queries from transaction in query tool

2017-09-20 Thread Dave Page
T > statements are already protected from dirty reads. > RM#2683 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB U

pgAdmin 4 commit: Clarify how virtual envs can be used in WSGI mode, an

2017-09-20 Thread Dave Page
Clarify how virtual envs can be used in WSGI mode, and ensure we ship the required bits on Windows. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=263e235862d5db6dd10c4f064625b2f7369f6eb2 Author: Surinder Kumar Modified Files --

pgAdmin 4 commit: Use the correct lexer in the Apache/Windows docs.

2017-09-20 Thread Dave Page
Use the correct lexer in the Apache/Windows docs. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=18dc938556e9f3f65b35c62d02c1b96019b5ed46 Modified Files -- docs/en_US/server_deployment.rst | 9 - 1 file changed, 4 insertion

Re: v2.0 RC2 test builds

2017-09-21 Thread Dave Page
/issues/2691 > https://redmine.postgresql.org/issues/2713 > https://redmine.postgresql.org/issues/2660 > https://redmine.postgresql.org/issues/2709 > https://redmine.postgresql.org/issues/2671 > > Regards, > > > On Mon, Sep 18, 2017 at 9:12 PM, Dave Page wrote: > >&

pgAdmin 4 commit: Add the ability to build a basic Docker container.

2017-09-21 Thread Dave Page
Add the ability to build a basic Docker container. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bcba59640834b48b95c96d0e90f8c5788ae12709 Modified Files -- .gitignore | 1 + Makefile | 8 +++- pkg/do

Re: pgAdmin 4 commit: Tree view icons

2017-09-22 Thread Dave Page
wrote: > Hi, > > PFA patch which resolves the alignment issues of the tree view icons. > > Regards, > > Chethana Kumar > Principal UI/UX Designer > EnterpriseDB Corporation > > > The Postgres Database Company > > P: +91 86981 57146 <+91%2086981%2057

Re: pgAdmin 4 debian packaging (?)

2017-09-22 Thread Dave Page
, modelled on Devrim's v2.0 RPMs which are looking great. We get far too many people complaining about lack of .debs :-( Oh, and welcome back! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Improve icon alignment.

2017-09-22 Thread Dave Page
Improve icon alignment. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=62c93765462b5505a927b2621d5a78a601b614ed Author: Chethana Kumar Modified Files -- .../servers/databases/casts/static/img/cast.svg | 2 +- .../serve

pgAdmin 4 v2.0 GA build

2017-09-25 Thread Dave Page
- the only one of them I know about is Murtuza's work on certificate auth. Thanks. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: Allow user to provide custom SSL certificates and provide .pgpass file

2017-09-27 Thread Dave Page
e above by tomorrow AM? Thanks. On Mon, Sep 25, 2017 at 6:34 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > Attaching updated patch, Please review. > > On Mon, Sep 4, 2017 at 7:31 PM, Dave Page wrote: > >> Hi >&

Re: [pgAdmin4][Patch]: Allow user to provide custom SSL certificates and provide .pgpass file

2017-09-27 Thread Dave Page
It's also missing a schema version bump isn't it? On Wed, Sep 27, 2017 at 12:36 PM, Dave Page wrote: > Hi > > I've attached an updated patch, as I changed the docs a little. However: > > - "Hidden?" on the File dialogue should be "Show hidden fi

pgAdmin 4 commit: Update release notes.

2017-09-27 Thread Dave Page
Update release notes. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=510bc6c9741344e0c7406e8e3da3b3a9c45101cd Modified Files -- docs/en_US/release_notes_2_0.rst | 13 - 1 file changed, 12 insertions(+), 1 deletion(-)

pgAdmin 4 commit: Allow selection of SSL certificates and pgpass files

2017-09-28 Thread Dave Page
Allow selection of SSL certificates and pgpass files in connection properties. Fixes #2649. Fixes #2650 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f855ed88ce447a0c58c1f063c61f33a6bef14dc0 Author: Murtuza Zabuawala Modified Files ---

pgAdmin 4 commit: Dead code cleanup.

2017-09-28 Thread Dave Page
Dead code cleanup. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=739d8e2f1fc19b37b7c7e68f12d8d65520aa6dfc Modified Files -- web/migrations/versions/09d53fca90c7_.py | 7 +++ web/migrations/versions/3c1e4b6eda55_.py | 11 +

pgAdmin 4 commit: Update release notes.

2017-09-28 Thread Dave Page
Update release notes. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=50a78abf48795173c2e4cbd5f49157339db92bf5 Modified Files -- docs/en_US/release_notes_2_0.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

pgAdmin 4 commit: Update message catalogs.

2017-09-28 Thread Dave Page
Update message catalogs. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8ea85221f0d59f4aa20a50882b72092f88fcb13f Modified Files -- web/pgadmin/messages.pot | 8037 + .../translations/de/LC_

pgAdmin 4 commit: Add missing issue, per Harshal.

2017-09-28 Thread Dave Page
Add missing issue, per Harshal. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9588d76b752ac7700aefcde4281c8ff126148576 Modified Files -- docs/en_US/release_notes_2_0.rst | 1 + 1 file changed, 1 insertion(+)

Re: pgAdmin 4 commit: Update release notes.

2017-09-28 Thread Dave Page
b.com > The Enterprise PostgreSQL Company > > On Thu, Sep 28, 2017 at 2:51 PM, Dave Page wrote: > >> Update release notes. >> >> Branch >> -- >> master >> >> Details >> --- >> https://git.postgresql.org/git

Re: [pgAdmin4][Patch] RM 2742 Unable to connect to database server with different user and role

2017-09-28 Thread Dave Page
t; > *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246 > <+91%2097678%2088246>* > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Ensure using an alternate role to connect to a databa

2017-09-28 Thread Dave Page
Ensure using an alternate role to connect to a database doesn't cause an error when checking recovery state. Fixes #2742 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5a132a547fd9f84db6a93d06e61e0c47c37a92e8 Author: Akshay Joshi Modified F

pgAdmin 4 commit: Bump version number for release.

2017-09-29 Thread Dave Page
Bump version number for release. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d57072b1562e298b272fac76ac89f0beca8f9325 Modified Files -- web/config.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

pgAdmin 4 commit: Tag REL-2_0 has been created.

2017-09-29 Thread Dave Page
Tag REL-2_0 has been created. View: https://git.postgresql.org/gitweb?p=pgadmin4.git;a=tag;h=refs/tags/REL-2_0 Log Message --- Tag 2.0

pgAdmin 4 commit: Add missing date.

2017-10-05 Thread Dave Page
Add missing date. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cb25bb0e930a5a6dfcc424d702f773fdf673f7e4 Modified Files -- docs/en_US/release_notes_2_0.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgAdmin 4 v2.0 Released!

2017-10-05 Thread Dave Page
sessions For more information, please see the website: https://www.pgadmin.org/ Download your copy from: https://www.pgadmin.org/download/ -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: pgAdmin 4 v2.0 Released!

2017-10-06 Thread Dave Page
Postgres APT team are working on it. > > I'm still using v3 because that is all that is available in the Ubuntu GIS > repo for Trusty... > > Thanks, > > Brent Wood > -- > *From:* Devrim Gündüz > *To:* Mike Surcouf ; 'Dave Pag

Re: pgAdmin 4 v2.0 Released!

2017-10-06 Thread Dave Page
a Windows 10 virtual machine, with 2GB RAM and access to 2 CPU cores. What are you running on? > Love the install once run anywhere of the server version. > > You definitely made the right decision going webapp. > > > > Thanks to all for the hard work on this. > Than

pgAdmin 4 commit: Refactor to remove duplicate code for the cancel/term

2017-10-09 Thread Dave Page
Refactor to remove duplicate code for the cancel/terminate buttons in the dashboard. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f2929046fa84d27bbb49b762307e377db6a0faaa Author: Murtuza Zabuawala Modified Files -- web/pgadmin

Re: [pgAdmin4][Patch]: Code refactoring - Dashboard module

2017-10-09 Thread Dave Page
rpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Ensure HTMLMIN is only used with Python 2.7+

2017-10-10 Thread Dave Page
Ensure HTMLMIN is only used with Python 2.7+ Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=91406d2879d2b6a4952d2073727f3771a558f952 Author: Khushboo Vashi Modified Files -- requirements.txt| 2 +- web/pgadmin/__init__.py

pgAdmin 4 commit: Remove panels for www.pgadmin.org and www.postgresql.

2017-10-10 Thread Dave Page
Remove panels for www.pgadmin.org and www.postgresql.org as they won't work with X-Frame-Options: SAMEORIGIN which is used now. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=63103c7a4869a6594eabde098b527315fefb8df2 Author: Murtuza Zabuawala

Re: [pgAdmin4][Patch]: Remove external links from Panel's context menu

2017-10-10 Thread Dave Page
eDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: Enable/Disable passfile filed based on supported libpq version

2017-10-10 Thread Dave Page
ssfile connection parameter is only available with latest version of > libpq which is libpq10+ > Ref: Link > <https://www.postgresql.org/docs/current/static/libpq-pgpass.html> > > Please review. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterp

pgAdmin 4 commit: Only allow specification of a pgpass file if libpq >=

2017-10-10 Thread Dave Page
Only allow specification of a pgpass file if libpq >= 10. Fixes #2768 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2f5a2b23920032a05700d921ff955cb69ef275c9 Author: Murtuza Zabuawala Modified Files -- docs/en_US/server_dialog.rs

Re: pgadmin4 exception: session['_id'] not in self.managers

2017-10-10 Thread Dave Page
t get Python tracebacks dumped to the >>> error logs every time this happens but I have been able to resolve the >>> issue by turning off IPv6 temporarily. That was an interesting one to >>> troubleshoot! >>> >>> On Mon, Oct 9, 2017 at 4:30 AM, Harshal Dhumal < >

pgAdmin 4 commit: Fix various issues that could cause an exception on s

2017-10-10 Thread Dave Page
Fix various issues that could cause an exception on startup. Fixes #2713 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=04beec1309d3672576d15c67d9767e9a7ece2976 Author: Harshal Dhumal Modified Files -- web/pgadmin/browser/server_

pgAdmin 4 commit: Remove some unused index directives.

2017-10-11 Thread Dave Page
Remove some unused index directives. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1f4a814e72ab4f7bcf3bd1e9b16803745f4bf049 Modified Files -- docs/en_US/connect_error.rst | 6 +- docs/en_US/debugger.rst| 6 +- docs/en

pgAdmin 4 commit: Add a target for building PDF docs.

2017-10-11 Thread Dave Page
Add a target for building PDF docs. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cd7d80b650745c52b816e136bec9b34fab4f00c9 Modified Files -- Makefile | 3 +++ 1 file changed, 3 insertions(+)

pgAdmin 4 commit: Ensure line numbers form CodeMirror don't appear on t

2017-10-12 Thread Dave Page
Ensure line numbers form CodeMirror don't appear on top of menus. Fixes #2738 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=56e1fd85f49d630b7bdb552a26bd50863bc39a8a Author: Neel Patel Modified Files -- web/pgadmin/browser/static

Re: [patch][pgAdmin4]: RM #2738 - Line numbers of SQL tab appear above open menus

2017-10-12 Thread Dave Page
Thanks, applied. On Thu, Oct 12, 2017 at 9:06 AM, Neel Patel wrote: > Hi, > > Please find attached patch with the fix of RM# 2738 where Code mirror sql > line number of SQL tab appear above menus. > > Do review it and let me know for the comments. > > Thanks, > Ne

pgAdmin 4 commit: Remove the runtime zoom shortcuts from the SQL Editor

2017-10-12 Thread Dave Page
Remove the runtime zoom shortcuts from the SQL Editor shortcuts section. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a8a2947da612db1b1a13896feafe071383818590 Modified Files -- docs/en_US/keyboard_shortcuts.rst | 4 1 file c

pgAdmin 4 commit: Add optional TLS support to the docker container.

2017-10-12 Thread Dave Page
Add optional TLS support to the docker container. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=845b296aedaef6d22bab0184e0e2f8bc5a326fcb Modified Files -- pkg/docker/Dockerfile | 14 +++-- pkg/docker/README | 7

Re: [pgAdmin4][Patch]: Use https:// to open postgres online help documents

2017-10-16 Thread Dave Page
seDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Use HTTPS for accessing help docs.

2017-10-16 Thread Dave Page
Use HTTPS for accessing help docs. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ce5f5015b3f0855cbf45f252593583a200bda047 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/help/__init__.py | 4 ++-- 1 file changed, 2 insert

Re: [pgAdmin4][Patch]: To fix Indentation issue in query tool

2017-10-16 Thread Dave Page
; Shouldn't we just use the use_spaces option here? I don't see any reason why pressing tab vs. an auto-indent should be any different. As a sidenote, in sqleditor/__init__.py, both config options are being defined as "self.use_spaces = ..." -- Dave Page Blog: http://pgsnake.

Re: [pgAdmin4][Patch]: To fix Indentation issue in query tool

2017-10-16 Thread Dave Page
use_spaces. I can't think of any reason why you would want the two settings to have different values... therefore, why not have just one setting that is honoured whether the indent is the result of the user pressing the tab key, or an auto-indent following an end of line? > > &g

pgAdmin 4 commit: Ensure auto-indent honours the spaces/tabs config set

2017-10-16 Thread Dave Page
Ensure auto-indent honours the spaces/tabs config setting. Fixes #2780 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0cb57848f87e036d086ab59aafd1f363483a4723 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/browser/__init

Re: [pgAdmin4][Patch]: To fix Indentation issue in query tool

2017-10-16 Thread Dave Page
Thanks - applied with a minor tweak to the help message. On Mon, Oct 16, 2017 at 1:56 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > Please find updated patch. > > On Mon, Oct 16, 2017 at 5:56 PM, Dave Page wrote: > >> Hi >>

Re: [pgAdmin4][Patch]: Fix naming convention for Check constraint.

2017-10-16 Thread Dave Page
review. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Fix name of 'check-constraints' to follow the usual s

2017-10-16 Thread Dave Page
Fix name of 'check-constraints' to follow the usual singular convention. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=784f3f59d8e3dc7a81d935affb21ec6db0900f8c Author: Murtuza Zabuawala Modified Files -- .../constraints/check_co

pgAdmin 4 commit: Fix check constraint regression tests.

2017-10-16 Thread Dave Page
Fix check constraint regression tests. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=890fece73a0f261bde566ace2828b6e7d9a46ff5 Modified Files -- .../constraints/check_constraint/tests/test_check_constraint_add.py | 2 +- .../co

pgAdmin 4 commit: Update yarn lock file.

2017-10-16 Thread Dave Page
Update yarn lock file. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a9f10ddad12cc3aef68077fa6fdad69199ae10cf Modified Files -- web/yarn.lock | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

pgAdmin 4 commit: Show how the config/storage directory can be mounted

2017-10-16 Thread Dave Page
Show how the config/storage directory can be mounted on the host under docker. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a2c4fb02bc7a53710db733575a1bc47b9292740d Modified Files -- pkg/docker/README | 3 ++- 1 file changed, 2 i

Re: pgadmin4 l10n issues

2017-10-19 Thread Dave Page
.) > > -- > Alexander Lakhin > Postgres Professional: http://www.postgrespro.com > The Russian Postgres Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: pgadmin4 l10n issues

2017-10-23 Thread Dave Page
Should be upthread I believe - archives.postgresql.org if you cannot find it? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK:http://www.enterprisedb.com The Enterprise PostgreSQL Company > On 23 Oct 2017, at 07:21, Ashesh Vashi wrote: > > Hi Dave/

Re: [pgAgent][Patch] Fixing connection pool leak

2017-10-25 Thread Dave Page
t;>>>>>> *l *Auto Trader extends partnership with Codeweavers >>>>>>>>> <https://codeweavers.net/company-blog/auto-trader-extends-partnership-with-codeweavers-to-power-finance-on-auto-trader-websites> >>>>>>>>> >&g

pgAdmin 4 commit: Update message catalogs.

2017-10-27 Thread Dave Page
Update message catalogs. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=61e809b6369be6163b0ea3e62ef7c5b8e3e25fe7 Modified Files -- web/pgadmin/messages.pot | 640 .../translations/de/LC_ME

pgAdmin 4 commit: Add a Japanese translation created by:

2017-10-27 Thread Dave Page
Add a Japanese translation created by: Junichi Tado Nozomi Amzai Kouske Kida Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bc0320d21eb20019719cd7ce96137d1b9111201f Modified Files -- web/config.py

pgAdmin 4 commit: Add a Russian translation

2017-10-31 Thread Dave Page
Add a Russian translation Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=87549e09364a35b6e450da91aa731c981e020bed Author: Alexander Lakhin Modified Files -- web/config.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

Re: pgAdmin 4: Russian translation

2017-10-31 Thread Dave Page
he Russian Postgres Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Update translations

2017-10-31 Thread Dave Page
Update translations Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6a5ac730a0bc8d5c5793987d354adff666c64e06 Modified Files -- web/pgadmin/messages.pot | 12 ++-- .../translations/de/LC_MESSAGES/me

pgAdmin 4 commit: Add a Russian translation

2017-10-31 Thread Dave Page
Add a Russian translation Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=706ef38e95154fd5402ea2e56a4a0023c106ef96 Author: Alexander Lakhin Modified Files -- .../translations/ru/LC_MESSAGES/messages.mo| Bin 0 -> 165510 by

pgAdmin 4 commit: Output statistics when compiling messages

2017-10-31 Thread Dave Page
Output statistics when compiling messages Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=45be22b00e044e9e3d573656fa9af4ffcbf74dee Modified Files -- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: Fixes for pgAdmin4 messages

2017-11-01 Thread Dave Page
ation marks in some of the messages? > And if so, in which messages exactly they should be used? > > Best regards, > -- > Alexander Lakhin > Postgres Professional: http://www.postgrespro.com > The Russian Postgres Company > > -- Dave Page Blog: http://pgsnake.blogspot

pgAdmin 4 commit: Update psycopg2 requirement to ensure 10.x+ features

2017-11-01 Thread Dave Page
Update psycopg2 requirement to ensure 10.x+ features work. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=714a429879d15f3b923b6f78001057572d82547f Author: Murtuza Zabuawala Modified Files -- requirements.txt | 2 +- 1 file changed

Re: [pgAdmin4][Patch]: To update Psycopg2 version

2017-11-01 Thread Dave Page
Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Various string improvements and fixes.

2017-11-01 Thread Dave Page
Various string improvements and fixes. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9be1364d1afa92f9525cd9df2f4420ee2f4e423f Author: Alexander Lakhin Modified Files -- .../databases/foreign_data_wrappers/__init__.py| 4 ++-

pgAdmin 4 commit: Message catalog update. Current stats look like:

2017-11-01 Thread Dave Page
Message catalog update. Current stats look like: 1503 of 1756 messages (85%) translated in pgadmin/translations/de/LC_MESSAGES/messages.po 1716 of 1756 messages (97%) translated in pgadmin/translations/ja/LC_MESSAGES/messages.po 1494 of 1756 messages (85%) translated in pgadmin/translations/pl/

Re: Fixes for pgAdmin4 messages

2017-11-01 Thread Dave Page
Hi On Wed, Nov 1, 2017 at 9:12 AM, Alexander Lakhin wrote: > 01.11.2017 12:04, Dave Page wrote: > > Hi, > > Can you re-sent this as a single patch please? Working through 23 will > take me significantly more time (which I have little of). > > Sure, If you are going to a

Re: [pgAdmin4][Patch]: To handle long numbers for Rows (estimated) field in Table's properties

2017-11-01 Thread Dave Page
greater than the specified value (the default for which was 2000 in pgAdmin III I believe). -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: To handle long numbers for Rows (estimated) field in Table's properties

2017-11-01 Thread Dave Page
@enterprisedb.com> wrote: >> >>> Thanks Dave, I'll check the implementation in pgAdmin3 & send new patch >>> with suggested changes. >>> >>> >>> On Wed, Nov 1, 2017 at 6:41 PM, Dave Page wrote: >>> >>>> Hi >>&g

Re: [pgAdmin4][Patch]: To handle long numbers for Rows (estimated) field in Table's properties

2017-11-01 Thread Dave Page
ual value doesn't looks good. > OR > What we can do is, we can hide the field if it is empty/or less than > threshold. > I don't think it would necessarily look bad - after all, the estimated row count will be displayed right above it. > > Thoughts? > > > On

pgAdmin 4 commit: Remove more exclamation marks from error messages.

2017-11-01 Thread Dave Page
Remove more exclamation marks from error messages. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=23d431fb54b0bd5fd15ecbe2a8f6e22a0caacd38 Author: Alexander Lakhin Modified Files -- web/pgadmin/browser/server_groups/servers/__ini

pgAdmin 4 commit: Another message catalog update. Stats:

2017-11-01 Thread Dave Page
Another message catalog update. Stats: 1481 of 1750 messages (84%) translated in pgadmin/translations/de/LC_MESSAGES/messages.po 1694 of 1750 messages (96%) translated in pgadmin/translations/ja/LC_MESSAGES/messages.po 1472 of 1750 messages (84%) translated in pgadmin/translations/pl/LC_MESSAGE

Re: Fixes for pgAdmin4 messages

2017-11-01 Thread Dave Page
Hi On Wed, Nov 1, 2017 at 2:13 PM, Alexander Lakhin wrote: > Hello Dave, > 01.11.2017 16:05, Dave Page wrote: > > Hi > > On Wed, Nov 1, 2017 at 9:12 AM, Alexander Lakhin > wrote: > >> >> > I did - albeit with a couple of additional tweaks. > > Thank

<    1   2   3   4   5   6   7   8   9   10   >