Hi On Wed, Nov 1, 2017 at 9:12 AM, Alexander Lakhin <exclus...@gmail.com> wrote:
> 01.11.2017 12:04, Dave Page wrote: > > Hi, > > Can you re-sent this as a single patch please? Working through 23 will > take me significantly more time (which I have little of). > > Sure, If you are going to accept all (or almost all) the changes, a single > patch is better. > I did - albeit with a couple of additional tweaks. > > On Wed, Nov 1, 2017 at 7:33 AM, Alexander Lakhin <exclus...@gmail.com> > wrote: > >> Hello, >> >> While translating the messages, I encountered some English messages, that >> I think should be fixed. >> Please consider applying the attached patches. >> If you have any concerns or questions, I'm ready to explain all the fixes >> proposed. >> >> And I have a question - do you use some kind of style guide? >> (Something like: https://www.postgresql.org/doc >> s/10/static/error-style-guide.html) >> > We do, but it is a WIP: https://www.pgadmin.org/styleguide/. Unfortunately, we haven't got as far as message phrasing yet. If anyone wants to take a crack at it, that would be helpful. > In particular, I'm confused with such messages: >> This URL cannot be called directly! >> This URL cannot be called directly. >> ... >> Name must be specified. >> Name must be specified! >> ... >> Are there any reasons to use exclamation marks in some of the messages? >> And if so, in which messages exactly they should be used? >> > No, I don't think there are reasons to have exclamation marks. pgAdmin shouldn't ever be surprised :-). Seriously though, I think messages should lack emotion like that. Thanks for the patch! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
