SonarQube Fixes #4 Database & Foreign Tables

Hi Hackers, Please find the attached patch which resolves the sonar qube issues relating: 1. *Foreign Tables* -*Refactor this function to reduce its Cognitive Complexity from 67 to the 15 allowed.* 2. *Database* -*Refactor this function to reduce its Cognitive Complexity from 17 to t

Re: SonarQube Fixes #4 Database & Foreign Tables

Hi Rahul Following are the review comments: - Change the name of the function 'get_pg_db_properties'. The function returns lastsysoid and datistemplate only and I assume it is applicable for PG/EPAS both. - Add comments for all the new functions introduce in the patch. On Thu, Jan 2

pgAdmin 4 commit: Fixed an issue where shared server entries not gettin

Fixed an issue where shared server entries not getting deleted from SQLite database if the user gets deleted. Fixes #6143 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=57ed02a9aa137d170e8fbf675366cb490276af82 Author: Nikhil Mohite Modified

pgAdmin 4 commit: Ensure that the current value of the sequence should

Ensure that the current value of the sequence should be ignored while comparing using schema diff. Fixes #6144 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3e09f1bf40489a36f0bb0ae379dc35d43f545ccb Modified Files -- docs/en_US/r

Re: [pgAdmin][RM-6143]: Shared server entries not getting deleted.

Thanks, patch applied. On Thu, Jan 21, 2021 at 12:18 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > Please find the attached patch for RM-6143 > : Shared server entries not > getting deleted. > Added code to delete shared serve

Re: [pgAdmin][RM1802] ERD Tool (Beta)

On Thu, Jan 21, 2021 at 4:48 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Dave, > > On Wed, Jan 20, 2021 at 9:20 PM Dave Page wrote: > >> Hi >> >> Where's the Save Image button gone? I know Aditya was removing it whilst >> working on other things, but it's still required f

Re: [pgAdmin][RM-6143]: Shared server entries not getting deleted.

This seems like a very bad idea. What if the user that has left was the user that setup 50 connections used by everyone else? Deleting those shared entries is (I would guess) most likely *not* what the majority of users would want, and the current behaviour is definitely safest. We should make th

Re: [pgAmin4][Patch] - Kerberos support for Windows Installer

Hi On Thu, Jan 21, 2021 at 7:11 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to add the Kerberos support in the Windows > installer script. > A couple of comments: - The file names should be in lower case in the COPY lines. It will still w

pgAdmin 4 commit: Revert "Fixed an issue where shared server entries no

Revert "Fixed an issue where shared server entries not getting deleted from SQLite database if the user gets deleted. Fixes #6143" This reverts commit 57ed02a9aa137d170e8fbf675366cb490276af82. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f

Re: [pgAdmin][RM-6143]: Shared server entries not getting deleted.

Reverted the commit. On Thu, Jan 21, 2021 at 3:13 PM Dave Page wrote: > This seems like a very bad idea. What if the user that has left was the > user that setup 50 connections used by everyone else? > > Deleting those shared entries is (I would guess) most likely *not* what > the majority of us

Re: [pgAmin4][Patch] - Kerberos support for Windows Installer

Hi Dave, Please find the attached updated patch. Thanks, Khushbo On Thu, Jan 21, 2021 at 3:17 PM Dave Page wrote: > Hi > > On Thu, Jan 21, 2021 at 7:11 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch to add the Kerberos support in the

Re: [pgAdmin][RM-6143]: Shared server entries not getting deleted.

Hi Dave, On Thu, Jan 21, 2021 at 3:24 PM Akshay Joshi wrote: > Reverted the commit. > > On Thu, Jan 21, 2021 at 3:13 PM Dave Page wrote: > >> This seems like a very bad idea. What if the user that has left was the >> user that setup 50 connections used by everyone else? >> >> Deleting those sha

Re: [pgAdmin][RM-6143]: Shared server entries not getting deleted.

Hi On Thu, Jan 21, 2021 at 10:33 AM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Dave, > > On Thu, Jan 21, 2021 at 3:24 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Reverted the commit. >> >> On Thu, Jan 21, 2021 at 3:13 PM Dave Page wrote: >> >>> This seems like

pgAdmin 4 commit: Updated Windows installer script for Kerberos support

Updated Windows installer script for Kerberos support. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=45fa74ae467024a175aa479c0263720b2af60b52 Author: Khushboo Vashi Modified Files -- Make.bat | 17 + 1 file change

Re: [pgAmin4][Patch] - Kerberos support for Windows Installer

Thanks, patch applied. On Thu, Jan 21, 2021 at 3:46 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Dave, > > Please find the attached updated patch. > > Thanks, > Khushbo > > On Thu, Jan 21, 2021 at 3:17 PM Dave Page wrote: > >> Hi >> >> On Thu, Jan 21, 2021 at 7:11 AM Khushboo

Re: [pgAdmin][RM1802] ERD Tool (Beta)

Hi, On Thu, Jan 21, 2021 at 3:08 PM Dave Page wrote: > > > On Thu, Jan 21, 2021 at 4:48 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Wed, Jan 20, 2021 at 9:20 PM Dave Page wrote: >> >>> Hi >>> >>> Where's the Save Image button gone? I know Aditya was

Re: SonarQube Fixes #4 Database & Foreign Tables

On Thu, Jan 21, 2021 at 2:47 PM Akshay Joshi wrote: > Hi Rahul > > Following are the review comments: > >- Change the name of the function 'get_pg_db_properties'. The function >returns lastsysoid and datistemplate only and I assume it is applicable for >PG/EPAS both. > > *Done!* > >

[pgAdmin][RM6147] - Kerberos documentation

Hi, PFA patch for the Kerberos documentation. Best Regards, Nidhi Bhammar www.enterprisedb.com RM6147.patch Description: Binary data

Testing required: pgAdmin 4 with new desktop runtime

All, As you know, when run in Desktop mode, pgAdmin 4 uses a server process which runs all the time and opens a browser window to display the UI. Very early versions used a Qt based runtime that integrated the browser and server which gave a much more "normal" application feel, but unfortunately w

Re: Testing required: pgAdmin 4 with new desktop runtime

Dave, Sounds promising, can the new beta be installed alongside the existing version? Thanks, rik. On Thu, Jan 21, 2021 at 10:56 AM Dave Page wrote: > All, > > As you know, when run in Desktop mode, pgAdmin 4 uses a server process > which runs all the time and opens a browser window to displa

Re: Testing required: pgAdmin 4 with new desktop runtime

I’cew got it installed on my mac. I’ll use it and see what I notice. Doug Easterbrook Arts Management Systems Ltd. mailto:d...@artsman.com http://www.artsman.com Phone (403) 650-1978 > On January 21, 2021, at 7:55 AM, Dave Page wrote: > > All, > > As you know, when run in Desktop mode, pgAdm

Re: Testing required: pgAdmin 4 with new desktop runtime

Hi On Thu, 21 Jan 2021 at 16:01, richard coleman wrote: > Dave, > > Sounds promising, can the new beta be installed alongside the existing > version? > Only on macOS, due to the way appbundles work. > Thanks, > > rik. > > On Thu, Jan 21, 2021 at 10:56 AM Dave Page wrote: > >> All, >> >> As y