Hi On Thu, Jan 21, 2021 at 7:11 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote:
> Hi, > > Please find the attached patch to add the Kerberos support in the Windows > installer script. > A couple of comments: - The file names should be in lower case in the COPY lines. It will still work of course, but for consistency and style... - There's no check that the environment variable is set to a valid value. For others, we have code block like: IF NOT EXIST "%PGADMIN_QT_DIR%" ( ECHO !PGADMIN_QT_DIR! does not exist. ECHO Please install Qt and set the PGADMIN_QT_DIR environment variable. EXIT /B 1 ) -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EDB: http://www.enterprisedb.com