Re: Want to contribute as a developer

Hi Aditya, Thanks for the informations. > On 23-Mar-2020, at 10:42 AM, Aditya Toshniwal > wrote: > > Hi Vijender, > > > > On Mon, Mar 23, 2020 at 5:00 AM Vijender Thakur > wrote: > Hi, > I want to contribute to the pgadmin4 project as a developer. I am a fu

Re: pgAdmin 4 - gettext usage fixes

Hi Aditya Can you please review this? On Mon, Mar 23, 2020 at 5:00 AM Libor M. wrote: > Hello, > I fixed using gettext function and add more usages for translations, > specifically: > > - fixed usage gettext('') instead of _('') in javascript files > - fixed usage gettext('') instead of `${gett

[pgAdmin][RM5128] [Accessibility] Revisit color contrast to meet the standards

Hi Hackers, Attached is a small patch to change certain colors and opacity in pgAdmin in order to comply with WCAG color contrast standards. Please review. -- Thanks and Regards, Aditya Toshniwal pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plan

pgAdmin 4 commit: Change some colors and opacity to comply with WCAG co

Change some colors and opacity to comply with WCAG color contrast standards. Fixes #5128 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6988ce96d7a32eaa64c05e1bb2424426f68b9b2e Author: Aditya Toshniwal Modified Files -- docs/en_

Re: [pgAdmin][RM5128] [Accessibility] Revisit color contrast to meet the standards

Thanks, patch applied. On Mon, Mar 23, 2020 at 5:46 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is a small patch to change certain colors and opacity in pgAdmin > in order to comply with WCAG color contrast standards. > > Please review. > > -- > Than

Re: pgAdmin 4 - gettext usage fixes

Hi Libor, Thank you for the patch. It is good clean up patch. I've made a few changes in the patch. You've imported sprintf which was not required since gettext also works as sprintf directly. I've also created a housekeeping redmine ticket to track it - https://redmine.postgresql.org/issues/5284

Re: [pgAdmin4][Patch] - RM 2186 - Support external authentication sources [LDAP]

Hi, Please find the attached updated patch. On Tue, Mar 17, 2020 at 4:11 PM Dave Page wrote: > Hi > > On Tue, Mar 17, 2020 at 10:24 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Dave, >> >> Thanks for the review. >> >> On Tue, Mar 17, 2020 at 3:42 PM Dave Page wrote: >

Re: [pgAdmin4][Patch] - RM 2186 - Support external authentication sources [LDAP]

Please disregard my previous patch, attached the updated patch. On Tue, Mar 24, 2020 at 10:29 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > > > On Tue, Mar 17, 2020 at 4:11 PM Dave Page wrote: > >> Hi >> >> On Tue, Mar 17, 2020 at

Re: pgAdmin 4 - gettext usage fixes

Hi Hackers, Please find the updated patch with pep8, linter issues fixed. On Mon, Mar 23, 2020 at 8:31 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Libor, > > Thank you for the patch. It is good clean up patch. > I've made a few changes in the patch. You've imported spri

pgAdmin 4 commit: Added and fixed gettext usage for better translation

Added and fixed gettext usage for better translation coverage. Fixes #5284   1) Fixed usage gettext('') instead of _('') in javascript files.   2) Fixed usage gettext('') instead of `${gettext('')}` in javascript files, because "pybabel extract" not support extracting from this syntax. Branch

Re: pgAdmin 4 - gettext usage fixes

Thanks, patch applied. On Tue, Mar 24, 2020 at 11:06 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the updated patch with pep8, linter issues fixed. > > > On Mon, Mar 23, 2020 at 8:31 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: