Hi Hackers, Please find the updated patch with pep8, linter issues fixed.
On Mon, Mar 23, 2020 at 8:31 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Libor, > > Thank you for the patch. It is good clean up patch. > I've made a few changes in the patch. You've imported sprintf which was > not required since gettext also works as sprintf directly. > I've also created a housekeeping redmine ticket to track it - > https://redmine.postgresql.org/issues/5284 > > The messages compile fine. The patch can be committed. > Please find the attached updated patch. > > > > On Mon, Mar 23, 2020 at 4:00 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Aditya >> >> Can you please review this? >> >> On Mon, Mar 23, 2020 at 5:00 AM Libor M. <libor...@gmail.com> wrote: >> >>> Hello, >>> I fixed using gettext function and add more usages for translations, >>> specifically: >>> >>> - fixed usage gettext('') instead of _('') in javascript files >>> - fixed usage gettext('') instead of `${gettext('')}` in javascript >>> files, because "pybabel extract" not support extracting from this >>> syntax >>> - added a lot of gettext for support translations >>> >>> Diff file is attached. >>> >>> Best regards, >>> >>> Libor M. >>> >>> E-mail: libor...@gmail.com >>> GitHub: https://github.com/liborm85 >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- Thanks and Regards, Aditya Toshniwal pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE"
RM5284_v2.patch
Description: Binary data
