Re: [pgAdmin][RM4195] Tab navigation is broken in Query tool (Accessibility)

2019-05-30 Thread Aditya Toshniwal
Hi, On Thu, May 30, 2019 at 1:38 AM Dave Page wrote: > Hi > > On Tue, May 28, 2019 at 3:41 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi, >> >> On Thu, May 23, 2019 at 1:31 PM Dave Page wrote: >> >>> Hi, >>> >>> On further testing, this doesn't seem to be working as

[RM#4307][pgAdmin4] Graphical Explain Plan - Embed images in explain plan only when user try to download it

2019-05-30 Thread Murtuza Zabuawala
Hi, Embedding images using *.toDataURL()* method hits the performance of the explain plan rendering if the plan is complex because first it downloads the images then it will convert each images into base64, to improve the performance we will embed the images only when downloading of SVG is called

[pgAdmin][RM2653] Lock layout

2019-05-30 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to introduce feature to lock the layout with three different levels: 1) None - No locking 2) Prevent docking - The docking/undocking of panels will be disabled 3) Full lock - The resizing along with docking/undocking of panels will be disabled - This can be chang

Re: [RM#4307][pgAdmin4] Graphical Explain Plan - Embed images in explain plan only when user try to download it

2019-05-30 Thread Aditya Toshniwal
Hi Murtuza, I was just going through code change, and I would suggest one small change. In the image_mapper.js, export it as default, as it will have only one export. Then you can use it as imageMapper.default rather than imageMapper. imageMapper. Otherwise, looks fine to me. I didn't test though

Re: pgAdmin4 v4.7 candidate builds

2019-05-30 Thread Fahar Abbas
Hello Akshay, One round of testing has been completed for 4.7 and it's ready for the release. Kind Regards, On Wed, May 29, 2019 at 11:59 PM Akshay Joshi wrote: > Hi All, > > New installers and source can be found at > https://developer.pgadmin.org/builds/2019-05-29-1/ > > Fahar, please verify

Re: [RM#4307][pgAdmin4] Graphical Explain Plan - Embed images in explain plan only when user try to download it

2019-05-30 Thread Murtuza Zabuawala
Here is updated patch. On Thu, May 30, 2019 at 4:06 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Murtuza, > > I was just going through code change, and I would suggest one small change. > In the image_mapper.js, export it as default, as it will have only one > export. Then

[pgAdmin][RM4169] Multiple Geometry Viewer issue

2019-05-30 Thread Aditya Toshniwal
Hi Hackers, Attached is a tiny patch to fix the issue where geometry viewer is already open on opening a new query tool. Excluded geometry viewer panel from layout saving. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TR

pgAdmin 4 v4.7 released

2019-05-30 Thread Akshay Joshi
The pgAdmin Development Team are pleased to announce pgAdmin 4 version 4.7. This release of pgAdmin 4 includes over 22 bug fixes and new features. For more details please see the release notes at: https://www.pgadmin.org/docs/pgadmin4/dev/release_notes_4_7.html. pgAdmin is the leading Open So

pgAdmin 4 commit: Improve the performance of explain plan by embedding

2019-05-30 Thread Akshay Joshi
Improve the performance of explain plan by embedding the images only when downloading it. Fixes #4307 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=32defc91cc9fd381f1f08968a268b02ebd014df3 Author: Murtuza Zabuawala Modified Files -

Re: [RM#4307][pgAdmin4] Graphical Explain Plan - Embed images in explain plan only when user try to download it

2019-05-30 Thread Akshay Joshi
Thanks patch applied. On Thu, May 30, 2019 at 5:01 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Here is updated patch. > > On Thu, May 30, 2019 at 4:06 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Murtuza, >> >> I was just going through code cha

Re: [pgAdmin][RM4195] Tab navigation is broken in Query tool (Accessibility)

2019-05-30 Thread Dave Page
Hi On Thu, May 30, 2019 at 4:40 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > On Thu, May 30, 2019 at 1:38 AM Dave Page wrote: > >> Hi >> >> On Tue, May 28, 2019 at 3:41 AM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> On Thu, May

Re: [pgAdmin][RM2653] Lock layout

2019-05-30 Thread Dave Page
Hi Can you rebase please? (pgadmin4) dpage@orac:*~/git/pgadmin4*$ git apply ~/Downloads/RM2653.patch error: patch failed: web/pgadmin/browser/static/js/browser.js:15 error: web/pgadmin/browser/static/js/browser.js: patch does not apply On Thu, May 30, 2019 at 6:15 AM Aditya Toshniwal < aditya.

pgAdmin 4 commit: Omit the geometry viewer in the Query Tool from layou

2019-05-30 Thread Dave Page
Omit the geometry viewer in the Query Tool from layout saving. Fixes #4169 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2185ea302d3e7a6c724b12d0d98a68e194495bad Author: Aditya Toshniwal Modified Files -- docs/en_US/release_note

Re: [pgAdmin][RM4169] Multiple Geometry Viewer issue

2019-05-30 Thread Dave Page
Thanks, patch applied. On Thu, May 30, 2019 at 7:36 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is a tiny patch to fix the issue where geometry viewer is already > open on opening a new query tool. Excluded geometry viewer panel from > layout saving.

pgAdmin 4 commit: Fix the issue of accessing the SQL for Views and Mate

2019-05-30 Thread Akshay Joshi
Fix the issue of accessing the SQL for Views and Materialized Views. Regression of pluralisation of folder names. Fixes #4308 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=26c7d76d4f274a905085bd5a168e428f0defbc50 Modified Files