Hi On Thu, May 30, 2019 at 4:40 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote:
> Hi, > > On Thu, May 30, 2019 at 1:38 AM Dave Page <dp...@pgadmin.org> wrote: > >> Hi >> >> On Tue, May 28, 2019 at 3:41 AM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> On Thu, May 23, 2019 at 1:31 PM Dave Page <dp...@pgadmin.org> wrote: >>> >>>> Hi, >>>> >>>> On further testing, this doesn't seem to be working as expected. >>>> Alt+Shift+] or [ in the query tool are typing ’ and ” and not changing the >>>> tab. If I switch to a non-input tab (e.g. History), they still don't work. >>>> >>> I am not able to simulate the quotes problem, but I have made a few >>> corrections to fix the switching. >>> Attached is the updated patch, kindly review. >>> >> >> Alt+Shift+[ (or ]) don[t work at all for me now :-( >> > Did you restart the server after applying the patch ? What shortcut does > preferences show ? > Yes, did that, rebuilt the bundle and hard-reloaded the browser, all multiple times. The shortcut preferences show the expected keys. > >> >>> >>>> Alt+Shift+Tab changes the panel successfully though, and does cause the >>>> flash as expected. >>>> >>>> I'm using Chrome 74.0.3729.131 on Mojave. >>>> >>>> On Wed, May 22, 2019 at 6:53 AM Aditya Toshniwal < >>>> aditya.toshni...@enterprisedb.com> wrote: >>>> >>>>> Hi, >>>>> >>>>> Attached is the updated patch with doc changes. >>>>> >>>>> On Tue, May 21, 2019 at 5:42 PM Aditya Toshniwal < >>>>> aditya.toshni...@enterprisedb.com> wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> On Tue, May 21, 2019 at 5:32 PM Dave Page <dp...@pgadmin.org> wrote: >>>>>> >>>>>>> Hi >>>>>>> >>>>>>> On Tue, May 21, 2019 at 10:01 AM Aditya Toshniwal < >>>>>>> aditya.toshni...@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Hi Hackers, >>>>>>>> >>>>>>>> Attached is the patch to fix the accessibility issue in query tool. >>>>>>>> >>>>>>>> The query tool can be completely restructured unlike previously >>>>>>>> where query tool used to stick at top and other tabs in the bottom. >>>>>>>> - I have added a new shortcut to switch between frames if in query >>>>>>>> tool the tab positions are changed. On switching the frames, the frame >>>>>>>> will >>>>>>>> blink to show it is focussed. >>>>>>>> - In the frame, you can switch tab same as previous. The tabs in >>>>>>>> SQL editor are cyclic now, which means if you execute shortcut to go >>>>>>>> right >>>>>>>> on the last tab then it will cycle to first tab. >>>>>>>> - I have also changed the default shortcut to switch between tabs >>>>>>>> from Shift+Ctrl+ArrowKeys to Shift+Ctrl+[ and ] similar to what we >>>>>>>> have in >>>>>>>> browser tabs. >>>>>>>> - Similar changes done for debugger also. >>>>>>>> >>>>>>> >>>>>>> Shouldn't there be documentation changes to go with this? >>>>>>> >>>>>> Yes, definitely :P >>>>>> Will send the updated patch. >>>>>> >>>>>>> >>>>>>> Otherwise, it seems to work :-) >>>>>>> >>>>>>> -- >>>>>>> Dave Page >>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>> Twitter: @pgsnake >>>>>>> >>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>> The Enterprise PostgreSQL Company >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Thanks and Regards, >>>>>> Aditya Toshniwal >>>>>> Software Engineer | EnterpriseDB India | Pune >>>>>> "Don't Complain about Heat, Plant a TREE" >>>>>> >>>>> >>>>> >>>>> -- >>>>> Thanks and Regards, >>>>> Aditya Toshniwal >>>>> Software Engineer | EnterpriseDB India | Pune >>>>> "Don't Complain about Heat, Plant a TREE" >>>>> >>>> >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
