Re: [pgadmin][patch] Make Feature and Unit tests Green Again

2018-01-26 Thread Dave Page
Hi On Thu, Jan 25, 2018 at 7:10 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > > Attached you can find a diff with the correction of Bug 3057. > With the latest changes to display some information in GP some Feature > Tests stopped working when run against a GP

pgAdmin 4 commit: Include a hash of the executable path in the lock and

2018-01-26 Thread Dave Page
Include a hash of the executable path in the lock and address file names. This allows side-by-side running of different instances of the runtime. While we're at it, improve some comments and tidy up a little. Branch -- runtime-revamp Details --- https://git.postgresql.org/gitweb?p=pgadm

[pgAdmin4][RM#3063] Add 'pycodestyle ' Python PEP-8 checker module

2018-01-26 Thread Murtuza Zabuawala
Hi, PFA patch to add 'pycodestyle ' (formerly called pep8) which is a Python PEP-8 checker module. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/requirements.txt b/requirements.txt index 2e486f3..ef0936d 100644 --- a/require

Re: [pgadmin][patch] Make Feature and Unit tests Green Again

2018-01-26 Thread Joao De Almeida Pereira
Hello, We changed the name in the JSON and extracted the validation to a function to make the code more readable. Thanks Joao On Fri, Jan 26, 2018 at 5:47 AM Dave Page wrote: > Hi > > On Thu, Jan 25, 2018 at 7:10 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hi Hacke

pgAdmin 4 commit: Add a log viewer. stderr is redirected to a per-insta

2018-01-26 Thread Dave Page
Add a log viewer. stderr is redirected to a per-installation logfile, and can be viewed with an internal viewer. Branch -- runtime-revamp Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1b41558a56682940d2a2454f9af74af96ade59b2 Modified Files -- ru

Fwd: pgAdmin4 2.1 on apt.postgresql.org

2018-01-26 Thread Dave Page
For those that may not watch -announce -- Forwarded message -- From: Christoph Berg Date: Thu, Jan 25, 2018 at 2:20 PM Subject: pgAdmin4 2.1 on apt.postgresql.org To: PostgreSQL Announce pgAdmin 4 (https://www.pgadmin.org/) is now also available via the Debian and Ubuntu re

pgAdmin 4 commit: Update the regression tests to fix issues with Python

2018-01-26 Thread Dave Page
Update the regression tests to fix issues with Python 3.5 and PG 9.2. Fixes #3057 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=de1c767e8849bdd761c3425452babcae18402c12 Author: Joao Pedro De Almeida Pereira Modified Files -- ..

Re: [pgadmin][patch] Make Feature and Unit tests Green Again

2018-01-26 Thread Dave Page
Thanks - patch applied! On Fri, Jan 26, 2018 at 3:54 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello, > We changed the name in the JSON and extracted the validation to a function > to make the code more readable. > > Thanks > Joao > > On Fri, Jan 26, 2018 at 5:47 AM Dav

pgAdmin 4 commit: Fix PEP8 issues in the Tools module. Fixes #3063

2018-01-26 Thread Dave Page
Fix PEP8 issues in the Tools module. Fixes #3063 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=393ce53d2da5c7fd686ebcc849d63d920c02fffe Author: Murtuza Zabuawala Modified Files -- web/config.py |

Re: [pgAdmin4][RM#3062] Fix PEP-8 issues in Tools module

2018-01-26 Thread Dave Page
Thanks, patch applied. On Fri, Jan 26, 2018 at 1:26 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix PEP-8 issues in Tools module's python code. > > How to run, > 1) Apply patch RM#3063 > 2) activate virtual environemt > 3) Install pycodestyle

Re: [pgAdmin4][RM#3063] Add 'pycodestyle ' Python PEP-8 checker module

2018-01-26 Thread Dave Page
Hi On Fri, Jan 26, 2018 at 1:26 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to add 'pycodestyle ' (formerly called pep8) which is a Python > PEP-8 checker module. > Nice! A couple of thoughts: - I think this should go into web/regression/requirements.

Jenkins build is back to normal : pgadmin4-master-python35 #460

2018-01-26 Thread pgAdmin 4 Jenkins
See