Re: pgAdmin 4 - gettext usage fixes

Thanks, patch applied. On Tue, Mar 24, 2020 at 11:06 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the updated patch with pep8, linter issues fixed. > > > On Mon, Mar 23, 2020 at 8:31 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote:

Re: pgAdmin 4 - gettext usage fixes

Hi Hackers, Please find the updated patch with pep8, linter issues fixed. On Mon, Mar 23, 2020 at 8:31 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Libor, > > Thank you for the patch. It is good clean up patch. > I've made a few changes in the patch. You've imported spri

Re: pgAdmin 4 - gettext usage fixes

Hi Libor, Thank you for the patch. It is good clean up patch. I've made a few changes in the patch. You've imported sprintf which was not required since gettext also works as sprintf directly. I've also created a housekeeping redmine ticket to track it - https://redmine.postgresql.org/issues/5284

Re: pgAdmin 4 - gettext usage fixes

Hi Aditya Can you please review this? On Mon, Mar 23, 2020 at 5:00 AM Libor M. wrote: > Hello, > I fixed using gettext function and add more usages for translations, > specifically: > > - fixed usage gettext('') instead of _('') in javascript files > - fixed usage gettext('') instead of `${gett

pgAdmin 4 - gettext usage fixes

Hello, I fixed using gettext function and add more usages for translations, specifically: - fixed usage gettext('') instead of _('') in javascript files - fixed usage gettext('') instead of `${gettext('')}` in javascript files, because "pybabel extract" not support extracting from this syntax - ad