Re: [pgadmin-hackers][patch] Upgrade slickgrid to version 2.3.7

2017-06-23 Thread Surinder Kumar
On Fri, Jun 23, 2017 at 4:21 PM, Dave Page wrote: > > > On Fri, Jun 23, 2017 at 11:47 AM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Sorry, I forgot to attach screenshot. >> I looked into Query tool HTML using inspect tool. >> >> > That's code that's part of SlickGrid isn't i

Re: [pgadmin-hackers][patch] Upgrade slickgrid to version 2.3.7

2017-06-23 Thread Dave Page
On Fri, Jun 23, 2017 at 11:47 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Sorry, I forgot to attach screenshot. > I looked into Query tool HTML using inspect tool. > > That's code that's part of SlickGrid isn't it? If there are improvements to be made there, patches should be se

Re: [pgadmin-hackers][patch] Upgrade slickgrid to version 2.3.7

2017-06-23 Thread Dave Page
Hi On Fri, Jun 23, 2017 at 11:33 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > On latest git pull, couple of issues: > > 1. The edit grid font(text-12) is overriden by 'ui-widget' font - Verdana. > 2. The dotted border around cell appears again. > > The class 'ui-widget' i

Re: [pgadmin-hackers][patch] Upgrade slickgrid to version 2.3.7

2017-06-23 Thread Surinder Kumar
Hi On latest git pull, couple of issues: 1. The edit grid font(text-12) is overriden by 'ui-widget' font - Verdana. 2. The dotted border around cell appears again. The class 'ui-widget' is added dynamically which i don't know why it is added. Also, Cascaded style is used(i.e. CSS is embedded in

Re: [pgadmin-hackers][patch] Upgrade slickgrid to version 2.3.7

2017-06-23 Thread Dave Page
Thanks - all applied! On Thu, Jun 22, 2017 at 8:00 PM, Matthew Kleiman wrote: > Hello Dave, > > We noticed that the makefile is not installing node_modules dependencies, > so we created a new patch that changes the makefile to install > node_modules first and then execute the tasks. > > Thanks >

Re: [pgadmin-hackers][patch] Upgrade slickgrid to version 2.3.7

2017-06-20 Thread Dave Page
Hi, This fails tests: (pgadmin4)piranha:pgadmin4 dpage$ make check-feature cd web && yarn run bundle && python regression/runtests.py --pkg feature_tests yarn run v0.24.6 $ yarn run linter && yarn run webpacker yarn run v0.24.6 $ yarn run eslint pgadmin/static/jsx/**/*.jsx pgadmin/static/js/selec